OpenBSD CVS

CVS log for src/usr.bin/ssh/ssh-ecdsa.c


[BACK] Up to [local] / src / usr.bin / ssh

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.26 / (download) - annotate - [select for diffs], Wed Mar 8 04:43:12 2023 UTC (14 months, 1 week ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, HEAD
Changes since 1.25: +1 -3 lines
Diff to previous 1.25 (colored)

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

Revision 1.25 / (download) - annotate - [select for diffs], Fri Oct 28 00:44:44 2022 UTC (18 months, 2 weeks ago) by djm
Branch: MAIN
Changes since 1.24: +47 -27 lines
Diff to previous 1.24 (colored)

refactor sshkey_private_deserialize

feedback/ok markus@

Revision 1.24 / (download) - annotate - [select for diffs], Fri Oct 28 00:44:17 2022 UTC (18 months, 2 weeks ago) by djm
Branch: MAIN
Changes since 1.23: +18 -1 lines
Diff to previous 1.23 (colored)

refactor sshkey_private_serialize_opt()

feedback/ok markus@

Revision 1.23 / (download) - annotate - [select for diffs], Fri Oct 28 00:43:08 2022 UTC (18 months, 2 weeks ago) by djm
Branch: MAIN
Changes since 1.22: +29 -24 lines
Diff to previous 1.22 (colored)

refactor sshkey_sign() and sshkey_verify()

feedback/ok markus@

Revision 1.22 / (download) - annotate - [select for diffs], Fri Oct 28 00:41:52 2022 UTC (18 months, 2 weeks ago) by djm
Branch: MAIN
Changes since 1.21: +54 -4 lines
Diff to previous 1.21 (colored)

refactor sshkey_from_blob_internal()

feedback/ok markus@

Revision 1.21 / (download) - annotate - [select for diffs], Fri Oct 28 00:41:17 2022 UTC (18 months, 2 weeks ago) by djm
Branch: MAIN
Changes since 1.20: +14 -1 lines
Diff to previous 1.20 (colored)

refactor sshkey_from_private()

feedback/ok markus@

Revision 1.20 / (download) - annotate - [select for diffs], Fri Oct 28 00:39:29 2022 UTC (18 months, 2 weeks ago) by djm
Branch: MAIN
Changes since 1.19: +20 -1 lines
Diff to previous 1.19 (colored)

factor out key generation

feedback/ok markus@

Revision 1.19 / (download) - annotate - [select for diffs], Fri Oct 28 00:37:24 2022 UTC (18 months, 2 weeks ago) by djm
Branch: MAIN
Changes since 1.18: +20 -1 lines
Diff to previous 1.18 (colored)

factor out public key serialization

feedback/ok markus@

Revision 1.18 / (download) - annotate - [select for diffs], Fri Oct 28 00:36:31 2022 UTC (18 months, 2 weeks ago) by djm
Branch: MAIN
Changes since 1.17: +25 -2 lines
Diff to previous 1.17 (colored)

factor out sshkey_equal_public()

feedback/ok markus@

Revision 1.17 / (download) - annotate - [select for diffs], Fri Oct 28 00:35:40 2022 UTC (18 months, 2 weeks ago) by djm
Branch: MAIN
Changes since 1.16: +101 -1 lines
Diff to previous 1.16 (colored)

begin big refactor of sshkey

Move keytype data and some of the type-specific code (allocation,
cleanup, etc) out into each key type's implementation. Subsequent
commits will move more, with the goal of having each key-*.c file
owning as much of its keytype's implementation as possible.

lots of feedback + ok markus@

Revision 1.16 / (download) - annotate - [select for diffs], Mon Jan 21 09:54:11 2019 UTC (5 years, 3 months ago) by djm
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.15: +6 -8 lines
Diff to previous 1.15 (colored)

Make sshpkt_get_bignum2() allocate the bignum it is parsing rather
than make the caller do it. Saves a lot of boilerplate code.

from markus@ ok djm@

Revision 1.15 / (download) - annotate - [select for diffs], Thu Sep 13 02:08:33 2018 UTC (5 years, 8 months ago) by djm
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE, OPENBSD_6_4
Changes since 1.14: +19 -6 lines
Diff to previous 1.14 (colored)

hold our collective noses and use the openssl-1.1.x API in OpenSSH;
feedback and ok tb@ jsing@ markus@

Revision 1.14 / (download) - annotate - [select for diffs], Wed Feb 7 02:06:51 2018 UTC (6 years, 3 months ago) by jsing
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_3
Changes since 1.13: +3 -5 lines
Diff to previous 1.13 (colored)

Remove all guards for calls to OpenSSL free functions - all of these
functions handle NULL, from at least OpenSSL 1.0.1g onwards.

Prompted by dtucker@ asking about guards for RSA_free(), when looking at
openssh-portable pr#84 on github.

ok deraadt@ dtucker@

Revision 1.13 / (download) - annotate - [select for diffs], Thu Apr 21 06:08:02 2016 UTC (8 years ago) by djm
Branch: MAIN
CVS Tags: OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.12: +3 -2 lines
Diff to previous 1.12 (colored)

make argument == NULL tests more consistent

Revision 1.12 / (download) - annotate - [select for diffs], Fri Dec 11 04:21:12 2015 UTC (8 years, 5 months ago) by mmcc
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.11: +5 -9 lines
Diff to previous 1.11 (colored)

Remove NULL-checks before sshbuf_free().

ok djm@

Revision 1.11 / (download) - annotate - [select for diffs], Tue Jun 24 01:13:21 2014 UTC (9 years, 10 months ago) by djm
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7, OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.10: +128 -114 lines
Diff to previous 1.10 (colored)

New key API: refactor key-related functions to be more library-like,
existing API is offered as a set of wrappers.

with and ok markus@

Thanks also to Ben Hawkes, David Tomaschik, Ivan Fratric, Matthew
Dempsky and Ron Bowes for a detailed review a few months ago.

Revision 1.10 / (download) - annotate - [select for diffs], Mon Feb 3 23:28:00 2014 UTC (10 years, 3 months ago) by djm
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.9: +1 -4 lines
Diff to previous 1.9 (colored)

fix memory leak; ECDSA_SIG_new() allocates 'r' and 's' for us, unlike
DSA_SIG_new. Reported by Batz Spear; ok markus@

Revision 1.9 / (download) - annotate - [select for diffs], Sun Feb 2 03:44:31 2014 UTC (10 years, 3 months ago) by djm
Branch: MAIN
Changes since 1.8: +4 -4 lines
Diff to previous 1.8 (colored)

convert memset of potentially-private data to explicit_bzero()

Revision 1.8 / (download) - annotate - [select for diffs], Thu Jan 9 23:20:00 2014 UTC (10 years, 4 months ago) by djm
Branch: MAIN
Changes since 1.7: +26 -16 lines
Diff to previous 1.7 (colored)

Introduce digest API and use it to perform all hashing operations
rather than calling OpenSSL EVP_Digest* directly. Will make it easier
to build a reduced-feature OpenSSH without OpenSSL in future;
feedback, ok markus@

Revision 1.7 / (download) - annotate - [select for diffs], Fri Dec 27 22:30:17 2013 UTC (10 years, 4 months ago) by djm
Branch: MAIN
Changes since 1.6: +7 -5 lines
Diff to previous 1.6 (colored)

make the original RSA and DSA signing/verification code look more like
the ECDSA/Ed25519 ones: use key_type_plain() when checking the key type
rather than tediously listing all variants, use __func__ for debug/
error messages

Revision 1.6 / (download) - annotate - [select for diffs], Fri May 17 00:13:14 2013 UTC (11 years ago) by djm
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4
Changes since 1.5: +5 -5 lines
Diff to previous 1.5 (colored)

bye, bye xfree(); ok markus@

Revision 1.5 / (download) - annotate - [select for diffs], Sun Jan 8 13:17:11 2012 UTC (12 years, 4 months ago) by miod
Branch: MAIN
CVS Tags: OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1
Changes since 1.4: +2 -1 lines
Diff to previous 1.4 (colored)

Fix memory leak in ssh_ecdsa_verify(); from Loganaden Velvindron, ok markus@

Revision 1.4 / (download) - annotate - [select for diffs], Fri Sep 10 01:04:10 2010 UTC (13 years, 8 months ago) by djm
Branch: MAIN
CVS Tags: OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9
Changes since 1.3: +1 -1 lines
Diff to previous 1.3 (colored)

fix ident

Revision 1.3 / (download) - annotate - [select for diffs], Thu Sep 9 10:45:45 2010 UTC (13 years, 8 months ago) by djm
Branch: MAIN
Changes since 1.2: +4 -2 lines
Diff to previous 1.2 (colored)

ECDH/ECDSA compliance fix: these methods vary the hash function they use
(SHA256/384/512) depending on the length of the curve in use. The previous
code incorrectly used SHA256 in all cases.

This fix will cause authentication failure when using 384 or 521-bit curve
keys if one peer hasn't been upgraded and the other has. (256-bit curve
keys work ok). In particular you may need to specify HostkeyAlgorithms
when connecting to a server that has not been upgraded from an upgraded
client.

ok naddy@

Revision 1.2 / (download) - annotate - [select for diffs], Mon Sep 6 16:53:54 2010 UTC (13 years, 8 months ago) by deraadt
Branch: MAIN
Changes since 1.1: +1 -1 lines
Diff to previous 1.1 (colored)

decl before code for compiler compatibility

Revision 1.1 / (download) - annotate - [select for diffs], Tue Aug 31 11:54:45 2010 UTC (13 years, 8 months ago) by djm
Branch: MAIN

Implement Elliptic Curve Cryptography modes for key exchange (ECDH) and
host/user keys (ECDSA) as specified by RFC5656. ECDH and ECDSA offer
better performance than plain DH and DSA at the same equivalent symmetric
key length, as well as much shorter keys.

Only the mandatory sections of RFC5656 are implemented, specifically the
three REQUIRED curves nistp256, nistp384 and nistp521 and only ECDH and
ECDSA. Point compression (optional in RFC5656 is NOT implemented).

Certificate host and user keys using the new ECDSA key types are supported.

Note that this code has not been tested for interoperability and may be
subject to change.

feedback and ok markus@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.