=================================================================== RCS file: /cvsrepo/anoncvs/cvs/src/usr.bin/ssh/ssh-keygen.c,v retrieving revision 1.32.2.3 retrieving revision 1.42 diff -u -r1.32.2.3 -r1.42 --- src/usr.bin/ssh/ssh-keygen.c 2001/03/21 19:46:30 1.32.2.3 +++ src/usr.bin/ssh/ssh-keygen.c 2001/02/04 15:32:26 1.42 @@ -12,7 +12,7 @@ */ #include "includes.h" -RCSID("$OpenBSD: ssh-keygen.c,v 1.32.2.3 2001/03/21 19:46:30 jason Exp $"); +RCSID("$OpenBSD: ssh-keygen.c,v 1.42 2001/02/04 15:32:26 stevesk Exp $"); #include #include @@ -46,7 +46,6 @@ /* Flag indicating that we just want to see the key fingerprint */ int print_fingerprint = 0; -int print_bubblebabble = 0; /* The identity file name, given on the command line or entered by the user. */ char identity_file[1024]; @@ -322,15 +321,13 @@ void do_fingerprint(struct passwd *pw) { + FILE *f; Key *public; - char *comment = NULL, *cp, *ep, line[16*1024], *fp; - int i, skip = 0, num = 1, invalid = 1, success = 0, rep, type; + char *comment = NULL, *cp, *ep, line[16*1024]; + int i, skip = 0, num = 1, invalid = 1, success = 0; struct stat st; - type = print_bubblebabble ? SSH_FP_SHA1 : SSH_FP_MD5; - rep = print_bubblebabble ? SSH_FP_BUBBLEBABBLE : SSH_FP_HEX; - if (!have_identity) ask_filename(pw, "Enter file in which the key is"); if (stat(identity_file, &st) < 0) { @@ -349,12 +346,9 @@ debug("try_load_public_key KEY_UNSPEC failed"); } if (success) { - fp = key_fingerprint(public, type, rep); - printf("%d %s %s\n", key_size(public), - fp, comment); + printf("%d %s %s\n", key_size(public), key_fingerprint(public), comment); key_free(public); xfree(comment); - xfree(fp); exit(0); } @@ -405,10 +399,9 @@ } } comment = *cp ? cp : comment; - fp = key_fingerprint(public, type, rep); - printf("%d %s %s\n", key_size(public), fp, + printf("%d %s %s\n", key_size(public), + key_fingerprint(public), comment ? comment : "no comment"); - xfree(fp); invalid = 0; } fclose(f); @@ -515,11 +508,12 @@ void do_change_comment(struct passwd *pw) { - char new_comment[1024], *comment, *passphrase; - Key *private, *public; + char new_comment[1024], *comment; + Key *private; + Key *public; + char *passphrase; struct stat st; FILE *f; - int fd; if (!have_identity) ask_filename(pw, "Enter file in which the key is"); @@ -534,7 +528,6 @@ public = key_new(KEY_RSA1); if (!load_public_key(identity_file, public, NULL)) { printf("%s is not a valid key file.\n", identity_file); - printf("Comments are only supported in RSA1 keys\n"); exit(1); } @@ -587,16 +580,11 @@ key_free(private); strlcat(identity_file, ".pub", sizeof(identity_file)); - fd = open(identity_file, O_WRONLY | O_CREAT | O_TRUNC, 0644); - if (fd == -1) { + f = fopen(identity_file, "w"); + if (!f) { printf("Could not save your public key in %s\n", identity_file); exit(1); } - f = fdopen(fd, "w"); - if (f == NULL) { - printf("fdopen %s failed", identity_file); - exit(1); - } if (!key_write(public, f)) fprintf(stderr, "write key failed"); key_free(public); @@ -612,8 +600,7 @@ void usage(void) { - printf("Usage: %s [-lpqxXyc] [-t type] [-b bits] [-f file] [-C comment] " - "[-N new-pass] [-P pass]\n", __progname); + printf("Usage: %s [-lpqxXyc] [-t type] [-b bits] [-f file] [-C comment] [-N new-pass] [-P pass]\n", __progname); exit(1); } @@ -624,11 +611,12 @@ main(int ac, char **av) { char dotsshdir[16 * 1024], comment[1024], *passphrase1, *passphrase2; - Key *private, *public; struct passwd *pw; - int opt, type, fd; + int opt, type; struct stat st; FILE *f; + Key *private; + Key *public; extern int optind; extern char *optarg; @@ -646,7 +634,7 @@ exit(1); } - while ((opt = getopt(ac, av, "dqpclBRxXyb:f:t:P:N:C:")) != -1) { + while ((opt = getopt(ac, av, "dqpclRxXyb:f:t:P:N:C:")) != -1) { switch (opt) { case 'b': bits = atoi(optarg); @@ -660,10 +648,6 @@ print_fingerprint = 1; break; - case 'B': - print_bubblebabble = 1; - break; - case 'p': change_passphrase = 1; break; @@ -731,7 +715,7 @@ printf("Can only have one of -p and -c.\n"); usage(); } - if (print_fingerprint || print_bubblebabble) + if (print_fingerprint) do_fingerprint(pw); if (change_passphrase) do_change_passphrase(pw); @@ -834,28 +818,21 @@ printf("Your identification has been saved in %s.\n", identity_file); strlcat(identity_file, ".pub", sizeof(identity_file)); - fd = open(identity_file, O_WRONLY | O_CREAT | O_TRUNC, 0644); - if (fd == -1) { + f = fopen(identity_file, "w"); + if (!f) { printf("Could not save your public key in %s\n", identity_file); exit(1); } - f = fdopen(fd, "w"); - if (f == NULL) { - printf("fdopen %s failed", identity_file); - exit(1); - } if (!key_write(public, f)) fprintf(stderr, "write key failed"); fprintf(f, " %s\n", comment); fclose(f); if (!quiet) { - char *fp = key_fingerprint(public, SSH_FP_MD5, SSH_FP_HEX); printf("Your public key has been saved in %s.\n", identity_file); printf("The key fingerprint is:\n"); - printf("%s %s\n", fp, comment); - xfree(fp); + printf("%s %s\n", key_fingerprint(public), comment); } key_free(public);