=================================================================== RCS file: /cvsrepo/anoncvs/cvs/src/usr.bin/ssh/ssh-keyscan.c,v retrieving revision 1.35.2.3 retrieving revision 1.36 diff -u -r1.35.2.3 -r1.36 --- src/usr.bin/ssh/ssh-keyscan.c 2003/04/03 22:35:18 1.35.2.3 +++ src/usr.bin/ssh/ssh-keyscan.c 2002/06/16 21:30:58 1.36 @@ -7,7 +7,7 @@ */ #include "includes.h" -RCSID("$OpenBSD: ssh-keyscan.c,v 1.35.2.3 2003/04/03 22:35:18 miod Exp $"); +RCSID("$OpenBSD: ssh-keyscan.c,v 1.36 2002/06/16 21:30:58 itojun Exp $"); #include #include @@ -109,8 +109,7 @@ if (!(lb = malloc(sizeof(*lb)))) { if (errfun) - (*errfun) ("linebuf (%s): malloc failed\n", - filename ? filename : "(stdin)"); + (*errfun) ("linebuf (%s): malloc failed\n", lb->filename); return (NULL); } if (filename) { @@ -165,14 +164,13 @@ Linebuf_getline(Linebuf * lb) { int n = 0; - void *p; lb->lineno++; for (;;) { /* Read a line */ if (!fgets(&lb->buf[n], lb->size - n, lb->stream)) { if (ferror(lb->stream) && lb->errfun) - (*lb->errfun)("%s: %s\n", lb->filename, + (*lb->errfun) ("%s: %s\n", lb->filename, strerror(errno)); return (NULL); } @@ -185,20 +183,17 @@ } if (n != lb->size - 1) { if (lb->errfun) - (*lb->errfun)("%s: skipping incomplete last line\n", + (*lb->errfun) ("%s: skipping incomplete last line\n", lb->filename); return (NULL); } /* Double the buffer if we need more space */ - lb->size *= 2; - if ((p = realloc(lb->buf, lb->size)) == NULL) { - lb->size /= 2; + if (!(lb->buf = realloc(lb->buf, (lb->size *= 2)))) { if (lb->errfun) - (*lb->errfun)("linebuf (%s): realloc failed\n", + (*lb->errfun) ("linebuf (%s): realloc failed\n", lb->filename); return (NULL); } - lb->buf = p; } } @@ -219,7 +214,6 @@ fdlim_set(int lim) { struct rlimit rlfd; - if (lim <= 0) return (-1); if (getrlimit(RLIMIT_NOFILE, &rlfd) < 0) @@ -335,8 +329,6 @@ myproposal[PROPOSAL_SERVER_HOST_KEY_ALGS] = c->c_keytype == KT_DSA? "ssh-dss": "ssh-rsa"; c->c_kex = kex_setup(myproposal); - c->c_kex->kex[KEX_DH_GRP1_SHA1] = kexdh_client; - c->c_kex->kex[KEX_DH_GEX_SHA1] = kexgex_client; c->c_kex->verify_host_key = hostjump; if (!(j = setjmp(kexjmp))) { @@ -400,8 +392,8 @@ static int conalloc(char *iname, char *oname, int keytype) { - char *namebase, *name, *namelist; int s; + char *namebase, *name, *namelist; namebase = namelist = xstrdup(iname); @@ -465,8 +457,8 @@ static int conrecycle(int s) { - con *c = &fdcon[s]; int ret; + con *c = &fdcon[s]; ret = conalloc(c->c_namelist, c->c_output_name, c->c_keytype); confree(s); @@ -476,10 +468,10 @@ static void congreet(int s) { - int remote_major, remote_minor, n = 0; char buf[256], *cp; char remote_version[sizeof buf]; size_t bufsiz; + int remote_major, remote_minor, n = 0; con *c = &fdcon[s]; bufsiz = sizeof(buf); @@ -543,8 +535,8 @@ static void conread(int s) { - con *c = &fdcon[s]; int n; + con *c = &fdcon[s]; if (c->c_status == CS_CON) { congreet(s); @@ -583,10 +575,10 @@ static void conloop(void) { - struct timeval seltime, now; fd_set *r, *e; - con *c; + struct timeval seltime, now; int i; + con *c; gettimeofday(&now, NULL); c = TAILQ_FIRST(&tq); @@ -653,7 +645,6 @@ fatal(const char *fmt,...) { va_list args; - va_start(args, fmt); do_log(SYSLOG_LEVEL_FATAL, fmt, args); va_end(args); @@ -666,9 +657,16 @@ static void usage(void) { - fprintf(stderr, "usage: %s [-v46] [-p port] [-T timeout] [-f file]\n" - "\t\t [host | addrlist namelist] [...]\n", + fprintf(stderr, "Usage: %s [options] host ...\n", __progname); + fprintf(stderr, "Options:\n"); + fprintf(stderr, " -f file Read hosts or addresses from file.\n"); + fprintf(stderr, " -p port Connect to the specified port.\n"); + fprintf(stderr, " -t keytype Specify the host key type.\n"); + fprintf(stderr, " -T timeout Set connection timeout.\n"); + fprintf(stderr, " -v Verbose; display verbose debugging messages.\n"); + fprintf(stderr, " -4 Use IPv4 only.\n"); + fprintf(stderr, " -6 Use IPv6 only.\n"); exit(1); } @@ -697,11 +695,9 @@ } break; case 'T': - timeout = convtime(optarg); - if (timeout == -1 || timeout == 0) { - fprintf(stderr, "Bad timeout '%s'\n", optarg); + timeout = atoi(optarg); + if (timeout <= 0) usage(); - } break; case 'v': if (!debug_flag) {