OpenBSD CVS

CVS log for src/usr.bin/systat/mbufs.c


[BACK] Up to [local] / src / usr.bin / systat

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.44 / (download) - annotate - [select for diffs], Tue Dec 22 06:57:18 2020 UTC (3 years, 4 months ago) by dlg
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, HEAD
Changes since 1.43: +2 -2 lines
Diff to previous 1.43 (colored)

print all the rings on a nic without limiting it to the number of mclpools

"makes sense" jmatthew@

Revision 1.43 / (download) - annotate - [select for diffs], Mon Jun 15 10:54:29 2020 UTC (3 years, 11 months ago) by dlg
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8
Changes since 1.42: +17 -14 lines
Diff to previous 1.42 (colored)

print the name of the rings in systat mbuf output too.

useful if you're looking at a nic with a lot of different rings.

Revision 1.42 / (download) - annotate - [select for diffs], Fri Jun 28 13:35:04 2019 UTC (4 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.41: +7 -7 lines
Diff to previous 1.41 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.41 / (download) - annotate - [select for diffs], Mon Apr 4 16:26:00 2016 UTC (8 years, 1 month ago) by sthen
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.40: +2 -1 lines
Diff to previous 1.40 (colored)

Add sys/queue.h where it's needed. Unbreak userland following recent
removal from mbuf.h.  ok mpi@

Revision 1.40 / (download) - annotate - [select for diffs], Sat Apr 18 09:32:59 2015 UTC (9 years, 1 month ago) by jsg
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9, OPENBSD_5_8_BASE, OPENBSD_5_8
Changes since 1.39: +4 -3 lines
Diff to previous 1.39 (colored)

Avoid calling freeifaddrs() with an uninitialised pointer in an
error path.

Revision 1.39 / (download) - annotate - [select for diffs], Tue Jan 20 18:26:57 2015 UTC (9 years, 3 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.38: +1 -2 lines
Diff to previous 1.38 (colored)

Adjust <sys/param.h> comments regarding use of use of MSIZE, or
delete <sys/param.h> if now possible
ok guenther

Revision 1.38 / (download) - annotate - [select for diffs], Fri Jan 16 00:03:37 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
Changes since 1.37: +4 -3 lines
Diff to previous 1.37 (colored)

first batch of programs adapting to the namespace cleanup
(pfvar.h nameser.h proc.h ucred.h)
ok guenther millert, and some review from doug as well.

Revision 1.37 / (download) - annotate - [select for diffs], Thu Nov 6 12:50:55 2014 UTC (9 years, 6 months ago) by dlg
Branch: MAIN
Changes since 1.36: +2 -2 lines
Diff to previous 1.36 (colored)

i renamed the mbuf pool.

Revision 1.36 / (download) - annotate - [select for diffs], Mon Oct 20 07:06:00 2014 UTC (9 years, 7 months ago) by jsg
Branch: MAIN
Changes since 1.35: +2 -2 lines
Diff to previous 1.35 (colored)

fix if (statement);
ok dlg@

Revision 1.35 / (download) - annotate - [select for diffs], Tue Jul 8 05:35:19 2014 UTC (9 years, 10 months ago) by dlg
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.34: +107 -68 lines
Diff to previous 1.34 (colored)

cut things that relied on mclgeti for rx ring accounting/restriction over
to using if_rxr.

cut the reporting systat did over to the rxr ioctl.

tested as much as i can on alpha, amd64, and sparc64.
mpi@ has run it on macppc.
ok mpi@

Revision 1.34 / (download) - annotate - [select for diffs], Wed Jul 2 00:12:34 2014 UTC (9 years, 10 months ago) by dlg
Branch: MAIN
Changes since 1.33: +7 -7 lines
Diff to previous 1.33 (colored)

info about pools is currently given to userland by copying each
pools struct out. however, struct pool in the kernel contains lots
of things that userland probably isnt interested in, like actual
mutexes, and probably shouldnt get easy access to, like pointers
to kernel memory via all the lists/trees.

this implements a kinfo_pool structure that has only the data that
userland needs to know about. it cuts the sysctl code over to
building it from struct pool as required and copying that out
instead, and cuts userland over to only handling kinfo_pool.

the only problem with this is vmstat, which can read kernel images
via kvm, which needs some understanding of struct pool. to cope,
the struct pool definition is guarded by if defined(_KERNEL) ||
defined(_LIBKVM) as inspired by sysctl which needs to do the same
thing sometimes. struct pool itself is generally not visible to
userland though, which is good.

matthew@ suggested struct kinfo_pool instead of struct pool_info.
the kinfo prefix has precedent.
lots of people liked this.

Revision 1.33 / (download) - annotate - [select for diffs], Fri Jun 13 07:31:18 2014 UTC (9 years, 11 months ago) by mpi
Branch: MAIN
Changes since 1.32: +6 -9 lines
Diff to previous 1.32 (colored)

Now that the water marks are updated on a per-pool basis indicate in
the LIVELOCKS column if there is a pending (deferred) update.

ok claudio@

Revision 1.32 / (download) - annotate - [select for diffs], Wed Mar 2 06:48:17 2011 UTC (13 years, 2 months ago) by jasper
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0
Changes since 1.31: +10 -12 lines
Diff to previous 1.31 (colored)

- use a common FIELD_ADDR macro, instead of rolling 78 identical copies.

ok canacar@

Revision 1.31 / (download) - annotate - [select for diffs], Fri Nov 5 10:07:30 2010 UTC (13 years, 6 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_4_9_BASE, OPENBSD_4_9
Changes since 1.30: +7 -5 lines
Diff to previous 1.30 (colored)

Print relativ number of livelocks that happend between two systat
updates instead of showing absolut figures. Makes it easier to
estimate the "livelockyness" of a system.
OK dlg@

Revision 1.30 / (download) - annotate - [select for diffs], Tue Nov 2 10:24:34 2010 UTC (13 years, 6 months ago) by dlg
Branch: MAIN
Changes since 1.29: +12 -3 lines
Diff to previous 1.29 (colored)

expose the kernels network livelock counter

Revision 1.29 / (download) - annotate - [select for diffs], Thu Sep 23 10:49:55 2010 UTC (13 years, 7 months ago) by dlg
Branch: MAIN
Changes since 1.28: +2 -2 lines
Diff to previous 1.28 (colored)

tweak the mclgeti algorithm to behave better under load.

instead of letting hardware rings grow on every interrupt, restrict
it so it can only grow once per softclock tick. we can only punish
the rings on softclock ticks, so it make sense to only grow on
softclock tick boundaries too.

the rings are now punished after >1 lost softclock tick rather than
>2. mclgeti is now more aggressive at detecting livelock.

the rings get punished by an 8th, rather than by half.

we now allow the rings to be punished again even if the system is
already considered in livelock.

without this diff a livelocked system will have its rx ring sizes
scale up and down very rapidly, while holding the rings low for too
long. this affected throughput significantly.

discussed and tested heavily at j2k10. there are still some games
with softnet we can play, but this is a good first step.

"put it in" and ok deraadt@
ok claudio@ krw@ henning@ mcbride@

if we find out that it sucks we can pull it out again later. till then
we'll run with it and see how it goes.

Revision 1.28 / (download) - annotate - [select for diffs], Sun Aug 1 05:30:13 2010 UTC (13 years, 9 months ago) by blambert
Branch: MAIN
CVS Tags: OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.27: +2 -1 lines
Diff to previous 1.27 (colored)

don't rely on mbuf.h to pull in pool.h here either

ok miod@

Revision 1.27 / (download) - annotate - [select for diffs], Sun Aug 1 03:09:48 2010 UTC (13 years, 9 months ago) by chl
Branch: MAIN
Changes since 1.26: +2 -2 lines
Diff to previous 1.26 (colored)

fix use of uninitialized variable.

reported by gcc.

ok canacar@

Revision 1.26 / (download) - annotate - [select for diffs], Mon Nov 23 21:44:33 2009 UTC (14 years, 5 months ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.25: +8 -12 lines
Diff to previous 1.25 (colored)

args, not that file

Revision 1.25 / (download) - annotate - [select for diffs], Mon Nov 23 21:30:14 2009 UTC (14 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.24: +13 -9 lines
Diff to previous 1.24 (colored)

no more natpass

Revision 1.24 / (download) - annotate - [select for diffs], Mon Apr 20 20:30:41 2009 UTC (15 years, 1 month ago) by chl
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6
Changes since 1.23: +2 -8 lines
Diff to previous 1.23 (colored)

remove unneeded argument to warnx()
remove unused variable
kill some extra blank lines

ok canacar@

Revision 1.23 / (download) - annotate - [select for diffs], Sun Mar 29 21:51:54 2009 UTC (15 years, 1 month ago) by kettenis
Branch: MAIN
Changes since 1.22: +10 -9 lines
Diff to previous 1.22 (colored)

Make sure systat mbufs prints the interface name even if an interface only
allocates clusters larger than 2k.

ok deraadt@

Revision 1.22 / (download) - annotate - [select for diffs], Tue Jan 27 09:18:37 2009 UTC (15 years, 3 months ago) by dlg
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.21: +5 -6 lines
Diff to previous 1.21 (colored)

fix the mbuf view to cope with the recent change to the mclgeti allocator.

from canacar@

Revision 1.21 / (download) - annotate - [select for diffs], Wed Dec 31 05:37:24 2008 UTC (15 years, 4 months ago) by canacar
Branch: MAIN
Changes since 1.20: +2 -3 lines
Diff to previous 1.20 (colored)

Skip missing pool indices instead of printing errors.

Revision 1.20 / (download) - annotate - [select for diffs], Thu Dec 18 19:46:39 2008 UTC (15 years, 5 months ago) by canacar
Branch: MAIN
Changes since 1.19: +3 -4 lines
Diff to previous 1.19 (colored)

Print the interface livelocks if non-zero. From deraadt@

Revision 1.19 / (download) - annotate - [select for diffs], Wed Dec 17 08:21:43 2008 UTC (15 years, 5 months ago) by canacar
Branch: MAIN
Changes since 1.18: +296 -112 lines
Diff to previous 1.18 (colored)

Rewrite the 'mbuf' page to display mbuf usage information from system pools
and mbuf cluster statistics collected for each interface. More useful than
earlier bar graphs about mbuf types. Requested by and ok deraadt@

Revision 1.18 / (download) - annotate - [select for diffs], Thu Jun 12 22:26:01 2008 UTC (15 years, 11 months ago) by canacar
Branch: MAIN
CVS Tags: OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.17: +110 -69 lines
Diff to previous 1.17 (colored)

New display engine for systat, based on pftop. Adds new views for pf
(status, state, rule, queue). While all displays work, some keyboard
comands are not implemented yet. Other features include better handling
of display resize and scrolling for long views. Committing now to fix
the remaining issues in the tree.
Testing and comments by otto@ and harding@, ok deraadt@

Revision 1.17 / (download) - annotate - [select for diffs], Sun Feb 25 18:21:24 2007 UTC (17 years, 2 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1
Changes since 1.16: +3 -3 lines
Diff to previous 1.16 (colored)

use the 1 line load line from 'systat vm' on all the other displays, giving
them more room.  much cleaner, and it is less code too; ok deanna

Revision 1.16 / (download) - annotate - [select for diffs], Fri Mar 31 04:10:59 2006 UTC (18 years, 1 month ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.15: +12 -10 lines
Diff to previous 1.15 (colored)

fairly simple cleanup, lots of testing done

Revision 1.15 / (download) - annotate - [select for diffs], Fri Jul 9 16:33:15 2004 UTC (19 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6
Changes since 1.14: +17 -47 lines
Diff to previous 1.14 (colored)

post-mortem stuff can go away here too

Revision 1.14 / (download) - annotate - [select for diffs], Sat Jul 3 22:25:15 2004 UTC (19 years, 10 months ago) by deraadt
Branch: MAIN
Changes since 1.13: +4 -4 lines
Diff to previous 1.13 (colored)

move sysctl comment on namelist[] entry

Revision 1.13 / (download) - annotate - [select for diffs], Tue Jun 3 02:56:17 2003 UTC (20 years, 11 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.12: +3 -7 lines
Diff to previous 1.12 (colored)

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999.  Proofed by myself and Theo.

Revision 1.12 / (download) - annotate - [select for diffs], Wed Jun 19 08:45:52 2002 UTC (21 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.11: +3 -3 lines
Diff to previous 1.11 (colored)

mark which nlist[] kmem entries are not needed in the sysctl case, and which are

Revision 1.11 / (download) - annotate - [select for diffs], Tue Jun 18 00:46:47 2002 UTC (21 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.10: +8 -9 lines
Diff to previous 1.10 (colored)

ANSI

Revision 1.10 / (download) - annotate - [select for diffs], Sun Jun 9 05:16:20 2002 UTC (21 years, 11 months ago) by angelos
Branch: MAIN
Changes since 1.9: +25 -12 lines
Diff to previous 1.9 (colored)

Use sysctl for mbstat

Revision 1.9 / (download) - annotate - [select for diffs], Fri Dec 7 09:18:08 2001 UTC (22 years, 5 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.8: +4 -3 lines
Diff to previous 1.8 (colored)

move back.  pvalchev -- the bug was quite obscure

Revision 1.8 / (download) - annotate - [select for diffs], Fri Dec 7 07:57:35 2001 UTC (22 years, 5 months ago) by pvalchev
Branch: MAIN
Changes since 1.7: +1 -2 lines
Diff to previous 1.7 (colored)

back out latest changes which cause problems on alpha/sparc64 until
they are fixed

Revision 1.7 / (download) - annotate - [select for diffs], Fri Nov 23 22:20:06 2001 UTC (22 years, 5 months ago) by deraadt
Branch: MAIN
Changes since 1.6: +4 -3 lines
Diff to previous 1.6 (colored)

fix signal races.  use sysctl() instead of kvm where possible, and then KNF
the hell out of it; checked by miod

Revision 1.6 / (download) - annotate - [select for diffs], Mon Nov 19 19:02:16 2001 UTC (22 years, 6 months ago) by mpech
Branch: MAIN
Changes since 1.5: +3 -3 lines
Diff to previous 1.5 (colored)

kill more registers

millert@ ok

Revision 1.5 / (download) - annotate - [select for diffs], Fri May 4 16:48:34 2001 UTC (23 years ago) by ericj
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0
Changes since 1.4: +7 -5 lines
Diff to previous 1.4 (colored)


handle kvm_nlist() failing, from pr#1798.
Patch similar to the one submitted by <peterw@documenta.com.au>

Revision 1.4 / (download) - annotate - [select for diffs], Fri Dec 19 09:03:32 1997 UTC (26 years, 5 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_9_BASE, OPENBSD_2_9, OPENBSD_2_8_BASE, OPENBSD_2_8, OPENBSD_2_7_BASE, OPENBSD_2_7, OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4, OPENBSD_2_3_BASE, OPENBSD_2_3
Changes since 1.3: +4 -4 lines
Diff to previous 1.3 (colored)

bye bye sprintf

Revision 1.3 / (download) - annotate - [select for diffs], Wed Jun 26 05:40:08 1996 UTC (27 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_2_BASE, OPENBSD_2_2, OPENBSD_2_1_BASE, OPENBSD_2_1, OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.2: +2 -1 lines
Diff to previous 1.2 (colored)

rcsid

Revision 1.2 / (download) - annotate - [select for diffs], Sun Jun 2 19:40:15 1996 UTC (27 years, 11 months ago) by mickey
Branch: MAIN
Changes since 1.1: +2 -2 lines
Diff to previous 1.1 (colored)

it compiles w/ new curses

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:46:10 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:46:10 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.