OpenBSD CVS

CVS log for src/usr.bin/systat/pool.c


[BACK] Up to [local] / src / usr.bin / systat

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.20 / (download) - annotate - [select for diffs], Sat May 18 09:02:34 2024 UTC (29 hours, 32 minutes ago) by jsg
Branch: MAIN
CVS Tags: HEAD
Changes since 1.19: +1 -2 lines
Diff to previous 1.19 (colored)

remove prototypes with no matching function

Revision 1.19 / (download) - annotate - [select for diffs], Fri Jun 28 13:35:04 2019 UTC (4 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.18: +2 -2 lines
Diff to previous 1.18 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.18 / (download) - annotate - [select for diffs], Wed Jun 20 13:09:08 2018 UTC (5 years, 11 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4
Changes since 1.17: +1 -3 lines
Diff to previous 1.17 (colored)

Remove unused variable. Make clang happier.

Revision 1.17 / (download) - annotate - [select for diffs], Sun Feb 11 09:47:33 2018 UTC (6 years, 3 months ago) by martijn
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_3
Changes since 1.16: +213 -16 lines
Diff to previous 1.16 (colored)

Make sorting in the pcache view work. This allows us to sort on all
shown columns. There's still parts that could do with a good polishing,
but it's an improvement.

OK tedu@

Revision 1.16 / (download) - annotate - [select for diffs], Thu Feb 8 13:22:25 2018 UTC (6 years, 3 months ago) by martijn
Branch: MAIN
Changes since 1.15: +3 -9 lines
Diff to previous 1.15 (colored)

Make pool order on size actually order on size instead of size*inuse.

Prompted by and OK otto@

Revision 1.15 / (download) - annotate - [select for diffs], Mon Jul 31 04:23:30 2017 UTC (6 years, 9 months ago) by dlg
Branch: MAIN
CVS Tags: OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.14: +2 -2 lines
Diff to previous 1.14 (colored)

print the number of GCs with print_fld_size instead of print_fld_uint.

this makes a large number of GCs appear as something like "26K"
instead of "*".

Revision 1.14 / (download) - annotate - [select for diffs], Sat Jul 29 16:03:10 2017 UTC (6 years, 9 months ago) by florian
Branch: MAIN
Changes since 1.13: +2 -1 lines
Diff to previous 1.13 (colored)

return -1 in error path of non-void function, pointed out by clang
OK deraadt

Revision 1.13 / (download) - annotate - [select for diffs], Fri Jun 23 01:02:18 2017 UTC (6 years, 10 months ago) by dlg
Branch: MAIN
Changes since 1.12: +5 -5 lines
Diff to previous 1.12 (colored)

change the semantic for calculating when to grow the size of a cache list.

previously it would figure out if there's enough items overall for
all the cpus to have full active an inactive free lists. this
included currently allocated items, which pools wont actually hold
on a free list and cannot predict when they will come back.

instead, see if there's enough items in the idle lists in the depot
that could instead go on all the free lists on the cpus. if there's
enough idle items, then we can grow.

tested by hrvoje popovski and amit kulkarni
ok visa@

Revision 1.12 / (download) - annotate - [select for diffs], Thu Jun 15 03:47:07 2017 UTC (6 years, 11 months ago) by dlg
Branch: MAIN
Changes since 1.11: +317 -31 lines
Diff to previous 1.11 (colored)

add a rough start to a pcache view, to show pool cpu cache info.

ok mikeb@ millert@

Revision 1.11 / (download) - annotate - [select for diffs], Sat Mar 12 12:45:27 2016 UTC (8 years, 2 months ago) by sthen
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.10: +2 -2 lines
Diff to previous 1.10 (colored)

Use 12 chars for pool name in "systat pool" to match vmstat -m.  ok stefan@

Revision 1.10 / (download) - annotate - [select for diffs], Fri Jan 16 00:03:37 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9, OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.9: +3 -2 lines
Diff to previous 1.9 (colored)

first batch of programs adapting to the namespace cleanup
(pfvar.h nameser.h proc.h ucred.h)
ok guenther millert, and some review from doug as well.

Revision 1.9 / (download) - annotate - [select for diffs], Wed Oct 8 04:10:04 2014 UTC (9 years, 7 months ago) by doug
Branch: MAIN
Changes since 1.8: +2 -2 lines
Diff to previous 1.8 (colored)

userland reallocarray audit.

Replace malloc() and realloc() calls that may have integer overflow in the
multiplication of the size argument with reallocarray().

ok deraadt@

Revision 1.8 / (download) - annotate - [select for diffs], Thu Aug 14 08:10:30 2014 UTC (9 years, 9 months ago) by mpi
Branch: MAIN
Changes since 1.7: +26 -3 lines
Diff to previous 1.7 (colored)

Show only active pools by default, pressing 'A' shows all of them.

ok deraadt@

Revision 1.7 / (download) - annotate - [select for diffs], Wed Jul 2 00:12:34 2014 UTC (9 years, 10 months ago) by dlg
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.6: +3 -3 lines
Diff to previous 1.6 (colored)

info about pools is currently given to userland by copying each
pools struct out. however, struct pool in the kernel contains lots
of things that userland probably isnt interested in, like actual
mutexes, and probably shouldnt get easy access to, like pointers
to kernel memory via all the lists/trees.

this implements a kinfo_pool structure that has only the data that
userland needs to know about. it cuts the sysctl code over to
building it from struct pool as required and copying that out
instead, and cuts userland over to only handling kinfo_pool.

the only problem with this is vmstat, which can read kernel images
via kvm, which needs some understanding of struct pool. to cope,
the struct pool definition is guarded by if defined(_KERNEL) ||
defined(_LIBKVM) as inspired by sysctl which needs to do the same
thing sometimes. struct pool itself is generally not visible to
userland though, which is good.

matthew@ suggested struct kinfo_pool instead of struct pool_info.
the kinfo prefix has precedent.
lots of people liked this.

Revision 1.6 / (download) - annotate - [select for diffs], Wed Mar 2 06:48:17 2011 UTC (13 years, 2 months ago) by jasper
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0
Changes since 1.5: +13 -15 lines
Diff to previous 1.5 (colored)

- use a common FIELD_ADDR macro, instead of rolling 78 identical copies.

ok canacar@

Revision 1.5 / (download) - annotate - [select for diffs], Wed Dec 31 05:37:24 2008 UTC (15 years, 4 months ago) by canacar
Branch: MAIN
CVS Tags: OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7, OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.4: +14 -8 lines
Diff to previous 1.4 (colored)

Skip missing pool indices instead of printing errors.

Revision 1.4 / (download) - annotate - [select for diffs], Sun Dec 7 07:46:05 2008 UTC (15 years, 5 months ago) by canacar
Branch: MAIN
Changes since 1.3: +42 -1 lines
Diff to previous 1.3 (colored)

Add option to order the pool view by size and number of pages columns.

Revision 1.3 / (download) - annotate - [select for diffs], Wed Nov 5 16:03:02 2008 UTC (15 years, 6 months ago) by chl
Branch: MAIN
Changes since 1.2: +2 -1 lines
Diff to previous 1.2 (colored)

add missing header needed by strcmp/strerror/memset functions.

ok canacar@

Revision 1.2 / (download) - annotate - [select for diffs], Sun Nov 2 07:14:16 2008 UTC (15 years, 6 months ago) by canacar
Branch: MAIN
Changes since 1.1: +21 -4 lines
Diff to previous 1.1 (colored)

Add the option to sort by requests to the pool view, and document
the hotkeys 'o' to select and 'r' to reverse column orderings.

Revision 1.1 / (download) - annotate - [select for diffs], Sun Nov 2 06:23:28 2008 UTC (15 years, 6 months ago) by canacar
Branch: MAIN

Add a view that displays pool(9) information. Idea and ok deraadt@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.