OpenBSD CVS

CVS log for src/usr.bin/timeout/timeout.c


[BACK] Up to [local] / src / usr.bin / timeout

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.26 / (download) - annotate - [select for diffs], Fri Nov 3 19:16:31 2023 UTC (6 months, 2 weeks ago) by cheloha
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, HEAD
Changes since 1.25: +3 -2 lines
Diff to previous 1.25 (colored)

timeout(1): align execvp(3) failure statuses with GNU timeout

Align our exit statuses with those of GNU timeout in the execvp(3)
failure case.  Exit with 127 if the utility is not found.  Exit with
126 if we cannot execute the utility for any other reason.

While here, the child should _exit(2) instead of calling exit(3) via
err(3).

Update the manpage accordingly.

With input from millert@ and deraadt@.

Link: https://marc.info/?l=openbsd-tech&m=169739592322978&w=2

ok millert@

Revision 1.25 / (download) - annotate - [select for diffs], Fri Jan 13 06:53:04 2023 UTC (16 months ago) by cheloha
Branch: MAIN
CVS Tags: OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3
Changes since 1.24: +5 -5 lines
Diff to previous 1.24 (colored)

timeout(1): sig_atomic_t variables must also be 'volatile'; ok job@

Revision 1.24 / (download) - annotate - [select for diffs], Thu Jan 12 14:08:39 2023 UTC (16 months ago) by jmc
Branch: MAIN
Changes since 1.23: +2 -2 lines
Diff to previous 1.23 (colored)

diff from sobrado to use a full argument name for -s: after some discussion
we used "signal", as per pkill/pgrep; also lift the descriptive text
from kill.1 to clarify that both signal name and number are accepted;

ok sobrado job

Revision 1.23 / (download) - annotate - [select for diffs], Tue Jan 10 14:19:12 2023 UTC (16 months, 1 week ago) by job
Branch: MAIN
Changes since 1.22: +13 -8 lines
Diff to previous 1.22 (colored)

Add short options for --foreground and --preserve-status

Align with upcoming POSIX spec: https://www.austingroupbugs.net/view.php?id=1586

OK jmc@

Revision 1.22 / (download) - annotate - [select for diffs], Thu Dec 22 19:53:23 2022 UTC (16 months, 3 weeks ago) by kn
Branch: MAIN
Changes since 1.21: +2 -2 lines
Diff to previous 1.21 (colored)

Denote multiple arguments with 'arg ...' not 'args'

A few programs used the plural in their synopsis which doesn't read as
clear as the obvious triple-dot notation.

mdoc(7) .Ar defaults to "file ..." if no arguments are given and consistent
use of 'arg ...' matches that behaviour.

Cleanup a few markups of the same argument so the text keeps reading
naturally;  omit unhelpful parts like 'if optional arguments are given,
they are passed along' for tools like time(1) and timeout(1) that obviously
execute commands with whatever arguments where given -- just like doas(1)
which doesn't mention arguments in its DESCRIPTION in the first place.

For expr(1) the difference between 'expressions' and 'expression ...' is
crucial, as arguments must be passed as individual words.

Feedback millert jmc schwarze deraadt
OK jmc

Revision 1.21 / (download) - annotate - [select for diffs], Sat Jul 2 19:00:35 2022 UTC (22 months, 2 weeks ago) by kn
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2
Changes since 1.20: +5 -3 lines
Diff to previous 1.20 (colored)

Make -s accept HUP like kill(1) and GNU timeout(1) do

timeout.c's parse_signal() basically does what kill.c's signame_to_num()
does, except it expects "SIG" in string signals.

Borrow the isalpha() check from kill.c to get the same behaviour.

OK deraadt

Revision 1.20 / (download) - annotate - [select for diffs], Wed Jan 12 22:51:44 2022 UTC (2 years, 4 months ago) by tb
Branch: MAIN
CVS Tags: OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.19: +14 -14 lines
Diff to previous 1.19 (colored)

zap spaces before tabs

Revision 1.19 / (download) - annotate - [select for diffs], Sat Sep 4 11:49:11 2021 UTC (2 years, 8 months ago) by schwarze
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0
Changes since 1.18: +7 -7 lines
Diff to previous 1.18 (colored)

* more specific error messages
* no need to check suffix != NULL twice in a row
* style:  *(suffix + 1)  ->  suffix[1]
feedback & OK deraadt@

Revision 1.18 / (download) - annotate - [select for diffs], Thu Sep 2 21:50:24 2021 UTC (2 years, 8 months ago) by jmc
Branch: MAIN
Changes since 1.17: +5 -3 lines
Diff to previous 1.17 (colored)

various improvements to the text/usage, chiefly removing alternative long
options from SYNOPSIS/usage;

diff from leon fischer

the opening sentence is mine - i say that not to take credit, just to
distinguish that leon did not agree with wording

Revision 1.17 / (download) - annotate - [select for diffs], Thu Sep 2 11:26:54 2021 UTC (2 years, 8 months ago) by semarie
Branch: MAIN
Changes since 1.16: +4 -5 lines
Diff to previous 1.16 (colored)

timeout(1): execvp(2) does not return except on error

there is no need to check if the return value is -1. just
unconditionally call err(3).

ok deraadt@ schwarze@

Revision 1.16 / (download) - annotate - [select for diffs], Thu Sep 2 09:35:17 2021 UTC (2 years, 8 months ago) by deraadt
Branch: MAIN
Changes since 1.15: +3 -2 lines
Diff to previous 1.15 (colored)

move comment into correct place

Revision 1.15 / (download) - annotate - [select for diffs], Thu Sep 2 09:08:08 2021 UTC (2 years, 8 months ago) by deraadt
Branch: MAIN
Changes since 1.14: +7 -7 lines
Diff to previous 1.14 (colored)

bunch of err() should be errx()

Revision 1.14 / (download) - annotate - [select for diffs], Thu Sep 2 08:52:10 2021 UTC (2 years, 8 months ago) by job
Branch: MAIN
Changes since 1.13: +1 -2 lines
Diff to previous 1.13 (colored)

No need to list foreign source code repository tags

Feedback from deraadt@

Revision 1.13 / (download) - annotate - [select for diffs], Thu Sep 2 06:23:32 2021 UTC (2 years, 8 months ago) by deraadt
Branch: MAIN
Changes since 1.12: +2 -2 lines
Diff to previous 1.12 (colored)

some functionality requires pledge "proc"

Revision 1.12 / (download) - annotate - [select for diffs], Wed Sep 1 21:45:10 2021 UTC (2 years, 8 months ago) by job
Branch: MAIN
Changes since 1.11: +2 -1 lines
Diff to previous 1.11 (colored)

Add the NetBSD source code repository tag back to help future historians

Revision 1.11 / (download) - annotate - [select for diffs], Wed Sep 1 21:43:51 2021 UTC (2 years, 8 months ago) by job
Branch: MAIN
Changes since 1.10: +10 -11 lines
Diff to previous 1.10 (colored)

Fix overflow / underflow check by moving it up before the return

Also rename 'end' to 'suffix' for readability.

OK beck@

Revision 1.10 / (download) - annotate - [select for diffs], Wed Sep 1 20:18:54 2021 UTC (2 years, 8 months ago) by job
Branch: MAIN
Changes since 1.9: +9 -8 lines
Diff to previous 1.9 (colored)

Update project tag line, shorten some err() calls

Revision 1.9 / (download) - annotate - [select for diffs], Wed Sep 1 20:03:43 2021 UTC (2 years, 8 months ago) by deraadt
Branch: MAIN
Changes since 1.8: +6 -12 lines
Diff to previous 1.8 (colored)

small unused/initialization improvements

Revision 1.8 / (download) - annotate - [select for diffs], Wed Sep 1 20:01:14 2021 UTC (2 years, 8 months ago) by deraadt
Branch: MAIN
Changes since 1.7: +3 -10 lines
Diff to previous 1.7 (colored)

repair strtonum idiom and improve error messaging
ok job

Revision 1.7 / (download) - annotate - [select for diffs], Wed Sep 1 19:54:34 2021 UTC (2 years, 8 months ago) by job
Branch: MAIN
Changes since 1.6: +6 -6 lines
Diff to previous 1.6 (colored)

Style nits

Contribution from Anton Lindqvist

Revision 1.6 / (download) - annotate - [select for diffs], Wed Sep 1 16:12:38 2021 UTC (2 years, 8 months ago) by job
Branch: MAIN
Changes since 1.5: +0 -1 lines
Diff to previous 1.5 (colored)

Case h is pointless

Feedback from deraadt@

Revision 1.5 / (download) - annotate - [select for diffs], Wed Sep 1 16:11:30 2021 UTC (2 years, 8 months ago) by job
Branch: MAIN
Changes since 1.4: +2 -10 lines
Diff to previous 1.4 (colored)

Fix indenting

Feedback from deraadt@

Revision 1.4 / (download) - annotate - [select for diffs], Wed Sep 1 16:09:54 2021 UTC (2 years, 8 months ago) by job
Branch: MAIN
Changes since 1.3: +6 -8 lines
Diff to previous 1.3 (colored)

Simplify code by replacing strtol() with strtonum()

Feedback from deraadt@

Revision 1.3 / (download) - annotate - [select for diffs], Wed Sep 1 16:04:40 2021 UTC (2 years, 8 months ago) by job
Branch: MAIN
Changes since 1.2: +11 -5 lines
Diff to previous 1.2 (colored)

pledge() timeout

Feedback from deraadt@

Revision 1.2 / (download) - annotate - [select for diffs], Wed Sep 1 16:00:48 2021 UTC (2 years, 8 months ago) by job
Branch: MAIN
Changes since 1.1: +16 -20 lines
Diff to previous 1.1 (colored)

Remove sysexits.h reference and improve usage string.

Feedback from deraadt@

Revision 1.1 / (download) - annotate - [select for diffs], Wed Sep 1 15:50:33 2021 UTC (2 years, 8 months ago) by job
Branch: MAIN

Import timeout(1) from NetBSD

The timeout(1) utility can be used to run commands with a time limit.

OK deraadt@ beck@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.