=================================================================== RCS file: /cvsrepo/anoncvs/cvs/src/usr.bin/tmux/cmd-find.c,v retrieving revision 1.39 retrieving revision 1.40 diff -u -r1.39 -r1.40 --- src/usr.bin/tmux/cmd-find.c 2016/10/18 12:51:26 1.39 +++ src/usr.bin/tmux/cmd-find.c 2016/11/16 00:24:03 1.40 @@ -1,4 +1,4 @@ -/* $OpenBSD: cmd-find.c,v 1.39 2016/10/18 12:51:26 nicm Exp $ */ +/* $OpenBSD: cmd-find.c,v 1.40 2016/11/16 00:24:03 nicm Exp $ */ /* * Copyright (c) 2015 Nicholas Marriott @@ -658,7 +658,7 @@ /* Check for pane ids starting with %. */ if (*pane == '%') { fs->wp = window_pane_find_by_id_str(pane); - if (fs->wp == NULL) + if (fs->wp == NULL || window_pane_outside(fs->wp)) return (-1); fs->w = fs->wp->window; return (cmd_find_best_session_with_window(fs)); @@ -695,7 +695,7 @@ /* Check for pane ids starting with %. */ if (*pane == '%') { fs->wp = window_pane_find_by_id_str(pane); - if (fs->wp == NULL) + if (fs->wp == NULL || window_pane_outside(fs->wp)) return (-1); fs->w = fs->wp->window; return (cmd_find_best_winlink_with_window(fs)); @@ -727,8 +727,10 @@ /* Check for pane ids starting with %. */ if (*pane == '%') { fs->wp = window_pane_find_by_id_str(pane); - if (fs->wp == NULL || fs->wp->window != fs->w) + if (fs->wp == NULL || window_pane_outside(fs->wp)) return (-1); + if (fs->wp->window != fs->w) + return (-1); return (0); } @@ -737,25 +739,27 @@ if (fs->w->last == NULL) return (-1); fs->wp = fs->w->last; + if (fs->wp == NULL || window_pane_outside(fs->wp)) + return (-1); return (0); } else if (strcmp(pane, "{up-of}") == 0) { fs->wp = window_pane_find_up(fs->w->active); - if (fs->wp == NULL) + if (fs->wp == NULL || window_pane_outside(fs->wp)) return (-1); return (0); } else if (strcmp(pane, "{down-of}") == 0) { fs->wp = window_pane_find_down(fs->w->active); - if (fs->wp == NULL) + if (fs->wp == NULL || window_pane_outside(fs->wp)) return (-1); return (0); } else if (strcmp(pane, "{left-of}") == 0) { fs->wp = window_pane_find_left(fs->w->active); - if (fs->wp == NULL) + if (fs->wp == NULL || window_pane_outside(fs->wp)) return (-1); return (0); } else if (strcmp(pane, "{right-of}") == 0) { fs->wp = window_pane_find_right(fs->w->active); - if (fs->wp == NULL) + if (fs->wp == NULL || window_pane_outside(fs->wp)) return (-1); return (0); } @@ -771,7 +775,7 @@ fs->wp = window_pane_next_by_number(fs->w, wp, n); else fs->wp = window_pane_previous_by_number(fs->w, wp, n); - if (fs->wp != NULL) + if (fs->wp != NULL && !window_pane_outside(fs->wp)) return (0); } @@ -779,13 +783,13 @@ idx = strtonum(pane, 0, INT_MAX, &errstr); if (errstr == NULL) { fs->wp = window_pane_at_index(fs->w, idx); - if (fs->wp != NULL) + if (fs->wp != NULL && !window_pane_outside(fs->wp)) return (0); } /* Try as a description. */ fs->wp = window_find_string(fs->w, pane); - if (fs->wp != NULL) + if (fs->wp != NULL && !window_pane_outside(fs->wp)) return (0); return (-1); @@ -837,7 +841,7 @@ if (!window_has_pane(fs->w, fs->wp)) return (0); - return (window_pane_visible(fs->wp)); + return (!window_pane_outside(fs->wp)); } /* Copy a state. */ @@ -945,6 +949,8 @@ { if (cmd_find_from_window(fs, wp->window) != 0) return (-1); + if (window_pane_outside(wp)) + return (-1); fs->wp = wp; cmd_find_log_state(__func__, fs); @@ -1012,7 +1018,7 @@ switch (type) { case CMD_FIND_PANE: fs->wp = cmd_mouse_pane(m, &fs->s, &fs->wl); - if (fs->wp != NULL) + if (fs->wp != NULL && !window_pane_outside(fs->wp)) fs->w = fs->wl->window; break; case CMD_FIND_WINDOW: