=================================================================== RCS file: /cvsrepo/anoncvs/cvs/src/usr.bin/tmux/cmd-new-window.c,v retrieving revision 1.72 retrieving revision 1.73 diff -u -r1.72 -r1.73 --- src/usr.bin/tmux/cmd-new-window.c 2017/08/30 10:33:57 1.72 +++ src/usr.bin/tmux/cmd-new-window.c 2018/03/01 12:53:08 1.73 @@ -1,4 +1,4 @@ -/* $OpenBSD: cmd-new-window.c,v 1.72 2017/08/30 10:33:57 nicm Exp $ */ +/* $OpenBSD: cmd-new-window.c,v 1.73 2018/03/01 12:53:08 nicm Exp $ */ /* * Copyright (c) 2007 Nicholas Marriott @@ -57,8 +57,8 @@ struct winlink *wl = item->target.wl; struct client *c = cmd_find_client(item, NULL, 1); int idx = item->target.idx; - const char *cmd, *path, *template, *cwd; - char **argv, *cause, *cp, *to_free = NULL; + const char *cmd, *path, *template, *tmp; + char **argv, *cause, *cp, *cwd, *name; int argc, detached; struct environ_entry *envent; struct cmd_find_state fs; @@ -93,15 +93,18 @@ if (envent != NULL) path = envent->value; - if (args_has(args, 'c')) { - cwd = args_get(args, 'c'); - to_free = format_single(item, cwd, c, s, NULL, NULL); - cwd = to_free; - } else if (item->client != NULL && item->client->session == NULL) - cwd = item->client->cwd; + if ((tmp = args_get(args, 'c')) != NULL) + cwd = format_single(item, tmp, c, s, NULL, NULL); + else if (item->client != NULL && item->client->session == NULL) + cwd = xstrdup(item->client->cwd); else - cwd = s->cwd; + cwd = xstrdup(s->cwd); + if ((tmp = args_get(args, 'n')) != NULL) + name = format_single(item, tmp, c, s, NULL, NULL); + else + name = NULL; + wl = NULL; if (idx != -1) wl = winlink_find_by_index(&s->windows, idx); @@ -124,7 +127,7 @@ if (idx == -1) idx = -1 - options_get_number(s->options, "base-index"); - wl = session_new(s, args_get(args, 'n'), argc, argv, path, cwd, idx, + wl = session_new(s, name, argc, argv, path, cwd, idx, &cause); if (wl == NULL) { cmdq_error(item, "create window failed: %s", cause); @@ -149,10 +152,12 @@ cmd_find_from_winlink(&fs, wl, 0); hooks_insert(s->hooks, item, &fs, "after-new-window"); - free(to_free); + free(name); + free(cwd); return (CMD_RETURN_NORMAL); error: - free(to_free); + free(name); + free(cwd); return (CMD_RETURN_ERROR); }