OpenBSD CVS

CVS log for src/usr.bin/touch/touch.c


[BACK] Up to [local] / src / usr.bin / touch

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.27 / (download) - annotate - [select for diffs], Sat Jan 29 00:06:26 2022 UTC (2 years, 3 months ago) by cheloha
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, HEAD
Changes since 1.26: +11 -2 lines
Diff to previous 1.26 (colored)

touch(1): don't leak file descriptor if futimens(2) fails

This conditional chain short-circuits if futimens(2) fails, leaving the
file descriptor open.  We need to evaluate each system call in the chain
separately to ensure we attempt to close(2) the descriptor.

With input from guenther@ and millert@.

Thread: https://marc.info/?l=openbsd-tech&m=164332809900558&w=2

ok millert@, probably ok guenther@

Revision 1.26 / (download) - annotate - [select for diffs], Sun Mar 10 15:11:52 2019 UTC (5 years, 2 months ago) by schwarze
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.25: +4 -7 lines
Diff to previous 1.25 (colored)

Delete a useless call to setlocale(3): strptime(3) is only called
with %F and %T, neither of which is locale-dependent, and nothing
else in the code depends on the locale either, since most of the
parsing is done by hand and only supports numerical formats in the
first place.

While here, make usage() static and return from main rather than exit(3).

Patch from Jan Stary <hans at stare dot cz>.

tedu@ agrees.

Revision 1.25 / (download) - annotate - [select for diffs], Fri Oct 9 01:37:09 2015 UTC (8 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.24: +3 -3 lines
Diff to previous 1.24 (colored)

Change all tame callers to namechange to pledge(2).

Revision 1.24 / (download) - annotate - [select for diffs], Tue Oct 6 13:48:34 2015 UTC (8 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.23: +4 -1 lines
Diff to previous 1.23 (colored)

use tame "stdio rpath wpath cpath fattr".  There is some timezone
database stuff here which goes further than most programs, but the
neccessary files are readable using "rpath".

Revision 1.23 / (download) - annotate - [select for diffs], Tue Mar 17 19:31:30 2015 UTC (9 years, 2 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8
Changes since 1.22: +4 -4 lines
Diff to previous 1.22 (colored)

Eliminate use of TM_YEAR_BASE.  OK guenther@ deraadt@ miod@

Revision 1.22 / (download) - annotate - [select for diffs], Sun Mar 15 00:41:28 2015 UTC (9 years, 2 months ago) by millert
Branch: MAIN
Changes since 1.21: +1 -2 lines
Diff to previous 1.21 (colored)

tzfile.h is an internal header that should never have been installed.
What's worse, the tzfile.h that gets installed is over 20 years old
and doesn't match the real tzfile.h in libc/time.  This makes the
tree safe for /usr/include/tzfile.h removal.  The TM_YEAR_BASE
define has been moved to time.h temporarily until its usage is
replaced by 1900 in the tree.  Actual removal of tzfile.h is pending
a ports build.  Based on a diff from deraadt@

Revision 1.21 / (download) - annotate - [select for diffs], Wed Aug 31 08:48:40 2011 UTC (12 years, 8 months ago) by jmc
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE, OPENBSD_5_7, OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1
Changes since 1.20: +3 -3 lines
Diff to previous 1.20 (colored)

use the same format/text, as far as possible, for date strings;
help/ok guenther millert

Revision 1.20 / (download) - annotate - [select for diffs], Tue Aug 30 02:07:11 2011 UTC (12 years, 8 months ago) by guenther
Branch: MAIN
Changes since 1.19: +10 -5 lines
Diff to previous 1.19 (colored)

Make the code match the manpage and POSIX spec when the year is specified
but the century isn't: century is 1900 if year >= 69; else 2000

ok millert@

Revision 1.19 / (download) - annotate - [select for diffs], Sun Aug 21 20:55:23 2011 UTC (12 years, 9 months ago) by guenther
Branch: MAIN
Changes since 1.18: +3 -3 lines
Diff to previous 1.18 (colored)

With gettimeofday() removed from the top of main(), need to call time()
for the defaulting of the year to work in the -t and arg1 forms that were
broken by previous change

ok millert@

Revision 1.18 / (download) - annotate - [select for diffs], Sat Aug 20 06:44:24 2011 UTC (12 years, 9 months ago) by guenther
Branch: MAIN
Changes since 1.17: +94 -69 lines
Diff to previous 1.17 (colored)

Add nanosecond precision and support for -d option (new in POSIX 2008)

ok millert@, manpage fixes jmc@

Revision 1.17 / (download) - annotate - [select for diffs], Mon Aug 6 19:16:06 2007 UTC (16 years, 9 months ago) by sobrado
Branch: MAIN
CVS Tags: OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7, OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.16: +3 -2 lines
Diff to previous 1.16 (colored)

the ellipsis is not an optional argument; while here, sync the usage
and synopsis of commands

lots of good ideas by jmc@

ok jmc@

Revision 1.16 / (download) - annotate - [select for diffs], Mon Jun 18 11:20:58 2007 UTC (16 years, 11 months ago) by millert
Branch: MAIN
Changes since 1.15: +2 -2 lines
Diff to previous 1.15 (colored)

Fix typo introduced in seconds parsing.  From Tim van der Molen.

Revision 1.15 / (download) - annotate - [select for diffs], Fri May 25 13:56:59 2007 UTC (16 years, 11 months ago) by millert
Branch: MAIN
Changes since 1.14: +58 -38 lines
Diff to previous 1.14 (colored)

Sanity check time spec and if no century is specified, just use the
current one.

Revision 1.14 / (download) - annotate - [select for diffs], Wed Mar 8 12:20:05 2006 UTC (18 years, 2 months ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.13: +5 -5 lines
Diff to previous 1.13 (colored)

even betterer
From: Przemyslaw Nowaczyk <p_nowaczyk@o2.pl>

Revision 1.13 / (download) - annotate - [select for diffs], Tue Mar 7 11:49:40 2006 UTC (18 years, 2 months ago) by henning
Branch: MAIN
Changes since 1.12: +20 -31 lines
Diff to previous 1.12 (colored)

KNF & cleanup
mostly From: Przemyslaw Nowaczyk <p_nowaczyk@o2.pl>

Revision 1.12 / (download) - annotate - [select for diffs], Wed Apr 20 19:16:34 2005 UTC (19 years, 1 month ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8
Changes since 1.11: +5 -5 lines
Diff to previous 1.11 (colored)

spacing

Revision 1.11 / (download) - annotate - [select for diffs], Wed Apr 20 19:13:53 2005 UTC (19 years, 1 month ago) by otto
Branch: MAIN
Changes since 1.10: +7 -60 lines
Diff to previous 1.10 (colored)

Remove redundant rw() function, which is unsafe and, well, redundant.
ok tedu@ deraadt@

Revision 1.10 / (download) - annotate - [select for diffs], Tue Jun 10 22:20:53 2003 UTC (20 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.9: +8 -20 lines
Diff to previous 1.9 (colored)

mostly ansi cleanup; pval ok

Revision 1.9 / (download) - annotate - [select for diffs], Tue Jun 3 02:56:20 2003 UTC (20 years, 11 months ago) by millert
Branch: MAIN
Changes since 1.8: +3 -7 lines
Diff to previous 1.8 (colored)

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999.  Proofed by myself and Theo.

Revision 1.8 / (download) - annotate - [select for diffs], Fri Jan 10 11:42:00 2003 UTC (21 years, 4 months ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3
Changes since 1.7: +3 -3 lines
Diff to previous 1.7 (colored)

typo in comment; Jim Geovedi

Revision 1.7 / (download) - annotate - [select for diffs], Sat Feb 16 21:27:55 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_2_BASE, OPENBSD_3_2, OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.6: +7 -7 lines
Diff to previous 1.6 (colored)

Part one of userland __P removal.  Done with a simple regexp with some minor hand editing to make comments line up correctly.  Another pass is forthcoming that handles the cases that could not be done automatically.

Revision 1.6 / (download) - annotate - [select for diffs], Fri Oct 13 13:54:59 2000 UTC (23 years, 7 months ago) by pjanzen
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0, OPENBSD_2_9_BASE, OPENBSD_2_9, OPENBSD_2_8_BASE, OPENBSD_2_8
Changes since 1.5: +4 -5 lines
Diff to previous 1.5 (colored)

Missed one TM_YEAR_BASE in previous commit; pointed out by peters@telia.net
in PR 1445.

Revision 1.5 / (download) - annotate - [select for diffs], Wed Sep 20 22:25:26 2000 UTC (23 years, 8 months ago) by pjanzen
Branch: MAIN
Changes since 1.4: +11 -8 lines
Diff to previous 1.4 (colored)

use TM_YEAR_BASE and set seconds to zero in obsolescent "compatibility" case;
from NetBSD.

Revision 1.4 / (download) - annotate - [select for diffs], Wed Sep 20 13:26:55 2000 UTC (23 years, 8 months ago) by pjanzen
Branch: MAIN
Changes since 1.3: +10 -6 lines
Diff to previous 1.3 (colored)

Y2K fix for obsolescent time format:  found by Camiel Dobbelaar.

Revision 1.3 / (download) - annotate - [select for diffs], Wed Jan 15 23:43:22 1997 UTC (27 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_7_BASE, OPENBSD_2_7, OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4, OPENBSD_2_3_BASE, OPENBSD_2_3, OPENBSD_2_2_BASE, OPENBSD_2_2, OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.2: +3 -3 lines
Diff to previous 1.2 (colored)

getopt(3) returns -1 when out of args, not EOF, whee!

Revision 1.2 / (download) - annotate - [select for diffs], Wed Jun 26 05:41:45 1996 UTC (27 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.1: +2 -1 lines
Diff to previous 1.1 (colored)

rcsid

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:46:25 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:46:25 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.