OpenBSD CVS

CVS log for src/usr.bin/vi/cl/cl_main.c


[BACK] Up to [local] / src / usr.bin / vi / cl

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.36 / (download) - annotate - [select for diffs], Sun Oct 24 21:24:17 2021 UTC (2 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, HEAD
Changes since 1.35: +2 -2 lines
Diff to previous 1.35 (colored)

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant.  Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk.  They could all be 0xdeafbeef.
ok millert

Revision 1.35 / (download) - annotate - [select for diffs], Thu Sep 2 11:19:02 2021 UTC (2 years, 9 months ago) by schwarze
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0
Changes since 1.34: +7 -24 lines
Diff to previous 1.34 (colored)

Make all signal handler functions async-signal-safe
by deleting the redundant "killersig" struct member
and using the existing sig_atomic_t cl_sigterm variable instead.
While here, garbage collect the h_hup() signal handler
which is essentially identical to h_term().
This also gets rid of the last #define & #undef in cl_main.c.

OK martijn@, and also tested by Tim <trondd at kagu hyphen tsuchi dot com>.

Revision 1.34 / (download) - annotate - [select for diffs], Wed Sep 1 14:28:15 2021 UTC (2 years, 9 months ago) by schwarze
Branch: MAIN
Changes since 1.33: +15 -9 lines
Diff to previous 1.33 (colored)

As a first step towards safe signal handling, improve the h_int()
and h_winch() signal handlers to make one single store to a
sig_atomic_t variable.  Note that the h_hup() and h_term() signal
handlers are still unsafe after this commit because they also set
the "killersig" (how fitting!) field in a global struct.

Despite storing information in static global variables rather than
in structs passed around as arguments, this patch does not cause a
change in behaviour because there is always exactly one GS object,
initialized using gs_init() called from the top of main(), and
screen_init() stores a pointer to this one and only GS object in
the .gp member of each and every SCR object.  Talk about useless
abstraction...

Problem pointed out by deraadt@.
Patch from Tim <trondd at kagu hyphen tsuchi dot com> on tech@.
OK deraadt@.

Revision 1.33 / (download) - annotate - [select for diffs], Thu May 5 20:36:41 2016 UTC (8 years, 1 month ago) by martijn
Branch: MAIN
CVS Tags: OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.32: +3 -11 lines
Diff to previous 1.32 (colored)

Remove __sigblockset. This is a leftover after the removal of the signal
blocking code in common/gs.h rev 1.14.

Remove a redundant return while here.

OK millert@

Revision 1.32 / (download) - annotate - [select for diffs], Wed Apr 20 19:34:32 2016 UTC (8 years, 1 month ago) by martijn
Branch: MAIN
Changes since 1.31: +1 -6 lines
Diff to previous 1.31 (colored)

Remove pointless reenter variable.

OK millert@

Revision 1.31 / (download) - annotate - [select for diffs], Wed Feb 3 01:47:25 2016 UTC (8 years, 4 months ago) by mmcc
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.30: +3 -5 lines
Diff to previous 1.30 (colored)

Remove needless alias macros for malloc and calloc. No binary change. I
got this upstreamed a few weeks ago.

ok tb (less a few style tweaks), martijn (who suggested style tweaks)

Revision 1.30 / (download) - annotate - [select for diffs], Sat Jan 30 21:23:50 2016 UTC (8 years, 4 months ago) by martijn
Branch: MAIN
Changes since 1.29: +4 -11 lines
Diff to previous 1.29 (colored)

replace progname variable in gs structure with getprogname

OK zhuk@ and tb@

Revision 1.29 / (download) - annotate - [select for diffs], Wed Jan 27 22:38:12 2016 UTC (8 years, 4 months ago) by martijn
Branch: MAIN
Changes since 1.28: +6 -10 lines
Diff to previous 1.28 (colored)

Replace fprintf+exit with errx. No functional change

OK zhuk@ and schwarze@
fine with me tb@

Revision 1.28 / (download) - annotate - [select for diffs], Mon Dec 28 19:24:01 2015 UTC (8 years, 5 months ago) by millert
Branch: MAIN
Changes since 1.27: +8 -24 lines
Diff to previous 1.27 (colored)

Use err() instead of custom perr() function.  Also applied by nvi2
upstream.  From Martijn van Duren.

Revision 1.27 / (download) - annotate - [select for diffs], Mon Dec 7 20:39:19 2015 UTC (8 years, 6 months ago) by mmcc
Branch: MAIN
Changes since 1.26: +3 -3 lines
Diff to previous 1.26 (colored)

Remove needless type casts and corresponding type parameters from
allocation macros. No binary change.

ok tb@

Revision 1.26 / (download) - annotate - [select for diffs], Sun Mar 29 01:04:23 2015 UTC (9 years, 2 months ago) by bcallah
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8
Changes since 1.25: +2 -11 lines
Diff to previous 1.25 (colored)

Remove SA_INTERRUPT, HISTORIC_PRACTICE, and HISTORICAL_PRACTICE using
unifdef. It seems clear that no one was using these (SA_INTERRUPT didn't
even build the other way). Tweak comments as appropriate.

ok brynet@

Revision 1.25 / (download) - annotate - [select for diffs], Wed Nov 19 03:42:40 2014 UTC (9 years, 6 months ago) by bentley
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.24: +2 -2 lines
Diff to previous 1.24 (colored)

Remove ifdef checks for LIBRARY.
It is undocumented and triggers the same conditional inclusions as
PURIFY does.

From Martin Natano.

Revision 1.24 / (download) - annotate - [select for diffs], Fri Nov 14 20:27:03 2014 UTC (9 years, 6 months ago) by tedu
Branch: MAIN
Changes since 1.23: +2 -2 lines
Diff to previous 1.23 (colored)

from natano:
_PATH_BSHELL, _PATH_SENDMAIL, _PATH_TMP and _PATH_TTY are defined in
<paths.h> and _PATH_SYSV_TTY is unused. All of them can be removed from
pathnames.h. The other defines can be made unconditionally.

Revision 1.23 / (download) - annotate - [select for diffs], Wed Nov 12 16:29:04 2014 UTC (9 years, 6 months ago) by millert
Branch: MAIN
Changes since 1.22: +3 -11 lines
Diff to previous 1.22 (colored)

Remove more portability bits for older systems; from Martin Natano

Revision 1.22 / (download) - annotate - [select for diffs], Wed Nov 12 04:28:41 2014 UTC (9 years, 7 months ago) by bentley
Branch: MAIN
Changes since 1.21: +13 -28 lines
Diff to previous 1.21 (colored)

Ansify vi.

ok bcallah@ millert@

Revision 1.21 / (download) - annotate - [select for diffs], Mon Nov 10 21:34:13 2014 UTC (9 years, 7 months ago) by tedu
Branch: MAIN
Changes since 1.20: +1 -49 lines
Diff to previous 1.20 (colored)

remove ipc leftovers. from Martin Natano

Revision 1.20 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:47 2009 UTC (14 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.19: +1 -5 lines
Diff to previous 1.19 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.19 / (download) - annotate - [select for diffs], Fri Mar 28 17:58:20 2008 UTC (16 years, 2 months ago) by jasper
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.18: +2 -4 lines
Diff to previous 1.18 (colored)

- minor ansification
  from Gleydson Soares

ok otto@

Revision 1.18 / (download) - annotate - [select for diffs], Wed Oct 17 20:10:44 2007 UTC (16 years, 7 months ago) by chl
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.17: +3 -2 lines
Diff to previous 1.17 (colored)

remove "unused variable" warnings

tested by deraadt@ on a gcc2 arch

looks ok ray@ ok deraadt@

Revision 1.17 / (download) - annotate - [select for diffs], Sat Apr 22 03:09:15 2006 UTC (18 years, 1 month ago) by ray
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.16: +1 -3 lines
Diff to previous 1.16 (colored)

Removes unused variables and rename variables shadowing external
variables.  No binary change.

Found by lint.

OK otto@ and jaredy@

Revision 1.16 / (download) - annotate - [select for diffs], Sat Mar 11 06:58:00 2006 UTC (18 years, 3 months ago) by ray
Branch: MAIN
Changes since 1.15: +5 -2 lines
Diff to previous 1.15 (colored)

Silence 39 warnings.

ok miod, otto

Revision 1.15 / (download) - annotate - [select for diffs], Sun Jan 8 21:05:39 2006 UTC (18 years, 5 months ago) by miod
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9
Changes since 1.14: +1 -2 lines
Diff to previous 1.14 (colored)

Explicit braces around macro fields and logical operations, gets rid of 148
warnings, no functional change.

From Ray Lai.

Revision 1.14 / (download) - annotate - [select for diffs], Fri Jul 18 23:11:43 2003 UTC (20 years, 10 months ago) by david
Branch: MAIN
CVS Tags: OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.13: +2 -1 lines
Diff to previous 1.13 (colored)

add missing includes
ok tedu@

Revision 1.13 / (download) - annotate - [select for diffs], Sun Feb 17 19:42:33 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2, OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.12: +2 -2 lines
Diff to previous 1.12 (colored)

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Revision 1.12 / (download) - annotate - [select for diffs], Sat Feb 16 21:27:56 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
Changes since 1.11: +9 -9 lines
Diff to previous 1.11 (colored)

Part one of userland __P removal.  Done with a simple regexp with some minor hand editing to make comments line up correctly.  Another pass is forthcoming that handles the cases that could not be done automatically.

Revision 1.11 / (download) - annotate - [select for diffs], Mon Jan 29 01:58:27 2001 UTC (23 years, 4 months ago) by niklas
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0, OPENBSD_2_9_BASE, OPENBSD_2_9
Changes since 1.10: +2 -0 lines
Diff to previous 1.10 (colored)

$OpenBSD$

Revision 1.10 / (download) - annotate - [select for diffs], Fri Nov 26 22:49:08 1999 UTC (24 years, 6 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_8_BASE, OPENBSD_2_8, OPENBSD_2_7_BASE, OPENBSD_2_7
Changes since 1.9: +1 -1 lines
Diff to previous 1.9 (colored)

o Update README files etc. from nvi-1.79 so they have the correct info
o make port.h empty since we there is nothing we lack
o include <sys/param.h>, not <sys/types.h> in files that use MIN/MAX macros
o add perl api support since we have libperl (off by default)

Revision 1.9 / (download) - annotate - [select for diffs], Sat Mar 6 20:27:43 1999 UTC (25 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5
Changes since 1.8: +1 -1 lines
Diff to previous 1.8 (colored)

back out changes that should not have escaped my local tree

Revision 1.8 / (download) - annotate - [select for diffs], Sat Mar 6 20:19:23 1999 UTC (25 years, 3 months ago) by millert
Branch: MAIN
Changes since 1.7: +1 -1 lines
Diff to previous 1.7 (colored)

add missing reference to infocmp

Revision 1.7 / (download) - annotate - [select for diffs], Fri Jul 24 00:07:39 1998 UTC (25 years, 10 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_4_BASE, OPENBSD_2_4
Changes since 1.6: +0 -4 lines
Diff to previous 1.6 (colored)

-D_USE_OLD_CURSE_ for -locurses and no more -ltermlib/termcap

Revision 1.6 / (download) - annotate - [select for diffs], Tue Sep 23 07:12:44 1997 UTC (26 years, 8 months ago) by downsj
Branch: MAIN
CVS Tags: OPENBSD_2_3_BASE, OPENBSD_2_3, OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.5: +5 -1 lines
Diff to previous 1.5 (colored)

Make building with ocurses/termcap and curses/termlib conditional on
USE_OCURSES being defined, and define it for now.  This switches nvi back
to use BSD curses.

Revision 1.5 / (download) - annotate - [select for diffs], Sun Jul 27 22:28:05 1997 UTC (26 years, 10 months ago) by downsj
Branch: MAIN
Changes since 1.4: +15 -14 lines
Diff to previous 1.4 (colored)

Update to 1.79 and install as vi/ex/view.

Revision 1.4 / (download) - annotate - [select for diffs], Wed Oct 16 01:18:10 1996 UTC (27 years, 8 months ago) by michaels
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.3: +11 -7 lines
Diff to previous 1.3 (colored)

nvi 1.78:
        + Fix bugs when both the leftright scrolling and number edit options
          were on.
        + Fix bug where splitting in the middle of the screen could repaint
          incorrectly.
        + Fix first-nul in input bug, where random garbage was inserted.
        + Correct search and mark-as-motion-command bug, it's a line mode
          action if the search starts at or before the first non<blank>.
        + Fix bug autoindent bug, where ^D could shift too far in the line.
        + Fix core dump where ! command called from the .exrc file.
        + Add the -S command-line option, which initializes vi to have the
          secure edit option preset.

Revision 1.3 / (download) - annotate - [select for diffs], Fri Aug 16 17:58:16 1996 UTC (27 years, 10 months ago) by michaels
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.2: +37 -24 lines
Diff to previous 1.2 (colored)

nvi 1.73

Revision 1.2 / (download) - annotate - [select for diffs], Wed Jul 24 16:15:14 1996 UTC (27 years, 10 months ago) by mickey
Branch: MAIN
Changes since 1.1: +90 -23 lines
Diff to previous 1.1 (colored)

bring vi/ex up to 1.71

Revision 1.1 / (download) - annotate - [select for diffs], Wed May 22 11:33:50 1996 UTC (28 years ago) by deraadt
Branch: MAIN

new vi

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.