OpenBSD CVS

CVS log for src/usr.sbin/ac/ac.c


[BACK] Up to [local] / src / usr.sbin / ac

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.30 / (download) - annotate - [select for diffs], Tue May 21 05:00:48 2024 UTC (2 weeks, 4 days ago) by jsg
Branch: MAIN
CVS Tags: HEAD
Changes since 1.29: +0 -1 lines
Diff to previous 1.29 (colored)

remove prototypes with no matching function and externs with no var
partly checked by millert@

Revision 1.29 / (download) - annotate - [select for diffs], Wed Dec 28 21:30:15 2022 UTC (17 months, 1 week ago) by jmc
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3
Changes since 1.28: +1 -1 lines
Diff to previous 1.28 (colored)

spelling fixes; from paul tagliamonte
any parts of his diff not taken are noted on tech

Revision 1.28 / (download) - annotate - [select for diffs], Sun Dec 4 23:50:50 2022 UTC (18 months ago) by cheloha
Branch: MAIN
Changes since 1.27: +0 -1 lines
Diff to previous 1.27 (colored)

userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument.  We can
handle this case with the "default" failure case with no loss of
legibility.  Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@.  With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

Revision 1.27 / (download) - annotate - [select for diffs], Thu Aug 23 06:27:54 2018 UTC (5 years, 9 months ago) by mestre
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4
Changes since 1.26: +2 -1 lines
Diff to previous 1.26 (colored)

We can safely assume that our utmp(5) file format implementation can guarantee
space for the NUL character, nevertheless there will always be some piece of
software that can get it wrong and corrupt the database, so we must take this
into consideration.

That being said, there is one strlcpy(3) that needs to be reverted back into
strncpy(3) + '\0' since if we try to use a bogus wtmp(5) file with ac(8) that
is big enough then the NUL char is not verified and it will write memory
out-of-bounds which will make the program crash.

discussed with and OK cheloha@ deraadt@

Revision 1.26 / (download) - annotate - [select for diffs], Mon Aug 20 06:24:50 2018 UTC (5 years, 9 months ago) by mestre
Branch: MAIN
Changes since 1.25: +4 -0 lines
Diff to previous 1.25 (colored)

Since we can feed localtime(3) with garbage input, or with input it cannot
interpret, we always need to check its return value, and in the case it's NULL
then error and exit before proceeding further otherwise in this specific
program we would find a null dereference down the road which would make the
program segfault.

OK cheloha@

Revision 1.25 / (download) - annotate - [select for diffs], Thu Apr 26 12:42:51 2018 UTC (6 years, 1 month ago) by guenther
Branch: MAIN
Changes since 1.24: +1 -2 lines
Diff to previous 1.24 (colored)

Use <fcntl.h> instead of <sys/file.h> for open() and friends.
Delete a bunch of unnecessary #includes and sort to match style(9)
while doing the above cleanup.

ok deraadt@ krw@

Revision 1.24 / (download) - annotate - [select for diffs], Mon Oct 12 02:02:00 2015 UTC (8 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.23: +3 -0 lines
Diff to previous 1.23 (colored)

pledge to only use "stdio rpath"; rpath is for readig the wtmp files.
ok doug

Revision 1.23 / (download) - annotate - [select for diffs], Mon Feb 9 23:00:14 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.22: +1 -1 lines
Diff to previous 1.22 (colored)

clean up flags++ instances around getopt()
ok florian

Revision 1.22 / (download) - annotate - [select for diffs], Fri Aug 31 19:57:12 2012 UTC (11 years, 9 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3
Changes since 1.21: +24 -12 lines
Diff to previous 1.21 (colored)

Update license to two-clause BSD.  Permission to do so was granted
by the authors as per Ed Schouten.

Revision 1.21 / (download) - annotate - [select for diffs], Sun Jul 4 10:17:25 2010 UTC (13 years, 11 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.20: +1 -53 lines
Diff to previous 1.20 (colored)

Remove the non-standard, commented out, -c option.
OK tedu@ jmc@ deraadt@

Revision 1.20 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:50 2009 UTC (14 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.19: +0 -4 lines
Diff to previous 1.19 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.19 / (download) - annotate - [select for diffs], Sat Nov 17 15:08:57 2007 UTC (16 years, 6 months ago) by sobrado
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.18: +4 -5 lines
Diff to previous 1.18 (colored)

the usage message should start with "usage:";
no need for "users", ellipsis allows various users to be specified;
synchronize synopsis and usage

ok jmc@

Revision 1.18 / (download) - annotate - [select for diffs], Mon Apr 3 21:32:38 2006 UTC (18 years, 2 months ago) by dhill
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.17: +7 -10 lines
Diff to previous 1.17 (colored)

Change an int to size_t
Remove NEW()
Remove unused return value of add_tty()

ok moritz@

Revision 1.17 / (download) - annotate - [select for diffs], Thu Mar 18 01:28:40 2004 UTC (20 years, 2 months ago) by tedu
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5
Changes since 1.16: +4 -4 lines
Diff to previous 1.16 (colored)

0 vs NULL, from Joris Vink

Revision 1.16 / (download) - annotate - [select for diffs], Wed Jan 21 07:52:02 2004 UTC (20 years, 4 months ago) by deraadt
Branch: MAIN
Changes since 1.15: +13 -13 lines
Diff to previous 1.15 (colored)

spacing

Revision 1.15 / (download) - annotate - [select for diffs], Sun Jul 20 19:39:35 2003 UTC (20 years, 10 months ago) by mickey
Branch: MAIN
CVS Tags: OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.14: +5 -2 lines
Diff to previous 1.14 (colored)

ignore backwards going entries

Revision 1.14 / (download) - annotate - [select for diffs], Wed Jun 11 23:33:24 2003 UTC (21 years ago) by deraadt
Branch: MAIN
Changes since 1.13: +15 -35 lines
Diff to previous 1.13 (colored)

some ansification, some de-register

Revision 1.13 / (download) - annotate - [select for diffs], Thu Mar 13 09:09:37 2003 UTC (21 years, 3 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3
Changes since 1.12: +2 -2 lines
Diff to previous 1.12 (colored)

lots of sprintf -> snprintf and strcpy -> strlcpy; checked by tedu

Revision 1.12 / (download) - annotate - [select for diffs], Thu May 30 19:09:05 2002 UTC (22 years ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.11: +10 -10 lines
Diff to previous 1.11 (colored)

minor KNF

Revision 1.11 / (download) - annotate - [select for diffs], Sun Feb 17 19:42:35 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.10: +3 -3 lines
Diff to previous 1.10 (colored)

Manual cleanup of remaining userland __P use (excluding packages maintained outside the tree)

Revision 1.10 / (download) - annotate - [select for diffs], Sat Feb 16 21:28:00 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
Changes since 1.9: +13 -13 lines
Diff to previous 1.9 (colored)

Part one of userland __P removal.  Done with a simple regexp with some minor hand editing to make comments line up correctly.  Another pass is forthcoming that handles the cases that could not be done automatically.

Revision 1.9 / (download) - annotate - [select for diffs], Thu May 24 03:02:32 2001 UTC (23 years ago) by pvalchev
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0
Changes since 1.8: +9 -4 lines
Diff to previous 1.8 (colored)

- Let '-' mean stdin.
- Correct usage message: -p and -d cannot be usefully used together.
- Use __progname in usage()
millert@ ok

Revision 1.8 / (download) - annotate - [select for diffs], Sat May 5 07:12:50 2001 UTC (23 years, 1 month ago) by mickey
Branch: MAIN
Changes since 1.7: +4 -7 lines
Diff to previous 1.7 (colored)

use strlcpy vs strncpy+a[n-1]='\0'

Revision 1.7 / (download) - annotate - [select for diffs], Thu Oct 9 15:07:17 1997 UTC (26 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_9_BASE, OPENBSD_2_9, OPENBSD_2_8_BASE, OPENBSD_2_8, OPENBSD_2_7_BASE, OPENBSD_2_7, OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4, OPENBSD_2_3_BASE, OPENBSD_2_3, OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.6: +3 -2 lines
Diff to previous 1.6 (colored)

if user specified wtmp file, use timestamp on final record instead of
current system time for "end of run" time; tim@pool1.convey.ru

Revision 1.6 / (download) - annotate - [select for diffs], Sat Aug 30 19:54:45 1997 UTC (26 years, 9 months ago) by deraadt
Branch: MAIN
Changes since 1.5: +2 -2 lines
Diff to previous 1.5 (colored)

incorrect length in comparison; hubert.feyrer@rz.uni-regensburg.de

Revision 1.5 / (download) - annotate - [select for diffs], Fri Aug 1 07:33:57 1997 UTC (26 years, 10 months ago) by deraadt
Branch: MAIN
Changes since 1.4: +2 -2 lines
Diff to previous 1.4 (colored)

catch ptys correctly; tolik@www.tomsk.su

Revision 1.4 / (download) - annotate - [select for diffs], Mon Jun 2 09:44:51 1997 UTC (27 years ago) by deraadt
Branch: MAIN
Changes since 1.3: +3 -3 lines
Diff to previous 1.3 (colored)

correct for our pty list

Revision 1.3 / (download) - annotate - [select for diffs], Wed Jan 15 23:43:44 1997 UTC (27 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.2: +2 -2 lines
Diff to previous 1.2 (colored)

getopt(3) returns -1 when out of args, not EOF, whee!

Revision 1.2 / (download) - annotate - [select for diffs], Thu Aug 29 03:32:19 1996 UTC (27 years, 9 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.1: +2 -2 lines
Diff to previous 1.1 (colored)

fix warnings

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:47:09 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:47:09 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.