OpenBSD CVS

CVS log for src/usr.sbin/acme-client/chngproc.c


[BACK] Up to [local] / src / usr.sbin / acme-client

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.17 / (download) - annotate - [select for diffs], Thu May 5 19:51:35 2022 UTC (2 years ago) by florian
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, HEAD
Changes since 1.16: +14 -1 lines
Diff to previous 1.16 (colored)

Check that the challenge token which is turned into a filename is
base64url encoded.
We have only the challenge directory unveil(2)'ed so funny business
like ../ will not work, but we shouldn't generate garbage filenames
that someone else might trip over either.
Pointed out and diff by Ali Farzanrad (ali_farzanrad AT riseup.net)
OK beck

Revision 1.16 / (download) - annotate - [select for diffs], Mon Jul 12 15:09:20 2021 UTC (2 years, 10 months ago) by beck
Branch: MAIN
CVS Tags: OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0
Changes since 1.15: +2 -2 lines
Diff to previous 1.15 (colored)

Change the error reporting pattern throughout the tree when unveil
fails to report the path that the failure occured on. Suggested by
deraadt@ after some tech discussion.

Work done and verified by Ashton Fagg <ashton@fagg.id.au>

ok deraadt@ semarie@ claudio@

Revision 1.15 / (download) - annotate - [select for diffs], Mon Aug 12 18:01:44 2019 UTC (4 years, 9 months ago) by benno
Branch: MAIN
CVS Tags: OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.14: +2 -2 lines
Diff to previous 1.14 (colored)

Do not exit with error if the challenge file already exists, instead truncate it and
write the challenge again. We can get asked to supply the same challenge multiple times.
bug found and patch tested by jmc@
patch discussed with, mangled and okayed by florian@

Revision 1.14 / (download) - annotate - [select for diffs], Sun Jun 16 19:49:13 2019 UTC (4 years, 11 months ago) by florian
Branch: MAIN
Changes since 1.13: +15 -13 lines
Diff to previous 1.13 (colored)

Trade unveil(2) for chroot(2).
This uses less code and unveil(2) seems to be the better tool here.
The directory one chroots into needs to be carefully setup (they are
not) and comon wisedom is that root can break out of chroots.
There is probably nothing wrong with the chroot code because of pledge
but it still makes me feel uneasy.
input & OK on previous version mestre
OK on previous version deraadt
bug found, input & OK benno

Revision 1.13 / (download) - annotate - [select for diffs], Mon Apr 1 04:18:54 2019 UTC (5 years, 2 months ago) by naddy
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.12: +5 -3 lines
Diff to previous 1.12 (colored)

repair confusing "} if"; from florian@

Revision 1.12 / (download) - annotate - [select for diffs], Tue Jan 24 13:32:55 2017 UTC (7 years, 4 months ago) by jsing
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.11: +2 -2 lines
Diff to previous 1.11 (colored)

Make returns consistent and remove parentheses per style(9).

Transformed with coccinelle.

Requested by and ok tb@

Revision 1.11 / (download) - annotate - [select for diffs], Tue Jan 24 12:53:52 2017 UTC (7 years, 4 months ago) by deraadt
Branch: MAIN
Changes since 1.10: +4 -4 lines
Diff to previous 1.10 (colored)


Complete jsing's coccinelle cleanup... by hand
ok jsing

Revision 1.10 / (download) - annotate - [select for diffs], Tue Jan 24 12:05:14 2017 UTC (7 years, 4 months ago) by jsing
Branch: MAIN
Changes since 1.9: +13 -13 lines
Diff to previous 1.9 (colored)

Replace comparisons between a constant or enum and an expression, with
a comparison between the expression and the constant or enum. This
significantly improves readability.

Transformed with coccinelle.

Requested by deraadt@

Revision 1.9 / (download) - annotate - [select for diffs], Sat Jan 21 08:49:30 2017 UTC (7 years, 4 months ago) by florian
Branch: MAIN
Changes since 1.8: +15 -31 lines
Diff to previous 1.8 (colored)

kill remote with fire, we need to handle this differently
OK benno

Revision 1.8 / (download) - annotate - [select for diffs], Sat Jan 21 08:41:42 2017 UTC (7 years, 4 months ago) by benno
Branch: MAIN
Changes since 1.7: +3 -2 lines
Diff to previous 1.7 (colored)

acme-client use configuration file [1 of 5]

start using the configuration file and delete command line arguments:

-a agreement    -> agreement url ...
-c certdir      -> domain certificate "path"
-f accountkey   -> account key "path"
-k domainkey    -> domain key "path"
-s authority    -> sign with "name"

new argument:
-f configfile

the changes needed to use the new configuration are local to main.c for now.
While the configuration could be passed directly to netproc(), keyproc() etc,
the diff is smaller this way.

This also removes the multidir (-m) mode for now - specify different paths in
each domain {} block instead.

ok florian

Revision 1.7 / (download) - annotate - [select for diffs], Tue Sep 13 17:13:37 2016 UTC (7 years, 8 months ago) by deraadt
Branch: MAIN
Changes since 1.6: +3 -4 lines
Diff to previous 1.6 (colored)

A small amount more KNF to make this easier on our eyes.  Not going further
than this.
ok florian

Revision 1.6 / (download) - annotate - [select for diffs], Tue Sep 13 16:49:28 2016 UTC (7 years, 8 months ago) by deraadt
Branch: MAIN
Changes since 1.5: +4 -12 lines
Diff to previous 1.5 (colored)

hoist local variable initialization directly into the definitions,
rather than doing it right afterwards.
ok florian

Revision 1.5 / (download) - annotate - [select for diffs], Tue Sep 13 16:00:26 2016 UTC (7 years, 8 months ago) by deraadt
Branch: MAIN
Changes since 1.4: +2 -2 lines
Diff to previous 1.4 (colored)

use reallocarray()

Revision 1.4 / (download) - annotate - [select for diffs], Thu Sep 1 00:35:21 2016 UTC (7 years, 9 months ago) by florian
Branch: MAIN
Changes since 1.3: +1 -4 lines
Diff to previous 1.3 (colored)

we don't have config.h

Revision 1.3 / (download) - annotate - [select for diffs], Thu Sep 1 00:21:36 2016 UTC (7 years, 9 months ago) by deraadt
Branch: MAIN
Changes since 1.2: +10 -6 lines
Diff to previous 1.2 (colored)

Collapse krazy abstractions for other sandbox models, using chroot and
pledge directly as needed.
ok florian

Revision 1.2 / (download) - annotate - [select for diffs], Wed Aug 31 22:49:09 2016 UTC (7 years, 9 months ago) by benno
Branch: MAIN
Changes since 1.1: +10 -10 lines
Diff to previous 1.1 (colored)

whitespace

Revision 1.1 / (download) - annotate - [select for diffs], Wed Aug 31 22:01:42 2016 UTC (7 years, 9 months ago) by florian
Branch: MAIN

Import Kristaps' letskencrypt and call it acme-client in tree.
OK to get it in deraadt@ (and probably beck@)

At least deraadt@, beck@ and otto@ are fine with the name and the
disagreements stopped.

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.