OpenBSD CVS

CVS log for src/usr.sbin/acme-client/parse.y


[BACK] Up to [local] / src / usr.sbin / acme-client

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.45 / (download) - annotate - [select for diffs], Thu Dec 15 08:06:13 2022 UTC (17 months, 3 weeks ago) by florian
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, HEAD
Changes since 1.44: +2 -2 lines
Diff to previous 1.44 (colored)

The argument to ctype functions must be EOF or representable as an
unsigned char.

Casting to int is particularly useless because that's what the
compiler already does. We need to prevent sign extension, not write
down that we want sign extension.

OK deraadt, kn, miod

Revision 1.44 / (download) - annotate - [select for diffs], Sun Oct 9 09:59:31 2022 UTC (20 months ago) by op
Branch: MAIN
Changes since 1.43: +6 -6 lines
Diff to previous 1.43 (colored)

allow newlines inside the `alternative names' block in acme-client.conf

ok florian

Revision 1.43 / (download) - annotate - [select for diffs], Fri Oct 15 15:01:27 2021 UTC (2 years, 7 months ago) by naddy
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.42: +6 -6 lines
Diff to previous 1.42 (colored)

Don't declare variables as "unsigned char *" that are passed to
functions that take "char *" arguments.  Where such chars are
assigned to int or passed to ctype functions, explicitly cast them
to unsigned char.

For OpenBSD's clang, -Wpointer-sign has been disabled by default,
but when the parse.y code was built elsewhere, the compiler would
complain.

With help from millert@
ok benno@ deraadt@

Revision 1.42 / (download) - annotate - [select for diffs], Mon Sep 14 16:00:17 2020 UTC (3 years, 8 months ago) by florian
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8
Changes since 1.41: +13 -2 lines
Diff to previous 1.41 (colored)

We need to be able to provide contact information to use the
buypass.com acme api.
From Bartosz Kuzma (bartosz.kuzma AT release11.com), thanks!
OK beck, deraadt

Revision 1.41 / (download) - annotate - [select for diffs], Sat May 16 20:19:23 2020 UTC (4 years ago) by sthen
Branch: MAIN
Changes since 1.40: +3 -2 lines
Diff to previous 1.40 (colored)

somehow yacc pieces got missed from the "domain name" commit; add them.
ok florian@

Revision 1.40 / (download) - annotate - [select for diffs], Sun May 10 12:06:18 2020 UTC (4 years, 1 month ago) by benno
Branch: MAIN
Changes since 1.39: +23 -6 lines
Diff to previous 1.39 (colored)

Allow to have multiple domain ... {} sextions with the same domain
name, by adding a new (optional) config option "domain name".
This can be used to create a rsa and an ecdsa key for the same domain
name.
The old domain name in the 'title' line continues to be used as domain
name in the abscence of the domain name argument, i.e. the change is
backward compatible with current config files.
tested by sthen@
ok florian@ sthen@

Revision 1.39 / (download) - annotate - [select for diffs], Fri Dec 27 16:56:40 2019 UTC (4 years, 5 months ago) by benno
Branch: MAIN
CVS Tags: OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.38: +7 -3 lines
Diff to previous 1.38 (colored)

make -n stop after parsing the config.
make -nv print the parsed configuration, then stop.
ok sthen@, seems better deraadt@

Revision 1.38 / (download) - annotate - [select for diffs], Mon Jun 17 12:42:52 2019 UTC (4 years, 11 months ago) by florian
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.37: +5 -3 lines
Diff to previous 1.37 (colored)

    Implement elliptic curve account keys.
    OK benno
    Input & OK tb

Revision 1.37 / (download) - annotate - [select for diffs], Sat Jun 15 12:51:19 2019 UTC (4 years, 11 months ago) by florian
Branch: MAIN
Changes since 1.36: +17 -2 lines
Diff to previous 1.36 (colored)

Print domain key type in config test mode (-n).

Revision 1.36 / (download) - annotate - [select for diffs], Fri Jun 14 19:55:08 2019 UTC (4 years, 11 months ago) by florian
Branch: MAIN
Changes since 1.35: +7 -9 lines
Diff to previous 1.35 (colored)

Track key type (RSA or ECDSA) in an enum and clean up a bit while here.
Originaly from Renaud Allard following input from benno, tweaked by me.
OK benno

Revision 1.35 / (download) - annotate - [select for diffs], Wed Jun 12 11:09:25 2019 UTC (5 years ago) by gilles
Branch: MAIN
Changes since 1.34: +16 -3 lines
Diff to previous 1.34 (colored)

use acme-client to sign certificated with ecdsa keys

diff from Renaud Allard <renaud@allard.it>, ok to get in from florian@

Revision 1.34 / (download) - annotate - [select for diffs], Sat Jun 8 07:52:55 2019 UTC (5 years ago) by florian
Branch: MAIN
Changes since 1.33: +7 -7 lines
Diff to previous 1.33 (colored)

    Remove A and D flag, they are superfluous.
    One could always use them on the command line and acme-client would do
    the right thing.

Revision 1.33 / (download) - annotate - [select for diffs], Wed Feb 13 22:57:08 2019 UTC (5 years, 3 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.32: +3 -3 lines
Diff to previous 1.32 (colored)

(unsigned) means (unsigned int) which on ptrdiff_t or size_t or other
larger types really is a range reduction...
Almost any cast to (unsigned) is a bug.
ok millert tb benno

Revision 1.32 / (download) - annotate - [select for diffs], Tue Jan 29 16:38:29 2019 UTC (5 years, 4 months ago) by benno
Branch: MAIN
Changes since 1.31: +11 -2 lines
Diff to previous 1.31 (colored)

add an extra check for existing "api ..." line in the config.
move the check of existing "account ..." line from main.c to the parser.
ok deraadt@

Revision 1.31 / (download) - annotate - [select for diffs], Thu Nov 1 00:18:44 2018 UTC (5 years, 7 months ago) by sashan
Branch: MAIN
Changes since 1.30: +3 -2 lines
Diff to previous 1.30 (colored)

- odd condition/test in PF lexer
  (and other lexers too)

This commit rectifies earlier change:

    in the lex... even inside quotes, a \ followed by space or tab should
    expand to space or tab, and a \ followed by newline should be ignored
    (as a line continuation).  compatible with the needs of hoststated
    (which has the most strict quoted string requirements), and ifstated
    (where one commonly does line continuations in strings).

OK deraadt@, OK millert@

Revision 1.30 / (download) - annotate - [select for diffs], Fri Sep 7 07:35:30 2018 UTC (5 years, 9 months ago) by miko
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE, OPENBSD_6_4
Changes since 1.29: +4 -9 lines
Diff to previous 1.29 (colored)

replace malloc()+strlcpy() with strndup() in cmdline_symset().

"looks good" gilles@ halex@

Revision 1.29 / (download) - annotate - [select for diffs], Fri Aug 3 17:57:21 2018 UTC (5 years, 10 months ago) by benno
Branch: MAIN
Changes since 1.28: +61 -61 lines
Diff to previous 1.28 (colored)

return is not a function and if (x) -> if (x != NULL)
From Ross L Richardson, thanks
ok millert@

Revision 1.28 / (download) - annotate - [select for diffs], Fri Aug 3 17:51:40 2018 UTC (5 years, 10 months ago) by benno
Branch: MAIN
Changes since 1.27: +3 -3 lines
Diff to previous 1.27 (colored)

fix error messages from earlier syntax change
From Ross L Richardson
ok millert@

Revision 1.27 / (download) - annotate - [select for diffs], Fri Aug 3 17:49:57 2018 UTC (5 years, 10 months ago) by benno
Branch: MAIN
Changes since 1.26: +2 -2 lines
Diff to previous 1.26 (colored)

correct an error message, from Ross L Richardson
ok millert@

Revision 1.26 / (download) - annotate - [select for diffs], Sun Jul 29 12:46:31 2018 UTC (5 years, 10 months ago) by deraadt
Branch: MAIN
Changes since 1.25: +3 -3 lines
Diff to previous 1.25 (colored)

remove extra space in output; from Ross L Richardson

Revision 1.25 / (download) - annotate - [select for diffs], Wed Jul 11 07:39:22 2018 UTC (5 years, 11 months ago) by krw
Branch: MAIN
Changes since 1.24: +8 -8 lines
Diff to previous 1.24 (colored)

Do for most running out of memory err() what was done for most running
out of memory log_warn(). i.e. ("%s", __func__) instead of manual
function names and redundant verbiage about which wrapper detected the
out of memory condition.

ok henning@

Revision 1.24 / (download) - annotate - [select for diffs], Mon Jul 9 12:05:11 2018 UTC (5 years, 11 months ago) by krw
Branch: MAIN
Changes since 1.23: +5 -5 lines
Diff to previous 1.23 (colored)

No need to mention which memory allocation entry point failed (malloc,
calloc or strdup), we just need to log that we ran out of memory in a
particular function.

Recommended by florian@ and deraadt@

ok benno@ henning@ tb@

Revision 1.23 / (download) - annotate - [select for diffs], Sun Jul 8 17:15:07 2018 UTC (5 years, 11 months ago) by krw
Branch: MAIN
Changes since 1.22: +2 -2 lines
Diff to previous 1.22 (colored)

Be consistent in warn() and log_warn() usage when
running out of memory.

Next step, be correct *and* consistent.

ok dennis@ tb@ benno@ schwarze@

Revision 1.22 / (download) - annotate - [select for diffs], Sun Jun 17 19:28:36 2018 UTC (5 years, 11 months ago) by denis
Branch: MAIN
Changes since 1.21: +78 -47 lines
Diff to previous 1.21 (colored)

Fix an off-by-one line count when using include statements.

Thanks to otto@ for the initial diff.

OK benno@

Revision 1.21 / (download) - annotate - [select for diffs], Thu Apr 26 14:12:19 2018 UTC (6 years, 1 month ago) by krw
Branch: MAIN
Changes since 1.20: +3 -1 lines
Diff to previous 1.20 (colored)

Plug leak in error case of the common 'varset' implementations.

ok benno@

Revision 1.20 / (download) - annotate - [select for diffs], Sun Apr 8 19:10:12 2018 UTC (6 years, 2 months ago) by florian
Branch: MAIN
Changes since 1.19: +3 -8 lines
Diff to previous 1.19 (colored)

We warned long enough, also sysmerge(8) should have handled the
removal of the agreement url by now.

OK benno

Revision 1.19 / (download) - annotate - [select for diffs], Mon Nov 27 01:58:52 2017 UTC (6 years, 6 months ago) by florian
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_3
Changes since 1.18: +3 -11 lines
Diff to previous 1.18 (colored)

Deprecate agreement url config option and get the information from the
directory call. This way we don't need to update the acme-client.conf
file every time it changes. Still parse the option, ignore and warn about
it for a release. Sysmerge should be able to handle the removal.
"nice" deraadt@
OK benno

Revision 1.18 / (download) - annotate - [select for diffs], Thu Oct 19 06:49:46 2017 UTC (6 years, 7 months ago) by jsg
Branch: MAIN
Changes since 1.17: +3 -2 lines
Diff to previous 1.17 (colored)

fix a use after free and a memory leak in error paths
ok deraadt@ florian@

Revision 1.17 / (download) - annotate - [select for diffs], Thu Mar 23 12:59:32 2017 UTC (7 years, 2 months ago) by florian
Branch: MAIN
CVS Tags: OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.16: +1 -5 lines
Diff to previous 1.16 (colored)

It is perfectly valid to have a cert / key not owned by root; remove
useless check.
OK benno

Revision 1.16 / (download) - annotate - [select for diffs], Tue Jan 24 12:53:52 2017 UTC (7 years, 4 months ago) by deraadt
Branch: MAIN
Changes since 1.15: +4 -4 lines
Diff to previous 1.15 (colored)


Complete jsing's coccinelle cleanup... by hand
ok jsing

Revision 1.15 / (download) - annotate - [select for diffs], Mon Jan 23 03:31:33 2017 UTC (7 years, 4 months ago) by deraadt
Branch: MAIN
Changes since 1.14: +3 -3 lines
Diff to previous 1.14 (colored)

whitespace

Revision 1.14 / (download) - annotate - [select for diffs], Sat Jan 21 13:16:40 2017 UTC (7 years, 4 months ago) by benno
Branch: MAIN
Changes since 1.13: +2 -8 lines
Diff to previous 1.13 (colored)

find the first authority works better this way, now that we use a tailq
ok florian@

Revision 1.13 / (download) - annotate - [select for diffs], Sat Jan 21 12:59:06 2017 UTC (7 years, 4 months ago) by benno
Branch: MAIN
Changes since 1.12: +19 -19 lines
Diff to previous 1.12 (colored)

move config data structures mostly to TAILQs, because that way we
preserve order.

ok florian@

Revision 1.12 / (download) - annotate - [select for diffs], Sat Jan 21 12:04:37 2017 UTC (7 years, 4 months ago) by benno
Branch: MAIN
Changes since 1.11: +4 -4 lines
Diff to previous 1.11 (colored)

dont print config if its broken
ok florian@

Revision 1.11 / (download) - annotate - [select for diffs], Sat Jan 21 11:51:58 2017 UTC (7 years, 4 months ago) by florian
Branch: MAIN
Changes since 1.10: +3 -3 lines
Diff to previous 1.10 (colored)

it's chain certificate not certificate chain

Revision 1.10 / (download) - annotate - [select for diffs], Sat Jan 21 11:45:52 2017 UTC (7 years, 4 months ago) by florian
Branch: MAIN
Changes since 1.9: +13 -2 lines
Diff to previous 1.9 (colored)

Enforce minimum config in the parser.
Based on a diff by & OK benno@

Revision 1.9 / (download) - annotate - [select for diffs], Sat Jan 21 09:00:29 2017 UTC (7 years, 4 months ago) by benno
Branch: MAIN
Changes since 1.8: +21 -2 lines
Diff to previous 1.8 (colored)

add option 'domain full chain certificate "path"',
revokation works, the fullchain file will be unlinked.

ok florian

Revision 1.8 / (download) - annotate - [select for diffs], Sat Jan 21 08:55:09 2017 UTC (7 years, 4 months ago) by florian
Branch: MAIN
Changes since 1.7: +22 -4 lines
Diff to previous 1.7 (colored)

Implement domain chain certificate.
OK benno

Revision 1.7 / (download) - annotate - [select for diffs], Sat Jan 21 08:47:21 2017 UTC (7 years, 4 months ago) by benno
Branch: MAIN
Changes since 1.6: +49 -2 lines
Diff to previous 1.6 (colored)

acme-client use configuration file [5 of 5]
implement new -n option to check and print configuration

ok florian

Revision 1.6 / (download) - annotate - [select for diffs], Sat Jan 21 08:43:09 2017 UTC (7 years, 4 months ago) by benno
Branch: MAIN
Changes since 1.5: +13 -2 lines
Diff to previous 1.5 (colored)

acme-client use configuration file [2 of 5]

- add challengedir option to config file
- remove -C option from command line

ok florian

Revision 1.5 / (download) - annotate - [select for diffs], Sat Jan 21 08:41:42 2017 UTC (7 years, 4 months ago) by benno
Branch: MAIN
Changes since 1.4: +13 -9 lines
Diff to previous 1.4 (colored)

acme-client use configuration file [1 of 5]

start using the configuration file and delete command line arguments:

-a agreement    -> agreement url ...
-c certdir      -> domain certificate "path"
-f accountkey   -> account key "path"
-k domainkey    -> domain key "path"
-s authority    -> sign with "name"

new argument:
-f configfile

the changes needed to use the new configuration are local to main.c for now.
While the configuration could be passed directly to netproc(), keyproc() etc,
the diff is smaller this way.

This also removes the multidir (-m) mode for now - specify different paths in
each domain {} block instead.

ok florian

Revision 1.4 / (download) - annotate - [select for diffs], Thu Jan 5 13:53:09 2017 UTC (7 years, 5 months ago) by krw
Branch: MAIN
Changes since 1.3: +2 -3 lines
Diff to previous 1.3 (colored)

Replace hand-rolled for(;;) emptying of 'symhead' TAILQ with more
modern TAILQ_FOREACH_SAFE().

No intentional functional change.

ok millert@ bluhm@ gilles@

Revision 1.3 / (download) - annotate - [select for diffs], Thu Jan 5 12:42:18 2017 UTC (7 years, 5 months ago) by krw
Branch: MAIN
Changes since 1.2: +7 -5 lines
Diff to previous 1.2 (colored)

Replace symset()'s hand-rolled for(;;) traversal of 'symhead' TAILQ
with more modern TAILQ_FOREACH(). This what symget() was already
doing.

Add paranoia '{}' around body of symget()'s TAILQ_FOREACH().

No intentional functional change.

ok bluhm@ otto@

Revision 1.2 / (download) - annotate - [select for diffs], Tue Sep 20 19:16:32 2016 UTC (7 years, 8 months ago) by benno
Branch: MAIN
Changes since 1.1: +4 -4 lines
Diff to previous 1.1 (colored)

reoorder includes,
noticed by & ok florian@

Revision 1.1 / (download) - annotate - [select for diffs], Sun Sep 18 20:18:25 2016 UTC (7 years, 8 months ago) by benno
Branch: MAIN

add a config file parser to acme-client (unused at the moment, so that
it can be worked on in the tree).
ok florian@ deraadt@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.