CVS log for src/usr.sbin/bgpctl/bgpctl.c

Up to [local] / src / usr.sbin / bgpctl

Request diff between arbitrary revisions

Default branch: MAIN

Revision 1.306 / (download) - annotate - [select for diffs], Wed May 22 08:42:34 2024 UTC (2 weeks, 4 days ago) by claudio
Branch: MAIN
CVS Tags: HEAD
Changes since 1.305: +6 -4 lines
Diff to previous 1.305 (colored)

Adjust code since remote_bgpid, bgpid and clusterid changed to
host byte order.
OK tb@

Revision 1.305 / (download) - annotate - [select for diffs], Thu Feb 1 11:37:10 2024 UTC (4 months, 1 week ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5
Changes since 1.304: +89 -138 lines
Diff to previous 1.304 (colored)

Convert the mrtparser to use ibufs in many places.

More is possible but for now this covers most of the message parsers.
OK tb@

Revision 1.304 / (download) - annotate - [select for diffs], Wed Jan 31 11:23:19 2024 UTC (4 months, 1 week ago) by claudio
Branch: MAIN
Changes since 1.303: +11 -13 lines
Diff to previous 1.303 (colored)

Convert IMSG_CTL_SHOW_RIB_ATTR over to the new ibuf API.

This converts show_attr() and json_attr() and with that also the
community specific functions. This removes some hacks inside of
show_attr() that where added before.

OK tb@

Revision 1.303 / (download) - annotate - [select for diffs], Tue Jan 30 13:51:13 2024 UTC (4 months, 1 week ago) by claudio
Branch: MAIN
Changes since 1.302: +9 -12 lines
Diff to previous 1.302 (colored)

Adjust bgpctl to work with the modified aspath functions from util.c

While doing that convert IMSG_CTL_SHOW_RIB over to the new ibuf api.
OK tb@

Revision 1.302 / (download) - annotate - [select for diffs], Thu Jan 25 09:54:21 2024 UTC (4 months, 2 weeks ago) by claudio
Branch: MAIN
Changes since 1.301: +20 -31 lines
Diff to previous 1.301 (colored)

Siwtch IMSG_CTL_SHOW_RIB_COMMUNITIES over to the new ibuf api.

Adjust fmt_ext_community() to take a uint64_t as argument instead of
passing a pointer.
OK tb@

Revision 1.301 / (download) - annotate - [select for diffs], Tue Jan 23 16:16:15 2024 UTC (4 months, 2 weeks ago) by claudio
Branch: MAIN
Changes since 1.300: +50 -83 lines
Diff to previous 1.300 (colored)

Adopt bgpctl code to the ibuf changes done in bgpd.

Adjust code that calls nlri_get_prefix() and friends to work with
an ibuf. show_mrt_update() is mostly converted because of this.
The output functions and the rest of the mrtparser are just
minimally touched to keep the diff reasonable.
OK tb@

Revision 1.300 / (download) - annotate - [select for diffs], Thu Jan 18 14:46:21 2024 UTC (4 months, 3 weeks ago) by claudio
Branch: MAIN
Changes since 1.299: +36 -42 lines
Diff to previous 1.299 (colored)

Convert the simple imsgs to use imsg_get_data().
OK tb@

Revision 1.299 / (download) - annotate - [select for diffs], Mon Jan 8 15:09:14 2024 UTC (5 months ago) by claudio
Branch: MAIN
Changes since 1.298: +7 -13 lines
Diff to previous 1.298 (colored)

Simplify the IMSG_CTL_KROUTE after the change in bgpd.
OK tb@

Revision 1.298 / (download) - annotate - [select for diffs], Mon Nov 20 14:41:55 2023 UTC (6 months, 2 weeks ago) by claudio
Branch: MAIN
Changes since 1.297: +65 -60 lines
Diff to previous 1.297 (colored)

Rename struct imsgbuf *ibuf to *imsgbuf. Same was done in bgpd.
OK tb@

Revision 1.297 / (download) - annotate - [select for diffs], Mon Nov 20 14:40:52 2023 UTC (6 months, 2 weeks ago) by claudio
Branch: MAIN
Changes since 1.296: +3 -2 lines
Diff to previous 1.296 (colored)

KNF, fix long line.
OK tb@

Revision 1.296 / (download) - annotate - [select for diffs], Wed Sep 6 09:52:26 2023 UTC (9 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_4_BASE, OPENBSD_7_4
Changes since 1.295: +2 -1 lines
Diff to previous 1.295 (colored)

Add missing <sys/time.h> include for timespecsub()

Revision 1.295 / (download) - annotate - [select for diffs], Fri Apr 28 13:24:25 2023 UTC (13 months, 1 week ago) by claudio
Branch: MAIN
Changes since 1.294: +3 -1 lines
Diff to previous 1.294 (colored)

Same change as in bgpd:
Add explicit default labels in switch() statements with error handling.
Right now these are not reachable. Should also clear some gcc warnings.
OK tb@

Revision 1.294 / (download) - annotate - [select for diffs], Sun Apr 23 11:39:51 2023 UTC (13 months, 2 weeks ago) by claudio
Branch: MAIN
Changes since 1.293: +15 -2 lines
Diff to previous 1.293 (colored)

For FLOWSPEC_SHOW conver the AID form regular inet/inet6 to flowspec versions.
OK tb@

Revision 1.293 / (download) - annotate - [select for diffs], Fri Apr 21 10:49:01 2023 UTC (13 months, 2 weeks ago) by claudio
Branch: MAIN
Changes since 1.292: +25 -15 lines
Diff to previous 1.292 (colored)

Adjust ext community handling to support the generic transitive communities
introduced with flowspec.
OK tb@

Revision 1.292 / (download) - annotate - [select for diffs], Fri Apr 21 09:12:41 2023 UTC (13 months, 2 weeks ago) by claudio
Branch: MAIN
Changes since 1.291: +125 -1 lines
Diff to previous 1.291 (colored)

Implement flowspec add and delete to add/remove flowspec rules dynamically.
OK tb@

Revision 1.291 / (download) - annotate - [select for diffs], Thu Apr 20 14:01:50 2023 UTC (13 months, 3 weeks ago) by claudio
Branch: MAIN
Changes since 1.290: +26 -1 lines
Diff to previous 1.290 (colored)

Implement bgpctl show flowspec and bgpctl flowspec flush.

This uses the flowspec.c file from bgpd and implements the output
for flowspec only for the text printer for now. That code uses a lot
of code from printconf.c
OK tb@

Revision 1.290 / (download) - annotate - [select for diffs], Mon Mar 13 16:59:22 2023 UTC (14 months, 4 weeks ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_3_BASE, OPENBSD_7_3
Changes since 1.289: +4 -4 lines
Diff to previous 1.289 (colored)

Extend bgpctl show rib with two new options:
 - invalid: show only routes that are not valid
 - leaked: show only routes where a route leak was detected
OK tb@

Revision 1.289 / (download) - annotate - [select for diffs], Tue Jan 24 11:29:34 2023 UTC (16 months, 2 weeks ago) by claudio
Branch: MAIN
Changes since 1.288: +14 -1 lines
Diff to previous 1.288 (colored)

Print the ASPA validation state (avs) in various show rib outputs.
OK tb@

Revision 1.288 / (download) - annotate - [select for diffs], Tue Jan 17 16:09:34 2023 UTC (16 months, 3 weeks ago) by claudio
Branch: MAIN
Changes since 1.287: +3 -1 lines
Diff to previous 1.287 (colored)

Teach bgpctl about ASPA tables.
OK tb@

Revision 1.287 / (download) - annotate - [select for diffs], Tue Oct 18 09:30:29 2022 UTC (19 months, 3 weeks ago) by job
Branch: MAIN
Changes since 1.286: +3 -3 lines
Diff to previous 1.286 (colored)

Fix some spelling errors

Thanks Marco D'Itri for spotting them

OK claudio@

Revision 1.286 / (download) - annotate - [select for diffs], Mon Oct 17 16:51:36 2022 UTC (19 months, 3 weeks ago) by claudio
Branch: MAIN
Changes since 1.285: +3 -3 lines
Diff to previous 1.285 (colored)

SHOW_METRICS for the actions enum. Just to match the rest.

Revision 1.285 / (download) - annotate - [select for diffs], Mon Oct 17 12:01:19 2022 UTC (19 months, 3 weeks ago) by claudio
Branch: MAIN
Changes since 1.284: +52 -10 lines
Diff to previous 1.284 (colored)

Implement openmetric output via bgpctl show metric command

This adds most of the generic code to output the metrics with labels
and implements some basic metrics. The code works but metrics may still
change.

OK tb@

Revision 1.284 / (download) - annotate - [select for diffs], Fri Oct 7 09:20:30 2022 UTC (20 months ago) by claudio
Branch: MAIN
Changes since 1.283: +5 -5 lines
Diff to previous 1.283 (colored)

Kill extra space in ext community ovs output.
Noticed by job@, OK tb@

Revision 1.283 / (download) - annotate - [select for diffs], Wed Aug 31 15:00:53 2022 UTC (21 months, 1 week ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2
Changes since 1.282: +2 -9 lines
Diff to previous 1.282 (colored)

Remove the hash statistics print code. The RDE no longer sends these
imsgs.
OK tb@

Revision 1.282 / (download) - annotate - [select for diffs], Wed Aug 17 15:16:12 2022 UTC (21 months, 3 weeks ago) by claudio
Branch: MAIN
Changes since 1.281: +11 -11 lines
Diff to previous 1.281 (colored)

Use memset() instead of bzero().
OK tb@ deraadt@

Revision 1.281 / (download) - annotate - [select for diffs], Thu Jul 28 10:40:25 2022 UTC (22 months, 1 week ago) by claudio
Branch: MAIN
Changes since 1.280: +5 -13 lines
Diff to previous 1.280 (colored)

Adjust bgpctl show fib output.

Remove F_DOWN from flags since kroutes can no longer be marked down.
Also clean up the flag printing code and printf() and increase the size
of destionation and gateway so that more IPv6 addrs fit.

OK tb@

Revision 1.280 / (download) - annotate - [select for diffs], Thu Jul 7 12:17:57 2022 UTC (23 months ago) by claudio
Branch: MAIN
Changes since 1.279: +10 -2 lines
Diff to previous 1.279 (colored)

Print dmetric for prefixes, this may still change in the future.
OK tb@

Revision 1.279 / (download) - annotate - [select for diffs], Mon Jun 27 13:27:38 2022 UTC (23 months, 2 weeks ago) by claudio
Branch: MAIN
Changes since 1.278: +11 -1 lines
Diff to previous 1.278 (colored)

bgpctl bits for RFC 9234 support.
OK tb@

Revision 1.278 / (download) - annotate - [select for diffs], Thu Jun 23 12:40:32 2022 UTC (23 months, 2 weeks ago) by claudio
Branch: MAIN
Changes since 1.277: +9 -12 lines
Diff to previous 1.277 (colored)

fmt_timeframe() cleanup. Remove the ring buffer, it is not required.
Ensure that the time_t is positive and print increadibly long timeframes
of over 19 years just as weeks.
OK tb@

Revision 1.277 / (download) - annotate - [select for diffs], Wed Jun 15 10:10:50 2022 UTC (23 months, 3 weeks ago) by claudio
Branch: MAIN
Changes since 1.276: +2 -4 lines
Diff to previous 1.276 (colored)

Adjust after chaning F_BGPD_INSERTED to F_BGPD and removal of F_DYNAMIC

Revision 1.276 / (download) - annotate - [select for diffs], Mon Mar 21 10:16:23 2022 UTC (2 years, 2 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.275: +3 -3 lines
Diff to previous 1.275 (colored)

Adjust to renaming of F_CTL_ACTIVE/F_PREF_ACTIVE to F_CTL_ACTIVE/F_PREF_BEST
OK tb@

Revision 1.275 / (download) - annotate - [select for diffs], Sun Feb 6 09:52:32 2022 UTC (2 years, 4 months ago) by claudio
Branch: MAIN
Changes since 1.274: +52 -52 lines
Diff to previous 1.274 (colored)

Switch from u_intX_t types to stdint.h uintX_t like it was done in bgpd.
OK florian@ tb@

Revision 1.274 / (download) - annotate - [select for diffs], Fri Feb 4 12:01:33 2022 UTC (2 years, 4 months ago) by claudio
Branch: MAIN
Changes since 1.273: +7 -7 lines
Diff to previous 1.273 (colored)

Rename sockaddr_un sun to sa_un since sun is defined on illumos systems.
OK dlg@

Revision 1.273 / (download) - annotate - [select for diffs], Mon Aug 9 08:24:36 2021 UTC (2 years, 10 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0
Changes since 1.272: +2 -1 lines
Diff to previous 1.272 (colored)

Make it possible to match on path-id in bgpctl show rib outputs.
To work properly also a neighbor needs to be selected. The assumption
here is that the peer will use the same path-id for the same peer
accross all its routes. The RFC does not require this and it is valid
to assign path-ids randomly. The path-id only matters for one specific
path but most BGP implementations seem to assign the same path-id to
multiple routes when originated from the same source.
OK benno@

Revision 1.272 / (download) - annotate - [select for diffs], Mon Aug 2 16:51:39 2021 UTC (2 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.271: +3 -2 lines
Diff to previous 1.271 (colored)

Show if add_path was used when decoding the BGP message in MRT format.
This may help to spot encoding errors a bit more easily.

Revision 1.271 / (download) - annotate - [select for diffs], Tue Jul 27 07:42:37 2021 UTC (2 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.270: +42 -7 lines
Diff to previous 1.270 (colored)

Implemnt the RFC8050 in the MRT parser. With this MRT dumps containing
add-path information will be dumped properly.

There is one bit where this implementation is not in line with the RFC.
The encoding of DUMP_V2_RIB_GENERIC_ADDPATH for non IPv4 or IPv6 prefixes
is implemented the way gobgp did it (which seems to be the only other BGP
implementation that supports generic encoding). The RFC puts the path_id
in the NLRI for generic encoding instead of adding it to RIB entry struct
like in the IPv4 and IPv6 encoding. This is an open discussion point with
the RFC author.

OK benno@

Revision 1.270 / (download) - annotate - [select for diffs], Tue Jul 20 12:08:53 2021 UTC (2 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.269: +2 -2 lines
Diff to previous 1.269 (colored)

Also add missing -V to usage

Revision 1.269 / (download) - annotate - [select for diffs], Wed Jun 16 16:24:11 2021 UTC (2 years, 11 months ago) by job
Branch: MAIN
Changes since 1.268: +6 -2 lines
Diff to previous 1.268 (colored)

Add command line option to show the version

OK claudio@

Revision 1.268 / (download) - annotate - [select for diffs], Thu May 27 08:29:06 2021 UTC (3 years ago) by claudio
Branch: MAIN
Changes since 1.267: +8 -1 lines
Diff to previous 1.267 (colored)

Add the bits needed in bgpctl to show the new ADD-PATH and enhanced
route refresh capabilities in the neighbor output.

Revision 1.267 / (download) - annotate - [select for diffs], Mon May 3 14:01:56 2021 UTC (3 years, 1 month ago) by claudio
Branch: MAIN
Changes since 1.266: +18 -8 lines
Diff to previous 1.266 (colored)

Print the timestamps both formatted and as a time in seconds field in
the various JSON object that have time values.
OK benno@

Revision 1.266 / (download) - annotate - [select for diffs], Thu Apr 15 14:12:05 2021 UTC (3 years, 1 month ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_6_9_BASE, OPENBSD_6_9
Changes since 1.265: +7 -6 lines
Diff to previous 1.265 (colored)

Fix bgpctl show mrt for UPDATE messages. The call to output->attr() was
incorrect. Adjust output->attr() to take a reqflag argument instead of
a struct parse_result pointer since that is the only bit needed.
Found by and OK procter@, OK deraadt@

Revision 1.265 / (download) - annotate - [select for diffs], Tue Feb 16 08:30:21 2021 UTC (3 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.264: +30 -12 lines
Diff to previous 1.264 (colored)

Add `bgpctl show rtr` to display basic information about RTR sessions.
OK job@

Revision 1.264 / (download) - annotate - [select for diffs], Wed Dec 30 07:31:19 2020 UTC (3 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.263: +26 -1 lines
Diff to previous 1.263 (colored)

Add 'bgpctl show sets' to display information about the roa-set, as-sets,
and prefix-sets loaded into bgpd.
OK benno@

Revision 1.263 / (download) - annotate - [select for diffs], Sun May 10 13:38:46 2020 UTC (4 years, 1 month ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8
Changes since 1.262: +18 -14 lines
Diff to previous 1.262 (colored)

In bgpctl argument parser, re-arrange 'reason' parsing ('nei action [reason]')
to be more generic,  then change 'reload' to take take a '[reason]' also,
which will be logged by bgpd.
ok kn claudio

Revision 1.262 / (download) - annotate - [select for diffs], Sat May 2 14:33:33 2020 UTC (4 years, 1 month ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.261: +6 -3 lines
Diff to previous 1.261 (colored)

Add support to output data in JSON. This is still work in progress and
the output structures may still change but it should be a good starting
point for poeple to start playing with it.
OK benno@, job@, deraadt@

Revision 1.261 / (download) - annotate - [select for diffs], Sat May 2 14:31:32 2020 UTC (4 years, 1 month ago) by claudio
Branch: MAIN
Changes since 1.260: +3 -3 lines
Diff to previous 1.260 (colored)

Adjust fmt_attr() to pass in -1 for flags to tell it you don't care
about the flags of the attribute. Part of the JSON output diff.
OK job@, benno@, deraadt@

Revision 1.260 / (download) - annotate - [select for diffs], Sat May 2 14:28:10 2020 UTC (4 years, 1 month ago) by claudio
Branch: MAIN
Changes since 1.259: +23 -18 lines
Diff to previous 1.259 (colored)

Indirect the output functions through function pointers so that they
can be changed easily. This will be used later on to add JSON output.
OK benno@, job@, deraadt@

Revision 1.259 / (download) - annotate - [select for diffs], Fri Mar 20 07:56:34 2020 UTC (4 years, 2 months ago) by claudio
Branch: MAIN
Changes since 1.258: +181 -569 lines
Diff to previous 1.258 (colored)

Reshuffle code more to separate out the output functions into output.c.
Rewrite some functions to return a string instead of calling printf directly.
OK benno@

Revision 1.258 / (download) - annotate - [select for diffs], Fri Jan 24 05:46:00 2020 UTC (4 years, 4 months ago) by claudio
Branch: MAIN
Changes since 1.257: +3 -1 lines
Diff to previous 1.257 (colored)

Extend 'bgpctl show neighbor' to include the received and sent prefix
count. Also show the max-prefix out limit if one is set.
OK job@

Revision 1.257 / (download) - annotate - [select for diffs], Tue Jan 21 11:14:26 2020 UTC (4 years, 4 months ago) by claudio
Branch: MAIN
Changes since 1.256: +46 -14 lines
Diff to previous 1.256 (colored)

Update get_errstr() to report errors like log_notification() in bgpd.
With this suberrors of cease will be reported which is very helpful.
OK denis@ deraadt@

Revision 1.256 / (download) - annotate - [select for diffs], Thu Jan 9 11:57:04 2020 UTC (4 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.255: +18 -11 lines
Diff to previous 1.255 (colored)

Adjust time printing to the changes done in bgpd. Most timestamps are
now relative only last_updown, last_read and lastwrite are still based
on CLOCK_MONOTONIC.
OK denis@

Revision 1.255 / (download) - annotate - [select for diffs], Tue Dec 31 14:09:27 2019 UTC (4 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.254: +2 -14 lines
Diff to previous 1.254 (colored)

Rename print_timer() to show_timer() and move it to output.c
Currently this needs a bit of a hack because fmt_timeframe()
does not really print a timeframe but instead needs a timestamp
relative to now. This needs to be adjusted but will be done later.

Revision 1.254 / (download) - annotate - [select for diffs], Fri Dec 20 09:16:05 2019 UTC (4 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.253: +5 -531 lines
Diff to previous 1.253 (colored)

Split out show functions into a new file called output.c
OK benno@

Revision 1.253 / (download) - annotate - [select for diffs], Fri Dec 20 07:18:51 2019 UTC (4 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.252: +28 -24 lines
Diff to previous 1.252 (colored)

Shuffle the fmt_timeframe functions and change fmt_timeframe() to avoid
printing negative time frames (caused by jumping the system clock back
in time).
OK benno@

Revision 1.252 / (download) - annotate - [select for diffs], Fri Dec 20 07:17:02 2019 UTC (4 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.251: +7 -4 lines
Diff to previous 1.251 (colored)

Change show_mrt_dump() to call show_rib() instead of the internal
show_rib_detail() and show_rib_brief() functions.
OK benno@

Revision 1.251 / (download) - annotate - [select for diffs], Thu Dec 19 06:43:51 2019 UTC (4 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.250: +401 -554 lines
Diff to previous 1.250 (colored)

Change the way individual show functions are called. Up until now an imsg
was passed to each function and output happened based on the imsg type.
Now show() will look at the imsg and based on the type call the right
function to output this type. Because of this every show function is now
only displaying one specific object.
OK benno@

Revision 1.250 / (download) - annotate - [select for diffs], Fri Dec 13 11:11:22 2019 UTC (4 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.249: +1 -54 lines
Diff to previous 1.249 (colored)

Remove some more show_*_head() functions. Compiler agrees.

Revision 1.249 / (download) - annotate - [select for diffs], Fri Dec 13 09:01:07 2019 UTC (4 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.248: +1 -13 lines
Diff to previous 1.248 (colored)

Remove show_rib_summary_head() it is no longer used.
Reminded by denis@

Revision 1.248 / (download) - annotate - [select for diffs], Fri Dec 13 08:59:07 2019 UTC (4 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.247: +175 -118 lines
Diff to previous 1.247 (colored)

First step of refactoring the output processing of bgpctl. Move
header printing into show_head() and printing of the data into
show(), these are now the only entrypoints where data is printed.
OK denis@

Revision 1.247 / (download) - annotate - [select for diffs], Wed Nov 27 01:23:30 2019 UTC (4 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.246: +20 -15 lines
Diff to previous 1.246 (colored)

Adjust after changing the struct ctl_show_rib (removal of aspath_len)
OK benno@

Revision 1.246 / (download) - annotate - [select for diffs], Fri Sep 27 10:34:54 2019 UTC (4 years, 8 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.245: +19 -9 lines
Diff to previous 1.245 (colored)

Implement 'bgpctl show rib 8.8.8.8 or-shorter' to show all routes covering
8.8.8.8. Additionally add 'or-longer' as an alias for 'all'.
OK job@ sthen@

Revision 1.245 / (download) - annotate - [select for diffs], Wed Sep 25 15:35:50 2019 UTC (4 years, 8 months ago) by sthen
Branch: MAIN
Changes since 1.244: +5 -4 lines
Diff to previous 1.244 (colored)

also show peer AS and description in "bgpctl sh nei group XXX terse" output
ok deraadt@ claudio@

Revision 1.244 / (download) - annotate - [select for diffs], Tue Sep 24 14:46:09 2019 UTC (4 years, 8 months ago) by sthen
Branch: MAIN
Changes since 1.243: +18 -3 lines
Diff to previous 1.243 (colored)

add the neighbour's address, to disambiguate peers in the output from
"bgpctl sh nei group XX terse". feedback benno@ ok claudio@

Revision 1.243 / (download) - annotate - [select for diffs], Mon Aug 5 12:51:32 2019 UTC (4 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.242: +5 -1 lines
Diff to previous 1.242 (colored)

Add a comment why network_bulk() is not using send_filterset(). Using
send_filterset() would result in a use after free because send_filterset()
frees the set after sending but network_bulk() runs in a loop.

Revision 1.242 / (download) - annotate - [select for diffs], Wed Jul 3 06:15:48 2019 UTC (4 years, 11 months ago) by claudio
Branch: MAIN
Changes since 1.241: +2 -2 lines
Diff to previous 1.241 (colored)

Remove unneccessary type cast

Revision 1.241 / (download) - annotate - [select for diffs], Tue Jun 25 07:44:20 2019 UTC (4 years, 11 months ago) by claudio
Branch: MAIN
Changes since 1.240: +1 -9 lines
Diff to previous 1.240 (colored)

Remove irrfilter from bgpctl. The current code is not very useful.
Trying to parse RPSL has shown to be impossible. For now tools like
bgpq3 (in ports) can be used to generate AS and prefix sets based on
IRR data.
OK job@ deraadt@ sthen@ benno@

Revision 1.240 / (download) - annotate - [select for diffs], Mon Jun 17 13:46:33 2019 UTC (4 years, 11 months ago) by claudio
Branch: MAIN
Changes since 1.239: +7 -7 lines
Diff to previous 1.239 (colored)

Cleanup some spaces here as well. Again no binary change.

Revision 1.239 / (download) - annotate - [select for diffs], Mon Jun 17 11:03:07 2019 UTC (4 years, 11 months ago) by claudio
Branch: MAIN
Changes since 1.238: +167 -83 lines
Diff to previous 1.238 (colored)

Adjust and sync the code with the new struct community code from bgpd.
OK benno@

Revision 1.238 / (download) - annotate - [select for diffs], Thu May 23 14:12:06 2019 UTC (5 years ago) by claudio
Branch: MAIN
Changes since 1.237: +27 -2 lines
Diff to previous 1.237 (colored)

Implement bgpctl show mrt neighbors, a command to print the neighbor table
of MRT TABLE_DUMP_V2 dumps. It only works with TABLE_DUMP_V2 dumps on other
table dumps the neighbor of the first entry is printed since those table
dumps don't have a neighbor table.
OK sthen@ benno@

Revision 1.237 / (download) - annotate - [select for diffs], Tue May 14 16:47:30 2019 UTC (5 years ago) by benno
Branch: MAIN
Changes since 1.236: +2 -2 lines
Diff to previous 1.236 (colored)

make "bgpctl sh rib detail *out*" look less confusing
ok claudio@

Revision 1.236 / (download) - annotate - [select for diffs], Fri May 3 01:48:42 2019 UTC (5 years, 1 month ago) by jsg
Branch: MAIN
Changes since 1.235: +2 -1 lines
Diff to previous 1.235 (colored)

missing break
ok benno@

Revision 1.235 / (download) - annotate - [select for diffs], Thu Apr 25 12:14:37 2019 UTC (5 years, 1 month ago) by claudio
Branch: MAIN
Changes since 1.234: +7 -7 lines
Diff to previous 1.234 (colored)

Adjust the MRT notification parser similar to bgpd to support extended
shutdown communication messages.

Revision 1.234 / (download) - annotate - [select for diffs], Wed Feb 27 04:34:21 2019 UTC (5 years, 3 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.233: +6 -21 lines
Diff to previous 1.233 (colored)

Adjust to the last bgpd change. sa2addr gets an extra agrument and
local and remote address in struct peer changed to bgpd_addrs.
OK benno@

Revision 1.233 / (download) - annotate - [select for diffs], Mon Feb 25 11:51:58 2019 UTC (5 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.232: +13 -42 lines
Diff to previous 1.232 (colored)

Use struct bgpd_addr instead of a union of sockaddrs to store addresses
in the mrt dump structs. This is more compatible with bgpctl since it uses
struct bgpd_addr in most cases anyway.
OK kn@

Revision 1.232 / (download) - annotate - [select for diffs], Thu Feb 21 12:12:46 2019 UTC (5 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.231: +3 -3 lines
Diff to previous 1.231 (colored)

type is not used here. Still keep a comment around to keep the code
similar to all other attr parsers.

Revision 1.231 / (download) - annotate - [select for diffs], Thu Feb 21 11:18:27 2019 UTC (5 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.230: +19 -31 lines
Diff to previous 1.230 (colored)

Adjust bgpctl to the new ctl_show_interface struct that is sent instead of
the system specific struct kif. Makes this code a lot more portable but
still prints the same info in the same way.
OK sthen@

Revision 1.230 / (download) - annotate - [select for diffs], Tue Feb 19 09:15:21 2019 UTC (5 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.229: +20 -20 lines
Diff to previous 1.229 (colored)

Switch betoh64 to the posix be64toh also remove some casts since we now
use long long instead of int64_t.

Revision 1.229 / (download) - annotate - [select for diffs], Mon Feb 11 15:47:55 2019 UTC (5 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.228: +5 -10 lines
Diff to previous 1.228 (colored)

Adjust to last bgpd commit changing the MPLS VPN configuration.
Sync the community handling code to be in sync with parsing code of bgpd.
To inject networks into MPLS VPN it is required to specify the route
distinguisher as part of the attributes.
With and OK dlg@, OK denis@

Revision 1.228 / (download) - annotate - [select for diffs], Sun Jan 20 23:30:15 2019 UTC (5 years, 4 months ago) by claudio
Branch: MAIN
Changes since 1.227: +2 -1 lines
Diff to previous 1.227 (colored)

Allow 'neighbor descripton' to be used like neighbor group description
which will match all neighbors in that group. Works for
    bgpctl neighbor group <name> [clear|destroy|down|refresh|up]
    bgpctl show neighbor group <name> [messages|terse|timers]
    bgpctl show rib neighbor group <name> ...
Manpage bits from sthen@
OK benno@ sthen@

Revision 1.227 / (download) - annotate - [select for diffs], Wed Dec 19 15:27:29 2018 UTC (5 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.226: +1 -3 lines
Diff to previous 1.226 (colored)

Adjust bgpctl now that filter_extcommunity is no more.
OK benno@

Revision 1.226 / (download) - annotate - [select for diffs], Tue Dec 11 09:03:36 2018 UTC (5 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.225: +65 -6 lines
Diff to previous 1.225 (colored)

bgpctl can no long reuse the aspath_match function from bgpd so move the
roughly the same function here called match_aspath().
OK denis@

Revision 1.225 / (download) - annotate - [select for diffs], Wed Dec 5 06:53:52 2018 UTC (5 years, 6 months ago) by denis
Branch: MAIN
Changes since 1.224: +7 -4 lines
Diff to previous 1.224 (colored)

Set the routing table when adding a network

OK claudio@

Revision 1.224 / (download) - annotate - [select for diffs], Wed Nov 28 08:33:59 2018 UTC (5 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.223: +7 -34 lines
Diff to previous 1.223 (colored)

Adjust bgpctl to handle the community changes done in bgpd.
OK job@, phessler@

Revision 1.223 / (download) - annotate - [select for diffs], Thu Nov 1 10:09:52 2018 UTC (5 years, 7 months ago) by denis
Branch: MAIN
Changes since 1.222: +3 -3 lines
Diff to previous 1.222 (colored)

fix typos

Noticed by David Higgs, thanks.

OK claudio@

Revision 1.222 / (download) - annotate - [select for diffs], Wed Oct 31 14:58:59 2018 UTC (5 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.221: +2 -2 lines
Diff to previous 1.221 (colored)

Remove extra ,
Noticed by denis@

Revision 1.221 / (download) - annotate - [select for diffs], Wed Oct 31 14:51:12 2018 UTC (5 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.220: +3 -1 lines
Diff to previous 1.220 (colored)

Show the number of references hold by struct rde_aspath objects (which should
be the same as the number of prefixes for now).
OK denis@

Revision 1.220 / (download) - annotate - [select for diffs], Fri Oct 26 16:54:53 2018 UTC (5 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.219: +8 -1 lines
Diff to previous 1.219 (colored)

Show how much memory is used for *-sets.
OK deraadt@

Revision 1.219 / (download) - annotate - [select for diffs], Mon Oct 1 23:09:53 2018 UTC (5 years, 8 months ago) by job
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE, OPENBSD_6_4
Changes since 1.218: +26 -7 lines
Diff to previous 1.218 (colored)

Expose BGP Origin Validation state in bgpctl show commands

OK denis@ claudio@

Revision 1.218 / (download) - annotate - [select for diffs], Wed Sep 26 15:48:47 2018 UTC (5 years, 8 months ago) by claudio
Branch: MAIN
Changes since 1.217: +6 -6 lines
Diff to previous 1.217 (colored)

Rename AS_NONE to AS_UNDEF here as well. OK compiler & grep

Revision 1.217 / (download) - annotate - [select for diffs], Thu Sep 20 11:46:40 2018 UTC (5 years, 8 months ago) by claudio
Branch: MAIN
Changes since 1.216: +3 -3 lines
Diff to previous 1.216 (colored)

as_set_match() changed again, so adjust it here too.
OK benno@

Revision 1.216 / (download) - annotate - [select for diffs], Fri Sep 14 10:22:55 2018 UTC (5 years, 8 months ago) by claudio
Branch: MAIN
Changes since 1.215: +3 -3 lines
Diff to previous 1.215 (colored)

Adjust the dummy as_set_match function to new prototype after last bgpd commit
OK benno@

Revision 1.215 / (download) - annotate - [select for diffs], Sun Sep 9 12:53:41 2018 UTC (5 years, 9 months ago) by benno
Branch: MAIN
Changes since 1.214: +2 -2 lines
Diff to previous 1.214 (colored)

sync header line with whats actually in the output.
ok claudio@

Revision 1.214 / (download) - annotate - [select for diffs], Fri Sep 7 05:44:58 2018 UTC (5 years, 9 months ago) by claudio
Branch: MAIN
Changes since 1.213: +7 -1 lines
Diff to previous 1.213 (colored)

Add a dummy as_set_match() function since it is needed to link util.c now.

Revision 1.213 / (download) - annotate - [select for diffs], Thu Sep 6 18:38:06 2018 UTC (5 years, 9 months ago) by claudio
Branch: MAIN
Changes since 1.212: +39 -44 lines
Diff to previous 1.212 (colored)

Use getline() for the network bulk code. Also make the parser better by
doing tokenizing on spaces and correctly ignore comments.
This should make this feature in general more robust.
OK benno@

Revision 1.212 / (download) - annotate - [select for diffs], Wed Sep 5 09:50:43 2018 UTC (5 years, 9 months ago) by claudio
Branch: MAIN
Changes since 1.211: +4 -4 lines
Diff to previous 1.211 (colored)

Adjust after change of struct filter_as.
OK phessler@

Revision 1.211 / (download) - annotate - [select for diffs], Wed Aug 29 19:52:23 2018 UTC (5 years, 9 months ago) by claudio
Branch: MAIN
Changes since 1.210: +5 -3 lines
Diff to previous 1.210 (colored)

Introduce 'bgpctl show rib error' to show all prefixes that got flagged
invalid because of a soft parsing error. These prefixes are never eligible
or valid but the listing may help to understand what is going on.
'bgpctl show rib error' run automatically on Adj-RIB-In since that is the only
RIB that has such prefixes.
OK sthen@ denis@

Revision 1.210 / (download) - annotate - [select for diffs], Sun Jul 29 13:02:01 2018 UTC (5 years, 10 months ago) by deraadt
Branch: MAIN
Changes since 1.209: +2 -2 lines
Diff to previous 1.209 (colored)

mestre and i both concluded pledge can be tightened, "unix" handles the
coming code and "rpath wpath" isn't needed
ok claudio

Revision 1.209 / (download) - annotate - [select for diffs], Sun Jul 22 17:07:53 2018 UTC (5 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.208: +690 -39 lines
Diff to previous 1.208 (colored)

First iteration of implementing full mrt dumping/printing support in bgpctl.
This is good enough as a start but I guess output could be nicer.
OK benno@

Revision 1.208 / (download) - annotate - [select for diffs], Sun Jul 22 16:52:27 2018 UTC (5 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.207: +1 -77 lines
Diff to previous 1.207 (colored)

Move functions to print link status etc. to util.c so that bgpd can use them
as well. OK benno@

Revision 1.207 / (download) - annotate - [select for diffs], Fri Jul 20 12:49:49 2018 UTC (5 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.206: +20 -3 lines
Diff to previous 1.206 (colored)

Print the timestamp embedded in mrt files for update and status messages.
Also implemented the extended precision format so microseconds are printed
as well when available. The output is relative to the previous message and
follows what kdump does.
OK benno@

Revision 1.206 / (download) - annotate - [select for diffs], Fri Jul 20 12:42:45 2018 UTC (5 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.205: +39 -32 lines
Diff to previous 1.205 (colored)

There is no need to have bgpd running when running bgpctl show mrt.
The first thing the code actually does is closing the socket. Instead
move the code up to where currently the IRR filter code is.
Additionally change the late pledges to just stdio since nothing after
that needs rpath or wpath.
OK benno@

Revision 1.205 / (download) - annotate - [select for diffs], Thu Jul 12 21:45:37 2018 UTC (5 years, 10 months ago) by benno
Branch: MAIN
Changes since 1.204: +5 -4 lines
Diff to previous 1.204 (colored)

store and print the rdomain of the interfaces we see.
ok phessler@ henning@

Revision 1.204 / (download) - annotate - [select for diffs], Wed Jul 11 16:35:37 2018 UTC (5 years, 11 months ago) by claudio
Branch: MAIN
Changes since 1.203: +17 -2 lines
Diff to previous 1.203 (colored)

Print out the hash info sent by the RDE in bgpctl show rib mem
OK phessler@ benno@

Revision 1.203 / (download) - annotate - [select for diffs], Tue Jul 10 13:02:14 2018 UTC (5 years, 11 months ago) by benno
Branch: MAIN
Changes since 1.202: +4 -4 lines
Diff to previous 1.202 (colored)

move the top level pledge, getrtable() works with pledge stdio.
ok claudio@ phessler@

Revision 1.202 / (download) - annotate - [select for diffs], Mon Nov 27 16:53:04 2017 UTC (6 years, 6 months ago) by sthen
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_3
Changes since 1.201: +2 -2 lines
Diff to previous 1.201 (colored)

lenght->length, mostly in comments

Revision 1.201 / (download) - annotate - [select for diffs], Mon Oct 16 08:39:16 2017 UTC (6 years, 7 months ago) by job
Branch: MAIN
Changes since 1.200: +2 -2 lines
Diff to previous 1.200 (colored)

Ensure last character in ssv mode is a newline

OK benno@

Revision 1.200 / (download) - annotate - [select for diffs], Sun Oct 15 20:44:21 2017 UTC (6 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.199: +31 -26 lines
Diff to previous 1.199 (colored)

Add "ssv" variant which turns a rib route output into a single
semicolon-seperated line, so that grep and such can operate easier;
then use tr ';' '\n' to convert it to normal form later.  This helps
with scanning vast swathes of routes..
ok benno claudio job

Revision 1.199 / (download) - annotate - [select for diffs], Thu Aug 10 14:22:59 2017 UTC (6 years, 10 months ago) by benno
Branch: MAIN
CVS Tags: OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.198: +22 -27 lines
Diff to previous 1.198 (colored)

replace memcpy() with assignements where the type is the same.
noticed by deraadt@, ok claudio@

Revision 1.198 / (download) - annotate - [select for diffs], Thu Aug 10 14:12:34 2017 UTC (6 years, 10 months ago) by benno
Branch: MAIN
Changes since 1.197: +6 -1 lines
Diff to previous 1.197 (colored)

handle extended communities in bgpctl.
From Dennis Fondras, thanks!
ok phessler@

Revision 1.197 / (download) - annotate - [select for diffs], Mon Jun 26 10:09:13 2017 UTC (6 years, 11 months ago) by phessler
Branch: MAIN
Changes since 1.196: +2 -2 lines
Diff to previous 1.196 (colored)

don't print the WELLKNOWN string for unknown well-known communities

from Job Snijders
ok phessler@ benno@

Revision 1.196 / (download) - annotate - [select for diffs], Mon Jun 26 10:05:57 2017 UTC (6 years, 11 months ago) by phessler
Branch: MAIN
Changes since 1.195: +4 -1 lines
Diff to previous 1.195 (colored)

add support for the "graceful shutdown" well-known community as described
in draft-ietf-grow-bgp-gshut

from Job Snijders
ok phessler@ benno@

Revision 1.195 / (download) - annotate - [select for diffs], Wed May 31 10:48:06 2017 UTC (7 years ago) by claudio
Branch: MAIN
Changes since 1.194: +31 -13 lines
Diff to previous 1.194 (colored)

Update ext community printer to the changes done in bgpd.
OK henning@ benno@

Revision 1.194 / (download) - annotate - [select for diffs], Mon May 29 09:56:33 2017 UTC (7 years ago) by benno
Branch: MAIN
Changes since 1.193: +7 -3 lines
Diff to previous 1.193 (colored)

change bgpd's control socket from /var/run/bgpd.sock to
/var/run/bgpd.sock.<rdomain> in both bgpd and bgpctl. makes life
easier for admins.
ok phessler, claudio, henning, feedback from Job Snijders

Revision 1.193 / (download) - annotate - [select for diffs], Mon Jan 23 23:38:51 2017 UTC (7 years, 4 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.192: +1 -32 lines
Diff to previous 1.192 (colored)

Mission accomplished, bgpctl is now fatal free.

Revision 1.192 / (download) - annotate - [select for diffs], Mon Jan 23 23:35:42 2017 UTC (7 years, 4 months ago) by benno
Branch: MAIN
Changes since 1.191: +15 -22 lines
Diff to previous 1.191 (colored)

cleanup log* functions that break with bgpd reacharound
ok claudio@

Revision 1.191 / (download) - annotate - [select for diffs], Fri Jan 13 18:59:12 2017 UTC (7 years, 4 months ago) by phessler
Branch: MAIN
Changes since 1.190: +13 -1 lines
Diff to previous 1.190 (colored)

Add support for draft-ietf-idr-shutdown

    BGP state = Idle, marked down with shutdown reason "goodbye, we are
    upgrading to openbsd 6.1", down for 00:00:17

developed by Peter van Dijk <peter.van.dijk@powerdns.com> and Job
Snijders <job@ntt.net>, thank you!

OK benno@

Revision 1.190 / (download) - annotate - [select for diffs], Fri Oct 14 16:05:35 2016 UTC (7 years, 7 months ago) by phessler
Branch: MAIN
Changes since 1.189: +49 -1 lines
Diff to previous 1.189 (colored)

Add support for draft-ietf-idr-large-community

Joint work with Job Snijders, many thanks!
OK benno@ deraadt@

Revision 1.189 / (download) - annotate - [select for diffs], Fri Oct 14 09:40:54 2016 UTC (7 years, 7 months ago) by phessler
Branch: MAIN
Changes since 1.188: +23 -1 lines
Diff to previous 1.188 (colored)

when looking at the details of a prefix, show any unknown attributes and
what we know about it.

OK claudio@

Revision 1.188 / (download) - annotate - [select for diffs], Fri Jun 3 17:36:37 2016 UTC (8 years ago) by benno
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.187: +3 -3 lines
Diff to previous 1.187 (colored)

Add operators =, !=, - (range), >< (exclsive range) to the as-path
filters (AS, peer-as, source-as, transit-as).

Add a use case (block illegal AS numbers) to the bgpd.conf example.

feedback from claudio, sthen, florian,
ok florian@ phessler@

Revision 1.187 / (download) - annotate - [select for diffs], Sat Dec 5 13:17:05 2015 UTC (8 years, 6 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.186: +2 -2 lines
Diff to previous 1.186 (colored)

EAGAIN handling for imsg_read. OK henning@ benno@

Revision 1.186 / (download) - annotate - [select for diffs], Sun Nov 1 21:20:46 2015 UTC (8 years, 7 months ago) by benno
Branch: MAIN
Changes since 1.185: +10 -1 lines
Diff to previous 1.185 (colored)

pledge in bgpctl.
ok deraadt

Revision 1.185 / (download) - annotate - [select for diffs], Sat Oct 24 11:54:50 2015 UTC (8 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.184: +26 -6 lines
Diff to previous 1.184 (colored)

Implement the missing bits to parse the other MRT message types.
Printing bgp messages is still missing lots but at least it is a start.
I onced abused tcpdump's bgp protocol handler for this but that is an ugly hack.

Revision 1.184 / (download) - annotate - [select for diffs], Sat Oct 24 11:41:03 2015 UTC (8 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.183: +9 -3 lines
Diff to previous 1.183 (colored)

Print if a route is redistributed or not at least for static & connected.
With phessler@

Revision 1.183 / (download) - annotate - [select for diffs], Sun Oct 11 19:53:57 2015 UTC (8 years, 8 months ago) by sthen
Branch: MAIN
Changes since 1.182: +4 -1 lines
Diff to previous 1.182 (colored)

Handle the blackhole well-known community in bgpctl as well (print it
symbolically, and don't deny its use in 'bgpctl sh rib comm 65535:6666').
ok phessler@

Revision 1.182 / (download) - annotate - [select for diffs], Wed Sep 16 20:25:41 2015 UTC (8 years, 8 months ago) by stsp
Branch: MAIN
Changes since 1.181: +12 -12 lines
Diff to previous 1.181 (colored)

Another ifmedia64 fix, this time for bgpd's ift2ifm().
And rename struct kif's media_type to if_type to avoid confusion with
ifmedia's media type. Same rename in other daemons will follow.
ok claudio henning benno

Revision 1.181 / (download) - annotate - [select for diffs], Sun Sep 13 11:13:12 2015 UTC (8 years, 8 months ago) by deraadt
Branch: MAIN
Changes since 1.180: +5 -5 lines
Diff to previous 1.180 (colored)

match a few if_media uint64_t conversions; ok miod

Revision 1.180 / (download) - annotate - [select for diffs], Sun Jul 19 06:57:27 2015 UTC (8 years, 10 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8
Changes since 1.179: +7 -3 lines
Diff to previous 1.179 (colored)

Match change to fatal()'s prototype in bgpd

ok benno@

Revision 1.179 / (download) - annotate - [select for diffs], Sat Jul 18 16:12:03 2015 UTC (8 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.178: +5 -2 lines
Diff to previous 1.178 (colored)

Tag dynamic routes with a D so I do not get confused when seeing dynamic
routes because of PMTU in the show fib output.

Revision 1.178 / (download) - annotate - [select for diffs], Fri Apr 17 07:51:09 2015 UTC (9 years, 1 month ago) by phessler
Branch: MAIN
Changes since 1.177: +2 -5 lines
Diff to previous 1.177 (colored)

parse_prefix in parse.c got changed but the declaration in bgpctl.c
wasn't updated, so we would crash when doing `bgpctl net bulk` commands.

Fix by moving parse_prefix into a header, since we use it in more than
one file.

crash found by henning@
underlying problem found by blambert@

OK sthen@ deraadt@ claudio@ henning@

Revision 1.177 / (download) - annotate - [select for diffs], Wed Feb 11 23:47:25 2015 UTC (9 years, 3 months ago) by phessler
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.176: +24 -2 lines
Diff to previous 1.176 (colored)

show if we are using a transport security mechanism other than "none"

OK claudio@

Revision 1.176 / (download) - annotate - [select for diffs], Wed Feb 4 23:30:37 2015 UTC (9 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.175: +1 -1 lines
Diff to previous 1.175 (colored)

potential double free in while-loop
Benjamin Baier <ben at netzbasis dot de>

Revision 1.175 / (download) - annotate - [select for diffs], Thu Oct 2 16:37:50 2014 UTC (9 years, 8 months ago) by benno
Branch: MAIN
Changes since 1.174: +15 -5 lines
Diff to previous 1.174 (colored)

bgpctl show summary output: enlarge columns for 4-byte ASN display
diff by Gregor Best (gbe AT ring0 DOT de), i just tweaked the column
calculation based on comments from claudio@

ok sthen@ henning@

Revision 1.174 / (download) - annotate - [select for diffs], Tue Mar 18 13:47:14 2014 UTC (10 years, 2 months ago) by florian
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.173: +2 -3 lines
Diff to previous 1.173 (colored)

Correctly parse attribute length form imsg. While there don't assign
data twice.
From rivo nurges ris _AT_ estpak _DOT_ ee, thanks!
OK sthen

Revision 1.173 / (download) - annotate - [select for diffs], Wed Nov 13 22:52:41 2013 UTC (10 years, 6 months ago) by sthen
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.172: +4 -3 lines
Diff to previous 1.172 (colored)

handle msgbuf_write() returning EAGAIN, looks right to deraadt

Revision 1.172 / (download) - annotate - [select for diffs], Wed Oct 9 08:56:38 2013 UTC (10 years, 8 months ago) by phessler
Branch: MAIN
Changes since 1.171: +69 -1 lines
Diff to previous 1.171 (colored)

Allow us to bulk add / delete routes with the same attributes.  Really
useful for distributing IP lists.

OK beck@, claudio@, henning@

Revision 1.171 / (download) - annotate - [select for diffs], Sun Aug 18 16:32:24 2013 UTC (10 years, 9 months ago) by guenther
Branch: MAIN
Changes since 1.170: +3 -3 lines
Diff to previous 1.170 (colored)

Fix calls to printf-like functions which passed a non-fixed string
as the format and no variable args.
Replace "%#0.*X" with "%#.*X": the zero-fill flag is ignored/implied
on numeric conversions when a precision is specified.

ok jung@ millert@ krw@

Revision 1.170 / (download) - annotate - [select for diffs], Tue Apr 9 14:51:33 2013 UTC (11 years, 2 months ago) by gilles
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4
Changes since 1.169: +4 -3 lines
Diff to previous 1.169 (colored)

do not store a time_t or the result of a time_t division in an int

prompted by deraadt@, ok claudio@ chl@ guenther@

Revision 1.169 / (download) - annotate - [select for diffs], Thu Mar 7 21:28:34 2013 UTC (11 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.168: +10 -4 lines
Diff to previous 1.168 (colored)

Implement a bgpctl nei foo destroy that will remove the specified cloned
neighbor. The neighbor must be set down before calling this function.
OK phessler

Revision 1.168 / (download) - annotate - [select for diffs], Tue Nov 27 05:38:08 2012 UTC (11 years, 6 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_5_3_BASE, OPENBSD_5_3
Changes since 1.167: +2 -2 lines
Diff to previous 1.167 (colored)

Fix type typo

ok henning@

Revision 1.167 / (download) - annotate - [select for diffs], Thu Nov 15 19:55:08 2012 UTC (11 years, 6 months ago) by sthen
Branch: MAIN
Changes since 1.166: +8 -1 lines
Diff to previous 1.166 (colored)

If max-prefix/restart are used, display the values in "bgpctl sh nei" output.
ok henning claudio benno

Revision 1.166 / (download) - annotate - [select for diffs], Tue Sep 18 10:11:23 2012 UTC (11 years, 8 months ago) by claudio
Branch: MAIN
Changes since 1.165: +4 -3 lines
Diff to previous 1.165 (colored)

Print the wieght in the show rib detail output. OK sthen@, henning@

Revision 1.165 / (download) - annotate - [select for diffs], Wed Sep 12 05:57:10 2012 UTC (11 years, 9 months ago) by claudio
Branch: MAIN
Changes since 1.164: +39 -7 lines
Diff to previous 1.164 (colored)

bgpctl bits for the GR support added to bgpd.
OK sthen

Revision 1.164 / (download) - annotate - [select for diffs], Sun May 27 18:53:50 2012 UTC (12 years ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_5_2_BASE, OPENBSD_5_2
Changes since 1.163: +106 -2 lines
Diff to previous 1.163 (colored)

Make it possible to load mrt table dumps into bgpd. This is a debug tool but
it  allows anyone to use MRT table dumps to load prefixes into a bgpd instance.
For example you can download the RIPE dumps and load full-feeds onto your
laptop until the poor thing dies.
OK henning@ sthen@

Revision 1.163 / (download) - annotate - [select for diffs], Wed Sep 21 10:37:51 2011 UTC (12 years, 8 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_5_1_BASE, OPENBSD_5_1
Changes since 1.162: +309 -161 lines
Diff to previous 1.162 (colored)

Make it possible to parse MRT table dumps (all 3 formats) and display
them like the show rib / show rib detail output. It is also possible
to filter the output. e.g.
   bgpctl show mrt file ./bview.20110914.1600 as 22512 204.209.0.0/16 all
OK sthen@, put it in henning@

Revision 1.162 / (download) - annotate - [select for diffs], Wed Sep 21 08:52:55 2011 UTC (12 years, 8 months ago) by claudio
Branch: MAIN
Changes since 1.161: +7 -1 lines
Diff to previous 1.161 (colored)

Unbreak the tree. I forgot to add a fatalx() stub to bgpctl.

Revision 1.161 / (download) - annotate - [select for diffs], Thu Sep 2 14:03:21 2010 UTC (13 years, 9 months ago) by sobrado
Branch: MAIN
CVS Tags: OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9
Changes since 1.160: +5 -5 lines
Diff to previous 1.160 (colored)

remove trailing spaces and tabs from source code; no binary changes
(verified by both sthen@ and me).

ok sthen@; "just commit it" claudio@

Revision 1.160 / (download) - annotate - [select for diffs], Wed May 26 13:56:07 2010 UTC (14 years ago) by nicm
Branch: MAIN
CVS Tags: OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.159: +2 -2 lines
Diff to previous 1.159 (colored)

Rename some imsg bits to make namespace collisions less likely buf to
ibuf, buf_read to ibuf_read, READ_BUF_SIZE to IBUF_READ_SIZE.

ok henning gilles claudio jacekm deraadt

Revision 1.159 / (download) - annotate - [select for diffs], Mon May 3 13:11:41 2010 UTC (14 years, 1 month ago) by claudio
Branch: MAIN
Changes since 1.158: +44 -19 lines
Diff to previous 1.158 (colored)

Adjustments for multiple kroute table support. This adds a few new command
arguments (show tables and show fib table 1, etc).
Tested by sthen@, OK to move on by henning@

Revision 1.158 / (download) - annotate - [select for diffs], Tue Apr 13 09:10:50 2010 UTC (14 years, 2 months ago) by claudio
Branch: MAIN
Changes since 1.157: +12 -35 lines
Diff to previous 1.157 (colored)

Sync with last bgpd commit, there are no AF_INET and AF_INET6 specific
kroute messages anymore.

Revision 1.157 / (download) - annotate - [select for diffs], Mon Mar 8 17:02:19 2010 UTC (14 years, 3 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.156: +5 -2 lines
Diff to previous 1.156 (colored)

res.flags is not only used by the irrfilter so initializing them with
irrfilter flags is causing strange behaviour on other commands (like show fib).
Set the IPV4 and IPV6 flags at the end unless one of them got already set.
OK henning, sthen, deraadt

Revision 1.156 / (download) - annotate - [select for diffs], Thu Feb 11 12:25:12 2010 UTC (14 years, 4 months ago) by claudio
Branch: MAIN
Changes since 1.155: +3 -3 lines
Diff to previous 1.155 (colored)

Force a space between address and nexthop. IPv6 is overflowing all size
restrictions and 2001:4bf8:bad:beef::/64fe80::20a:e4ff:fe39:5583 is not
acceptable.

Revision 1.155 / (download) - annotate - [select for diffs], Sun Jan 10 00:16:23 2010 UTC (14 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.154: +7 -5 lines
Diff to previous 1.154 (colored)

ribreq uses now a AID, use AID also on the parsing side and convert to
AF when necessary. OK henning@

Revision 1.154 / (download) - annotate - [select for diffs], Wed Dec 16 15:42:19 2009 UTC (14 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.153: +5 -30 lines
Diff to previous 1.153 (colored)

Use log_ext_subtype() instead of the homebrew version (which actually got
moved to bgpd but that does not matter).
OK henning and sthen

Revision 1.153 / (download) - annotate - [select for diffs], Tue Dec 8 17:36:12 2009 UTC (14 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.152: +6 -5 lines
Diff to previous 1.152 (colored)

Must byte-swap extended community data before printing since it is in
network byte order. Found and tested by Pete Vickers.

Revision 1.152 / (download) - annotate - [select for diffs], Tue Dec 8 15:10:29 2009 UTC (14 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.151: +19 -11 lines
Diff to previous 1.151 (colored)

Split out some code into own function to make the code a bit nicer.
OK henning@ upon his request

Revision 1.151 / (download) - annotate - [select for diffs], Tue Dec 8 14:04:54 2009 UTC (14 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.150: +18 -29 lines
Diff to previous 1.150 (colored)

Big AID change part 2 bgpctl part. Cope with the changes in bgpd, more to
follow.  OK henning

Revision 1.150 / (download) - annotate - [select for diffs], Tue Dec 1 14:29:40 2009 UTC (14 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.149: +25 -22 lines
Diff to previous 1.149 (colored)

Update code to use the new AID address ids so that this works again with
bgpd. Reads OK henning@

Revision 1.149 / (download) - annotate - [select for diffs], Mon Nov 2 20:38:45 2009 UTC (14 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.148: +13 -2 lines
Diff to previous 1.148 (colored)

Implement "log verbose" and "log brief" to enable or disable verbose debug
logging. henning, sthen, michele like the idea

Revision 1.148 / (download) - annotate - [select for diffs], Fri Oct 23 16:00:28 2009 UTC (14 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.147: +3 -3 lines
Diff to previous 1.147 (colored)

errx -> err since the errno is set.

Revision 1.147 / (download) - annotate - [select for diffs], Tue Sep 15 09:45:12 2009 UTC (14 years, 8 months ago) by sthen
Branch: MAIN
Changes since 1.146: +5 -1 lines
Diff to previous 1.146 (colored)

In bgpctl sh nei, display whether a neighbour is set to use passive
mode and/or E-BGP multihop. Ok and suggestions from claudio@

Revision 1.146 / (download) - annotate - [select for diffs], Mon Sep 14 11:49:25 2009 UTC (14 years, 8 months ago) by claudio
Branch: MAIN
Changes since 1.145: +22 -42 lines
Diff to previous 1.145 (colored)

Switch the various link state printing codes to use the new if_media
independent LINK_STATE_DESCRIPTIONS. Code is now more or less a one to
one copy of get_linkstate() in route/route.c.
OK henning, michele, sthen, deraadt

Revision 1.145 / (download) - annotate - [select for diffs], Thu Jul 23 14:55:25 2009 UTC (14 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.144: +75 -26 lines
Diff to previous 1.144 (colored)

Update bgpctl show next to show all necessary info. This time OK henning@

Revision 1.144 / (download) - annotate - [select for diffs], Tue Jul 21 11:49:36 2009 UTC (14 years, 10 months ago) by henning
Branch: MAIN
Changes since 1.143: +13 -12 lines
Diff to previous 1.143 (colored)

sorry, but showing a diff, getting an explicit "not ok" and then committing
anyway without oks is not our process

Revision 1.143 / (download) - annotate - [select for diffs], Mon Jul 20 15:04:50 2009 UTC (14 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.142: +13 -14 lines
Diff to previous 1.142 (colored)

Try to show a more usable nexthop output. It may still change but at least
it is better than what we had till now and syncs up with the last bgpd change.

Revision 1.142 / (download) - annotate - [select for diffs], Sat Jun 6 06:33:15 2009 UTC (15 years ago) by eric
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6
Changes since 1.141: +2 -3 lines
Diff to previous 1.141 (colored)

sync bgpd/bgpctl with the common imsg code, making it lib ready as well.

ok claudio@ pyr@

Revision 1.141 / (download) - annotate - [select for diffs], Sat Jun 6 06:05:41 2009 UTC (15 years ago) by claudio
Branch: MAIN
Changes since 1.140: +3 -1 lines
Diff to previous 1.140 (colored)

bgpctl part of allowing alternate RIBs to be shown. Had to use the
keyword table because show rib rib foo is strange.

Revision 1.140 / (download) - annotate - [select for diffs], Sun May 17 13:23:08 2009 UTC (15 years ago) by claudio
Branch: MAIN
Changes since 1.139: +4 -2 lines
Diff to previous 1.139 (colored)

Adjust for IMSG_CTL_SHOW_NETWORK change in the RDE. IMSG_CTL_SHOW_NETWORK is
now using the same payload as IMSG_CTL_SHOW_RIB.

Revision 1.139 / (download) - annotate - [select for diffs], Sun May 17 12:27:16 2009 UTC (15 years ago) by claudio
Branch: MAIN
Changes since 1.138: +5 -1 lines
Diff to previous 1.138 (colored)

Adjust show rib memory output after the monster commit to bgpd.

Revision 1.138 / (download) - annotate - [select for diffs], Sun Feb 1 17:21:21 2009 UTC (15 years, 4 months ago) by sobrado
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.137: +2 -2 lines
Diff to previous 1.137 (colored)

embellish the output of bgpctl(8).

ok claudio@

Revision 1.137 / (download) - annotate - [select for diffs], Fri Dec 12 23:15:39 2008 UTC (15 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.136: +4 -4 lines
Diff to previous 1.136 (colored)

Make bgpctl priority aware.

Revision 1.136 / (download) - annotate - [select for diffs], Wed Dec 10 23:57:10 2008 UTC (15 years, 6 months ago) by sthen
Branch: MAIN
Changes since 1.135: +3 -3 lines
Diff to previous 1.135 (colored)

convert the aggregator's AS number into host byte order when
displayed in "show rib detail".

ok claudio@

Revision 1.135 / (download) - annotate - [select for diffs], Sat Dec 6 13:18:12 2008 UTC (15 years, 6 months ago) by sobrado
Branch: MAIN
Changes since 1.134: +3 -3 lines
Diff to previous 1.134 (colored)

the ellipsis allows more than one argument being specified.

discussed with gilles@

ok jmc@

Revision 1.134 / (download) - annotate - [select for diffs], Sat Jun 7 20:23:15 2008 UTC (16 years ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.133: +3 -3 lines
Diff to previous 1.133 (colored)

repair usage, jmc

Revision 1.133 / (download) - annotate - [select for diffs], Sat Jun 7 18:14:41 2008 UTC (16 years ago) by henning
Branch: MAIN
Changes since 1.132: +6 -11 lines
Diff to previous 1.132 (colored)

teach the command lineparser about getopt style options after commands
use that for irrfilter mode.
hints from theo a year ago, code by me a year ago, ok claudio a year ago

Revision 1.132 / (download) - annotate - [select for diffs], Sun Feb 24 21:02:11 2008 UTC (16 years, 3 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.131: +2 -2 lines
Diff to previous 1.131 (colored)

Add missing space when printing ext. communities.

Revision 1.131 / (download) - annotate - [select for diffs], Wed Jan 23 08:18:11 2008 UTC (16 years, 4 months ago) by claudio
Branch: MAIN
Changes since 1.130: +127 -19 lines
Diff to previous 1.130 (colored)

extend bgpctl show rib detail output to include more attributes in the output.
In addition to communities bgpctl now prints the aggregator, originator id,
cluster list and extended communities if available.
OK henning@

Revision 1.130 / (download) - annotate - [select for diffs], Sun Dec 23 18:26:13 2007 UTC (16 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.129: +15 -31 lines
Diff to previous 1.129 (colored)

send timers for bgpctlshow neighbor foo timer in seperate messages after
the peer data. makes bgpctl display code independent from timer
implementation internals. only running timers are displayed now, stopped
ones are skipped.

Revision 1.129 / (download) - annotate - [select for diffs], Thu Dec 20 17:08:48 2007 UTC (16 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.128: +10 -10 lines
Diff to previous 1.128 (colored)

rework timers.
stop changing tienmr values directly, always use new
timer_(get/set/stop/running) functions. preparation for more to come :)
ok claudio

Revision 1.128 / (download) - annotate - [select for diffs], Mon Oct 15 02:16:35 2007 UTC (16 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.127: +2 -2 lines
Diff to previous 1.127 (colored)

specifying int instead of just unsigned is better style

Revision 1.127 / (download) - annotate - [select for diffs], Tue Sep 11 17:08:49 2007 UTC (16 years, 9 months ago) by henning
Branch: MAIN
Changes since 1.126: +7 -7 lines
Diff to previous 1.126 (colored)

baudrate is 64bit now, plus print w/ %llu

Revision 1.126 / (download) - annotate - [select for diffs], Mon Aug 6 19:16:06 2007 UTC (16 years, 10 months ago) by sobrado
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.125: +3 -3 lines
Diff to previous 1.125 (colored)

the ellipsis is not an optional argument; while here, sync the usage
and synopsis of commands

lots of good ideas by jmc@

ok jmc@

Revision 1.125 / (download) - annotate - [select for diffs], Thu May 31 04:21:43 2007 UTC (17 years ago) by claudio
Branch: MAIN
Changes since 1.124: +3 -2 lines
Diff to previous 1.124 (colored)

Use COMMUNITY_UNSET in bgpctl as well. This makes it possible to filter
on communities with 0 in them.

Revision 1.124 / (download) - annotate - [select for diffs], Wed May 30 01:13:19 2007 UTC (17 years ago) by otto
Branch: MAIN
Changes since 1.123: +1 -3 lines
Diff to previous 1.123 (colored)

bad henning

Revision 1.123 / (download) - annotate - [select for diffs], Mon Apr 23 13:05:35 2007 UTC (17 years, 1 month ago) by claudio
Branch: MAIN
Changes since 1.122: +11 -8 lines
Diff to previous 1.122 (colored)

bgpctl needs to know about 4-byte AS numbers as well.

Revision 1.122 / (download) - annotate - [select for diffs], Fri Apr 6 18:36:32 2007 UTC (17 years, 2 months ago) by claudio
Branch: MAIN
Changes since 1.121: +36 -1 lines
Diff to previous 1.121 (colored)

Implement "bgpctl show neighbor <peer> terse" this will print all statistics
in an easily parseable form. This output can be used to implement SNMP MIBs
or rrdtool/mrtg update scripts. OK henning@

Revision 1.121 / (download) - annotate - [select for diffs], Fri Apr 6 18:14:48 2007 UTC (17 years, 2 months ago) by claudio
Branch: MAIN
Changes since 1.120: +8 -2 lines
Diff to previous 1.120 (colored)

Include update statistics in the bgpctl show neighbor output.

Revision 1.120 / (download) - annotate - [select for diffs], Sat Mar 31 12:46:55 2007 UTC (17 years, 2 months ago) by henning
Branch: MAIN
Changes since 1.119: +3 -3 lines
Diff to previous 1.119 (colored)

some KNF, partially pt out by  rivo nurges <rix@estpak.ee>

Revision 1.119 / (download) - annotate - [select for diffs], Wed Mar 28 12:34:08 2007 UTC (17 years, 2 months ago) by henning
Branch: MAIN
Changes since 1.118: +6 -1 lines
Diff to previous 1.118 (colored)

add support for bgpctl show rib community <community>
mostly from rivo nurges <rix@estpak.ee>, ok claudio

Revision 1.118 / (download) - annotate - [select for diffs], Fri Mar 16 20:48:38 2007 UTC (17 years, 2 months ago) by claudio
Branch: MAIN
Changes since 1.117: +1 -4 lines
Diff to previous 1.117 (colored)

Missed to remove SAFI_BOTH here. Informed about it by Steven Mestdagh.

Revision 1.117 / (download) - annotate - [select for diffs], Sat Mar 3 12:43:08 2007 UTC (17 years, 3 months ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE, OPENBSD_4_1
Changes since 1.116: +6 -3 lines
Diff to previous 1.116 (colored)

allow the directory for generated filter files to be set. defaults to cwd

Revision 1.116 / (download) - annotate - [select for diffs], Sat Mar 3 11:45:30 2007 UTC (17 years, 3 months ago) by henning
Branch: MAIN
Changes since 1.115: +9 -2 lines
Diff to previous 1.115 (colored)

add irrfilter mode.
generates bgpd filter rules from the Internet Routing Registry aka IRR aka
the aut-num, as-set and route objects in the RIPE, ARIN, APNIC ... databases
accessed via whois, using the Routing Policy Specificaion Language RPSL.
implement the whois query interface, an RPSL parser (of course only the
parts we need), recursive as-set resolver, prefixes per AS lookup,
and an ouput module to make up the rules.
work in progress, not ready for general consumption yet.
import agreed by theo & claudio

Revision 1.115 / (download) - annotate - [select for diffs], Thu Feb 22 08:38:19 2007 UTC (17 years, 3 months ago) by henning
Branch: MAIN
Changes since 1.114: +3 -2 lines
Diff to previous 1.114 (colored)

minor KNF bits here too

Revision 1.114 / (download) - annotate - [select for diffs], Fri Feb 2 15:53:39 2007 UTC (17 years, 4 months ago) by claudio
Branch: MAIN
Changes since 1.113: +5 -3 lines
Diff to previous 1.113 (colored)

Print neighbor templates with a state of Template. Makes the difference
between templates and real sessions more obvious. OK henning@

Revision 1.113 / (download) - annotate - [select for diffs], Sat Jan 27 19:03:07 2007 UTC (17 years, 4 months ago) by claudio
Branch: MAIN
Changes since 1.112: +2 -2 lines
Diff to previous 1.112 (colored)

Make sure that the graceful restart capability is printed in any case.
The printf() was only reachable if one of the other capabilities were set.

Revision 1.112 / (download) - annotate - [select for diffs], Tue Nov 28 19:21:15 2006 UTC (17 years, 6 months ago) by reyk
Branch: MAIN
Changes since 1.111: +4 -2 lines
Diff to previous 1.111 (colored)

add additional link states to report the half duplex / full duplex
state, if known by the driver. this is required to check the full
duplex state without depending on the ifmedia ioctl which can't be
called in the kernel without process context.

ok henning@, brad@

Revision 1.111 / (download) - annotate - [select for diffs], Fri Nov 10 14:46:46 2006 UTC (17 years, 7 months ago) by henning
Branch: MAIN
Changes since 1.110: +12 -11 lines
Diff to previous 1.110 (colored)

cast to (long long) for %lld printfs
apparently from Jeff Rizzo <riz@NetBSD.org> via "Thomas E. Spanjaard"
<tgen@netphreax.net>, with changes from me (as far as I remember, this is
kinda old stuff). claudio ok

Revision 1.110 / (download) - annotate - [select for diffs], Mon Aug 28 05:28:49 2006 UTC (17 years, 9 months ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.109: +3 -1 lines
Diff to previous 1.109 (colored)

indicate when the peer announced the Graceful Restart capability, ok claudio

Revision 1.109 / (download) - annotate - [select for diffs], Wed Aug 23 08:21:11 2006 UTC (17 years, 9 months ago) by claudio
Branch: MAIN
Changes since 1.108: +5 -3 lines
Diff to previous 1.108 (colored)

Extend show rib command. Following new options are added:
 in: show the unfiltered input of a neighbor aka adj-rib-in
 out: show only the prefixes that are sent to a specified neighbor (adj-rib-out)
 neighbor <IP>: limit the output of the command to prefixes sent by the
                specified neighbor

OK henning@ manpage with help by jmc@ but the show rib section needs some
rework because it starts to be confusing. Actually the parser needs to get
smarter.

Revision 1.108 / (download) - annotate - [select for diffs], Tue Jul 25 09:38:05 2006 UTC (17 years, 10 months ago) by henning
Branch: MAIN
Changes since 1.107: +1 -4 lines
Diff to previous 1.107 (colored)

kill redundant prototypes

Revision 1.107 / (download) - annotate - [select for diffs], Thu Jun 15 10:05:18 2006 UTC (17 years, 11 months ago) by claudio
Branch: MAIN
Changes since 1.106: +17 -16 lines
Diff to previous 1.106 (colored)

Use new struct ctl_show_rib_request for show rib requests. OK henning@

Revision 1.106 / (download) - annotate - [select for diffs], Wed Jun 14 17:10:42 2006 UTC (18 years ago) by claudio
Branch: MAIN
Changes since 1.105: +4 -3 lines
Diff to previous 1.105 (colored)

bgpctl show rib shows now the exit nexthop per default and not the true
nexthop as before. The detailed output includes both nexthops. OK henning@

Revision 1.105 / (download) - annotate - [select for diffs], Sat May 27 21:25:06 2006 UTC (18 years ago) by claudio
Branch: MAIN
Changes since 1.104: +1 -2 lines
Diff to previous 1.104 (colored)

Wait for a response from bgpd on reloads.

Revision 1.104 / (download) - annotate - [select for diffs], Tue May 23 12:14:34 2006 UTC (18 years ago) by henning
Branch: MAIN
Changes since 1.103: +6 -1 lines
Diff to previous 1.103 (colored)

support requesting route refresh from a neighbor

Revision 1.103 / (download) - annotate - [select for diffs], Thu Apr 6 12:33:17 2006 UTC (18 years, 2 months ago) by claudio
Branch: MAIN
Changes since 1.102: +2 -1 lines
Diff to previous 1.102 (colored)

Add missing break. Now bgpctl show rib det source-as 8271 shows all announced
prefixes not only the first one.

Revision 1.102 / (download) - annotate - [select for diffs], Wed Mar 22 10:25:49 2006 UTC (18 years, 2 months ago) by claudio
Branch: MAIN
Changes since 1.101: +165 -16 lines
Diff to previous 1.101 (colored)

Detailed RIB output including communities. Detailed output is enabled via
the "detailed" keyword. Currently only works for IP or prefix lookups like
"bgpctl show rib detail 199.185.137.3". Requested by many, looks good henning@

Revision 1.101 / (download) - annotate - [select for diffs], Wed Mar 22 09:05:40 2006 UTC (18 years, 2 months ago) by claudio
Branch: MAIN
Changes since 1.100: +14 -11 lines
Diff to previous 1.100 (colored)

Change fmt_peer() so that it can be used by the upcomming detailed RIB output.
OK henning@

Revision 1.100 / (download) - annotate - [select for diffs], Tue Jan 24 15:28:03 2006 UTC (18 years, 4 months ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9
Changes since 1.99: +31 -1 lines
Diff to previous 1.99 (colored)

introduce "bgpctl show summary terse", shows summary in an easy to parse
format, intended for monitoring puposes. claudio ok

Revision 1.99 / (download) - annotate - [select for diffs], Tue Jan 24 10:01:14 2006 UTC (18 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.98: +8 -3 lines
Diff to previous 1.98 (colored)

make bgpctl deal with IMSG_CTL_RESULT no matter what request was sent
claudio ok

Revision 1.98 / (download) - annotate - [select for diffs], Thu Jan 5 16:01:09 2006 UTC (18 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.97: +2 -1 lines
Diff to previous 1.97 (colored)

Show attribute cache total reference count.

Revision 1.97 / (download) - annotate - [select for diffs], Wed Jan 4 12:46:52 2006 UTC (18 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.96: +2 -2 lines
Diff to previous 1.96 (colored)

Use new BGP attribute counter.

Revision 1.96 / (download) - annotate - [select for diffs], Tue Jan 3 22:51:14 2006 UTC (18 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.95: +67 -2 lines
Diff to previous 1.95 (colored)

Show RIB statistics via "bgpctl show rib mem".

Revision 1.95 / (download) - annotate - [select for diffs], Tue Jan 3 22:20:59 2006 UTC (18 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.94: +31 -1 lines
Diff to previous 1.94 (colored)

Cope with new util.c

Revision 1.94 / (download) - annotate - [select for diffs], Tue Jan 3 22:05:13 2006 UTC (18 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.93: +5 -5 lines
Diff to previous 1.93 (colored)

Don't use fatal() and friend in bgpctl. The log system does not work here.

Revision 1.93 / (download) - annotate - [select for diffs], Thu Nov 17 11:14:51 2005 UTC (18 years, 6 months ago) by henning
Branch: MAIN
Changes since 1.92: +3 -2 lines
Diff to previous 1.92 (colored)

missing strdup() check, From: David Hill <dhill@mindcry.org>

Revision 1.92 / (download) - annotate - [select for diffs], Wed Oct 19 12:32:17 2005 UTC (18 years, 7 months ago) by henning
Branch: MAIN
Changes since 1.91: +29 -11 lines
Diff to previous 1.91 (colored)

for "bgpctl neighbor foo up/down/clear", make bgpctl not exit after sending
the request, but wait for the new IMSG_CTL_RESULT message, which contains
a status code to indicate wether the request was processed successfully
or wether an error occured and if so what kind of error.
no more "IMSG_CTL_NEIGHBOR_ with unknown neighbor foobaz" in the log
when you mistyped foobar - no bgpctl itself complains
claudio ok

Revision 1.91 / (download) - annotate - [select for diffs], Tue Sep 20 14:40:32 2005 UTC (18 years, 8 months ago) by henning
Branch: MAIN
Changes since 1.90: +2 -2 lines
Diff to previous 1.90 (colored)

allow "show rib" to be limited to an address family too

Revision 1.90 / (download) - annotate - [select for diffs], Tue Sep 20 13:51:05 2005 UTC (18 years, 8 months ago) by henning
Branch: MAIN
Changes since 1.89: +2 -2 lines
Diff to previous 1.89 (colored)

don't try to print v6 nexthops as v4 address

Revision 1.89 / (download) - annotate - [select for diffs], Tue Sep 20 13:31:53 2005 UTC (18 years, 8 months ago) by henning
Branch: MAIN
Changes since 1.88: +4 -2 lines
Diff to previous 1.88 (colored)

let "bgpctl network show" print v6 addresses correctly

Revision 1.88 / (download) - annotate - [select for diffs], Fri Jul 1 18:59:14 2005 UTC (18 years, 11 months ago) by fgsch
Branch: MAIN
CVS Tags: OPENBSD_3_8_BASE, OPENBSD_3_8
Changes since 1.87: +3 -3 lines
Diff to previous 1.87 (colored)

fix breakage; if this proves to be wrong, will be fixed later. at least
make build will work now.

Revision 1.87 / (download) - annotate - [select for diffs], Mon Jun 13 08:16:30 2005 UTC (19 years ago) by claudio
Branch: MAIN
Changes since 1.86: +3 -3 lines
Diff to previous 1.86 (colored)

Properly align the show rib output. flags is 5 chars long not 4.

Revision 1.86 / (download) - annotate - [select for diffs], Fri Jun 10 08:30:38 2005 UTC (19 years ago) by claudio
Branch: MAIN
Changes since 1.85: +11 -56 lines
Diff to previous 1.85 (colored)

As we no longer send IMSG_CTL_SHOW_RIB_PREFIX from bgpd to bgpctl simplify
show_rib_summary_msg().

Revision 1.85 / (download) - annotate - [select for diffs], Tue Jun 7 17:45:28 2005 UTC (19 years ago) by claudio
Branch: MAIN
Changes since 1.84: +4 -4 lines
Diff to previous 1.84 (colored)

For show rib -- show_rib_summary_msg() and print_prefix() -- use log_addr()
to print prefixes and nexthops and suddenly we can print IPv6 addresses that
are stored in the RIB. Makes the code even simpler. OK henning@

Revision 1.84 / (download) - annotate - [select for diffs], Mon Jun 6 17:15:07 2005 UTC (19 years ago) by henning
Branch: MAIN
Changes since 1.83: +14 -5 lines
Diff to previous 1.83 (colored)

allow show fib to be limited to inet or inet6 families, claudio ok

Revision 1.83 / (download) - annotate - [select for diffs], Mon Jun 6 00:00:33 2005 UTC (19 years ago) by henning
Branch: MAIN
Changes since 1.82: +58 -29 lines
Diff to previous 1.82 (colored)

let "show fib" print out both the v4 and the v6 routes.

Revision 1.82 / (download) - annotate - [select for diffs], Sun Jun 5 00:24:18 2005 UTC (19 years ago) by henning
Branch: MAIN
Changes since 1.81: +44 -2 lines
Diff to previous 1.81 (colored)

print the error for the last notification sent when we're IDLE in the
neighbor detail display

Revision 1.81 / (download) - annotate - [select for diffs], Sat Jun 4 23:38:07 2005 UTC (19 years ago) by henning
Branch: MAIN
Changes since 1.80: +21 -17 lines
Diff to previous 1.80 (colored)

do not print the tcp connection details when the session is IDLE, we
have no connection in that case

Revision 1.80 / (download) - annotate - [select for diffs], Fri May 27 17:10:29 2005 UTC (19 years ago) by claudio
Branch: MAIN
Changes since 1.79: +13 -5 lines
Diff to previous 1.79 (colored)

Add a flag for specifying the socket to open to talk to bgpd.
Needed for upcomming spamd madness.  Requested and OK beck@

Revision 1.79 / (download) - annotate - [select for diffs], Mon May 23 20:08:59 2005 UTC (19 years ago) by claudio
Branch: MAIN
Changes since 1.78: +16 -1 lines
Diff to previous 1.78 (colored)

Make it possible to dynamicaly add networks with attributes like communities
or metrics. Requested by beck@ OK henning@

Revision 1.78 / (download) - annotate - [select for diffs], Mon Apr 18 11:09:51 2005 UTC (19 years, 1 month ago) by claudio
Branch: MAIN
Changes since 1.77: +2 -2 lines
Diff to previous 1.77 (colored)

Static routes are flagged with F_STATIC and not with F_KERNEL. OK henning@

Revision 1.77 / (download) - annotate - [select for diffs], Wed Apr 13 08:35:22 2005 UTC (19 years, 2 months ago) by claudio
Branch: MAIN
Changes since 1.76: +13 -3 lines
Diff to previous 1.76 (colored)

Show if a route is rejected or blackholed in show fib output. OK henning@

Revision 1.76 / (download) - annotate - [select for diffs], Mon Mar 14 12:36:27 2005 UTC (19 years, 3 months ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_3_7_BASE, OPENBSD_3_7
Changes since 1.75: +3 -1 lines
Diff to previous 1.75 (colored)

add IFT_/IFM_IEE80211 to ift2ifm so we can pretty-print link state and
such for those as well, pointed out by claudio

Revision 1.75 / (download) - annotate - [select for diffs], Mon Mar 14 12:26:37 2005 UTC (19 years, 3 months ago) by henning
Branch: MAIN
Changes since 1.74: +40 -22 lines
Diff to previous 1.74 (colored)

print interface and some stuff about it with the nexthops so it is easier
to see why a nexthop is treated invalid, claudio ok

Revision 1.74 / (download) - annotate - [select for diffs], Wed Feb 9 12:35:20 2005 UTC (19 years, 4 months ago) by claudio
Branch: MAIN
Changes since 1.73: +5 -3 lines
Diff to previous 1.73 (colored)

need to send IMSG_NETWORK_DONE after sending networks announcement.
Similar to the fix commited by henning@ a few hours ago. OK henning@

Revision 1.73 / (download) - annotate - [select for diffs], Wed Feb 2 18:52:32 2005 UTC (19 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.72: +3 -3 lines
Diff to previous 1.72 (colored)

usage() is __dead
pt out by Alexander v Gernler

Revision 1.72 / (download) - annotate - [select for diffs], Thu Dec 23 17:55:59 2004 UTC (19 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.71: +3 -3 lines
Diff to previous 1.71 (colored)

allo the "bgpctl show neighbor " commands to take the neighbor descr
too, claudio ok

Revision 1.71 / (download) - annotate - [select for diffs], Thu Dec 23 17:26:51 2004 UTC (19 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.70: +8 -4 lines
Diff to previous 1.70 (colored)

allow "bgpctl neighbor" to take the peer's descr as argument as well
as its address
so "bgpctl neighbor upstream1 clear" now works and you don't have to
remember IPs
claudio ok

Revision 1.70 / (download) - annotate - [select for diffs], Thu Nov 18 16:57:28 2004 UTC (19 years, 6 months ago) by henning
Branch: MAIN
Changes since 1.69: +8 -7 lines
Diff to previous 1.69 (colored)

cope with changes in capabilities announcement shitz

Revision 1.69 / (download) - annotate - [select for diffs], Tue Nov 2 11:46:17 2004 UTC (19 years, 7 months ago) by henning
Branch: MAIN
Changes since 1.68: +4 -1 lines
Diff to previous 1.68 (colored)

now that carp media descriptions are available through the ifmedia framework
print carp interface status correctly

Revision 1.68 / (download) - annotate - [select for diffs], Tue Oct 26 13:12:22 2004 UTC (19 years, 7 months ago) by henning
Branch: MAIN
Changes since 1.67: +3 -3 lines
Diff to previous 1.67 (colored)

ease the parser a bit.
parse() now wants the first argv member to be the first argument it parses,
i. e. it does not skip over argv[0] any more, caller has to account for that.
the caller does the usual getopt followed by argv += optind; argc -= optind;
dance so this is accounted for.
in parse() don't use a seperate curarg counter, just in/decrease argv/argc
claudio ok

Revision 1.67 / (download) - annotate - [select for diffs], Tue Oct 26 11:46:08 2004 UTC (19 years, 7 months ago) by henning
Branch: MAIN
Changes since 1.66: +48 -18 lines
Diff to previous 1.66 (colored)

in the "show summary" view print the peer descr instead of the IP (if a descr
is given in the config, fall back to IP otherwise)
new -n switch to force display of IPs
claudio ok

Revision 1.66 / (download) - annotate - [select for diffs], Tue Oct 26 11:44:06 2004 UTC (19 years, 7 months ago) by henning
Branch: MAIN
Changes since 1.65: +2 -2 lines
Diff to previous 1.65 (colored)

do /%u instead of /%6u for max_prefix, looks better, claudio ok

Revision 1.65 / (download) - annotate - [select for diffs], Thu Sep 23 02:05:29 2004 UTC (19 years, 8 months ago) by henning
Branch: MAIN
Changes since 1.64: +2 -2 lines
Diff to previous 1.64 (colored)

cosmetics

Revision 1.64 / (download) - annotate - [select for diffs], Tue Sep 21 18:29:47 2004 UTC (19 years, 8 months ago) by claudio
Branch: MAIN
Changes since 1.63: +2 -2 lines
Diff to previous 1.63 (colored)

Don't pad the prefix count with 0. OK henning@

Revision 1.63 / (download) - annotate - [select for diffs], Thu Sep 16 22:36:18 2004 UTC (19 years, 8 months ago) by henning
Branch: MAIN
Changes since 1.62: +30 -27 lines
Diff to previous 1.62 (colored)

malloc ibuf instead of having it statically

Revision 1.62 / (download) - annotate - [select for diffs], Thu Sep 16 17:40:10 2004 UTC (19 years, 8 months ago) by henning
Branch: MAIN
Changes since 1.61: +26 -24 lines
Diff to previous 1.61 (colored)

cope with imsg API change

Revision 1.61 / (download) - annotate - [select for diffs], Fri Aug 20 15:49:35 2004 UTC (19 years, 9 months ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_3_6_BASE, OPENBSD_3_6
Changes since 1.60: +8 -1 lines
Diff to previous 1.60 (colored)

add support for "bgpctl neighbor 1.2.3.4 clear", takes session down & up again
claudio ok

Revision 1.60 / (download) - annotate - [select for diffs], Fri Aug 6 11:53:12 2004 UTC (19 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.59: +11 -5 lines
Diff to previous 1.59 (colored)

In bgpctl show summary report the current and max prefix count if state is
established. OK henning@

Revision 1.59 / (download) - annotate - [select for diffs], Fri May 21 11:52:32 2004 UTC (20 years ago) by claudio
Branch: MAIN
Changes since 1.58: +41 -1 lines
Diff to previous 1.58 (colored)

Make it possible to add, delete, flush and show network announcements.
OK henning@

Revision 1.58 / (download) - annotate - [select for diffs], Thu May 20 12:17:04 2004 UTC (20 years ago) by henning
Branch: MAIN
Changes since 1.57: +4 -2 lines
Diff to previous 1.57 (colored)

check for strdup(3) failure was missing in one case, catched by
Andrey Matveev <andrushock@korovino.net>

Revision 1.57 / (download) - annotate - [select for diffs], Thu May 6 14:29:12 2004 UTC (20 years, 1 month ago) by henning
Branch: MAIN
Changes since 1.56: +4 -4 lines
Diff to previous 1.56 (colored)

print Multiprotocol capabilities slightly nicer

Revision 1.56 / (download) - annotate - [select for diffs], Sat May 1 17:08:04 2004 UTC (20 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.55: +5 -6 lines
Diff to previous 1.55 (colored)

becuase lint says so; henning ok

Revision 1.55 / (download) - annotate - [select for diffs], Wed Apr 28 00:56:49 2004 UTC (20 years, 1 month ago) by henning
Branch: MAIN
Changes since 1.54: +11 -5 lines
Diff to previous 1.54 (colored)

keep route refresh counters into account when building sums, and
print route refresh counters in the neighbor view

Revision 1.54 / (download) - annotate - [select for diffs], Tue Apr 27 04:06:10 2004 UTC (20 years, 1 month ago) by henning
Branch: MAIN
Changes since 1.53: +4 -2 lines
Diff to previous 1.53 (colored)

print route refresh capability if present

Revision 1.53 / (download) - annotate - [select for diffs], Sun Apr 25 23:31:16 2004 UTC (20 years, 1 month ago) by henning
Branch: MAIN
Changes since 1.52: +3 -3 lines
Diff to previous 1.52 (colored)

there's a slight difference between teh local and the remote sockaddr...

Revision 1.52 / (download) - annotate - [select for diffs], Sun Apr 25 20:04:37 2004 UTC (20 years, 1 month ago) by henning
Branch: MAIN
Changes since 1.51: +40 -10 lines
Diff to previous 1.51 (colored)

correctly pritn netmask with template neighbors, prettify output overall,
and print Template / Cloned flags in the neigbor view, claudio ok

Revision 1.51 / (download) - annotate - [select for diffs], Sun Apr 25 18:53:09 2004 UTC (20 years, 1 month ago) by henning
Branch: MAIN
Changes since 1.50: +20 -25 lines
Diff to previous 1.50 (colored)

use getnameinfo here too, itojun & markus ok

Revision 1.50 / (download) - annotate - [select for diffs], Fri Apr 16 04:41:49 2004 UTC (20 years, 1 month ago) by henning
Branch: MAIN
Changes since 1.49: +25 -13 lines
Diff to previous 1.49 (colored)

in the neighbor view, add support for local/remote addr beeing v6 ones

Revision 1.49 / (download) - annotate - [select for diffs], Tue Apr 13 22:55:01 2004 UTC (20 years, 2 months ago) by henning
Branch: MAIN
Changes since 1.48: +33 -1 lines
Diff to previous 1.48 (colored)

print the MP capabilities as the neighbor announced in the show neighbor
display, claudio ok

Revision 1.48 / (download) - annotate - [select for diffs], Thu Mar 11 18:56:34 2004 UTC (20 years, 3 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_3_5_BASE, OPENBSD_3_5
Changes since 1.47: +28 -11 lines
Diff to previous 1.47 (colored)

Plugging memory leaks is OK but don't break intended behaviour. So this time
do it correctly.

Revision 1.47 / (download) - annotate - [select for diffs], Thu Mar 11 16:39:34 2004 UTC (20 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.46: +2 -5 lines
Diff to previous 1.46 (colored)

Use aspath_asprint() instead of this malloc, aspath_snprint() mess. OK henning@

Revision 1.46 / (download) - annotate - [select for diffs], Thu Mar 11 15:08:46 2004 UTC (20 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.45: +10 -10 lines
Diff to previous 1.45 (colored)

Plug another memory leak. OK henning@

Revision 1.45 / (download) - annotate - [select for diffs], Thu Mar 11 14:49:08 2004 UTC (20 years, 3 months ago) by henning
Branch: MAIN
Changes since 1.44: +3 -2 lines
Diff to previous 1.44 (colored)

check for malloc failure...

Revision 1.44 / (download) - annotate - [select for diffs], Tue Mar 2 20:00:14 2004 UTC (20 years, 3 months ago) by henning
Branch: MAIN
Changes since 1.43: +3 -3 lines
Diff to previous 1.43 (colored)

KNF

Revision 1.43 / (download) - annotate - [select for diffs], Tue Mar 2 19:32:43 2004 UTC (20 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.42: +13 -4 lines
Diff to previous 1.42 (colored)

show rib A.B.C.D and show rib A.B.C.D/N [all] support. Now the most important
show commands are available. OK henning@

Revision 1.42 / (download) - annotate - [select for diffs], Thu Feb 26 16:19:58 2004 UTC (20 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.41: +132 -1 lines
Diff to previous 1.41 (colored)

Implement "show rib" and "show rib <astype> <AS>" commands to dump the
RIB. OK henning@

Revision 1.41 / (download) - annotate - [select for diffs], Tue Feb 24 13:12:24 2004 UTC (20 years, 3 months ago) by henning
Branch: MAIN
Changes since 1.40: +5 -4 lines
Diff to previous 1.40 (colored)

print # of queued outgoing messages in show summary view, claudio ok

Revision 1.40 / (download) - annotate - [select for diffs], Thu Jan 29 12:02:13 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.39: +2 -2 lines
Diff to previous 1.39 (colored)

KNF

Revision 1.39 / (download) - annotate - [select for diffs], Tue Jan 27 22:11:23 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.38: +4 -2 lines
Diff to previous 1.38 (colored)

don't use log_ntoa, claudio ok

Revision 1.38 / (download) - annotate - [select for diffs], Tue Jan 27 21:56:47 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.37: +4 -4 lines
Diff to previous 1.37 (colored)

struct kroute changed, cope
ok claudio

Revision 1.37 / (download) - annotate - [select for diffs], Tue Jan 27 21:26:52 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.36: +3 -1 lines
Diff to previous 1.36 (colored)

missing exit() at end of main

Revision 1.36 / (download) - annotate - [select for diffs], Tue Jan 27 16:50:20 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.35: +5 -5 lines
Diff to previous 1.35 (colored)

catch up with changes in struct peer_config, ok claudio

Revision 1.35 / (download) - annotate - [select for diffs], Thu Jan 22 03:09:29 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.34: +6 -4 lines
Diff to previous 1.34 (colored)

print the interface state wrt the nexthop verification in the show interface
output.
makes quite some sense so that not every reader has to know the algorithm
for deciding on the interface state...

Revision 1.34 / (download) - annotate - [select for diffs], Wed Jan 21 23:47:35 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.33: +3 -7 lines
Diff to previous 1.33 (colored)

there's a "slight" difference between our log_err() and the system's err()...
the latter does not return, so we don't need to exit() afterwards.
one of the two spotted by jared

Revision 1.33 / (download) - annotate - [select for diffs], Wed Jan 21 23:45:18 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.32: +21 -165 lines
Diff to previous 1.32 (colored)

new parser.
completely table driven and not wired into the action code like the
previous parser...
i wanted to do this for some time, and now it was just due.

ok claudio@

Revision 1.32 / (download) - annotate - [select for diffs], Tue Jan 20 13:11:39 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.31: +7 -2 lines
Diff to previous 1.31 (colored)

show usage if called without command

Revision 1.31 / (download) - annotate - [select for diffs], Tue Jan 20 13:03:39 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.30: +1 -13 lines
Diff to previous 1.30 (colored)

args, unbreak

Revision 1.30 / (download) - annotate - [select for diffs], Tue Jan 20 12:50:52 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.29: +23 -1 lines
Diff to previous 1.29 (colored)

getopt & usage, prodded by theo

Revision 1.29 / (download) - annotate - [select for diffs], Mon Jan 19 10:41:34 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.28: +89 -6 lines
Diff to previous 1.28 (colored)

for show interface, print the link status and speed as well. we need
to do this depending on the media type, so print that as well if known.
design following a discussion with theo
claudio ok

Revision 1.28 / (download) - annotate - [select for diffs], Sat Jan 17 18:27:37 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.27: +2 -2 lines
Diff to previous 1.27 (colored)

print interface name instead of index

Revision 1.27 / (download) - annotate - [select for diffs], Sat Jan 17 18:06:04 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.26: +44 -2 lines
Diff to previous 1.26 (colored)

implement "show interfaces"

Revision 1.26 / (download) - annotate - [select for diffs], Sun Jan 11 02:36:48 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.25: +41 -2 lines
Diff to previous 1.25 (colored)

+ show nexthop

Revision 1.25 / (download) - annotate - [select for diffs], Sun Jan 11 01:05:16 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.24: +15 -1 lines
Diff to previous 1.24 (colored)

print local/remote IP/port with the detailed neighbor view

ok claudio@

Revision 1.24 / (download) - annotate - [select for diffs], Sat Jan 10 21:04:37 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.23: +5 -1 lines
Diff to previous 1.23 (colored)

as buf_close does not implictely writes any more, imsg_compose doesn't
either, so we need to call msgbuf_write explictely now.

ok claudio@

Revision 1.23 / (download) - annotate - [select for diffs], Fri Jan 9 19:09:45 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.22: +22 -4 lines
Diff to previous 1.22 (colored)

show fib connected|static|bgp|nexthop|[address]

ok claudio@

Revision 1.22 / (download) - annotate - [select for diffs], Fri Jan 9 13:48:10 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.21: +79 -2 lines
Diff to previous 1.21 (colored)

a sample "show fib" implementation

ok claudio@

Revision 1.21 / (download) - annotate - [select for diffs], Wed Jan 7 02:00:05 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.20: +2 -2 lines
Diff to previous 1.20 (colored)

KNF

Revision 1.20 / (download) - annotate - [select for diffs], Tue Jan 6 23:23:49 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.19: +41 -7 lines
Diff to previous 1.19 (colored)

neighbor 1.2.3.4 up/down

ok claudio@

Revision 1.19 / (download) - annotate - [select for diffs], Tue Jan 6 19:24:37 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.18: +13 -10 lines
Diff to previous 1.18 (colored)

print intervals with the timers

Revision 1.18 / (download) - annotate - [select for diffs], Tue Jan 6 18:01:48 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.17: +2 -2 lines
Diff to previous 1.17 (colored)

StartTimer -> IdleHoldTimer

Revision 1.17 / (download) - annotate - [select for diffs], Mon Jan 5 16:29:20 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.16: +38 -3 lines
Diff to previous 1.16 (colored)

add support for couple/decouple

Revision 1.16 / (download) - annotate - [select for diffs], Sun Jan 4 23:44:17 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.15: +3 -5 lines
Diff to previous 1.15 (colored)

when imsg_get has no imsg any more for us, do not set the done flag,
instead, break out of the inner loop so the outer loop gets us a new fix
via imsg_read

Revision 1.15 / (download) - annotate - [select for diffs], Sun Jan 4 21:45:05 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.14: +92 -26 lines
Diff to previous 1.14 (colored)

show da timers

Revision 1.14 / (download) - annotate - [select for diffs], Sun Jan 4 20:21:56 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.13: +18 -2 lines
Diff to previous 1.13 (colored)

show message statistics in the "show neighbor" view

Revision 1.13 / (download) - annotate - [select for diffs], Sun Jan 4 20:07:30 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.12: +8 -4 lines
Diff to previous 1.12 (colored)

keep seperate message counters for open/update/keepalive/notification

Revision 1.12 / (download) - annotate - [select for diffs], Sun Jan 4 19:44:27 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.11: +12 -2 lines
Diff to previous 1.11 (colored)

new command "reload"

Revision 1.11 / (download) - annotate - [select for diffs], Sun Jan 4 18:51:23 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.10: +28 -3 lines
Diff to previous 1.10 (colored)

allow "show neighbor" to be limited to one specific neighbor

Revision 1.10 / (download) - annotate - [select for diffs], Sun Jan 4 17:55:19 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.9: +117 -17 lines
Diff to previous 1.9 (colored)

add infrastructure for command line parsing
to test that i had to add a "show neighbor" view...

Revision 1.9 / (download) - annotate - [select for diffs], Sun Jan 4 02:51:24 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.8: +51 -8 lines
Diff to previous 1.8 (colored)

print time since last up/down ninely

Revision 1.8 / (download) - annotate - [select for diffs], Sun Jan 4 02:13:52 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.7: +2 -11 lines
Diff to previous 1.7 (colored)

share statenames

Revision 1.7 / (download) - annotate - [select for diffs], Sat Jan 3 22:27:06 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.6: +6 -4 lines
Diff to previous 1.6 (colored)

print message counters

Revision 1.6 / (download) - annotate - [select for diffs], Sat Jan 3 20:39:51 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.5: +2 -1 lines
Diff to previous 1.5 (colored)

#include session.h

Revision 1.5 / (download) - annotate - [select for diffs], Sat Jan 3 16:46:08 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.4: +41 -27 lines
Diff to previous 1.4 (colored)

we'll have more than one view one day, strutural prepare for that

Revision 1.4 / (download) - annotate - [select for diffs], Sat Jan 3 16:13:49 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.3: +18 -4 lines
Diff to previous 1.3 (colored)

factor out the printing stuff and format nicer as well

Revision 1.3 / (download) - annotate - [select for diffs], Sat Jan 3 14:06:42 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.2: +5 -2 lines
Diff to previous 1.2 (colored)

cope with changed imsg_read semantics

Revision 1.2 / (download) - annotate - [select for diffs], Sat Jan 3 13:55:18 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.1: +27 -18 lines
Diff to previous 1.1 (colored)

there is no guarantee we get all we wan with a single read(), so we
have to do the imsg_read in a loop as well.

Revision 1.1 / (download) - annotate - [select for diffs], Fri Jan 2 02:22:52 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN

bring back bgpctl
ok and help theo

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.