OpenBSD CVS

CVS log for src/usr.sbin/bgpd/control.c


[BACK] Up to [local] / src / usr.sbin / bgpd

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.117 / (download) - annotate - [select for diffs], Mon Apr 22 09:36:04 2024 UTC (6 weeks, 5 days ago) by claudio
Branch: MAIN
CVS Tags: HEAD
Changes since 1.116: +7 -10 lines
Diff to previous 1.116 (colored)

Move setting of the shutdown reason to session_stop()

Also make sure that something is logged when a session is stopped.
Part of a bigger diff which was OK tb@

Revision 1.116 / (download) - annotate - [select for diffs], Thu Jan 11 15:46:25 2024 UTC (4 months, 3 weeks ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5
Changes since 1.115: +30 -27 lines
Diff to previous 1.115 (colored)

rename field ibuf to imsgbuf in struct ctl_conn
OK tb@

Revision 1.115 / (download) - annotate - [select for diffs], Wed Jan 10 11:08:04 2024 UTC (4 months, 4 weeks ago) by claudio
Branch: MAIN
Changes since 1.114: +69 -85 lines
Diff to previous 1.114 (colored)

Update the control.c code to use the new imsg API.

OK tb@

Revision 1.114 / (download) - annotate - [select for diffs], Tue Nov 7 11:18:35 2023 UTC (7 months ago) by claudio
Branch: MAIN
Changes since 1.113: +6 -6 lines
Diff to previous 1.113 (colored)

Rename struct imsgbuf *ibuf to *imsgbuf in all places.
ibuf should be reserved for struct ibuf * values.
OK tb@

Revision 1.113 / (download) - annotate - [select for diffs], Thu Sep 28 07:01:26 2023 UTC (8 months, 1 week ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_4_BASE, OPENBSD_7_4
Changes since 1.112: +8 -2 lines
Diff to previous 1.112 (colored)

Enforce NUL termination of the neighbor shutdown reason sent from
bgpctl before calling strlcpy() with that string.
OK tb@ some long time ago

Revision 1.112 / (download) - annotate - [select for diffs], Fri Aug 4 09:20:12 2023 UTC (10 months ago) by claudio
Branch: MAIN
Changes since 1.111: +1 -4 lines
Diff to previous 1.111 (colored)

Instead of forcing a NUL into struct ctl_neighbor descr adjust the
peer matching code to only match at maximum sizeof(n->descr) bytes
using strncmp().
OK tb@

Revision 1.111 / (download) - annotate - [select for diffs], Thu Jul 20 11:10:03 2023 UTC (10 months, 2 weeks ago) by claudio
Branch: MAIN
Changes since 1.110: +3 -3 lines
Diff to previous 1.110 (colored)

Use sizeof(destination) not sizeof(source) in strlcpy() calls.
OK tb@

Revision 1.110 / (download) - annotate - [select for diffs], Thu Apr 20 12:53:27 2023 UTC (13 months, 2 weeks ago) by claudio
Branch: MAIN
Changes since 1.109: +7 -1 lines
Diff to previous 1.109 (colored)

Implement IMSG_CTL_SHOW_FLOWSPEC and IMSG_FLOWSPEC_FLUSH and add bits for
IMSG_FLOWSPEC_ADD and IMSG_FLOWSPEC_REMOVE received from bgpctl via SE.
OK tb@

Revision 1.109 / (download) - annotate - [select for diffs], Thu Feb 9 13:43:23 2023 UTC (15 months, 4 weeks ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_3_BASE, OPENBSD_7_3
Changes since 1.108: +41 -13 lines
Diff to previous 1.108 (colored)

Instead of relaying struct peer from the SE to the RDE to fill out 10
stat numbers, just send the peerid and have the RDE response with the
stats. The control code will then merge these counters into the real
peer struct and send that to bgpctl. This reduces the number of bytes
sent around a fair bit.
OK tb@

Revision 1.108 / (download) - annotate - [select for diffs], Wed Aug 17 15:15:26 2022 UTC (21 months, 3 weeks ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2
Changes since 1.107: +3 -3 lines
Diff to previous 1.107 (colored)

Convert bzero() to memset(), bcmp() to memcmp() and bcopy() to memcpy().

The memory regions passed to memcpy() can not overlap so no need for memmove().
OK tb@ deraadt@

Revision 1.107 / (download) - annotate - [select for diffs], Thu Jul 28 13:11:48 2022 UTC (22 months, 1 week ago) by deraadt
Branch: MAIN
Changes since 1.106: +2 -2 lines
Diff to previous 1.106 (colored)

whitespace found during a read-thru; ok claudio

Revision 1.106 / (download) - annotate - [select for diffs], Fri Feb 4 12:01:12 2022 UTC (2 years, 4 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.105: +15 -15 lines
Diff to previous 1.105 (colored)

Rename sockaddr_un sun to sa_un since sun is defined on illumos systems.
OK dlg@

Revision 1.105 / (download) - annotate - [select for diffs], Tue Apr 27 15:34:18 2021 UTC (3 years, 1 month ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0
Changes since 1.104: +2 -1 lines
Diff to previous 1.104 (colored)

Add IMSG_CTL_SHOW_RTR to the list of restriced control messages.

Revision 1.104 / (download) - annotate - [select for diffs], Tue Feb 16 08:29:16 2021 UTC (3 years, 3 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_6_9_BASE, OPENBSD_6_9
Changes since 1.103: +2 -1 lines
Diff to previous 1.103 (colored)

Add RTR support to OpenBGPD. Add basic support for the protocol.
The RTR client runs in a new process where the protocol handling is done
and when new data is available all sources are merged into one ROA set
which is then loaded into the RDE. The roa-set from the config is also
handled by the new RTR engine.
Tested by and ok job@

Revision 1.103 / (download) - annotate - [select for diffs], Wed Dec 30 07:29:56 2020 UTC (3 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.102: +3 -1 lines
Diff to previous 1.102 (colored)

Implement IMSG_CTL_SHOW_SET to get information about roa-set, as-sets and
prefix-sets loaded into the RDE. For now only the number of prefixes or
asnumbers are shown plus the time since the last change was done to the table.
OK benno@

Revision 1.102 / (download) - annotate - [select for diffs], Fri Dec 11 12:00:01 2020 UTC (3 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.101: +5 -3 lines
Diff to previous 1.101 (colored)

Make the timer code independent of struct peer this way it can be used
in other places as well.
ok procter@

Revision 1.101 / (download) - annotate - [select for diffs], Thu Nov 5 11:28:11 2020 UTC (3 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.100: +28 -24 lines
Diff to previous 1.100 (colored)

Refactor the control code to be more like a module.
Change control_dispatch_msg() to return the change of control connection
count since the return value was not used before.
Add control_fill_pfds() to replace the TAILQ_FOREACH loop in session.c.
This allows to move the ctl_conns symbol to control.c (from session.h
where it caused issues when compiled with -fno-common).
OK benno@

Revision 1.100 / (download) - annotate - [select for diffs], Sun May 10 13:38:46 2020 UTC (4 years ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8
Changes since 1.99: +8 -8 lines
Diff to previous 1.99 (colored)

In bgpctl argument parser, re-arrange 'reason' parsing ('nei action [reason]')
to be more generic,  then change 'reload' to take take a '[reason]' also,
which will be logged by bgpd.
ok kn claudio

Revision 1.99 / (download) - annotate - [select for diffs], Mon Aug 12 15:02:05 2019 UTC (4 years, 9 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.98: +7 -1 lines
Diff to previous 1.98 (colored)

Reset the IdleHoldTime and the session error count when doing a admin
command that clears or starts a neighbor. This way an admin reset does
what people expect since it makes the session behave like a brand new one.
OK job@ deraadt@ sthen@

Revision 1.98 / (download) - annotate - [select for diffs], Thu Aug 8 20:06:29 2019 UTC (4 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.97: +2 -2 lines
Diff to previous 1.97 (colored)

Use O_CLOEXEC or SOCK_CLOEXEC on every open or socket call. Even though
some sockets are open for a short time it does not hurt and it ensures
that there is no file descriptor leak.
OK deraadt@ bluhm@

Revision 1.97 / (download) - annotate - [select for diffs], Mon May 27 09:14:32 2019 UTC (5 years ago) by claudio
Branch: MAIN
Changes since 1.96: +7 -7 lines
Diff to previous 1.96 (colored)

Switch the peer TAILQ to a RB tree indexed by the peer id. This way
getpeerbyid() gets a lot quicker at finding the peer when many peers
are configured. In my test case the difference is around 20% runtime.
OK denis@

Revision 1.96 / (download) - annotate - [select for diffs], Sun Mar 31 16:57:38 2019 UTC (5 years, 2 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.95: +12 -9 lines
Diff to previous 1.95 (colored)

Move the struct peer into bgpd_config and switch it to a TAILQ instead of
the hand-rolled list. This changes the way peers are reloaded since now
both parent and session engine are now merging the lists.
OK denis@

Revision 1.95 / (download) - annotate - [select for diffs], Tue Feb 12 13:30:39 2019 UTC (5 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.94: +3 -3 lines
Diff to previous 1.94 (colored)

Handle the abnormal case of not having any neighbors defined a bit better
when it comes to handling bgpctl show requests.
OK phessler@

Revision 1.94 / (download) - annotate - [select for diffs], Sun Jan 20 23:27:48 2019 UTC (5 years, 4 months ago) by claudio
Branch: MAIN
Changes since 1.93: +79 -88 lines
Diff to previous 1.93 (colored)

Support group descriptions in control messages that accept a neighbor
description. With this it is possible to show rib a group of peers, to show
or signal a group of peers all at once.
OK sthen@ benno@

Revision 1.93 / (download) - annotate - [select for diffs], Thu Dec 27 20:23:24 2018 UTC (5 years, 5 months ago) by remi
Branch: MAIN
Changes since 1.92: +27 -8 lines
Diff to previous 1.92 (colored)

Check if a control socket or address is already in use befor using it.
If it is used abort startup or let a reload fail.
Sockets are now not unlinked anymore on regular shutdown.

This helps a lot when one tries to do a config check without -n.

Inputs and OK claudio@

Revision 1.92 / (download) - annotate - [select for diffs], Sat Dec 22 16:12:40 2018 UTC (5 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.91: +15 -5 lines
Diff to previous 1.91 (colored)

bgpctl can cause bgpd to do a lot of work (e.g. dumping all of the RIB)
but then bgpctl can quickly exit and bgpd still has to do all the work.
Instead introduce a terminate imsg to stop such long running commands if
bgpctl closes the connection before the run is over.
OK benno@, sthen@, deraadt@

Revision 1.91 / (download) - annotate - [select for diffs], Wed Nov 28 08:32:27 2018 UTC (5 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.90: +1 -9 lines
Diff to previous 1.90 (colored)

Start reworking community handling. Merge standard communities and large
communities into one filter_community struct and allow it that more then
one community can be used in filter rules (currently up to 3).
Also rework the code handling bgpctl show rib commands. The special IMSG
types for the various filters are gone and the code is in general simpler.
OK job@, phessler@

Revision 1.90 / (download) - annotate - [select for diffs], Fri Aug 11 16:02:53 2017 UTC (6 years, 9 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.89: +1 -10 lines
Diff to previous 1.89 (colored)

softreconfig in and out are on by default for ever and machines now have
enough memory that it does not make sense to provide these knobs anymore.
They just make the code more complex for no much gain.
OK phessler@, benno@

Revision 1.89 / (download) - annotate - [select for diffs], Thu Aug 10 14:12:34 2017 UTC (6 years, 9 months ago) by benno
Branch: MAIN
Changes since 1.88: +3 -1 lines
Diff to previous 1.88 (colored)

handle extended communities in bgpctl.
From Dennis Fondras, thanks!
ok phessler@

Revision 1.88 / (download) - annotate - [select for diffs], Sun May 28 12:21:36 2017 UTC (7 years ago) by claudio
Branch: MAIN
Changes since 1.87: +12 -2 lines
Diff to previous 1.87 (colored)

Implement an XON/XOFF protocol between the RDE and the SE to throttle
per control session and peer the generation of imsg in the RDE. This
reduces the memory pressure in the SE substantially and also a bit in
the RDE. Makes the RDE more responsive for bgpctl commands.
Tested by me with 100 peers * 2000 prefixes and by phessler@ on an AMS-IX
border router with 200+ session. Convergance time got quite a bit better.
OK phessler@

Revision 1.87 / (download) - annotate - [select for diffs], Mon Feb 13 14:48:44 2017 UTC (7 years, 3 months ago) by phessler
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.86: +4 -1 lines
Diff to previous 1.86 (colored)

draft-ietf-idr-shutdown extends to support a message on either of
"Administrative Shutdown" or "Administrative Reset"

patch submitted by Job Snijders, thanks!

Revision 1.86 / (download) - annotate - [select for diffs], Tue Jan 24 04:22:42 2017 UTC (7 years, 4 months ago) by benno
Branch: MAIN
Changes since 1.85: +3 -2 lines
Diff to previous 1.85 (colored)

sync log.c from relayd et al to bgpd.

there is still a little difference regarding handling of the verbosity
value that will be handled later.

ok claudio@ florian@

Revision 1.85 / (download) - annotate - [select for diffs], Fri Jan 13 18:59:12 2017 UTC (7 years, 4 months ago) by phessler
Branch: MAIN
Changes since 1.84: +7 -1 lines
Diff to previous 1.84 (colored)

Add support for draft-ietf-idr-shutdown

    BGP state = Idle, marked down with shutdown reason "goodbye, we are
    upgrading to openbsd 6.1", down for 00:00:17

developed by Peter van Dijk <peter.van.dijk@powerdns.com> and Job
Snijders <job@ntt.net>, thank you!

OK benno@

Revision 1.84 / (download) - annotate - [select for diffs], Sun Jan 8 23:04:42 2017 UTC (7 years, 5 months ago) by krw
Branch: MAIN
Changes since 1.83: +9 -7 lines
Diff to previous 1.83 (colored)

Replace hand-rolled for(;;) traversal of ctl_conns TAILQ with
TAILQ_FOREACH().

No intentional functional change.

ok reyk@

Revision 1.83 / (download) - annotate - [select for diffs], Fri Oct 14 16:05:35 2016 UTC (7 years, 7 months ago) by phessler
Branch: MAIN
Changes since 1.82: +3 -1 lines
Diff to previous 1.82 (colored)

Add support for draft-ietf-idr-large-community

Joint work with Job Snijders, many thanks!
OK benno@ deraadt@

Revision 1.82 / (download) - annotate - [select for diffs], Sat Dec 5 18:28:04 2015 UTC (8 years, 6 months ago) by benno
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.81: +6 -6 lines
Diff to previous 1.81 (colored)

cleanup some log messages with wrong function names etc.
ok henning,claudio

Revision 1.81 / (download) - annotate - [select for diffs], Sat Dec 5 13:10:32 2015 UTC (8 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.80: +6 -8 lines
Diff to previous 1.80 (colored)

EAGAIN handling for imsg_read. OK henning@ benno@

Revision 1.80 / (download) - annotate - [select for diffs], Sun Oct 25 18:49:01 2015 UTC (8 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.79: +13 -13 lines
Diff to previous 1.79 (colored)

Rename imsg_compose_parent and imsg_compose_rde to imsg_ctl_parent and
imsg_ctl_rde since these function should only be used by the control
code. Also switch ibuf_rde to ibuf_rde_ctl so that the control imsgs
don't need to queue behind all the incoming bgp UPDATES. This speeds
up 'bgpctl show' from taking minutes to a few seconds. The RDE was doing
this since a very long time but it seems the SE was not adjusted. Yikes

Revision 1.79 / (download) - annotate - [select for diffs], Sat Oct 24 15:15:55 2015 UTC (8 years, 7 months ago) by benno
Branch: MAIN
Changes since 1.78: +13 -3 lines
Diff to previous 1.78 (colored)

"bgpctl sh rib in" and "bgpctl sh rib out" require a neighbor argument
to work. send an error if none is given.
ok claudio@

Revision 1.78 / (download) - annotate - [select for diffs], Sat Oct 17 13:07:07 2015 UTC (8 years, 7 months ago) by reyk
Branch: MAIN
Changes since 1.77: +26 -2 lines
Diff to previous 1.77 (colored)

Do no accept fds on the control socket; including the restricted socket.

OK gilles@ eric@

Revision 1.77 / (download) - annotate - [select for diffs], Sun Apr 26 20:12:03 2015 UTC (9 years, 1 month ago) by benno
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8
Changes since 1.76: +7 -2 lines
Diff to previous 1.76 (colored)

mlarkin asks "bgpctl checks the length of the control socket path to
make sure it fits. When browsing around last night I saw that bgpd
does not. Any reason it shouldn't? Please commit"

Add a check in parse.y to check this when reading the configuration.
ok phessler@ henning@

Revision 1.76 / (download) - annotate - [select for diffs], Mon Feb 9 11:37:31 2015 UTC (9 years, 4 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.75: +6 -8 lines
Diff to previous 1.75 (colored)

Kill session_socket_blockmode() and replace it with SOCK_CLOEXEC or
SOCK_NONBLOCK and accept4(). OK henning@ tested & OK benno@

Revision 1.75 / (download) - annotate - [select for diffs], Wed Nov 13 20:41:01 2013 UTC (10 years, 6 months ago) by benno
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.74: +2 -2 lines
Diff to previous 1.74 (colored)

from claudio
"Let msgbuf_write return -1 with errno EAGAIN. The users then must
check if this was the case and readd the event or poll again.  The
current handling in the imsg code is wrong for sure."

ok gilles, benno

Revision 1.74 / (download) - annotate - [select for diffs], Mon Mar 11 17:40:11 2013 UTC (11 years, 3 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4
Changes since 1.73: +3 -2 lines
Diff to previous 1.73 (colored)

handle ECONNABORTED errors from accept().  In many code blocks they can be
ignored silently and without aborting, much like EINTR and EWOULDBLOCK are.
ok's from various maintainers of these directories...

Revision 1.73 / (download) - annotate - [select for diffs], Thu Mar 7 21:26:28 2013 UTC (11 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.72: +19 -1 lines
Diff to previous 1.72 (colored)

Implements a few missing bits for better templates support:
- on config reload also adjust the cloned neighbors so that they get the
  config changes as well.
- clean up sessions that are 1h idle but in state active (instead of down)
- add bits to allow bgpctl to destroy cloned neighbors
Tested by sthen@ some time ago, OK phessler@

Revision 1.72 / (download) - annotate - [select for diffs], Sun May 27 18:52:07 2012 UTC (12 years ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2
Changes since 1.71: +3 -1 lines
Diff to previous 1.71 (colored)

Extend the network code to allow attributes to be passed in with prefixes.
In the end this will allow anyone to use MRT table dumps to load prefixes
into a bgpd instance. For example you can download the RIPE dumps and load
full-feeds onto your laptop until the poor thing dies.
OK henning@ sthen@

Revision 1.71 / (download) - annotate - [select for diffs], Thu Apr 12 17:26:09 2012 UTC (12 years, 1 month ago) by claudio
Branch: MAIN
Changes since 1.70: +6 -3 lines
Diff to previous 1.70 (colored)

accept() pacing for bgpd based on similar work done on other daemons.
OK henning@ sthen@

Revision 1.70 / (download) - annotate - [select for diffs], Fri Oct 29 12:51:53 2010 UTC (13 years, 7 months ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9
Changes since 1.69: +2 -2 lines
Diff to previous 1.69 (colored)

malloc -> calloc for ctl_conn
pt out by cppcheck/jasper, ok sthen claudio

Revision 1.69 / (download) - annotate - [select for diffs], Mon May 3 13:09:38 2010 UTC (14 years, 1 month ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.68: +13 -6 lines
Diff to previous 1.68 (colored)

Make it possible to load multiple routing tables at the same time and use
those for alternate RIBs. This allows to use "rde rib TESTIT rtable 1".
NOTE: nexthop verification has changed for alternate tables. For now
nexthop will only be verified against the main routing table (id 0).
Because of this "nexthop qualify via bgp" may now compare the nexthops
against bgpd routes from a different RIB.
Tested by sthen@, OK to move on by henning@

Revision 1.68 / (download) - annotate - [select for diffs], Wed Jan 13 06:02:37 2010 UTC (14 years, 4 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.67: +2 -3 lines
Diff to previous 1.67 (colored)

Add support for BGP MPLS VPN aka RFC 4364. This is only the RDE part so
that it is possible to use OpenBGPD as a route-reflector for VPNv4.
Some clean up of the BGP MP code so that multiple protocols are easier
supported. kroute/kernel support not yet done but comming.
OK henning@, reyk@

Revision 1.67 / (download) - annotate - [select for diffs], Tue Dec 8 15:54:50 2009 UTC (14 years, 6 months ago) by jsg
Branch: MAIN
Changes since 1.66: +2 -2 lines
Diff to previous 1.66 (colored)

porcesses -> processes

Revision 1.66 / (download) - annotate - [select for diffs], Thu Dec 3 19:22:53 2009 UTC (14 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.65: +10 -4 lines
Diff to previous 1.65 (colored)

A bgpctl nei XY clear should not restart neighbors that are administrativly
down. So after a bgpctl reload clearing a neighbor will bring that neighbor
into the configured state (in this case down). OK henning@

Revision 1.65 / (download) - annotate - [select for diffs], Wed Dec 2 19:10:02 2009 UTC (14 years, 6 months ago) by mk
Branch: MAIN
Changes since 1.64: +4 -4 lines
Diff to previous 1.64 (colored)

log_warn() consistency.

`OK' claudio

Revision 1.64 / (download) - annotate - [select for diffs], Tue Dec 1 14:28:05 2009 UTC (14 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.63: +4 -4 lines
Diff to previous 1.63 (colored)

Use an artificial address family id in struct bgpd_addr and almost everywhere
else. Adds conversion functions to map AFI/SAFI and the Unix AF_ values
from and into AID used in bgpd.  This is needed to support things like MPLS
VPN and other upcomming changes that need to play a lot with AFI/SAFI pairs.
Mostly mechanical change, henning@ has no particular issues with this.
Must go in so that I can continue working.

Revision 1.63 / (download) - annotate - [select for diffs], Mon Nov 2 20:38:15 2009 UTC (14 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.62: +17 -2 lines
Diff to previous 1.62 (colored)

Implement IMSG_CTL_LOG_VERBOSE similar to ospfd. Even though bgpd has almost
no log_debug() it makes more sense to make all routing daemons behave the same.

Revision 1.62 / (download) - annotate - [select for diffs], Wed Sep 2 08:06:42 2009 UTC (14 years, 9 months ago) by claudio
Branch: MAIN
Changes since 1.61: +3 -3 lines
Diff to previous 1.61 (colored)

Implement all of RFC 4486 BGP Cease Notification Message Subcodes.
The other side should now see why a session was dropped. e.g:
bgpd: ... received notification: Cease, administratively down
OK henning

Revision 1.61 / (download) - annotate - [select for diffs], Tue May 5 20:09:19 2009 UTC (15 years, 1 month ago) by sthen
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6
Changes since 1.60: +8 -1 lines
Diff to previous 1.60 (colored)

check that an IMSG_CTL_SHOW_RIB_PREFIX request has a valid
address family before passing it to the RDE.

ok henning@ claudio@

Revision 1.60 / (download) - annotate - [select for diffs], Sun May 11 01:08:05 2008 UTC (16 years, 1 month ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.59: +2 -1 lines
Diff to previous 1.59 (colored)

allow IMSG_CONTROL_SHOW_TIMER on restricted sockets

Revision 1.59 / (download) - annotate - [select for diffs], Thu May 8 04:05:37 2008 UTC (16 years, 1 month ago) by henning
Branch: MAIN
Changes since 1.58: +7 -4 lines
Diff to previous 1.58 (colored)

make sure we always send back something on IMSG_CTL_SHOW_NEIGHBOR
namely, the "no such neighbor" case was missing.
problem spotted by martin,ok claudio

Revision 1.58 / (download) - annotate - [select for diffs], Thu Jan 31 12:17:35 2008 UTC (16 years, 4 months ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.57: +2 -1 lines
Diff to previous 1.57 (colored)

do not leak confd on malloc failure in control_accept()
found by Igor Zinovik <zinovik@cs.karelia.ru>

Revision 1.57 / (download) - annotate - [select for diffs], Sun Dec 23 18:26:13 2007 UTC (16 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.56: +29 -4 lines
Diff to previous 1.56 (colored)

send timers for bgpctlshow neighbor foo timer in seperate messages after
the peer data. makes bgpctl display code independent from timer
implementation internals. only running timers are displayed now, stopped
ones are skipped.

Revision 1.56 / (download) - annotate - [select for diffs], Thu Dec 20 17:08:48 2007 UTC (16 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.55: +3 -3 lines
Diff to previous 1.55 (colored)

rework timers.
stop changing tienmr values directly, always use new
timer_(get/set/stop/running) functions. preparation for more to come :)
ok claudio

Revision 1.55 / (download) - annotate - [select for diffs], Wed Mar 28 12:33:32 2007 UTC (17 years, 2 months ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.54: +3 -1 lines
Diff to previous 1.54 (colored)

add IMSG_CTL_SHOW_RIB_COMMUNITY, rib by given community
mostly from rivo nurges <rix@estpak.ee>, ok claudio

Revision 1.54 / (download) - annotate - [select for diffs], Mon Mar 19 10:03:25 2007 UTC (17 years, 2 months ago) by henning
Branch: MAIN
Changes since 1.53: +2 -2 lines
Diff to previous 1.53 (colored)

when our red/recv/recvmsg in imsg_read gives EINTR or EAGAIN, do not
signal "connection closed" upstream.
spotted by Valentin Kozamernik <tin@komna.com>

Revision 1.53 / (download) - annotate - [select for diffs], Wed Aug 23 08:13:04 2006 UTC (17 years, 9 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.52: +42 -1 lines
Diff to previous 1.52 (colored)

Extend show rib interface code so that it is possible to show the adj-rib-in
and adj-rib-out. Additionally it is now possible to limit the output to a
specified peer. OK henning@

Revision 1.52 / (download) - annotate - [select for diffs], Sat May 27 21:24:36 2006 UTC (18 years ago) by claudio
Branch: MAIN
Changes since 1.51: +2 -2 lines
Diff to previous 1.51 (colored)

Pass a IMSG_CTL_RESULT messgae back to bgpctl on reloads to indicate if
the reload was successful or not. OK henning@

Revision 1.51 / (download) - annotate - [select for diffs], Sat May 27 15:43:13 2006 UTC (18 years ago) by claudio
Branch: MAIN
Changes since 1.50: +2 -2 lines
Diff to previous 1.50 (colored)

Cleanup with lint. Make the poll fd indexes unsigned and because of that
control_accept should also return a unsigned int. Remove old prototype.

Revision 1.50 / (download) - annotate - [select for diffs], Tue May 23 12:11:38 2006 UTC (18 years ago) by henning
Branch: MAIN
Changes since 1.49: +12 -2 lines
Diff to previous 1.49 (colored)

allow bgpd to request a route refresh from a neighbor if that neighbor
announced route refresh capabilities

Revision 1.49 / (download) - annotate - [select for diffs], Tue Jan 24 15:28:03 2006 UTC (18 years, 4 months ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9
Changes since 1.48: +8 -1 lines
Diff to previous 1.48 (colored)

introduce "bgpctl show summary terse", shows summary in an easy to parse
format, intended for monitoring puposes. claudio ok

Revision 1.48 / (download) - annotate - [select for diffs], Tue Jan 24 10:04:36 2006 UTC (18 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.47: +1 -6 lines
Diff to previous 1.47 (colored)

zap now unused var

Revision 1.47 / (download) - annotate - [select for diffs], Tue Jan 24 10:03:44 2006 UTC (18 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.46: +51 -20 lines
Diff to previous 1.46 (colored)

introduce a second control socket, which is restricted to certain messages,
nameley the show ones. needed for looking glass style applications,
monitoring etc. claudio ok

Revision 1.46 / (download) - annotate - [select for diffs], Tue Jan 3 22:49:17 2006 UTC (18 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.45: +2 -1 lines
Diff to previous 1.45 (colored)

Track some (memory) statistics in the RDE. Accessible via bgpctl.

Revision 1.45 / (download) - annotate - [select for diffs], Wed Oct 19 12:32:16 2005 UTC (18 years, 7 months ago) by henning
Branch: MAIN
Changes since 1.44: +11 -3 lines
Diff to previous 1.44 (colored)

for "bgpctl neighbor foo up/down/clear", make bgpctl not exit after sending
the request, but wait for the new IMSG_CTL_RESULT message, which contains
a status code to indicate wether the request was processed successfully
or wether an error occured and if so what kind of error.
no more "IMSG_CTL_NEIGHBOR_ with unknown neighbor foobaz" in the log
when you mistyped foobar - no bgpctl itself complains
claudio ok

Revision 1.44 / (download) - annotate - [select for diffs], Wed Oct 19 10:26:21 2005 UTC (18 years, 7 months ago) by henning
Branch: MAIN
Changes since 1.43: +3 -2 lines
Diff to previous 1.43 (colored)

on "bgpctl neighbor foo clear", we used to send a STOP event immediately
followed by a START event. Instead of sending START immediately, start the
IdleHoldTimer with a very low value (5 seconds) so that we restart the
session these seconds later. some other implementations deal poorly with
our previously superfast reconnects, namely, that commercial one from
san jose, claudio ok

Revision 1.43 / (download) - annotate - [select for diffs], Fri Mar 11 15:48:58 2005 UTC (19 years, 3 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7
Changes since 1.42: +5 -4 lines
Diff to previous 1.42 (colored)

move umask() song and dance closer around the bind, being more careful about errors; ok claudio

Revision 1.42 / (download) - annotate - [select for diffs], Fri Feb 25 23:00:23 2005 UTC (19 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.41: +2 -1 lines
Diff to previous 1.41 (colored)

unlink() control socket in error path. Spotted by Theo.

Revision 1.41 / (download) - annotate - [select for diffs], Thu Dec 23 17:55:58 2004 UTC (19 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.40: +6 -5 lines
Diff to previous 1.40 (colored)

allo the "bgpctl show neighbor " commands to take the neighbor descr
too, claudio ok

Revision 1.40 / (download) - annotate - [select for diffs], Thu Dec 23 17:26:51 2004 UTC (19 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.39: +8 -4 lines
Diff to previous 1.39 (colored)

allow "bgpctl neighbor" to take the peer's descr as argument as well
as its address
so "bgpctl neighbor upstream1 clear" now works and you don't have to
remember IPs
claudio ok

Revision 1.39 / (download) - annotate - [select for diffs], Tue Nov 23 13:07:01 2004 UTC (19 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.38: +3 -1 lines
Diff to previous 1.38 (colored)

Switch from a single filter_set to a linked list of sets. With this change
it is possible to specify multiple communities. This is also the first step
to better bgpd filters. OK henning@

Revision 1.38 / (download) - annotate - [select for diffs], Thu Sep 16 17:36:29 2004 UTC (19 years, 8 months ago) by henning
Branch: MAIN
Changes since 1.37: +2 -2 lines
Diff to previous 1.37 (colored)

imsg API cleanup:
-kill imsg_compose_pid, imsg_compose_fdpass and imsg_create_pid
-extend the original imsg_compose/_create API to take pid & fd too
-make imsg_compose do imsg_create + imsg_add + imsg_close instead of
 duplicating the code
-adjust all callers to the new API
ok claudio

Revision 1.37 / (download) - annotate - [select for diffs], Tue Aug 24 12:43:34 2004 UTC (19 years, 9 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_3_6_BASE, OPENBSD_3_6
Changes since 1.36: +2 -2 lines
Diff to previous 1.36 (colored)

missing space in log message.

Revision 1.36 / (download) - annotate - [select for diffs], Fri Aug 20 15:49:02 2004 UTC (19 years, 9 months ago) by henning
Branch: MAIN
Changes since 1.35: +5 -0 lines
Diff to previous 1.35 (colored)

add IMSG_CTL_NEIGHBOR_CLEAR, takes a session down and restarts it,
claudio ok

Revision 1.35 / (download) - annotate - [select for diffs], Fri Aug 20 15:47:38 2004 UTC (19 years, 9 months ago) by henning
Branch: MAIN
Changes since 1.34: +17 -20 lines
Diff to previous 1.34 (colored)

merge IMSG_CTL_NEIGHBOR_UP and _DOWN handling, kills some duplicate code,
claudio ok

Revision 1.34 / (download) - annotate - [select for diffs], Fri Aug 6 11:51:19 2004 UTC (19 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.33: +9 -8 lines
Diff to previous 1.33 (colored)

Forward IMSG_CTL_SHOW_NEIGHBOR messages to the rde so that we can report
the current and max prefix count back to bgpctl. OK henning@

Revision 1.33 / (download) - annotate - [select for diffs], Sun Jun 20 18:35:12 2004 UTC (19 years, 11 months ago) by henning
Branch: MAIN
Changes since 1.32: +5 -5 lines
Diff to previous 1.32 (colored)

at least somewhat consistently name the TAILQ_ENTRYs... this confused me
more than once

Revision 1.32 / (download) - annotate - [select for diffs], Wed Jun 9 13:01:44 2004 UTC (20 years ago) by henning
Branch: MAIN
Changes since 1.31: +15 -10 lines
Diff to previous 1.31 (colored)

move to a dynamically allocated struct pollfd array.
we used a ststic one with OPEN_MAX entries, which is a rather arbitary limit
as OPEN_MAX is _not_ the max # of open fds we can have, but just a default
for that setting.
in the same move we have to allocate the peer_l array, basically there
for pfd-index to peer pointers to prevent peer list scans all time,
dynamiccaly to. we overallocate a little and use that reserve until we
have to realloc again later to prevent reallocs for every single control
connection or a single flapping peer.
help & ok claudio

Revision 1.31 / (download) - annotate - [select for diffs], Fri May 21 11:48:56 2004 UTC (20 years ago) by claudio
Branch: MAIN
Changes since 1.30: +8 -1 lines
Diff to previous 1.30 (colored)

Add support for dynamic announcements. Usefule to annouce temporary
blackhole routes or to make network announcements dependent on a external
state (e.g. for carp setups) OK henning@

Revision 1.30 / (download) - annotate - [select for diffs], Sat May 8 11:22:43 2004 UTC (20 years, 1 month ago) by henning
Branch: MAIN
Changes since 1.29: +2 -2 lines
Diff to previous 1.29 (colored)

remove unused argument to control_dispatch_msg(), lint

Revision 1.29 / (download) - annotate - [select for diffs], Thu Apr 29 19:56:04 2004 UTC (20 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.28: +3 -3 lines
Diff to previous 1.28 (colored)

sock -> fd; ok henning

Revision 1.28 / (download) - annotate - [select for diffs], Sun Apr 25 03:13:42 2004 UTC (20 years, 1 month ago) by henning
Branch: MAIN
Changes since 1.27: +3 -4 lines
Diff to previous 1.27 (colored)

missing return; noticed by Joris Vink <amni@pandora.be> but I fixed in
another way

Revision 1.27 / (download) - annotate - [select for diffs], Fri Apr 16 04:51:09 2004 UTC (20 years, 1 month ago) by henning
Branch: MAIN
Changes since 1.26: +4 -4 lines
Diff to previous 1.26 (colored)

use getpeerbyaddr() instead of using the v4 part of the af independent
struct manually

Revision 1.26 / (download) - annotate - [select for diffs], Wed Mar 17 14:39:45 2004 UTC (20 years, 2 months ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_3_5_BASE, OPENBSD_3_5
Changes since 1.25: +1 -13 lines
Diff to previous 1.25 (colored)

remove getpeereid() call so that those who have write access to the socket
(root:wheel 0640) can send queries, claudio ok

Revision 1.25 / (download) - annotate - [select for diffs], Tue Mar 2 19:29:01 2004 UTC (20 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.24: +2 -1 lines
Diff to previous 1.24 (colored)

Framework for rib lookups by prefix. OK henning@

Revision 1.24 / (download) - annotate - [select for diffs], Sun Feb 29 22:48:01 2004 UTC (20 years, 3 months ago) by henning
Branch: MAIN
Changes since 1.23: +2 -1 lines
Diff to previous 1.23 (colored)

plug memory leak: when a control connection is closed we need to clear
its write buffers, noticed by claudio

Revision 1.23 / (download) - annotate - [select for diffs], Sun Feb 29 21:49:36 2004 UTC (20 years, 3 months ago) by henning
Branch: MAIN
Changes since 1.22: +4 -1 lines
Diff to previous 1.22 (colored)

of course the control socket needs to be nonblocking as well, i could have
sworn it was... noticed by & fixed with claudio

Revision 1.22 / (download) - annotate - [select for diffs], Thu Feb 26 16:16:41 2004 UTC (20 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.21: +7 -1 lines
Diff to previous 1.21 (colored)

show rib infrastructure. At least full dumps and per as dumps. Per prefix
dump need some more work. OK henning@

Revision 1.21 / (download) - annotate - [select for diffs], Mon Feb 2 23:17:34 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.20: +4 -1 lines
Diff to previous 1.20 (colored)

close socket on error in control_init
From: Patrick Latifi <pat@eyeo.org>

Revision 1.20 / (download) - annotate - [select for diffs], Thu Jan 22 20:34:55 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.19: +6 -6 lines
Diff to previous 1.19 (colored)

use log_warnx and log_info. reclassify a few messages in the process and fix
a few messages.

ok claudio@

Revision 1.19 / (download) - annotate - [select for diffs], Thu Jan 22 03:18:03 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.18: +11 -11 lines
Diff to previous 1.18 (colored)

s/log_err/log_warn/
it is like warn(3), nor err(3). so use a less confusing name.

Revision 1.18 / (download) - annotate - [select for diffs], Tue Jan 20 12:50:25 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.17: +2 -2 lines
Diff to previous 1.17 (colored)

fix error logging on connection attempts from !root user

Revision 1.17 / (download) - annotate - [select for diffs], Sat Jan 17 18:05:46 2004 UTC (20 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.16: +2 -1 lines
Diff to previous 1.16 (colored)

allow the interfaces as bgpd sees 'em to be queried via imsgs

Revision 1.16 / (download) - annotate - [select for diffs], Sun Jan 11 02:35:14 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.15: +2 -1 lines
Diff to previous 1.15 (colored)

new message IMSG_CTL_SHOW_NEXTHOP: request/send lost of BGP nexthops and
the result of their validity check

Revision 1.15 / (download) - annotate - [select for diffs], Fri Jan 9 19:08:50 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.14: +3 -2 lines
Diff to previous 1.14 (colored)

for IMSG_CTL_KROUTEs allow matching based on flags,
add IMGS_CTL_KROUTE_ADDR to match the route for a given address

ok claudio@

Revision 1.14 / (download) - annotate - [select for diffs], Fri Jan 9 13:47:07 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.13: +30 -0 lines
Diff to previous 1.13 (colored)

get us a stateful imsg relaying framework, and the first receiver,
IMSG_CTL_KROUTE, to have the kroute structs forming the fib sent to a
control socket.

ok claudio@

Revision 1.13 / (download) - annotate - [select for diffs], Fri Jan 9 13:14:25 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.12: +10 -1 lines
Diff to previous 1.12 (colored)

you must not try to read(2) without checking (pfd->revents & POLLIN)
you must not try to read(2) without checking (pfd->revents & POLLIN)
you must not try to read(2) without checking (pfd->revents & POLLIN)
[...]
you must not try to read(2) without checking (pfd->revents & POLLIN)

Revision 1.12 / (download) - annotate - [select for diffs], Tue Jan 6 23:14:58 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.11: +29 -1 lines
Diff to previous 1.11 (colored)

two new imsg types, IMSG_CTL_NEIGHBOR_UP and _DOWN, on their receival on the
control socket the given neighbor session is sent a START / STOP signal.

ok claudio@

Revision 1.11 / (download) - annotate - [select for diffs], Tue Jan 6 03:43:50 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.10: +2 -2 lines
Diff to previous 1.10 (colored)

2004

Revision 1.10 / (download) - annotate - [select for diffs], Mon Jan 5 16:21:14 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.9: +4 -2 lines
Diff to previous 1.9 (colored)

allow fib couple/decouple based on an imsg received on the control socket
by the SE and passed on to the main process

Revision 1.9 / (download) - annotate - [select for diffs], Sun Jan 4 19:39:46 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.8: +4 -1 lines
Diff to previous 1.8 (colored)

-new imsg CTL_RELOAD
-upong receival in the SE forward to parent
-make sending messages from SE to parent work for that (was not required before)
-parent reacts to that just like a SIGHUP, reread config file

Revision 1.8 / (download) - annotate - [select for diffs], Sun Jan 4 18:51:23 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.7: +15 -4 lines
Diff to previous 1.7 (colored)

allow "show neighbor" to be limited to one specific neighbor

Revision 1.7 / (download) - annotate - [select for diffs], Sat Jan 3 20:22:07 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.6: +2 -2 lines
Diff to previous 1.6 (colored)

decouple the peer list from bgpd_config.
so many parts of bgpd are not at all interested in the session specific peer
structs... allows for some further cleaning

Revision 1.6 / (download) - annotate - [select for diffs], Sat Jan 3 14:06:35 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.5: +2 -2 lines
Diff to previous 1.5 (colored)

change imsg_read semantics so that the number of bytes read is returned.
that means that the callers can (and must) coope with closed connections
themselves, what is exactly the desired behaviour.

Revision 1.5 / (download) - annotate - [select for diffs], Sat Jan 3 13:54:27 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.4: +2 -1 lines
Diff to previous 1.4 (colored)

send an imsg as list end indicator

Revision 1.4 / (download) - annotate - [select for diffs], Sat Jan 3 13:28:02 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.3: +2 -2 lines
Diff to previous 1.3 (colored)

fix umask, noticed by theo

Revision 1.3 / (download) - annotate - [select for diffs], Fri Jan 2 09:02:50 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.2: +20 -3 lines
Diff to previous 1.2 (colored)

umask setting and unlink before bind() the unix socket, chmod and umask
restore afterwards
help & ok theo

Revision 1.2 / (download) - annotate - [select for diffs], Fri Jan 2 02:27:57 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN
Changes since 1.1: +1 -2 lines
Diff to previous 1.1 (colored)

move the socket name #define to bgpd.h and get rid of bgpdctl*

Revision 1.1 / (download) - annotate - [select for diffs], Thu Jan 1 23:46:47 2004 UTC (20 years, 5 months ago) by henning
Branch: MAIN

listen on a AF_LOCAL socket for imsgs too.
only implemented type yet is IMSG_CTL_SHOW_NEIGHBOR which sends back
the struct peer for all neighbors.
will be used by bgpdctl

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.