OpenBSD CVS

CVS log for src/usr.sbin/bgpd/flowspec.c


[BACK] Up to [local] / src / usr.sbin / bgpd

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.5 / (download) - annotate - [select for diffs], Mon Oct 23 13:07:44 2023 UTC (7 months, 1 week ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, HEAD
Changes since 1.4: +2 -2 lines
Diff to previous 1.4 (colored)

Use xoff instead of *olen in the shift_right() call. xoff is the right
value here since *olen is (conditionally) set a few lines later to the
same value as xoff.

Should fix the CodeQL warnings because *olen is dereferenced without
proper NULL check.

OK tb@

Revision 1.4 / (download) - annotate - [select for diffs], Wed Apr 19 09:31:58 2023 UTC (13 months, 1 week ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_4_BASE, OPENBSD_7_4
Changes since 1.3: +10 -13 lines
Diff to previous 1.3 (colored)

Remove usage of fatalx() in here. This code will be shared with bgpctl.
In flowspec_cmp() make sure a deterministic sort is possible. Most error
cases are unreachable if flowspec NLRI are validated first (flowspec_valid).
In flowspec_valid() replace the assert like check with an error return.
OK tb@

Revision 1.3 / (download) - annotate - [select for diffs], Wed Apr 19 07:07:58 2023 UTC (13 months, 2 weeks ago) by claudio
Branch: MAIN
Changes since 1.2: +3 -3 lines
Diff to previous 1.2 (colored)

bad indents

Revision 1.2 / (download) - annotate - [select for diffs], Mon Apr 17 20:54:57 2023 UTC (13 months, 2 weeks ago) by claudio
Branch: MAIN
Changes since 1.1: +21 -21 lines
Diff to previous 1.1 (colored)

Reverse the polarity of flowspec_cmp() so it works better with our
RB trees. Mainly RB_FOREACH() walks form RB_MIN to RB_MAX so the most
preferred entry should be at RB_MIN.
OK tb@

Revision 1.1 / (download) - annotate - [select for diffs], Mon Apr 17 08:02:21 2023 UTC (13 months, 2 weeks ago) by claudio
Branch: MAIN

Implement a basic API to work with flowspec NLRI.

Flowspec is excessivly flexible and large so there is no way to convert
the flowspec data into a struct bgpd_addr and it is better to keep it in
wireformat and add a few functions to validate and extract information
from the NLRI encoding.
OK tb@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.