OpenBSD CVS

CVS log for src/usr.sbin/config/exec_elf.c


[BACK] Up to [local] / src / usr.sbin / config

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.18 / (download) - annotate - [select for diffs], Sun Oct 24 21:24:18 2021 UTC (2 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, HEAD
Changes since 1.17: +2 -2 lines
Diff to previous 1.17 (colored)

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant.  Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk.  They could all be 0xdeafbeef.
ok millert

Revision 1.17 / (download) - annotate - [select for diffs], Fri Jun 28 13:32:47 2019 UTC (4 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.16: +3 -3 lines
Diff to previous 1.16 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.16 / (download) - annotate - [select for diffs], Sun Oct 29 08:45:53 2017 UTC (6 years, 7 months ago) by mpi
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3
Changes since 1.15: +2 -2 lines
Diff to previous 1.15 (colored)

Prefer <elf.h> to the non portable <sys/exec_elf.h>.

ok jca@, deraadt@

Revision 1.15 / (download) - annotate - [select for diffs], Sat Jun 3 23:31:37 2017 UTC (7 years ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.14: +2 -2 lines
Diff to previous 1.14 (colored)

config -e mode should match our other policies which ensure og-rwx /bsd.
pointed out by brynet

Revision 1.14 / (download) - annotate - [select for diffs], Fri Sep 25 03:17:02 2015 UTC (8 years, 8 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.13: +6 -31 lines
Diff to previous 1.13 (colored)

exec.c provided indirection for multiple exec formats.  ELF-only now, so...

Revision 1.13 / (download) - annotate - [select for diffs], Sun Oct 2 22:20:49 2011 UTC (12 years, 8 months ago) by edd
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7, OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1
Changes since 1.12: +6 -5 lines
Diff to previous 1.12 (colored)

Fix some minor things in config(8):
 * As haesbaert suggests, correctly order include files.
 * Found some old style function defs. Updated.
 * Found a prototype inside a function. Moved.

OK nicm@

Revision 1.12 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:51 2009 UTC (14 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.11: +1 -5 lines
Diff to previous 1.11 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.11 / (download) - annotate - [select for diffs], Tue Aug 12 09:44:26 2008 UTC (15 years, 10 months ago) by otto
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.10: +16 -2 lines
Diff to previous 1.10 (colored)

basic bounds check on elf header info. avoid crashes on i.e.e truncated
kernels; noted by jasper@ ok miod@

Revision 1.10 / (download) - annotate - [select for diffs], Sun Jan 4 18:30:05 2004 UTC (20 years, 5 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5
Changes since 1.9: +7 -12 lines
Diff to previous 1.9 (colored)

knf and lint

Revision 1.9 / (download) - annotate - [select for diffs], Fri Sep 26 17:00:27 2003 UTC (20 years, 8 months ago) by deraadt
Branch: MAIN
Changes since 1.8: +4 -3 lines
Diff to previous 1.8 (colored)

use emalloc

Revision 1.8 / (download) - annotate - [select for diffs], Sat Jun 28 04:55:07 2003 UTC (20 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.7: +13 -13 lines
Diff to previous 1.7 (colored)

ansi & prototype cleanup.  tested in mkr on most arch's.  ok dhartmei

Revision 1.7 / (download) - annotate - [select for diffs], Mon Jun 2 21:19:03 2003 UTC (21 years ago) by maja
Branch: MAIN
Changes since 1.6: +2 -7 lines
Diff to previous 1.6 (colored)

remove clause 3 and 4. -moj

Revision 1.6 / (download) - annotate - [select for diffs], Mon Aug 5 00:26:56 2002 UTC (21 years, 10 months ago) by art
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.5: +4 -3 lines
Diff to previous 1.5 (colored)

Make readjust work correctly.
This allows config -e on sparc with elf.

Revision 1.5 / (download) - annotate - [select for diffs], Thu Mar 14 06:51:42 2002 UTC (22 years, 3 months ago) by mpech
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.4: +3 -3 lines
Diff to previous 1.4 (colored)

Remove \n from err/errx/warn/warnx().

millert@ ok

Revision 1.4 / (download) - annotate - [select for diffs], Wed Dec 5 10:11:23 2001 UTC (22 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.3: +13 -14 lines
Diff to previous 1.3 (colored)

more free KNF from maja, though this was hard to do

Revision 1.3 / (download) - annotate - [select for diffs], Thu Jan 25 05:42:12 2001 UTC (23 years, 4 months ago) by art
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0, OPENBSD_2_9_BASE, OPENBSD_2_9
Changes since 1.2: +11 -11 lines
Diff to previous 1.2 (colored)

Make this elf-size independent.
config -e works on my alpha.

Revision 1.2 / (download) - annotate - [select for diffs], Sat Sep 30 16:06:34 2000 UTC (23 years, 8 months ago) by aaron
Branch: MAIN
CVS Tags: OPENBSD_2_8_BASE, OPENBSD_2_8
Changes since 1.1: +4 -4 lines
Diff to previous 1.1 (colored)

Some format string problems that were missed during initial audit; deraadt@ and
millert@ ok

Revision 1.1 / (download) - annotate - [select for diffs], Mon Oct 4 20:00:51 1999 UTC (24 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_7_BASE, OPENBSD_2_7, OPENBSD_2_6_BASE, OPENBSD_2_6

config -e support; ukc from maja@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.