Return to entry.c CVS log

Up to [local] / src / usr.sbin / cron

Fix skipping of white space after the username in /etc/crontab.
Only a single white space character was consumed, we should be
consuming all white space between fields.  This change makes things
consistent with how lines without a username are parsed.
OK deraadt@ sthen@

/*	$OpenBSD: entry.c,v 1.59 2023/07/19 21:26:02 millert Exp $	*/

/*
 * Copyright 1988,1990,1993,1994 by Paul Vixie
 * Copyright (c) 2004 by Internet Systems Consortium, Inc. ("ISC")
 * Copyright (c) 1997,2000 by Internet Software Consortium, Inc.
 *
 * Permission to use, copy, modify, and distribute this software for any
 * purpose with or without fee is hereby granted, provided that the above
 * copyright notice and this permission notice appear in all copies.
 *
 * THE SOFTWARE IS PROVIDED "AS IS" AND ISC DISCLAIMS ALL WARRANTIES
 * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
 * MERCHANTABILITY AND FITNESS.  IN NO EVENT SHALL ISC BE LIABLE FOR
 * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
 * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
 * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT
 * OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

#include <sys/types.h>

#include <bitstring.h>		/* for structs.h */
#include <ctype.h>
#include <pwd.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <syslog.h>
#include <time.h>		/* for structs.h */
#include <unistd.h>

#include "pathnames.h"
#include "macros.h"
#include "structs.h"
#include "funcs.h"

typedef	enum ecode {
	e_none, e_minute, e_hour, e_dom, e_month, e_dow,
	e_cmd, e_timespec, e_username, e_option, e_memory, e_flags
} ecode_e;

static const char *ecodes[] = {
	"no error",
	"bad minute",
	"bad hour",
	"bad day-of-month",
	"bad month",
	"bad day-of-week",
	"bad command",
	"bad time specifier",
	"bad username",
	"bad option",
	"out of memory",
	"bad flags"
};

static const char *MonthNames[] = {
	"Jan", "Feb", "Mar", "Apr", "May", "Jun",
	"Jul", "Aug", "Sep", "Oct", "Nov", "Dec",
	NULL
};

static const char *DowNames[] = {
	"Sun", "Mon", "Tue", "Wed", "Thu", "Fri", "Sat", "Sun",
	NULL
};

static int	get_list(bitstr_t *, int, int, const char *[], int, FILE *),
		get_range(bitstr_t *, int, int, const char *[], int, FILE *),
		get_number(int *, int, const char *[], int, FILE *, const char *),
		set_element(bitstr_t *, int, int, int),
		set_range(bitstr_t *, int, int, int, int, int);

void
free_entry(entry *e)
{
	free(e->cmd);
	free(e->pwd);
	if (e->envp)
		env_free(e->envp);
	free(e);
}

/* return NULL if eof or syntax error occurs;
 * otherwise return a pointer to a new entry.
 */
entry *
load_entry(FILE *file, void (*error_func)(const char *), struct passwd *pw,
    char **envp)
{
	/* this function reads one crontab entry -- the next -- from a file.
	 * it skips any leading blank lines, ignores comments, and returns
	 * NULL if for any reason the entry can't be read and parsed.
	 *
	 * the entry is also parsed here.
	 *
	 * syntax:
	 *   user crontab:
	 *	minutes hours doms months dows cmd\n
	 *   system crontab (/etc/crontab):
	 *	minutes hours doms months dows USERNAME cmd\n
	 */

	ecode_e	ecode = e_none;
	entry *e;
	int ch;
	char cmd[MAX_COMMAND];
	char envstr[MAX_ENVSTR];
	char **tenvp;

	skip_comments(file);

	ch = get_char(file);
	if (ch == EOF)
		return (NULL);

	/* ch is now the first useful character of a useful line.
	 * it may be an @special or it may be the first character
	 * of a list of minutes.
	 */

	e = calloc(sizeof(entry), 1);
	if (e == NULL) {
		ecode = e_memory;
		goto eof;
	}

	if (ch == '@') {
		/* all of these should be flagged and load-limited; i.e.,
		 * instead of @hourly meaning "0 * * * *" it should mean
		 * "close to the front of every hour but not 'til the
		 * system load is low".  Problems are: how do you know
		 * what "low" means? (save me from /etc/cron.conf!) and:
		 * how to guarantee low variance (how low is low?), which
		 * means how to we run roughly every hour -- seems like
		 * we need to keep a history or let the first hour set
		 * the schedule, which means we aren't load-limited
		 * anymore.  too much for my overloaded brain. (vix, jan90)
		 * HINT
		 */
		ch = get_string(cmd, MAX_COMMAND, file, " \t\n");
		if (!strcmp("reboot", cmd)) {
			e->flags |= WHEN_REBOOT;
		} else if (!strcmp("yearly", cmd) || !strcmp("annually", cmd)){
			set_element(e->minute, FIRST_MINUTE, LAST_MINUTE,
			    FIRST_MINUTE);
			set_element(e->hour, FIRST_HOUR, LAST_HOUR, FIRST_HOUR);
			set_element(e->dom, FIRST_DOM, LAST_DOM, FIRST_DOM);
			set_element(e->month, FIRST_MONTH, LAST_MONTH,
			    FIRST_MONTH);
			set_range(e->dow, FIRST_DOW, LAST_DOW, FIRST_DOW,
			    LAST_DOW, 1);
			e->flags |= DOW_STAR;
		} else if (!strcmp("monthly", cmd)) {
			set_element(e->minute, FIRST_MINUTE, LAST_MINUTE,
			    FIRST_MINUTE);
			set_element(e->hour, FIRST_HOUR, LAST_HOUR, FIRST_HOUR);
			set_element(e->dom, FIRST_DOM, LAST_DOM, FIRST_DOM);
			set_range(e->month, FIRST_MONTH, LAST_MONTH,
			    FIRST_MONTH, LAST_MONTH, 1);
			set_range(e->dow, FIRST_DOW, LAST_DOW, FIRST_DOW,
			    LAST_DOW, 1);
			e->flags |= DOW_STAR;
		} else if (!strcmp("weekly", cmd)) {
			set_element(e->minute, FIRST_MINUTE, LAST_MINUTE,
			    FIRST_MINUTE);
			set_element(e->hour, FIRST_HOUR, LAST_HOUR, FIRST_HOUR);
			set_range(e->dom, FIRST_DOM, LAST_DOM, FIRST_DOM,
			    LAST_DOM, 1);
			set_range(e->month, FIRST_MONTH, LAST_MONTH,
			    FIRST_MONTH, LAST_MONTH, 1);
			set_element(e->dow, FIRST_DOW, LAST_DOW, FIRST_DOW);
			e->flags |= DOW_STAR;
		} else if (!strcmp("daily", cmd) || !strcmp("midnight", cmd)) {
			set_element(e->minute, FIRST_MINUTE, LAST_MINUTE,
			    FIRST_MINUTE);
			set_element(e->hour, FIRST_HOUR, LAST_HOUR, FIRST_HOUR);
			set_range(e->dom, FIRST_DOM, LAST_DOM, FIRST_DOM,
			    LAST_DOM, 1);
			set_range(e->month, FIRST_MONTH, LAST_MONTH,
			    FIRST_MONTH, LAST_MONTH, 1);
			set_range(e->dow, FIRST_DOW, LAST_DOW, FIRST_DOW,
			    LAST_DOW, 1);
		} else if (!strcmp("hourly", cmd)) {
			set_element(e->minute, FIRST_MINUTE, LAST_MINUTE,
			    FIRST_MINUTE);
			set_range(e->hour, FIRST_HOUR, LAST_HOUR, FIRST_HOUR,
			    LAST_HOUR, 1);
			set_range(e->dom, FIRST_DOM, LAST_DOM, FIRST_DOM,
			    LAST_DOM, 1);
			set_range(e->month, FIRST_MONTH, LAST_MONTH,
			    FIRST_MONTH, LAST_MONTH, 1);
			set_range(e->dow, FIRST_DOW, LAST_DOW,
			    FIRST_DOW, LAST_DOW, 1);
			e->flags |= HR_STAR;
		} else {
			ecode = e_timespec;
			goto eof;
		}
		/* Advance past whitespace between shortcut and
		 * username/command.
		 */
		Skip_Blanks(ch, file);
		if (ch == EOF || ch == '\n') {
			ecode = e_cmd;
			goto eof;
		}
	} else {
		if (ch == '*')
			e->flags |= MIN_STAR;
		ch = get_list(e->minute, FIRST_MINUTE, LAST_MINUTE,
		    NULL, ch, file);
		if (ch == EOF) {
			ecode = e_minute;
			goto eof;
		}

		/* hours
		 */

		if (ch == '*')
			e->flags |= HR_STAR;
		ch = get_list(e->hour, FIRST_HOUR, LAST_HOUR,
		    NULL, ch, file);
		if (ch == EOF) {
			ecode = e_hour;
			goto eof;
		}

		/* DOM (days of month)
		 */

		if (ch == '*')
			e->flags |= DOM_STAR;
		ch = get_list(e->dom, FIRST_DOM, LAST_DOM,
		    NULL, ch, file);
		if (ch == EOF) {
			ecode = e_dom;
			goto eof;
		}

		/* month
		 */

		ch = get_list(e->month, FIRST_MONTH, LAST_MONTH,
		    MonthNames, ch, file);
		if (ch == EOF) {
			ecode = e_month;
			goto eof;
		}

		/* DOW (days of week)
		 */

		if (ch == '*')
			e->flags |= DOW_STAR;
		ch = get_list(e->dow, FIRST_DOW, LAST_DOW,
		    DowNames, ch, file);
		if (ch == EOF) {
			ecode = e_dow;
			goto eof;
		}
	}

	/* make sundays equivalent */
	if (bit_test(e->dow, 0) || bit_test(e->dow, 7)) {
		bit_set(e->dow, 0);
		bit_set(e->dow, 7);
	}

	/* check for permature EOL and catch a common typo */
	if (ch == '\n' || ch == '*') {
		ecode = e_cmd;
		goto eof;
	}

	if (!pw) {
		char		*username = cmd;	/* temp buffer */

		unget_char(ch, file);
		ch = get_string(username, MAX_COMMAND, file, " \t\n");

		if (ch == EOF || ch == '\n' || ch == '*') {
			ecode = e_cmd;
			goto eof;
		}
		Skip_Blanks(ch, file)

		pw = getpwnam(username);
		if (pw == NULL) {
			ecode = e_username;
			goto eof;
		}
	}

	if ((e->pwd = pw_dup(pw)) == NULL) {
		ecode = e_memory;
		goto eof;
	}
	explicit_bzero(e->pwd->pw_passwd, strlen(e->pwd->pw_passwd));

	/* copy and fix up environment.  some variables are just defaults and
	 * others are overrides.
	 */
	if ((e->envp = env_copy(envp)) == NULL) {
		ecode = e_memory;
		goto eof;
	}
	if (!env_get("SHELL", e->envp)) {
		if (snprintf(envstr, sizeof envstr, "SHELL=%s", _PATH_BSHELL) >=
		    sizeof(envstr))
			syslog(LOG_ERR, "(CRON) ERROR (can't set SHELL)");
		else {
			if ((tenvp = env_set(e->envp, envstr)) == NULL) {
				ecode = e_memory;
				goto eof;
			}
			e->envp = tenvp;
		}
	}
	if (!env_get("HOME", e->envp)) {
		if (snprintf(envstr, sizeof envstr, "HOME=%s", pw->pw_dir) >=
		    sizeof(envstr))
			syslog(LOG_ERR, "(CRON) ERROR (can't set HOME)");
		else {
			if ((tenvp = env_set(e->envp, envstr)) == NULL) {
				ecode = e_memory;
				goto eof;
			}
			e->envp = tenvp;
		}
	}
	if (snprintf(envstr, sizeof envstr, "LOGNAME=%s", pw->pw_name) >=
		sizeof(envstr))
		syslog(LOG_ERR, "(CRON) ERROR (can't set LOGNAME)");
	else {
		if ((tenvp = env_set(e->envp, envstr)) == NULL) {
			ecode = e_memory;
			goto eof;
		}
		e->envp = tenvp;
	}
	if (snprintf(envstr, sizeof envstr, "USER=%s", pw->pw_name) >=
		sizeof(envstr))
		syslog(LOG_ERR, "(CRON) ERROR (can't set USER)");
	else {
		if ((tenvp = env_set(e->envp, envstr)) == NULL) {
			ecode = e_memory;
			goto eof;
		}
		e->envp = tenvp;
	}

	/* An optional series of '-'-prefixed flags in getopt style can
	 * occur before the command.
	 */
	while (ch == '-') {
		int flags = 0, loop = 1;

		while (loop) {
			switch (ch = get_char(file)) {
			case 'n':
				flags |= MAIL_WHEN_ERR;
				break;
			case 'q':
				flags |= DONT_LOG;
				break;
			case 's':
				flags |= SINGLE_JOB;
				break;
			case ' ':
			case '\t':
				Skip_Blanks(ch, file)
				loop = 0;
				break;
			case EOF:
			case '\n':
				ecode = e_cmd;
				goto eof;
			default:
				ecode = e_flags;
				goto eof;
			}
		}

		if (flags == 0) {
			ecode = e_flags;
			goto eof;
		}
		e->flags |= flags;
	}
	unget_char(ch, file);

	/* Everything up to the next \n or EOF is part of the command...
	 * too bad we don't know in advance how long it will be, since we
	 * need to malloc a string for it... so, we limit it to MAX_COMMAND.
	 */
	ch = get_string(cmd, MAX_COMMAND, file, "\n");

	/* a file without a \n before the EOF is rude, so we'll complain...
	 */
	if (ch == EOF) {
		ecode = e_cmd;
		goto eof;
	}

	/* got the command in the 'cmd' string; save it in *e.
	 */
	if ((e->cmd = strdup(cmd)) == NULL) {
		ecode = e_memory;
		goto eof;
	}

	/* success, fini, return pointer to the entry we just created...
	 */
	return (e);

 eof:
	if (e)
		free_entry(e);
	while (ch != '\n' && !feof(file))
		ch = get_char(file);
	if (ecode != e_none && error_func)
		(*error_func)(ecodes[(int)ecode]);
	return (NULL);
}

static int
get_list(bitstr_t *bits, int low, int high, const char *names[],
	 int ch, FILE *file)
{
	int done;

	/* we know that we point to a non-blank character here;
	 * must do a Skip_Blanks before we exit, so that the
	 * next call (or the code that picks up the cmd) can
	 * assume the same thing.
	 */

	/* list = range {"," range}
	 */

	/* clear the bit string, since the default is 'off'.
	 */
	bit_nclear(bits, 0, high - low);

	/* process all ranges
	 */
	done = FALSE;
	while (!done) {
		if ((ch = get_range(bits, low, high, names, ch, file)) == EOF)
			return (EOF);
		if (ch == ',')
			ch = get_char(file);
		else
			done = TRUE;
	}

	/* exiting.  skip to some blanks, then skip over the blanks.
	 */
	Skip_Nonblanks(ch, file)
	Skip_Blanks(ch, file)

	return (ch);
}


static int
get_range(bitstr_t *bits, int low, int high, const char *names[],
	  int ch, FILE *file)
{
	/* range = number |
	 * [number] "~" [number] ["/" number] |
	 * number "-" number ["/" number]
	 */

	int num1, num2, num3, rndstep;

	num1 = low;
	num2 = high;
	rndstep = 0;

	if (ch == '*') {
		/* '*' means [low, high] but can still be modified by /step
		 */
		ch = get_char(file);
		if (ch == EOF)
			return (EOF);
	} else {
		if (ch != '~') {
			ch = get_number(&num1, low, names, ch, file, ",-~ \t\n");
			if (ch == EOF)
				return (EOF);
		}

		switch (ch) {
		case '-':
			/* eat the dash
			 */
			ch = get_char(file);
			if (ch == EOF)
				return (EOF);

			/* get the number following the dash
			 */
			ch = get_number(&num2, low, names, ch, file, "/, \t\n");
			if (ch == EOF || num1 > num2)
				return (EOF);
			break;
		case '~':
			/* eat the tilde
			 */
			ch = get_char(file);
			if (ch == EOF)
				return (EOF);

			/* get the (optional) number following the tilde
			 */
			ch = get_number(&num2, low, names, ch, file, "/, \t\n");
			if (ch == EOF) {
				/* no second number, check for valid terminator
				 */
				ch = get_char(file);
				if (!strchr("/, \t\n", ch)) {
					unget_char(ch, file);
					return (EOF);
				}
			}
			if (ch == EOF || num1 > num2) {
				unget_char(ch, file);
				return (EOF);
			}

			/* we must perform the bounds checking ourselves
			 */
			if (num1 < low || num2 > high)
				return (EOF);

			if (ch == '/') {
				/* randomize the step value instead of num1
				 */
				rndstep = 1;
				break;
			}

			/* get a random number in the interval [num1, num2]
			 */
			num3 = num1;
			num1 = arc4random_uniform(num2 - num3 + 1) + num3;
			/* FALLTHROUGH */
		default:
			/* not a range, it's a single number.
			 */
			if (set_element(bits, low, high, num1) == EOF) {
				unget_char(ch, file);
				return (EOF);
			}
			return (ch);
		}
	}

	/* check for step size
	 */
	if (ch == '/') {
		/* eat the slash
		 */
		ch = get_char(file);
		if (ch == EOF)
			return (EOF);

		/* get the step size -- note: we don't pass the
		 * names here, because the number is not an
		 * element id, it's a step size.  'low' is
		 * sent as a 0 since there is no offset either.
		 */
		ch = get_number(&num3, 0, NULL, ch, file, ", \t\n");
		if (ch == EOF || num3 == 0)
			return (EOF);
		if (rndstep) {
			/*
			 * use a random offset smaller than the step size
			 * and the difference between high and low values.
			 */
			num1 += arc4random_uniform(MINIMUM(num3, num2 - num1));
		}
	} else {
		/* no step.  default==1.
		 */
		num3 = 1;
	}

	/* range. set all elements from num1 to num2, stepping
	 * by num3.  (the step is a downward-compatible extension
	 * proposed conceptually by bob@acornrc, syntactically
	 * designed then implemented by paul vixie).
	 */
	if (set_range(bits, low, high, num1, num2, num3) == EOF) {
		unget_char(ch, file);
		return (EOF);
	}

	return (ch);
}

static int
get_number(int *numptr, int low, const char *names[], int ch, FILE *file,
    const char *terms)
{
	char temp[MAX_TEMPSTR], *pc;
	int len, i;

	pc = temp;
	len = 0;

	/* first look for a number */
	while (isdigit((unsigned char)ch)) {
		if (++len >= MAX_TEMPSTR)
			goto bad;
		*pc++ = ch;
		ch = get_char(file);
	}
	*pc = '\0';
	if (len != 0) {
		/* got a number, check for valid terminator */
		if (!strchr(terms, ch))
			goto bad;
		*numptr = atoi(temp);
		return (ch);
	}

	/* no numbers, look for a string if we have any */
	if (names) {
		while (isalpha((unsigned char)ch)) {
			if (++len >= MAX_TEMPSTR)
				goto bad;
			*pc++ = ch;
			ch = get_char(file);
		}
		*pc = '\0';
		if (len != 0 && strchr(terms, ch)) {
			for (i = 0;  names[i] != NULL;  i++) {
				if (!strcasecmp(names[i], temp)) {
					*numptr = i+low;
					return (ch);
				}
			}
		}
	}

bad:
	unget_char(ch, file);
	return (EOF);
}

static int
set_element(bitstr_t *bits, int low, int high, int number)
{

	if (number < low || number > high)
		return (EOF);
	number -= low;

	bit_set(bits, number);
	return (0);
}

static int
set_range(bitstr_t *bits, int low, int high, int start, int stop, int step)
{
	int i;

	if (start < low || stop > high)
		return (EOF);
	start -= low;
	stop -= low;

	if (step == 1) {
		bit_nset(bits, start, stop);
	} else {
		for (i = start; i <= stop; i += step)
			bit_set(bits, i);
	}
	return (0);
}