OpenBSD CVS

CVS log for src/usr.sbin/cron/env.c


[BACK] Up to [local] / src / usr.sbin / cron

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.34 / (download) - annotate - [select for diffs], Sat May 21 01:21:29 2022 UTC (2 years ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, HEAD
Changes since 1.33: +2 -2 lines
Diff to previous 1.33 (colored)

repair a few more backwards compares that create headaches
ok millert

Revision 1.33 / (download) - annotate - [select for diffs], Wed Jun 7 23:36:43 2017 UTC (6 years, 11 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.32: +8 -7 lines
Diff to previous 1.32 (colored)

In cron(8), require that crontab and at files in the spool be owned
by group crontab.  The at(1) command now creates files owned by
group crontab, the crontab(1) command already does this.

Files in the crontab spool with parse errors are now ignored;
crontab(1) will not install a crontab file with parse errors.
The system crontab file (/etc/crontab) is not affected by this.

The required permissions on crontab files have been tightened.
Files in the cron spool must be mode 0600 (as created by crontab(1)).
The system crontab file may be readable/writable by the owner,
readable by group and readable by other.  The system crontab must
be readable by the owner.

Revision 1.32 / (download) - annotate - [select for diffs], Wed Nov 4 20:28:17 2015 UTC (8 years, 6 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.31: +15 -2 lines
Diff to previous 1.31 (colored)

Change cron from including all headers in every file to only including
what each .c file needs.  I have not removed cron.h since it will
be used in a future clean up of the cron's .h files.  OK nicm@

Revision 1.31 / (download) - annotate - [select for diffs], Thu Oct 29 21:24:09 2015 UTC (8 years, 7 months ago) by millert
Branch: MAIN
Changes since 1.30: +2 -2 lines
Diff to previous 1.30 (colored)

remove unused variables

Revision 1.30 / (download) - annotate - [select for diffs], Thu Oct 29 21:19:09 2015 UTC (8 years, 7 months ago) by millert
Branch: MAIN
Changes since 1.29: +50 -50 lines
Diff to previous 1.29 (colored)

Convert env_get() into env_find() similar to __findenv() in libc.
Use env_find() in both env_get() and env_set() to find a var in envp.
Remove now-unused strcmp_until() function.

Revision 1.29 / (download) - annotate - [select for diffs], Mon Feb 9 22:35:08 2015 UTC (9 years, 3 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.28: +1 -5 lines
Diff to previous 1.28 (colored)

correct copyright, upon approval from paul vixie via todd miller.  the
head copyright assertion was seperated from the remaining ones.

Revision 1.28 / (download) - annotate - [select for diffs], Fri Jan 23 19:07:27 2015 UTC (9 years, 4 months ago) by tedu
Branch: MAIN
Changes since 1.27: +13 -7 lines
Diff to previous 1.27 (colored)

braces to open a function go on their own line like god intended

Revision 1.27 / (download) - annotate - [select for diffs], Fri Jan 23 02:37:25 2015 UTC (9 years, 4 months ago) by tedu
Branch: MAIN
Changes since 1.26: +3 -3 lines
Diff to previous 1.26 (colored)

Remove the OK and ERR macros. They obfuscate the code and don't
help legibility. (unix system calls use 0 for ok, but hundreds of
other projects use 1 to indicate success.) Despite the name, many
system calls (e.g., open) also return not OK values for success.
It also cleans up some weird code like int crontab_fd = OK - 1;
This diff is mechanical in nature. Later I will fix the bugs it reveals.
ok deraadt

Revision 1.26 / (download) - annotate - [select for diffs], Fri Jan 23 01:01:06 2015 UTC (9 years, 4 months ago) by tedu
Branch: MAIN
Changes since 1.25: +1 -5 lines
Diff to previous 1.25 (colored)

remove debug code.
I think the level of debug code in cron is excessive for a program
that has reached feature complete. If cron needs to provide more
information to the user about its operational status, I think syslog
would be more appropriate. (The debug flags also disable forking
into the background, so they aren't even that useful for debugging a
live system.)
ok deraadt millert

Revision 1.25 / (download) - annotate - [select for diffs], Wed Jan 14 18:28:15 2015 UTC (9 years, 4 months ago) by millert
Branch: MAIN
Changes since 1.24: +3 -3 lines
Diff to previous 1.24 (colored)

Use reallocarray() instead of calloc() when making a copy of the
environment.  We already explicitly NULL terminate the array.

Revision 1.24 / (download) - annotate - [select for diffs], Wed Oct 8 04:20:57 2014 UTC (9 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.23: +2 -3 lines
Diff to previous 1.23 (colored)

use reallocarray() instead of realloc() to handle potential integer overflow; ok doug

Revision 1.23 / (download) - annotate - [select for diffs], Tue Jan 18 14:29:21 2011 UTC (13 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9
Changes since 1.22: +4 -1 lines
Diff to previous 1.22 (colored)

Quiet a gcc warning

Revision 1.22 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:51 2009 UTC (14 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.21: +1 -5 lines
Diff to previous 1.21 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.21 / (download) - annotate - [select for diffs], Fri Feb 29 23:33:29 2008 UTC (16 years, 3 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.20: +3 -3 lines
Diff to previous 1.20 (colored)

no , at end of enum; tobiasu@tmux.org

Revision 1.20 / (download) - annotate - [select for diffs], Mon Sep 10 14:29:53 2007 UTC (16 years, 8 months ago) by tobias
Branch: MAIN
Changes since 1.19: +3 -3 lines
Diff to previous 1.19 (colored)

Proper use of fseek/fseeko macros.

OK joris@, otto@

Revision 1.19 / (download) - annotate - [select for diffs], Sun Sep 2 15:19:38 2007 UTC (16 years, 9 months ago) by deraadt
Branch: MAIN
Changes since 1.18: +3 -3 lines
Diff to previous 1.18 (colored)

use calloc() to avoid malloc(n * m) overflows; checked by djm canacar jsg

Revision 1.18 / (download) - annotate - [select for diffs], Sun Jan 30 20:44:50 2005 UTC (19 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7
Changes since 1.17: +2 -3 lines
Diff to previous 1.17 (colored)

fix some whitespace

Revision 1.17 / (download) - annotate - [select for diffs], Tue Jun 22 03:15:33 2004 UTC (19 years, 11 months ago) by avsm
Branch: MAIN
CVS Tags: OPENBSD_3_6_BASE, OPENBSD_3_6
Changes since 1.16: +3 -3 lines
Diff to previous 1.16 (colored)

use snprintf(3) instead of home-grown glue_strings() function
millert@ ok

Revision 1.16 / (download) - annotate - [select for diffs], Thu Jun 17 22:11:55 2004 UTC (19 years, 11 months ago) by millert
Branch: MAIN
Changes since 1.15: +10 -10 lines
Diff to previous 1.15 (colored)

UUpdate ISC copyright year to 2004
Remove unused macros Skip_Line and MkLower
Remove trailing whitespace

Revision 1.15 / (download) - annotate - [select for diffs], Fri Feb 21 16:47:29 2003 UTC (21 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4, OPENBSD_3_3_BASE, OPENBSD_3_3
Changes since 1.14: +90 -28 lines
Diff to previous 1.14 (colored)

Improved environment variable parser from FreeBSD (Thomas Quinot).
Fixes some issues with quoting and allows no longer mistakes commands
starting with a variable assignment for environment variables.

Revision 1.14 / (download) - annotate - [select for diffs], Thu Feb 20 20:38:08 2003 UTC (21 years, 3 months ago) by millert
Branch: MAIN
Changes since 1.13: +3 -2 lines
Diff to previous 1.13 (colored)

Sync with ISC cron-current + my at(1) integration.
The at(1) code is now more tightly integrated into the cron codebase.

Revision 1.13 / (download) - annotate - [select for diffs], Thu Jul 11 20:15:40 2002 UTC (21 years, 10 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.12: +16 -16 lines
Diff to previous 1.12 (colored)

More syncing with my cron 4.0 patch tree, basically cosmetic:
o change an instance of e_none to e_memory that I missed (forgot?)
o kill some whitespace
o modify malloc failure recovery a bit

Revision 1.12 / (download) - annotate - [select for diffs], Tue Jul 9 18:59:12 2002 UTC (21 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.11: +5 -5 lines
Diff to previous 1.11 (colored)

o Add _PATH_CRON_PID which is built up from PIDDIR and PIDFILE via string
concatenation at compile time rather than run time.

o Some minor cosmetic changes to simplify diffing.

Revision 1.11 / (download) - annotate - [select for diffs], Mon Jul 8 23:42:17 2002 UTC (21 years, 10 months ago) by millert
Branch: MAIN
Changes since 1.10: +3 -3 lines
Diff to previous 1.10 (colored)

minor cosmetic change to reduce diffs

Revision 1.10 / (download) - annotate - [select for diffs], Mon Jul 8 18:11:02 2002 UTC (21 years, 11 months ago) by millert
Branch: MAIN
Changes since 1.9: +20 -41 lines
Diff to previous 1.9 (colored)

Merge in some changes from Paul Vixie's tree; most are cosmetic
o ANSI function headers
o return (foo) not return foo
o add -oi to sendmail flags
o update email address in man pages
o make some strings const
o completely remove globbing cruft from popen.c
o whitespace changes
o add DOW_STAR to flags for "monthly", "weekly", and "daily" cron entries

Revision 1.9 / (download) - annotate - [select for diffs], Sun Feb 18 20:17:20 2001 UTC (23 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1, OPENBSD_3_0_BASE, OPENBSD_3_0, OPENBSD_2_9_BASE, OPENBSD_2_9
Changes since 1.8: +3 -3 lines
Diff to previous 1.8 (colored)

NULL vs '\0'

Revision 1.8 / (download) - annotate - [select for diffs], Sun Feb 18 19:48:34 2001 UTC (23 years, 3 months ago) by millert
Branch: MAIN
Changes since 1.7: +54 -50 lines
Diff to previous 1.7 (colored)

Update to ISC cron 4.0b1 + our patches.  This is now under a BSD license.
I also fixed the signal handlers while I was at it.

Revision 1.7 / (download) - annotate - [select for diffs], Mon Aug 21 21:08:56 2000 UTC (23 years, 9 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_8_BASE, OPENBSD_2_8
Changes since 1.6: +2 -2 lines
Diff to previous 1.6 (colored)

snprintf sprinkles; solar@false.com & I

Revision 1.6 / (download) - annotate - [select for diffs], Mon Aug 21 20:57:21 2000 UTC (23 years, 9 months ago) by deraadt
Branch: MAIN
Changes since 1.5: +2 -2 lines
Diff to previous 1.5 (colored)

strncpy not safe on overlapping strings

Revision 1.5 / (download) - annotate - [select for diffs], Mon Mar 30 06:59:44 1998 UTC (26 years, 2 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_7_BASE, OPENBSD_2_7, OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4, OPENBSD_2_3_BASE, OPENBSD_2_3
Changes since 1.4: +2 -2 lines
Diff to previous 1.4 (colored)

Y2K fixes from Andreas.Gunnarsson@emw.ericsson.se; culled from various places

Revision 1.4 / (download) - annotate - [select for diffs], Fri Nov 1 23:27:33 1996 UTC (27 years, 7 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_2_BASE, OPENBSD_2_2, OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.3: +27 -5 lines
Diff to previous 1.3 (colored)

Check malloc/strdup ret val and deal.

Revision 1.3 / (download) - annotate - [select for diffs], Fri Oct 25 20:36:56 1996 UTC (27 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.2: +3 -1 lines
Diff to previous 1.2 (colored)

proactive buf check

Revision 1.2 / (download) - annotate - [select for diffs], Wed Sep 25 02:06:27 1996 UTC (27 years, 8 months ago) by bitblt
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.1: +2 -2 lines
Diff to previous 1.1 (colored)

Fixed buffer overflow.

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:47:30 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:47:30 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.