OpenBSD CVS

CVS log for src/usr.sbin/dhcpd/bpf.c


[BACK] Up to [local] / src / usr.sbin / dhcpd

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.20 / (download) - annotate - [select for diffs], Mon Mar 18 00:00:59 2019 UTC (5 years, 2 months ago) by dlg
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, HEAD
Changes since 1.19: +3 -2 lines
Diff to previous 1.19 (colored)

explicitly use BPF_FILDROP_CAPTURE when configuring BIOCSFILDROP

BIOCSFILDROP used to just be a flag, ie, any non-zero value was
treated the same, but i'm changing it so different values do different
things. this way the programs should keep working even if i decide
to change the values for these macros.

Revision 1.19 / (download) - annotate - [select for diffs], Wed Apr 19 05:36:12 2017 UTC (7 years, 1 month ago) by natano
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.18: +2 -2 lines
Diff to previous 1.18 (colored)

Switch base tools from /dev/bpf0 to /dev/bpf. Now that /dev/bpf has been
around for two releases, it should be safe to do so.

ok bluhm deraadt sthen tb yasuoka

Revision 1.18 / (download) - annotate - [select for diffs], Tue Apr 18 13:59:09 2017 UTC (7 years, 1 month ago) by krw
Branch: MAIN
Changes since 1.17: +5 -5 lines
Diff to previous 1.17 (colored)

Tweak parameters to decode_*, add a check or two, and thus gain most of the
sanity improvements reyk@ recently put into dhcrelay to ensure no more than
the captured packet is processed.

Revision 1.17 / (download) - annotate - [select for diffs], Tue Apr 18 13:44:03 2017 UTC (7 years, 1 month ago) by krw
Branch: MAIN
Changes since 1.16: +3 -3 lines
Diff to previous 1.16 (colored)

After 11 years of pondering about it I think that brookdavis@freebsd.org
had it correct. Don't BPF_WORDALIGN() the value for the number of
bytes read() into the buffer. This could theoretically cause the
processing of 1 - 3 more bytes than were read.

Revision 1.16 / (download) - annotate - [select for diffs], Mon Feb 13 23:04:05 2017 UTC (7 years, 3 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.15: +12 -13 lines
Diff to previous 1.15 (colored)

Eliminate pointless'%m' (a.k.a. hand rolled strerror()) by using fatal() and
log_warn(). Zap a couple of explicit 'syslog()' calls.

Revision 1.15 / (download) - annotate - [select for diffs], Mon Feb 13 19:13:14 2017 UTC (7 years, 3 months ago) by krw
Branch: MAIN
Changes since 1.14: +15 -14 lines
Diff to previous 1.14 (colored)

Switch from old errwarn.c logging to shiny new log.[ch].

ok benno@

Revision 1.14 / (download) - annotate - [select for diffs], Sat May 28 07:00:18 2016 UTC (8 years ago) by natano
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.13: +6 -19 lines
Diff to previous 1.13 (colored)

Replace the /dev/bpf* open loop with a plain open("/dev/bpf0", ...).
ok deraadt jca

Revision 1.13 / (download) - annotate - [select for diffs], Sat Feb 6 23:50:10 2016 UTC (8 years, 3 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.12: +19 -5 lines
Diff to previous 1.12 (colored)

Eliminate #include inside *.h files and include only needed headers in
each *.c file.

Inspired by mention of header silliness by Edgar Pettijohn and mmcc@
on tech@.

Revision 1.12 / (download) - annotate - [select for diffs], Sat Oct 25 03:23:49 2014 UTC (9 years, 7 months ago) by lteo
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.11: +1 -2 lines
Diff to previous 1.11 (colored)

Remove unnecessary netinet/in_systm.h include.

ok millert@

Revision 1.11 / (download) - annotate - [select for diffs], Fri Jul 11 09:42:27 2014 UTC (9 years, 10 months ago) by yasuoka
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.10: +5 -1 lines
Diff to previous 1.10 (colored)

Add -u option to bind UDP port as a socket to answer DHCPINFORM from
the clients on non ethernet interfaces (eg. tun(4) or pppx(4)).

input krw
ok krw

Revision 1.10 / (download) - annotate - [select for diffs], Fri Apr 5 19:31:36 2013 UTC (11 years, 1 month ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4
Changes since 1.9: +3 -2 lines
Diff to previous 1.9 (colored)

send_packet() and writev() return ssize_t, not int. Use correct
type to store the returned value. From dhill.

Revision 1.9 / (download) - annotate - [select for diffs], Sun Feb 3 21:04:19 2013 UTC (11 years, 3 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_5_3_BASE, OPENBSD_5_3
Changes since 1.8: +2 -2 lines
Diff to previous 1.8 (colored)

Remove unused (a.k.a. always passed NULL) parameter 'data' from
decode_udp_ip_header() and the useless check of it. Part of original
diff from pelikan about udp length errors.

Revision 1.8 / (download) - annotate - [select for diffs], Mon Dec 14 22:12:14 2009 UTC (14 years, 5 months ago) by mpf
Branch: MAIN
CVS Tags: OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.7: +4 -1 lines
Diff to previous 1.7 (colored)

Just like dhclient(8), we use the bpf filter drop to prevent
us from sending an icmp error along with the dhcp reply.
OK henning@

Revision 1.7 / (download) - annotate - [select for diffs], Mon Sep 15 20:38:17 2008 UTC (15 years, 8 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.6: +11 -11 lines
Diff to previous 1.6 (colored)

When checking if a syscall like open(), ioctl() or writev() failed compare
directly against -1 and do not use a < 0 test. OK henning@

Revision 1.6 / (download) - annotate - [select for diffs], Fri Jul 29 17:26:28 2005 UTC (18 years, 10 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8
Changes since 1.5: +13 -7 lines
Diff to previous 1.5 (colored)

Fix erroneous use of '=' instead of '+' that caused infinite loops
when skipping packets. Use BPF_WORDALIGN() to properly skip packets.
From Brooks Davis at FreeBSD.

ok deraadt@ henning@

Revision 1.5 / (download) - annotate - [select for diffs], Thu Sep 16 18:35:42 2004 UTC (19 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_7_BASE, OPENBSD_3_7
Changes since 1.4: +2 -2 lines
Diff to previous 1.4 (colored)

avoid aliasing with libc functions; ok henning

Revision 1.4 / (download) - annotate - [select for diffs], Tue May 4 20:28:40 2004 UTC (20 years, 1 month ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_6_BASE, OPENBSD_3_6
Changes since 1.3: +4 -4 lines
Diff to previous 1.3 (colored)

remove things not used, spotted by lint mostly; ok henning

Revision 1.3 / (download) - annotate - [select for diffs], Wed Apr 21 09:11:58 2004 UTC (20 years, 1 month ago) by canacar
Branch: MAIN
Changes since 1.2: +58 -14 lines
Diff to previous 1.2 (colored)

filter writes and lock bpf descriptor, ok henning@

Revision 1.2 / (download) - annotate - [select for diffs], Thu Apr 15 23:17:19 2004 UTC (20 years, 1 month ago) by henning
Branch: MAIN
Changes since 1.1: +2 -2 lines
Diff to previous 1.1 (colored)

dhcpd actually does not listen on port 68 ...

Revision 1.1 / (download) - annotate - [select for diffs], Tue Apr 13 23:41:48 2004 UTC (20 years, 1 month ago) by henning
Branch: MAIN

may the whacking begin

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.