OpenBSD CVS

CVS log for src/usr.sbin/dhcpd/packet.c


[BACK] Up to [local] / src / usr.sbin / dhcpd

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.14 / (download) - annotate - [select for diffs], Tue Apr 18 13:59:09 2017 UTC (7 years, 1 month ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, HEAD
Changes since 1.13: +15 -13 lines
Diff to previous 1.13 (colored)

Tweak parameters to decode_*, add a check or two, and thus gain most of the
sanity improvements reyk@ recently put into dhcrelay to ensure no more than
the captured packet is processed.

Revision 1.13 / (download) - annotate - [select for diffs], Mon Apr 17 18:31:08 2017 UTC (7 years, 1 month ago) by krw
Branch: MAIN
Changes since 1.12: +3 -6 lines
Diff to previous 1.12 (colored)

Use better types for checksum() parameters and local var from
dhclient. Eliminate extra prototypes for checksum() and wrapsum().

Revision 1.12 / (download) - annotate - [select for diffs], Mon Feb 13 19:13:14 2017 UTC (7 years, 3 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.11: +7 -6 lines
Diff to previous 1.11 (colored)

Switch from old errwarn.c logging to shiny new log.[ch].

ok benno@

Revision 1.11 / (download) - annotate - [select for diffs], Sat Feb 6 23:50:10 2016 UTC (8 years, 4 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.10: +13 -2 lines
Diff to previous 1.10 (colored)

Eliminate #include inside *.h files and include only needed headers in
each *.c file.

Inspired by mention of header silliness by Edgar Pettijohn and mmcc@
on tech@.

Revision 1.10 / (download) - annotate - [select for diffs], Wed Feb 3 14:48:36 2016 UTC (8 years, 4 months ago) by krw
Branch: MAIN
Changes since 1.9: +30 -7 lines
Diff to previous 1.9 (colored)

be very careful accepting packets via bpf. First check that the
fixed part of the IP header is completely present before using its
header length field.  Then use the data in the IP header to ensure
the entire IP packet is present. Then check that the entire UDP header
is present. Then use the data in the UDP header to ensure all the
data it thinks is present is actually present.

Started when tj@ and a few others noticed ISC "DHCP CVE-2015-8605:
UDP payload length not properly checked".

ok sthen@ henning@

Revision 1.9 / (download) - annotate - [select for diffs], Sat Oct 25 03:23:49 2014 UTC (9 years, 7 months ago) by lteo
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.8: +1 -2 lines
Diff to previous 1.8 (colored)

Remove unnecessary netinet/in_systm.h include.

ok millert@

Revision 1.8 / (download) - annotate - [select for diffs], Mon Aug 18 20:58:56 2014 UTC (9 years, 9 months ago) by tobias
Branch: MAIN
Changes since 1.7: +10 -10 lines
Diff to previous 1.7 (colored)

Variables to count seen packets should be unsigned.

ok krw@

Revision 1.7 / (download) - annotate - [select for diffs], Sat Jul 26 07:48:49 2014 UTC (9 years, 10 months ago) by tobias
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.6: +4 -3 lines
Diff to previous 1.6 (colored)

Fix very hard to reach DoS attack vector, which would involve more than
8 billion network packets.  Mixture of many many malformed and proper
packets could result in a division by zero.

ok krw@

Revision 1.6 / (download) - annotate - [select for diffs], Thu Dec 5 21:03:40 2013 UTC (10 years, 6 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.5: +4 -6 lines
Diff to previous 1.5 (colored)

Nuke local #define ETHER_HEADER_SIZE and use the identical value'd
ETHER_HDR_LEN from if_ether.h. dhclient change ok matthew@ as part
of larger diff.

Revision 1.5 / (download) - annotate - [select for diffs], Sun Feb 3 21:04:19 2013 UTC (11 years, 4 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3
Changes since 1.4: +21 -22 lines
Diff to previous 1.4 (colored)

Remove unused (a.k.a. always passed NULL) parameter 'data' from
decode_udp_ip_header() and the useless check of it. Part of original
diff from pelikan about udp length errors.

Revision 1.4 / (download) - annotate - [select for diffs], Sat Jan 5 12:34:53 2013 UTC (11 years, 5 months ago) by krw
Branch: MAIN
Changes since 1.3: +2 -2 lines
Diff to previous 1.3 (colored)

Check UDP length field for short as well as long values. Fixes a
dhcpd crash when a UDP packet arrives saying it has 0 length.

Spotted by Martin Pelikan, who also noted it was fixed a while ago
in ISC DHCP 3.0b2p17.

Fix tested by Martin. Thanks!

Revision 1.3 / (download) - annotate - [select for diffs], Wed Apr 21 09:11:58 2004 UTC (20 years, 1 month ago) by canacar
Branch: MAIN
CVS Tags: OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7, OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6
Changes since 1.2: +7 -11 lines
Diff to previous 1.2 (colored)

filter writes and lock bpf descriptor, ok henning@

Revision 1.2 / (download) - annotate - [select for diffs], Wed Apr 14 00:56:02 2004 UTC (20 years, 1 month ago) by henning
Branch: MAIN
Changes since 1.1: +1 -4 lines
Diff to previous 1.1 (colored)

more crap bites the dust

Revision 1.1 / (download) - annotate - [select for diffs], Tue Apr 13 23:41:49 2004 UTC (20 years, 2 months ago) by henning
Branch: MAIN

may the whacking begin

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.