OpenBSD CVS

CVS log for src/usr.sbin/eeprom/optree.c


[BACK] Up to [local] / src / usr.sbin / eeprom

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.11 / (download) - annotate - [select for diffs], Sun Oct 24 21:24:18 2021 UTC (2 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, HEAD
Changes since 1.10: +2 -2 lines
Diff to previous 1.10 (colored)

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant.  Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk.  They could all be 0xdeafbeef.
ok millert

Revision 1.10 / (download) - annotate - [select for diffs], Fri Jun 28 13:32:47 2019 UTC (4 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.9: +7 -7 lines
Diff to previous 1.9 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.9 / (download) - annotate - [select for diffs], Fri Oct 20 10:32:03 2017 UTC (6 years, 7 months ago) by kettenis
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3
Changes since 1.8: +13 -12 lines
Diff to previous 1.8 (colored)

Tweak heuristics to make sure /memory properties are more likely to be
printed as hex.

ok visa@

Revision 1.8 / (download) - annotate - [select for diffs], Sat May 21 19:08:29 2016 UTC (8 years ago) by kettenis
Branch: MAIN
CVS Tags: OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.7: +4 -2 lines
Diff to previous 1.7 (colored)

Byteswap 32-bit "cells" on little-endian platforms before printing them.
OpenFirware/FDT is defined to be big-endian.  This makes eeprom -p print
sensible numbers on little-endian platforms.

ok deraadt@

Revision 1.7 / (download) - annotate - [select for diffs], Sat May 21 19:06:15 2016 UTC (8 years ago) by kettenis
Branch: MAIN
Changes since 1.6: +2 -1 lines
Diff to previous 1.6 (colored)

Zero op_name when we start enumerating properties such that we don't risk
skipping the properties of the root node when the lookup of random stack
garbage fails.

ok deraadt@

Revision 1.6 / (download) - annotate - [select for diffs], Wed Jan 14 21:05:53 2009 UTC (15 years, 4 months ago) by fgsch
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9, OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7, OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7, OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.5: +13 -21 lines
Diff to previous 1.5 (colored)

update license.

Revision 1.5 / (download) - annotate - [select for diffs], Sun Mar 23 12:05:43 2008 UTC (16 years, 2 months ago) by miod
Branch: MAIN
CVS Tags: OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.4: +10 -4 lines
Diff to previous 1.4 (colored)

Do not abort walking the tree if a node's contents is too large; allows
eeprom -p to be used on more macppc models.
ok fgsch@

Revision 1.4 / (download) - annotate - [select for diffs], Fri Feb 22 20:23:19 2008 UTC (16 years, 3 months ago) by kettenis
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.3: +23 -6 lines
Diff to previous 1.3 (colored)

Allow multiple NUL characters within string-valued properties (but add an
XXX saying that this may not exactly be what we want).  This makes the output
on macppc look much saner.

ok fgsch@, beck@

Revision 1.3 / (download) - annotate - [select for diffs], Mon Nov 12 20:54:54 2007 UTC (16 years, 7 months ago) by kettenis
Branch: MAIN
Changes since 1.2: +7 -4 lines
Diff to previous 1.2 (colored)

Make this compile on macppc (OpenPROM support only) and build it there.

ok deraadt@

Revision 1.2 / (download) - annotate - [select for diffs], Sun Sep 9 14:19:28 2007 UTC (16 years, 9 months ago) by fgsch
Branch: MAIN
Changes since 1.1: +15 -9 lines
Diff to previous 1.1 (colored)

better printing code, fixing certain properties; reported by kettenis,
tested by him and Johan Mson Lindman.  ok kettenis.

Revision 1.1 / (download) - annotate - [select for diffs], Tue Sep 4 23:28:26 2007 UTC (16 years, 9 months ago) by fgsch
Branch: MAIN

add support to print the derivated tree from the OpenPROM (alas devinfo or
prtconf); ok kettenis@.
thanks to the various people who helped me test in different sparc* machines.

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.