OpenBSD CVS

CVS log for src/usr.sbin/hotplugd/hotplugd.c


[BACK] Up to [local] / src / usr.sbin / hotplugd

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.19 / (download) - annotate - [select for diffs], Wed Mar 8 04:43:13 2023 UTC (15 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, HEAD
Changes since 1.18: +1 -3 lines
Diff to previous 1.18 (colored)

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

Revision 1.18 / (download) - annotate - [select for diffs], Sun Dec 4 23:50:50 2022 UTC (18 months ago) by cheloha
Branch: MAIN
Changes since 1.17: +1 -2 lines
Diff to previous 1.17 (colored)

userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument.  We can
handle this case with the "default" failure case with no loss of
legibility.  Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@.  With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

Revision 1.17 / (download) - annotate - [select for diffs], Mon Jul 12 15:09:21 2021 UTC (2 years, 10 months ago) by beck
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0
Changes since 1.16: +5 -5 lines
Diff to previous 1.16 (colored)

Change the error reporting pattern throughout the tree when unveil
fails to report the path that the failure occured on. Suggested by
deraadt@ after some tech discussion.

Work done and verified by Ashton Fagg <ashton@fagg.id.au>

ok deraadt@ semarie@ claudio@

Revision 1.16 / (download) - annotate - [select for diffs], Thu Oct 15 19:45:50 2020 UTC (3 years, 7 months ago) by naddy
Branch: MAIN
CVS Tags: OPENBSD_6_9_BASE, OPENBSD_6_9
Changes since 1.15: +6 -2 lines
Diff to previous 1.15 (colored)

Accommodate POSIX basename(3) that takes a non-const parameter and
may modify the string buffer.
ok florian@

Revision 1.15 / (download) - annotate - [select for diffs], Tue Apr 30 17:05:15 2019 UTC (5 years, 1 month ago) by mestre
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.14: +10 -4 lines
Diff to previous 1.14 (colored)

Restrict filesystem access with unveil(2):

First it needs to open(2) `device' with read permissions, /dev/hotplug by
default but can be changed via arguments. Then it needs read/execute on both
_PATH_ETC_HOTPLUG_{ATTACH,DETACH} to access(2) and execl(3) them.

ok deraadt@

Revision 1.14 / (download) - annotate - [select for diffs], Sun Jul 31 20:13:12 2016 UTC (7 years, 10 months ago) by natano
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.13: +2 -2 lines
Diff to previous 1.13 (colored)

Close /dev/hotplug on exec(). Otherwise a restart of the daemon may
fail, because the device is occupied by a child process.

from Alexey Vatchenko
ok jca

Revision 1.13 / (download) - annotate - [select for diffs], Thu Nov 19 06:05:40 2015 UTC (8 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.12: +4 -1 lines
Diff to previous 1.12 (colored)

pledge "stdio rpath proc exec" for entire lifetime.  rpath must remain
even late, because of access() before doing wasteful fork+execs.

Revision 1.12 / (download) - annotate - [select for diffs], Sun Jan 10 13:20:41 2010 UTC (14 years, 5 months ago) by grange
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7, OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.11: +4 -3 lines
Diff to previous 1.11 (colored)

Make hotplugd to not complain if any of attach or detach script
doesn't exist.

ok stsp@ deraadt@

Revision 1.11 / (download) - annotate - [select for diffs], Fri Jun 26 01:06:04 2009 UTC (14 years, 11 months ago) by kurt
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6
Changes since 1.10: +10 -5 lines
Diff to previous 1.10 (colored)

If two or more children exit before hotplugd is scheduled only one SIGCHLD
will be delivered, so deal with this case in the SIGCHLD handler. Also
retry if waitpid() fails with EINTR. looks good deraadt@ millert@

Revision 1.10 / (download) - annotate - [select for diffs], Wed Jun 10 18:50:43 2009 UTC (15 years ago) by guenther
Branch: MAIN
Changes since 1.9: +3 -2 lines
Diff to previous 1.9 (colored)

Ignore ECHILD returns from waitpid() in the signal handler; it appears we
generate SIGCHLD spuriously in some cases.  Also, hotplugd doesn't care
if a child is stopped, so set SA_NOCLDSTOP to suppress SIGCHLDs from that.
Problem reported by Thomas Pfaff.

ok deraadt@

Revision 1.9 / (download) - annotate - [select for diffs], Sun May 25 16:49:04 2008 UTC (16 years ago) by jasper
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.8: +4 -3 lines
Diff to previous 1.8 (colored)

- chat to syslog if the script file can't be read or executed.

ok otto@

Revision 1.8 / (download) - annotate - [select for diffs], Mon May 12 19:15:02 2008 UTC (16 years, 1 month ago) by pyr
Branch: MAIN
Changes since 1.7: +6 -1 lines
Diff to previous 1.7 (colored)

Error out with usage line if additional arguments are given after the
option parsing. Found out the hard way by jdixon on ifstated.

ok sobrado@, jdixon@, millert@

Revision 1.7 / (download) - annotate - [select for diffs], Sun May 28 16:44:52 2006 UTC (18 years ago) by mk
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.6: +9 -11 lines
Diff to previous 1.6 (colored)

Device id was removed from hotplug events so cope with this.

Revision 1.6 / (download) - annotate - [select for diffs], Sun May 28 01:35:38 2006 UTC (18 years ago) by mk
Branch: MAIN
Changes since 1.5: +12 -10 lines
Diff to previous 1.5 (colored)

Include device id in hotplug event logging.  id is passed as new
script parameter so only scripts that are picky about arg count
needs updating.

ok henning.

Revision 1.5 / (download) - annotate - [select for diffs], Wed Apr 5 08:22:21 2006 UTC (18 years, 2 months ago) by grange
Branch: MAIN
Changes since 1.4: +37 -12 lines
Diff to previous 1.4 (colored)

Reap childs asynchronously in the signal handler.
Diff from Alexey Vatchenko <avv@mail.zp.ua>.

Revision 1.4 / (download) - annotate - [select for diffs], Wed Apr 5 08:10:29 2006 UTC (18 years, 2 months ago) by grange
Branch: MAIN
Changes since 1.3: +2 -1 lines
Diff to previous 1.3 (colored)

ARGSUSED for signal handler to please lint.

Revision 1.3 / (download) - annotate - [select for diffs], Sun May 30 16:35:22 2004 UTC (20 years ago) by grange
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6
Changes since 1.2: +2 -2 lines
Diff to previous 1.2 (colored)

Better error message.

Revision 1.2 / (download) - annotate - [select for diffs], Sun May 30 16:29:41 2004 UTC (20 years ago) by grange
Branch: MAIN
Changes since 1.1: +15 -1 lines
Diff to previous 1.1 (colored)

Missing waitpid, noticed by Gregory Steuck <greg@y2004.nest.cx>.

Revision 1.1 / (download) - annotate - [select for diffs], Sun May 30 08:28:28 2004 UTC (20 years ago) by grange
Branch: MAIN

hotplugd -- devices hot plugging monitor daemon.
The hotplugd daemon monitors the hotplug(4) pseudo-device, acting on
signaled events by executing the scripts in the /etc/hotplug directory.

Not linked to the build yet.

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.