OpenBSD CVS

CVS log for src/usr.sbin/ldapd/ldape.c


[BACK] Up to [local] / src / usr.sbin / ldapd

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.38 / (download) - annotate - [select for diffs], Wed Jan 17 08:28:15 2024 UTC (4 months, 3 weeks ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, HEAD
Changes since 1.37: +7 -5 lines
Diff to previous 1.37 (colored)

Use imsg_get_fd() and a local variable.
OK florian@

Revision 1.37 / (download) - annotate - [select for diffs], Wed Mar 1 08:17:53 2023 UTC (15 months, 1 week ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3
Changes since 1.36: +2 -2 lines
Diff to previous 1.36 (colored)

Change fatal() to fatalx() since the errno has no meaning here.
OK tb@

Revision 1.36 / (download) - annotate - [select for diffs], Sun Dec 19 12:19:31 2021 UTC (2 years, 5 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.35: +2 -2 lines
Diff to previous 1.35 (colored)

log_warn -> log_warnx since the warning printed uses tls_error()
and therefor printing the errno as well makes no sense.

Revision 1.35 / (download) - annotate - [select for diffs], Wed Dec 15 04:00:15 2021 UTC (2 years, 5 months ago) by deraadt
Branch: MAIN
Changes since 1.34: +3 -3 lines
Diff to previous 1.34 (colored)

PATH_MAX+1 rarely makes sense, and abort if this happens in the imsg.
ok jmatthew millert

Revision 1.34 / (download) - annotate - [select for diffs], Tue Apr 20 21:11:56 2021 UTC (3 years, 1 month ago) by dv
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0
Changes since 1.33: +1 -2 lines
Diff to previous 1.33 (colored)

Move TAILQ initialization to files where they are used.

These priv-sep daemons all follow a similar design and use TAILQs
for tracking control process connections. In most cases, the TAILQs
are initialized separate from where they are used. Since the scope
of use is generally confined to a specific control process file,
this commit also removes any extern definitions and exposing the
TAILQ structures to other compilation units.

ok bluhm@, tb@

Revision 1.31.2.1 / (download) - annotate - [select for diffs], Sun Oct 27 20:05:13 2019 UTC (4 years, 7 months ago) by tb
Branch: OPENBSD_6_6
Changes since 1.31: +22 -22 lines
Diff to previous 1.31 (colored) next main 1.32 (colored)

The ber_* namespace is used by liblber since time immemorial,
so move our BER API to the unused ober_* prefix to avoid some
breakage in ports.

Problem diagnosed by jmatthew with ber_free() in samba, but
there are many others as pointed out by sthen.

tests & ok rob
ok sthen (who had an almost identical diff for libutil)
"go head hit it" deraadt

OpenBSD 6.6 errata 002

Revision 1.33 / (download) - annotate - [select for diffs], Sat Oct 26 17:52:55 2019 UTC (4 years, 7 months ago) by martijn
Branch: MAIN
CVS Tags: OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.32: +3 -4 lines
Diff to previous 1.32 (colored)

The starttls command doesn't have a value with its extended request.
The handling of this changed with libutil/ber.c r1.12 resulting in starttls
failing.

Found by several.
Fix suggestion by roklein <at> roklein <dot> de
OK claudio@

Revision 1.32 / (download) - annotate - [select for diffs], Thu Oct 24 12:39:26 2019 UTC (4 years, 7 months ago) by tb
Branch: MAIN
Changes since 1.31: +22 -22 lines
Diff to previous 1.31 (colored)

The ber_* namespace is used by liblber since time immemorial,
so move our BER API to the unused ober_* prefix to avoid some
breakage in ports.

Problem diagnosed by jmatthew with ber_free() in samba, but
there are many others as pointed out by sthen.

tests & ok rob
ok sthen (who had an almost identical diff for libutil)
"go head hit it" deraadt

Revision 1.31 / (download) - annotate - [select for diffs], Fri Jun 28 13:32:48 2019 UTC (4 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE
Branch point for: OPENBSD_6_6
Changes since 1.30: +2 -2 lines
Diff to previous 1.30 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.30 / (download) - annotate - [select for diffs], Sun Aug 12 22:04:09 2018 UTC (5 years, 9 months ago) by rob
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4
Changes since 1.29: +3 -3 lines
Diff to previous 1.29 (colored)

Change ber_write_elements() to return ssize_t instead of int.

ok claudio@

Revision 1.29 / (download) - annotate - [select for diffs], Tue Jul 31 11:01:00 2018 UTC (5 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.28: +7 -7 lines
Diff to previous 1.28 (colored)

Make ber type and encoding a unsigned int instead of unsigned long.
This way the size is the same on all archs and 32bit should be good enough.
OK rob@

Revision 1.28 / (download) - annotate - [select for diffs], Wed Jul 4 10:05:56 2018 UTC (5 years, 11 months ago) by rob
Branch: MAIN
Changes since 1.27: +3 -2 lines
Diff to previous 1.27 (colored)

Avoid possible vfprintf NULL errors in ldap_unbind().

Ok benno@

Revision 1.27 / (download) - annotate - [select for diffs], Tue May 15 11:19:21 2018 UTC (6 years ago) by reyk
Branch: MAIN
Changes since 1.26: +5 -7 lines
Diff to previous 1.26 (colored)

Fix format string errors in log messages and update ldapd to use relayd's log.c

OK benno@ jmatthew@

Revision 1.26 / (download) - annotate - [select for diffs], Fri Feb 24 14:28:31 2017 UTC (7 years, 3 months ago) by gsoares
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.25: +12 -14 lines
Diff to previous 1.25 (colored)

Implement fork+exec model

OK jmatthew@

Revision 1.25 / (download) - annotate - [select for diffs], Fri Jan 20 11:55:08 2017 UTC (7 years, 4 months ago) by benno
Branch: MAIN
Changes since 1.24: +2 -1 lines
Diff to previous 1.24 (colored)

work on making log.c similar in all daemons:

move daemon-local functions into new logmsg.c, and reduce
the (mostly whitespace) differences so that log.c's can be diffed easily.

ok krw@ jmatthew@

Revision 1.24 / (download) - annotate - [select for diffs], Sun May 1 00:32:37 2016 UTC (8 years, 1 month ago) by jmatthew
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.23: +20 -2 lines
Diff to previous 1.23 (colored)

convert ldapd to use the libtls api, bringing in a copy of the evbuffer_tls
code from syslogd.

ok beck@ benno@

Revision 1.23 / (download) - annotate - [select for diffs], Thu Dec 24 17:47:57 2015 UTC (8 years, 5 months ago) by mmcc
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.22: +2 -2 lines
Diff to previous 1.22 (colored)

bzero -> memset. No binary change.

Revision 1.22 / (download) - annotate - [select for diffs], Mon Nov 2 06:32:51 2015 UTC (8 years, 7 months ago) by jmatthew
Branch: MAIN
Changes since 1.21: +3 -4 lines
Diff to previous 1.21 (colored)

use SOCK_NONBLOCK instead of fcntl

ok dlg@

Revision 1.21 / (download) - annotate - [select for diffs], Mon Nov 2 04:48:43 2015 UTC (8 years, 7 months ago) by jmatthew
Branch: MAIN
Changes since 1.20: +4 -1 lines
Diff to previous 1.20 (colored)

Both ldapd processes need "stdio" to talk to clients and each other.
The parent process opens database files ("rpath wpath cpath"), sends fds to
the child ("sendfd"), and does bsd auth on behalf of the child ("getpw proc
exec").

The child process accepts client connections ("inet unix"), receives fds from
the parent ("recvfd") and locks database files ("flock").

ok deraadt@

Revision 1.20 / (download) - annotate - [select for diffs], Wed Jun 3 02:24:36 2015 UTC (9 years ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8
Changes since 1.19: +4 -4 lines
Diff to previous 1.19 (colored)

Do not assume that asprintf() clears the pointer on failure, which
is non-portable.  Also add missing asprintf() return value checks.
OK deraadt@ guenther@ doug@

Revision 1.19 / (download) - annotate - [select for diffs], Fri Jan 16 16:04:38 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.18: +2 -2 lines
Diff to previous 1.18 (colored)

change to <limits.h> universe.  The only changes in the binary are due
to the heavy use of assert.
ok millert

Revision 1.18 / (download) - annotate - [select for diffs], Sat Nov 2 13:31:51 2013 UTC (10 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.17: +6 -5 lines
Diff to previous 1.17 (colored)

bunch of format string cleanups, removing %i, signed vs unsigned, and even
a few long long's
ok jmatthew

Revision 1.17 / (download) - annotate - [select for diffs], Sat Jun 16 00:08:32 2012 UTC (11 years, 11 months ago) by jmatthew
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2
Changes since 1.16: +21 -2 lines
Diff to previous 1.16 (colored)

Protect against fd exhaustion when reopening database files.  Only accept
client or control connections when there are at least 8 fds available,
and close a connection before calling imsg_read if it would be unable to
accept an fd from the parent process.

ok gilles@

Revision 1.16 / (download) - annotate - [select for diffs], Wed Apr 11 08:31:37 2012 UTC (12 years, 2 months ago) by deraadt
Branch: MAIN
Changes since 1.15: +3 -2 lines
Diff to previous 1.15 (colored)

rate limiting of accept() in various cases.  Testing by jmatthew.  there
maybe still be a corner case where it needs one more file descriptor
beyond the limit..

Revision 1.15 / (download) - annotate - [select for diffs], Sun Apr 1 16:20:00 2012 UTC (12 years, 2 months ago) by deraadt
Branch: MAIN
Changes since 1.14: +11 -3 lines
Diff to previous 1.14 (colored)

use our umask() before AF_UNIX bind() semantics; ok pyr

Revision 1.14 / (download) - annotate - [select for diffs], Wed Nov 10 08:00:54 2010 UTC (13 years, 7 months ago) by martinh
Branch: MAIN
CVS Tags: OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9
Changes since 1.13: +3 -1 lines
Diff to previous 1.13 (colored)

Make -dvv flags produce debug traces of decoded BER messages on stderr.
Also shows a hexdump of the input buffer if BER decoding fails.
Useful when debugging protocol issues.

Revision 1.13 / (download) - annotate - [select for diffs], Wed Sep 1 17:34:15 2010 UTC (13 years, 9 months ago) by martinh
Branch: MAIN
Changes since 1.12: +24 -29 lines
Diff to previous 1.12 (colored)

Move generic imsg/libevent glue to a separate file.

with eric@ at c2k10

Revision 1.12 / (download) - annotate - [select for diffs], Sat Jul 10 14:27:15 2010 UTC (13 years, 11 months ago) by martinh
Branch: MAIN
CVS Tags: OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.11: +2 -2 lines
Diff to previous 1.11 (colored)

Retry requests when the btree is busy. Without this, clients will just hang
waiting for a response if the btree was being reopened when the request was
received.

Revision 1.11 / (download) - annotate - [select for diffs], Thu Jul 1 20:09:34 2010 UTC (13 years, 11 months ago) by martinh
Branch: MAIN
Changes since 1.10: +46 -1 lines
Diff to previous 1.10 (colored)

Implement the LDAP compare operation.

Revision 1.10 / (download) - annotate - [select for diffs], Thu Jul 1 02:19:11 2010 UTC (13 years, 11 months ago) by martinh
Branch: MAIN
Changes since 1.9: +3 -2 lines
Diff to previous 1.9 (colored)

Remove dead assignments. Found by clang static analyzer.

Revision 1.9 / (download) - annotate - [select for diffs], Wed Jun 30 17:16:09 2010 UTC (13 years, 11 months ago) by martinh
Branch: MAIN
Changes since 1.8: +3 -1 lines
Diff to previous 1.8 (colored)

Don't send statistics for referral namespaces. This unbreaks ldapctl stats.
Avoid null pointer dereference when reopening a namespace.

Revision 1.8 / (download) - annotate - [select for diffs], Tue Jun 29 21:54:38 2010 UTC (13 years, 11 months ago) by martinh
Branch: MAIN
Changes since 1.7: +80 -2 lines
Diff to previous 1.7 (colored)

Add support for referrals. Referrals are configured in the config file,
either in the global context or in a namespace. The latter can be used to
delegate requests to different servers for specific parts of the DIT. The
former is a global catch-all referral.

Revision 1.7 / (download) - annotate - [select for diffs], Tue Jun 29 21:00:34 2010 UTC (13 years, 11 months ago) by martinh
Branch: MAIN
Changes since 1.6: +6 -1 lines
Diff to previous 1.6 (colored)

Remember on what listener a connection got from, and return protocol error
if trying to use starttls without a configured certificate, instead of just
blocking the client.

Revision 1.6 / (download) - annotate - [select for diffs], Wed Jun 23 12:40:19 2010 UTC (13 years, 11 months ago) by martinh
Branch: MAIN
Changes since 1.5: +1 -2 lines
Diff to previous 1.5 (colored)

Remove compaction and indexing from ldapd. It is better done by a separate
process now that the btree can pick up the changes automatically.

Revision 1.5 / (download) - annotate - [select for diffs], Tue Jun 15 15:12:54 2010 UTC (13 years, 11 months ago) by martinh
Branch: MAIN
Changes since 1.4: +55 -15 lines
Diff to previous 1.4 (colored)

Implement support in the parent to (re-)open database files on behalf of
the unprivileged child over imsg. Part of a larger change that will fix
database compaction.

Revision 1.4 / (download) - annotate - [select for diffs], Fri Jun 11 08:27:58 2010 UTC (14 years ago) by martinh
Branch: MAIN
Changes since 1.3: +2 -2 lines
Diff to previous 1.3 (colored)

print long long int as %lld

Revision 1.3 / (download) - annotate - [select for diffs], Thu Jun 3 17:29:54 2010 UTC (14 years ago) by martinh
Branch: MAIN
Changes since 1.2: +6 -6 lines
Diff to previous 1.2 (colored)

Open database files before chrooting, and use an absolute path to
the database files, instead of relying on the chrooted-to path.

This breaks compaction as the ldape process can't re-open the
database files. This is being worked on.

ok gilles@

Revision 1.2 / (download) - annotate - [select for diffs], Mon May 31 18:29:04 2010 UTC (14 years ago) by martinh
Branch: MAIN
Changes since 1.1: +2 -2 lines
Diff to previous 1.1 (colored)

Remove trailing whitespace and spaces before tabs.

ok gilles@

Revision 1.1 / (download) - annotate - [select for diffs], Mon May 31 17:36:31 2010 UTC (14 years ago) by martinh
Branch: MAIN

Initial import of ldapd, a small LDAP daemon. Work in progress.

ok deraadt@ jacekm@ gilles@ back@ henning@ blambert@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.