OpenBSD CVS

CVS log for src/usr.sbin/ldomctl/parse.y


[BACK] Up to [local] / src / usr.sbin / ldomctl

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.25 / (download) - annotate - [select for diffs], Thu Oct 6 21:35:52 2022 UTC (20 months ago) by kn
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, HEAD
Changes since 1.24: +3 -3 lines
Diff to previous 1.24 (colored)

accept iodevices as NACs as well

Assignable PCIe devices have a root complex path and a more descriptive
I/O slot path;  example output from a T4-2:

	# ldomctl list-io | head -n2
	PATH             NAME
	/@400/@2/@0/@8   /SYS/MB/PCIE0

ldom.conf(5) `iodevice' currently accepts PATH values, which are cryptic and
completely hardware specific, whereas NAME values are obvious (partially
same across machines) and match physical slot labels ("0 PCIe2 x8") besides
information from ILOM:
    /System/PCI_Devices/Add-on/Device_0 location = PCIE0 (PCIe Slot 0).

Make ldom.conf `iodevice' accept either value;  internally nothing changes.

Rename struct iodev's path member to dev to clarify this further.

OK kettenis

Revision 1.24 / (download) - annotate - [select for diffs], Fri Oct 15 15:01:28 2021 UTC (2 years, 7 months ago) by naddy
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.23: +13 -13 lines
Diff to previous 1.23 (colored)

Don't declare variables as "unsigned char *" that are passed to
functions that take "char *" arguments.  Where such chars are
assigned to int or passed to ctype functions, explicitly cast them
to unsigned char.

For OpenBSD's clang, -Wpointer-sign has been disabled by default,
but when the parse.y code was built elsewhere, the compiler would
complain.

With help from millert@
ok benno@ deraadt@

Revision 1.23 / (download) - annotate - [select for diffs], Sat Jan 30 19:32:44 2021 UTC (3 years, 4 months ago) by kn
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9
Changes since 1.22: +2 -1 lines
Diff to previous 1.22 (colored)

Move global domain declaration to parse.y

This is the only object that uses it;  required for "-fno-common".
OK kettenis

Revision 1.22 / (download) - annotate - [select for diffs], Mon Sep 14 18:09:57 2020 UTC (3 years, 8 months ago) by kn
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8
Changes since 1.21: +2 -2 lines
Diff to previous 1.21 (colored)

Typofix

Revision 1.21 / (download) - annotate - [select for diffs], Mon Jun 29 17:58:58 2020 UTC (3 years, 11 months ago) by kn
Branch: MAIN
Changes since 1.20: +16 -1 lines
Diff to previous 1.20 (colored)

Reject vdisk, vnet and iodevice parameters for primary domain

In analogy to guest domains requiring vcpu, memory and at least one
bootable device (vdisk, vnet or iodevice), the primary domain must not
be configured with vdisk, vnet or iodevice parameters;  it does not make
sense to provide virtual disks or interfaces to it and PCIe devices not
assigned to guest domains automatically end up in the primary domain.

ldom.conf(5) also documents those explicitly for guest domains only.

OK tracey

Revision 1.20 / (download) - annotate - [select for diffs], Sat May 23 13:19:13 2020 UTC (4 years ago) by kn
Branch: MAIN
Changes since 1.19: +2 -2 lines
Diff to previous 1.19 (colored)

Typofix

Revision 1.19 / (download) - annotate - [select for diffs], Sat May 23 13:06:33 2020 UTC (4 years ago) by kn
Branch: MAIN
Changes since 1.18: +20 -3 lines
Diff to previous 1.18 (colored)

Fail on duplicate vcpu, memory or iodevice parameters

Domains get to define their cores and memory only once unlike vnet, vdisk
and variable parameters of which it makes sense to have more than one;
iodevices are unique my design and may only be assigned once.

OK kettenis

Revision 1.18 / (download) - annotate - [select for diffs], Fri Feb 21 19:39:28 2020 UTC (4 years, 3 months ago) by kn
Branch: MAIN
CVS Tags: OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.17: +14 -4 lines
Diff to previous 1.17 (colored)

Support devaliases for vnet

vnet devalias=netboot

Creates a device alias to be used in OBP:

{ok} boot netboot

This helps navigating inside guests without remembering
device paths or rather their order as specified in the config.

OK kettenis

Revision 1.17 / (download) - annotate - [select for diffs], Fri Feb 21 19:29:41 2020 UTC (4 years, 3 months ago) by kn
Branch: MAIN
Changes since 1.16: +2 -1 lines
Diff to previous 1.16 (colored)

Actually pass devalias from parser to config

Missed in previous commit;  no breakage, the resulting MD would simply end
up without user defined device aliases.

Revision 1.16 / (download) - annotate - [select for diffs], Thu Feb 20 20:38:44 2020 UTC (4 years, 3 months ago) by kn
Branch: MAIN
Changes since 1.15: +34 -3 lines
Diff to previous 1.15 (colored)

Support devaliases for vdisk

vdisk "/var/ldom/miniroot.fs" devalias=miniroot

Creates a device alias to be used in OBP:

{ok} devlias
miniroot  /virutal-devices@100/...

This helps navigating inside guests without remembering
device paths or rather their order as specified in the config.

OK kettenis

Revision 1.15 / (download) - annotate - [select for diffs], Thu Jan 9 22:06:23 2020 UTC (4 years, 5 months ago) by kn
Branch: MAIN
Changes since 1.14: +20 -1 lines
Diff to previous 1.14 (colored)

Fail on incomplete guest parameters

Each guest needs vcpu and memory, otherwise it is invalid.
Each guest also needs at least one of vdisk, vnet or iodevice,
otherwise it has nothing to boot from.

OK kettenis

Revision 1.14 / (download) - annotate - [select for diffs], Thu Jan 9 09:23:57 2020 UTC (4 years, 5 months ago) by kn
Branch: MAIN
Changes since 1.13: +7 -8 lines
Diff to previous 1.13 (colored)

Bail earlier on duplicate domains

If the given domain was already specified, do not bother allocating and
initialising it.

No function change.

Revision 1.13 / (download) - annotate - [select for diffs], Thu Nov 28 18:40:42 2019 UTC (4 years, 6 months ago) by kn
Branch: MAIN
Changes since 1.12: +6 -18 lines
Diff to previous 1.12 (colored)

Use scan_scaled(3) for memory in ldom.conf

Replace the hand-written routing with a proper library allowing even more
formats.

Since ldomctl's local util.h conflicts with the now used global util.h from
libutil, rename it to ldom_util.h.

Manual wording from amd64's vm.conf(5).

OK kettenis

Revision 1.12 / (download) - annotate - [select for diffs], Mon Aug 5 19:27:47 2019 UTC (4 years, 10 months ago) by kettenis
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.11: +65 -18 lines
Diff to previous 1.11 (colored)

Allow an optional stride in the vcpu specification.  This makes it possible
to allocate virtual CPUs but not assign them to domains.  This way you
can give domains exclusive access to a core without assigning all threads
of that core to the domain.

Revision 1.11 / (download) - annotate - [select for diffs], Sun Jul 28 14:51:07 2019 UTC (4 years, 10 months ago) by kettenis
Branch: MAIN
Changes since 1.10: +9 -2 lines
Diff to previous 1.10 (colored)

Add support for configuring static direct I/O.

Revision 1.10 / (download) - annotate - [select for diffs], Wed Feb 13 22:57:08 2019 UTC (5 years, 3 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.9: +3 -3 lines
Diff to previous 1.9 (colored)

(unsigned) means (unsigned int) which on ptrdiff_t or size_t or other
larger types really is a range reduction...
Almost any cast to (unsigned) is a bug.
ok millert tb benno

Revision 1.9 / (download) - annotate - [select for diffs], Thu Nov 1 00:18:44 2018 UTC (5 years, 7 months ago) by sashan
Branch: MAIN
Changes since 1.8: +3 -2 lines
Diff to previous 1.8 (colored)

- odd condition/test in PF lexer
  (and other lexers too)

This commit rectifies earlier change:

    in the lex... even inside quotes, a \ followed by space or tab should
    expand to space or tab, and a \ followed by newline should be ignored
    (as a line continuation).  compatible with the needs of hoststated
    (which has the most strict quoted string requirements), and ifstated
    (where one commonly does line continuations in strings).

OK deraadt@, OK millert@

Revision 1.8 / (download) - annotate - [select for diffs], Sun Sep 16 14:27:32 2018 UTC (5 years, 8 months ago) by kettenis
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE, OPENBSD_6_4
Changes since 1.7: +10 -2 lines
Diff to previous 1.7 (colored)

Add support for setting NVRAM variables.

Revision 1.7 / (download) - annotate - [select for diffs], Mon Jul 9 12:05:11 2018 UTC (5 years, 11 months ago) by krw
Branch: MAIN
Changes since 1.6: +2 -2 lines
Diff to previous 1.6 (colored)

No need to mention which memory allocation entry point failed (malloc,
calloc or strdup), we just need to log that we ran out of memory in a
particular function.

Recommended by florian@ and deraadt@

ok benno@ henning@ tb@

Revision 1.6 / (download) - annotate - [select for diffs], Thu Nov 20 05:51:20 2014 UTC (9 years, 6 months ago) by jsg
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9, OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.5: +4 -1 lines
Diff to previous 1.5 (colored)

Don't allow embedded nul characters in strings.
Fixes a pfctl crash with an anchor name containing
an embedded nul found with the afl fuzzer.

pfctl parse.y patch from and ok deraadt@

Revision 1.5 / (download) - annotate - [select for diffs], Fri Nov 14 03:20:37 2014 UTC (9 years, 6 months ago) by doug
Branch: MAIN
Changes since 1.4: +4 -2 lines
Diff to previous 1.4 (colored)

Add gcc printf format attributes to yyerror() in parse.y files.
No yyerror() calls needed to be changed.

ok bluhm@

Revision 1.4 / (download) - annotate - [select for diffs], Mon Nov 25 12:57:18 2013 UTC (10 years, 6 months ago) by benno
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.3: +6 -6 lines
Diff to previous 1.3 (colored)

use u_char for buffers in yylex, for ctype calls
found by millert@, ok deraadt@

Revision 1.3 / (download) - annotate - [select for diffs], Mon Mar 4 11:54:13 2013 UTC (11 years, 3 months ago) by otto
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4
Changes since 1.2: +9 -2 lines
Diff to previous 1.2 (colored)

- check parser's return value and exit if parsing failed
- a duplicate domain name is a syntax error
tweaked diff from @jasper; ok kettenis@ jasper@

Revision 1.2 / (download) - annotate - [select for diffs], Sat Nov 24 12:13:06 2012 UTC (11 years, 6 months ago) by kettenis
Branch: MAIN
CVS Tags: OPENBSD_5_3_BASE, OPENBSD_5_3
Changes since 1.1: +3 -1 lines
Diff to previous 1.1 (colored)

Fix yacc warning.

Revision 1.1 / (download) - annotate - [select for diffs], Sat Nov 24 11:50:45 2012 UTC (11 years, 6 months ago) by kettenis
Branch: MAIN

Add code to create new system configuration.  Work in progress, but there's
enough functionality to create a configuration for a t1k or t2k running
System Firmware 6.7.x.

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.