OpenBSD CVS

CVS log for src/usr.sbin/ospf6d/rde.c


[BACK] Up to [local] / src / usr.sbin / ospf6d

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.91 / (download) - annotate - [select for diffs], Wed Mar 8 04:43:14 2023 UTC (15 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, HEAD
Changes since 1.90: +1 -4 lines
Diff to previous 1.90 (colored)

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

Revision 1.90 / (download) - annotate - [select for diffs], Thu Jan 20 14:03:32 2022 UTC (2 years, 4 months ago) by naddy
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.89: +5 -3 lines
Diff to previous 1.89 (colored)

ospf6d: fix -Wunused-but-set-variable warnings

ospf6d.c: sync a missing bit of (disabled) code with ospfd
rde.c: ifdef out some more incomplete code

ok denis@ claudio@

Revision 1.89 / (download) - annotate - [select for diffs], Tue Jan 19 09:54:08 2021 UTC (3 years, 4 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9
Changes since 1.88: +3 -3 lines
Diff to previous 1.88 (colored)

Make the struct imsgev static. With this ospf6d compiles with -fno-common

Revision 1.88 / (download) - annotate - [select for diffs], Sat May 16 15:54:12 2020 UTC (4 years ago) by denis
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8
Changes since 1.87: +1 -15 lines
Diff to previous 1.87 (colored)

When IMSG_IFADD is removed, IMSG_IFDELETE becomes useless

OK remi@

Revision 1.87 / (download) - annotate - [select for diffs], Sat May 16 15:53:03 2020 UTC (4 years ago) by denis
Branch: MAIN
Changes since 1.86: +1 -12 lines
Diff to previous 1.86 (colored)

IMSG_IFADD is never used, wipe it

OK remi@

Revision 1.86 / (download) - annotate - [select for diffs], Sun Apr 5 18:19:04 2020 UTC (4 years, 2 months ago) by denis
Branch: MAIN
CVS Tags: OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.85: +10 -3 lines
Diff to previous 1.85 (colored)

Handle connected routes as ospfd(8) does.

OK remi@

Revision 1.85 / (download) - annotate - [select for diffs], Sun Mar 29 11:59:11 2020 UTC (4 years, 2 months ago) by denis
Branch: MAIN
Changes since 1.84: +62 -49 lines
Diff to previous 1.84 (colored)

Rework of rde_asext_get()/rde_asext_put().
Also change get_net_link() and get_rtr_link() to work like ospfd(8)
couterpart.

OK remi@

Revision 1.84 / (download) - annotate - [select for diffs], Mon Feb 17 08:12:22 2020 UTC (4 years, 3 months ago) by denis
Branch: MAIN
Changes since 1.83: +6 -14 lines
Diff to previous 1.83 (colored)

Bring ospf6d closer to ospfd

- update debug messages to be more precise
- simplify call to lsa_self()
- drop lsa_find_lsid() redondant parameters

OK remi@

Revision 1.83 / (download) - annotate - [select for diffs], Tue Jan 21 15:17:12 2020 UTC (4 years, 4 months ago) by denis
Branch: MAIN
Changes since 1.82: +2 -2 lines
Diff to previous 1.82 (colored)

No need to pass peerid to lsa_snap()

OK remi@

Revision 1.82 / (download) - annotate - [select for diffs], Thu Jan 2 10:16:46 2020 UTC (4 years, 5 months ago) by denis
Branch: MAIN
Changes since 1.81: +1 -3 lines
Diff to previous 1.81 (colored)

Rename orig_rtr_lsa_area() to orig_rtr_lsa()

Now that area is part of iface, original orig_rtr_lsa() is useless. Also
verifying that area != NULL is not needed in some cases (these are
leftovers of the previous diff).

OK remi@

Revision 1.81 / (download) - annotate - [select for diffs], Mon Dec 23 07:33:49 2019 UTC (4 years, 5 months ago) by denis
Branch: MAIN
Changes since 1.80: +22 -13 lines
Diff to previous 1.80 (colored)

Area is now part of struct iface

OK remi@

Revision 1.80 / (download) - annotate - [select for diffs], Tue Jun 11 05:00:09 2019 UTC (4 years, 11 months ago) by remi
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.79: +3 -6 lines
Diff to previous 1.79 (colored)

Introduce conf_clear_redist_list() (from ospfd) and use it in all 3 procs.

ok benno@

Revision 1.79 / (download) - annotate - [select for diffs], Thu Jul 12 13:45:03 2018 UTC (5 years, 10 months ago) by remi
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4
Changes since 1.78: +2 -2 lines
Diff to previous 1.78 (colored)

Add support for rdomains.

small quirk from tb@
ok phessler@

Revision 1.78 / (download) - annotate - [select for diffs], Thu Jul 12 12:19:05 2018 UTC (5 years, 10 months ago) by remi
Branch: MAIN
Changes since 1.77: +24 -5 lines
Diff to previous 1.77 (colored)

With the "depend on" option routes are sent out with a metric of 65535 if
the referenced interface is down or in state backup. This is especially
useful on a carp cluster to ensure all traffic goes to the carp master.

ok friehm@ jca@

Revision 1.77 / (download) - annotate - [select for diffs], Tue Jul 10 21:21:56 2018 UTC (5 years, 11 months ago) by friehm
Branch: MAIN
Changes since 1.76: +4 -1 lines
Diff to previous 1.76 (colored)

pledge(2)

Looks great! deraadt@
OK florian
OK remi@

Revision 1.76 / (download) - annotate - [select for diffs], Tue Jun 12 20:12:36 2018 UTC (5 years, 11 months ago) by remi
Branch: MAIN
Changes since 1.75: +21 -5 lines
Diff to previous 1.75 (colored)

Send LSAs with MAX_METRIC for carp interfaces in state backup.
This is similar to what ospfd does.

ok jca@

Revision 1.75 / (download) - annotate - [select for diffs], Tue Jun 12 20:02:13 2018 UTC (5 years, 11 months ago) by remi
Branch: MAIN
Changes since 1.74: +13 -10 lines
Diff to previous 1.74 (colored)

Fix resending intra area prefix LSAs on link state or if flag change.

ok jca@

Revision 1.74 / (download) - annotate - [select for diffs], Sun Jun 10 14:39:38 2018 UTC (6 years ago) by remi
Branch: MAIN
Changes since 1.73: +3 -2 lines
Diff to previous 1.73 (colored)

memory leak spotted by claudio@

go ahead jca@
OK claudio@

Revision 1.73 / (download) - annotate - [select for diffs], Sun Jun 10 14:31:49 2018 UTC (6 years ago) by remi
Branch: MAIN
Changes since 1.72: +4 -2 lines
Diff to previous 1.72 (colored)

The value for metric of intra area prefix LSAs should be set to:
- 0 when referencing Network LSAs
- 0 for loopback interfaces
- interface output cost for other cases

go ahead jca@
OK claudio@

Revision 1.72 / (download) - annotate - [select for diffs], Sat Aug 12 16:27:50 2017 UTC (6 years, 9 months ago) by benno
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.71: +9 -3 lines
Diff to previous 1.71 (colored)

bring ospf6d's log.c in sync with ospfd and bgpd
ok florian@ claudio@

Revision 1.71 / (download) - annotate - [select for diffs], Mon Jun 19 19:55:57 2017 UTC (6 years, 11 months ago) by friehm
Branch: MAIN
Changes since 1.70: +1 -18 lines
Diff to previous 1.70 (colored)

Import route priority support from ospfd to ospf6d.
Also remove the RTF_UP flag from hdr.rtm_flags in send_rtmsg() since
ospfd and bgpd don't set the flag.

OK bluhm@ claudio@

Revision 1.70 / (download) - annotate - [select for diffs], Tue May 30 12:42:31 2017 UTC (7 years ago) by friehm
Branch: MAIN
Changes since 1.69: +25 -16 lines
Diff to previous 1.69 (colored)

Adding multipath route support to ospf6d. Almost copied from ospfd.

OK bluhm@

Revision 1.69 / (download) - annotate - [select for diffs], Tue Dec 27 17:18:56 2016 UTC (7 years, 5 months ago) by jca
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.68: +33 -34 lines
Diff to previous 1.68 (colored)

Replace struct rroute with struct kroute, as done in ospfd

ok claudio@

Revision 1.68 / (download) - annotate - [select for diffs], Sat Sep 3 10:25:36 2016 UTC (7 years, 9 months ago) by renato
Branch: MAIN
Changes since 1.67: +9 -5 lines
Diff to previous 1.67 (colored)

Simplify shutdown process.

On shutdown, there's no need to use kill(2) to kill the child
processes. Just closing the IPC sockets will make the children receive
an EOF, break out from the event loop and then exit.

Tha advantages of this "pipe teardown" are:
* simpler code;
* no need to pledge "proc" in the parent process;
* removal of a (hard to trigger) PID reuse race condition.

ok benno@ claudio@

Revision 1.67 / (download) - annotate - [select for diffs], Fri Sep 2 14:06:35 2016 UTC (7 years, 9 months ago) by benno
Branch: MAIN
Changes since 1.66: +2 -1 lines
Diff to previous 1.66 (colored)

work on making log.c similar in all daemons:

move daemon-local functions into new logmsg.c, and reduce
the (mostly whitespace) differences so that log.c's can be diffed easily.

ok claudio@, feedback from henning@, deraadt@, reyk@

Revision 1.66 / (download) - annotate - [select for diffs], Mon Jun 6 15:57:44 2016 UTC (8 years ago) by benno
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0
Changes since 1.65: +3 -3 lines
Diff to previous 1.65 (colored)

add format attributes to the proper functions and then fix the
warning in rde.c

Revision 1.65 / (download) - annotate - [select for diffs], Sat Dec 5 13:12:41 2015 UTC (8 years, 6 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.64: +5 -5 lines
Diff to previous 1.64 (colored)

EAGAIN handling for imsg_read. OK henning@ benno@

Revision 1.64 / (download) - annotate - [select for diffs], Sun Sep 27 17:31:50 2015 UTC (8 years, 8 months ago) by stsp
Branch: MAIN
Changes since 1.63: +2 -2 lines
Diff to previous 1.63 (colored)

As done for bgpd recently, rename if_mediatype to if_type in ospfd/ospf6d.
And some ifmedia64 fixes.
"move forward" deraadt@

Revision 1.63 / (download) - annotate - [select for diffs], Fri Jan 16 06:40:19 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.62: +4 -3 lines
Diff to previous 1.62 (colored)

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible.  Annotate <sys/param.h> lines with their current reasons.  Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc.  Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution.  These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Revision 1.62 / (download) - annotate - [select for diffs], Sat Jul 12 20:16:38 2014 UTC (9 years, 10 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.61: +7 -3 lines
Diff to previous 1.61 (colored)

Close connections when msgbuf_write() returns 0.

ok claudio@

Revision 1.61 / (download) - annotate - [select for diffs], Wed Nov 13 20:49:49 2013 UTC (10 years, 6 months ago) by benno
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.60: +3 -3 lines
Diff to previous 1.60 (colored)

handle msgbuf_write() returning EAGAIN,
taken from claudios previous fix to ospfd.

"do it" deraadt@

Revision 1.60 / (download) - annotate - [select for diffs], Mon Sep 17 13:49:27 2012 UTC (11 years, 8 months ago) by bluhm
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3
Changes since 1.59: +3 -3 lines
Diff to previous 1.59 (colored)

Fix trailing whitespaces.

Revision 1.59 / (download) - annotate - [select for diffs], Sun Nov 6 10:29:05 2011 UTC (12 years, 7 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1
Changes since 1.58: +2 -1 lines
Diff to previous 1.58 (colored)

Add a #include that's currently picked up via another header that's
violating namespace rules

ok claudio@

Revision 1.58 / (download) - annotate - [select for diffs], Thu Jul 7 17:10:48 2011 UTC (12 years, 11 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_5_0_BASE, OPENBSD_5_0
Changes since 1.57: +37 -29 lines
Diff to previous 1.57 (colored)

Rework the distribution of link state and iface FSM state changes.
Link state changes are sent from the parent to both childs and
iface FSM state changes are sent from the ospfe to the rde.

Revision 1.57 / (download) - annotate - [select for diffs], Thu Jul 7 04:37:56 2011 UTC (12 years, 11 months ago) by claudio
Branch: MAIN
Changes since 1.56: +2 -6 lines
Diff to previous 1.56 (colored)

Just use if_find() to find an interface by ifindex.

Revision 1.56 / (download) - annotate - [select for diffs], Thu Jul 7 04:35:47 2011 UTC (12 years, 11 months ago) by claudio
Branch: MAIN
Changes since 1.55: +7 -8 lines
Diff to previous 1.55 (colored)

correct/change some debug and fatal messages.

Revision 1.55 / (download) - annotate - [select for diffs], Thu Jul 7 00:36:13 2011 UTC (12 years, 11 months ago) by claudio
Branch: MAIN
Changes since 1.54: +1 -2 lines
Diff to previous 1.54 (colored)

Kill nh_reachable. Link state checking is so easy now that it does not
matter anymore to cache this value for ospf6d.

Revision 1.54 / (download) - annotate - [select for diffs], Mon Jul 4 04:34:14 2011 UTC (12 years, 11 months ago) by claudio
Branch: MAIN
Changes since 1.53: +2 -4 lines
Diff to previous 1.53 (colored)

LINK_STATE_IS_UP() cleanup userland part. There is no need to special
case carp(4) interfaces anymore. LINK_STATE_IS_UP() almost always does
the right job.
OK deraadt@ henning@

This needs a -current kernel or link state may be not reported correctly.

Revision 1.53 / (download) - annotate - [select for diffs], Mon Jul 4 04:08:34 2011 UTC (12 years, 11 months ago) by claudio
Branch: MAIN
Changes since 1.52: +27 -5 lines
Diff to previous 1.52 (colored)

Make sure that passive interfaces (like carp) are added to the
intra-area rtr LSA. Diff initialy made by Patrick Coleman but
simplified by myself. Tested and OK dlg@

Revision 1.52 / (download) - annotate - [select for diffs], Thu May 5 15:58:02 2011 UTC (13 years, 1 month ago) by claudio
Branch: MAIN
Changes since 1.51: +2 -2 lines
Diff to previous 1.51 (colored)

KNF

Revision 1.51 / (download) - annotate - [select for diffs], Mon May 2 06:34:29 2011 UTC (13 years, 1 month ago) by claudio
Branch: MAIN
Changes since 1.50: +8 -10 lines
Diff to previous 1.50 (colored)

Don't include sys/param.h and reformat some lines.

Revision 1.50 / (download) - annotate - [select for diffs], Sun Aug 22 20:55:10 2010 UTC (13 years, 9 months ago) by bluhm
Branch: MAIN
CVS Tags: OPENBSD_4_9_BASE, OPENBSD_4_9
Changes since 1.49: +28 -7 lines
Diff to previous 1.49 (colored)

When removing an announced prefix, inherit the metric and ext_tag
from the LSA that is currently in the tree.  Based on claudio@'s
diff and his fix for ospfd.  Additionally originate an LSA with
external route tag correctly by writing the AS-external-LSA's bit
T into the correct field.
ok claudio@

Revision 1.49 / (download) - annotate - [select for diffs], Fri Jul 9 12:39:46 2010 UTC (13 years, 11 months ago) by bluhm
Branch: MAIN
CVS Tags: OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.48: +9 -10 lines
Diff to previous 1.48 (colored)

Do not try to originate an intra-area-prefix-lsa if an interface
address changes that does not belong to any area.  This fixes an
ospf6d crash.  To not search for the area in orig_intra_lsa_net(),
just pass the area as function parameter.
ok claudio@

Revision 1.48 / (download) - annotate - [select for diffs], Tue Jul 6 13:24:35 2010 UTC (13 years, 11 months ago) by bluhm
Branch: MAIN
Changes since 1.47: +49 -1 lines
Diff to previous 1.47 (colored)

Update the interfaces changes from kroute to rde via imsg.  This
is needed to orginate correct intra-area-prefix-lsas.
ok claudio@ stsp@

Revision 1.47 / (download) - annotate - [select for diffs], Tue Jul 6 13:15:33 2010 UTC (13 years, 11 months ago) by bluhm
Branch: MAIN
Changes since 1.46: +10 -9 lines
Diff to previous 1.46 (colored)

Use the static variable narea only where needed for config reload.
The other imessages use the stack variables area and iface.
ok claudio@

Revision 1.46 / (download) - annotate - [select for diffs], Mon Jul 5 22:59:51 2010 UTC (13 years, 11 months ago) by bluhm
Branch: MAIN
Changes since 1.45: +13 -32 lines
Diff to previous 1.45 (colored)

During network intra-area-prefix-lsa origination, the designated
router's prefixes were ignored if all other routers on that link
had no prefixes.  Advertise a intra-area-prefix-lsa with all prefixes
for the network if there are any adjacent neighbors on link.
ok stsp@

Revision 1.45 / (download) - annotate - [select for diffs], Thu Jul 1 21:19:57 2010 UTC (13 years, 11 months ago) by bluhm
Branch: MAIN
Changes since 1.44: +3 -1 lines
Diff to previous 1.44 (colored)

Fix memory leak by adding a missing free(lsa).
ok claudio@

Revision 1.44 / (download) - annotate - [select for diffs], Thu Jul 1 19:47:04 2010 UTC (13 years, 11 months ago) by bluhm
Branch: MAIN
Changes since 1.43: +6 -6 lines
Diff to previous 1.43 (colored)

Fix all white space bugs in ospf6d at once.  No binary change.
ok claudio@

Revision 1.43 / (download) - annotate - [select for diffs], Thu Jul 1 18:57:21 2010 UTC (13 years, 11 months ago) by bluhm
Branch: MAIN
Changes since 1.42: +1 -2 lines
Diff to previous 1.42 (colored)

The prefixes of interface addresses of an ospf link have to be
advertised as link-lsa and intra-area-prefix-lsa when they change
dynamically.  Handle RTM_NEWADDR and RTM_DELADDR in kroute by sending
an imsg to ospfe.  Upon this event, originate a new link-lsa in
ospfe.  In rde a new intra-area-prefix-lsa is generated when a
link-lsa appears or goes away.
ok claudio@; ok and test stsp@

Revision 1.42 / (download) - annotate - [select for diffs], Mon Jun 28 15:05:01 2010 UTC (13 years, 11 months ago) by bluhm
Branch: MAIN
Changes since 1.41: +2 -1 lines
Diff to previous 1.41 (colored)

Store the ifindex into the kroute change imsg.  This way we can use
the interface index for writing routes into the kernel.
ok claudio@

Revision 1.41 / (download) - annotate - [select for diffs], Sat Jun 12 10:06:50 2010 UTC (14 years ago) by bluhm
Branch: MAIN
Changes since 1.40: +5 -4 lines
Diff to previous 1.40 (colored)

Fix an obvious use after free.  From ospfd.
ok claudio@

Revision 1.40 / (download) - annotate - [select for diffs], Tue Jun 1 11:29:29 2010 UTC (14 years ago) by bluhm
Branch: MAIN
Changes since 1.39: +3 -2 lines
Diff to previous 1.39 (colored)

Add NULL pointer check after calloc.
ok claudio@ stsp@

Revision 1.39 / (download) - annotate - [select for diffs], Tue Jun 1 11:22:28 2010 UTC (14 years ago) by bluhm
Branch: MAIN
Changes since 1.38: +2 -2 lines
Diff to previous 1.38 (colored)

Fix error message.
ok claudio@ stsp@

Revision 1.38 / (download) - annotate - [select for diffs], Fri Apr 16 11:36:10 2010 UTC (14 years, 1 month ago) by claudio
Branch: MAIN
Changes since 1.37: +79 -79 lines
Diff to previous 1.37 (colored)

Move a function to a place that is a bit more logical. No functional change.

Revision 1.37 / (download) - annotate - [select for diffs], Mon Mar 1 08:58:48 2010 UTC (14 years, 3 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.36: +65 -40 lines
Diff to previous 1.36 (colored)

Support for redistributing AS-ext LSA (redistribute static/connected).
Appart from multi-area support this is the last big missing piece in
ospf6d. ospf6d should now work correctly in single area setups.
So please test.
"it's always nice to see those #if 0 being killed" stsp@

Revision 1.36 / (download) - annotate - [select for diffs], Sun Jan 24 12:21:05 2010 UTC (14 years, 4 months ago) by stsp
Branch: MAIN
Changes since 1.35: +5 -8 lines
Diff to previous 1.35 (colored)

In orig_intra_lsa_rtr(), don't allocate and free a temporary buffer
which easily fits on the stack.

OK claudio@

Revision 1.35 / (download) - annotate - [select for diffs], Tue Dec 22 19:32:36 2009 UTC (14 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.34: +4 -1 lines
Diff to previous 1.34 (colored)

Add interface index aka. scope id to struct kroute so that the rde can pass
this information to kroute and kroute can use that information to fill in
the various sin6_scope_id fields.

Revision 1.34 / (download) - annotate - [select for diffs], Mon Nov 2 20:24:58 2009 UTC (14 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.33: +7 -2 lines
Diff to previous 1.33 (colored)

Add IMSG_CTL_LOG_VERBOSE similar to ospfd it allows to toggle debug logging.
henning, sthen, michele like the idea

Revision 1.33 / (download) - annotate - [select for diffs], Tue Jul 28 19:16:34 2009 UTC (14 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.32: +2 -2 lines
Diff to previous 1.32 (colored)

More fallout from the r1.31 commit. This time PID and the fd got swapped.
Again from stsp@

Revision 1.32 / (download) - annotate - [select for diffs], Tue Jul 28 19:14:25 2009 UTC (14 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.31: +2 -2 lines
Diff to previous 1.31 (colored)

Running 'ospf6ctl show' twice caused ospf6d to fatal. Cause was a missing -
when passing -1 as fd to the imsg call. No frogs for eric@ and pyr@
From stsp@

Revision 1.31 / (download) - annotate - [select for diffs], Sat Jun 6 09:02:46 2009 UTC (15 years ago) by eric
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6
Changes since 1.30: +73 -62 lines
Diff to previous 1.30 (colored)

make ospf6ctl/ospf6d imsg-in-a-lib ready too.

ospf6ctl is already broken in tree (not connected to build).

ok pyr@

Revision 1.30 / (download) - annotate - [select for diffs], Sun May 31 20:29:56 2009 UTC (15 years ago) by jacekm
Branch: MAIN
Changes since 1.29: +1 -3 lines
Diff to previous 1.29 (colored)

Remove redundant imsg_event_add calls; ok claudio@

Revision 1.29 / (download) - annotate - [select for diffs], Sun May 31 17:00:40 2009 UTC (15 years ago) by claudio
Branch: MAIN
Changes since 1.28: +7 -15 lines
Diff to previous 1.28 (colored)

libevent handler fix to allow EV_READ and EV_WRITE to be set at the same
time in the callback. Same diff that went into ospfd applied with some
fuzz.

Revision 1.28 / (download) - annotate - [select for diffs], Thu Apr 9 19:00:40 2009 UTC (15 years, 2 months ago) by stsp
Branch: MAIN
Changes since 1.27: +3 -3 lines
Diff to previous 1.27 (colored)

Fix a naming inconsistency in struct lsa_intra_prefix (lsid -> ls_id).

"consistency is a good thing" jsing@, ok claudio@

Revision 1.27 / (download) - annotate - [select for diffs], Sun Mar 29 21:42:30 2009 UTC (15 years, 2 months ago) by stsp
Branch: MAIN
Changes since 1.26: +1 -2 lines
Diff to previous 1.26 (colored)

As a first step towards SPF tree calculation, prepare for proper
next-hop calculation.

In OSPFv3, next-hop IP addresses are always link-local.
The kernel will want to know which interface the link-local
address belongs to, so we need an ifindex in struct v_nexthop
in addition to the IP address.

Because we cannot determine a link-local next hop IP address
for transit networks, only the outgoing interface will be recorded.

Update calc_nexthop_add() according to the above.

Also add new helpers calc_nexthop_lladdr() and calc_nexthop_transit_nbr(),
to figure out link-local addresses of nexthop neighbours.

ok claudio@

Revision 1.26 / (download) - annotate - [select for diffs], Thu Mar 12 01:21:49 2009 UTC (15 years, 3 months ago) by stsp
Branch: MAIN
Changes since 1.25: +13 -6 lines
Diff to previous 1.25 (colored)

lsa_self() did too many things at once, and had too much logic
buried inside of it that its caller relied on.

So split it up as follows:
lsa_self()    Check whether an LSA is self-originated.
lsa_flush()   Flush an LSA from the LSDB.
lsa_reflood() Prepare an LSA for reflooding (actual reflooding currently
              requires sending an imsg which must be done by the caller).

ok claudio@

Revision 1.25 / (download) - annotate - [select for diffs], Sat Mar 7 00:33:13 2009 UTC (15 years, 3 months ago) by stsp
Branch: MAIN
Changes since 1.24: +3 -12 lines
Diff to previous 1.24 (colored)

Add lsa_find_tree() to allow searching for LSAs in a specific LSA tree.
We had code marked XXX searching an LSA tree manually using RB_FIND(),
switch it over to lsa_find_tree().
Make lsa_find() use the new function, too, to avoid code duplication.
ok claudio@

Revision 1.24 / (download) - annotate - [select for diffs], Thu Feb 19 22:21:17 2009 UTC (15 years, 3 months ago) by stsp
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.23: +3 -3 lines
Diff to previous 1.23 (colored)

Use rde_router_id() instead of directly accessing rdeconf->rtr_id.s_addr.

"For sure!" claudio@

Revision 1.23 / (download) - annotate - [select for diffs], Thu Feb 19 22:19:53 2009 UTC (15 years, 3 months ago) by stsp
Branch: MAIN
Changes since 1.22: +14 -4 lines
Diff to previous 1.22 (colored)

Enable origination of Intra-Area-Prefix LSAs in rde.

New Intra-Area-Prefix LSAs are originated when a neighbour
becomes adjacent, or when a neighbour loses adjacency,
or when an interface changes state.

ok claudio@

Revision 1.22 / (download) - annotate - [select for diffs], Thu Feb 19 22:17:07 2009 UTC (15 years, 3 months ago) by stsp
Branch: MAIN
Changes since 1.21: +232 -82 lines
Diff to previous 1.21 (colored)

Virtually re-implement origination of Intra-Area-Prefix LSAs.
We now comply with RFC5340 and move prefixes between the two
ref-types of Intra-Area-Prefix LSAs (router and network).

In case an LSA ends up having all of its prefixes moved to another
one, the LSA is flushed from the LSDB by re-originating with MAX_AGE.
(This does not yet work reliably. We end up having LSAs with zero
prefixes in the LSDB in some cases. Should not affect SPF calculation,
so not much harm done, but will need to be fixed.)

This commit just adds the necessary code to do origination,
but it is not being called yet. This will be done in a separate
commit.

"Looks good." claudio@

Revision 1.21 / (download) - annotate - [select for diffs], Thu Feb 19 22:05:32 2009 UTC (15 years, 3 months ago) by stsp
Branch: MAIN
Changes since 1.20: +17 -1 lines
Diff to previous 1.20 (colored)

Sync iface fsm state from ospfe to rde.

Also syncs other fields the ospfe is syncing to when getting
iface updates from parent process.
None of these fields are used by the rde yet, but state will be
important soon, for proper origination of Intra-Area-Prefix LSAs.

ok claudio@

Revision 1.20 / (download) - annotate - [select for diffs], Tue Feb 10 17:32:58 2009 UTC (15 years, 4 months ago) by stsp
Branch: MAIN
Changes since 1.19: +2 -2 lines
Diff to previous 1.19 (colored)

Fix two obvious copy-paste errors in fatal error messages. We were
printing IFINFO while we are actually handling an IFDELETE imsg.

Revision 1.19 / (download) - annotate - [select for diffs], Tue Feb 3 14:02:01 2009 UTC (15 years, 4 months ago) by stsp
Branch: MAIN
Changes since 1.18: +4 -4 lines
Diff to previous 1.18 (colored)

Formatting fixes.

Revision 1.18 / (download) - annotate - [select for diffs], Thu Jan 29 12:16:09 2009 UTC (15 years, 4 months ago) by stsp
Branch: MAIN
Changes since 1.17: +2 -2 lines
Diff to previous 1.17 (colored)

Hard-code the Link State ID of Intra-Area-Prefix LSAs referencing Network
LSAs to zero. We were using the interface index, which is not quite right
for this type of LSA.

This is part of a greater scheme:
Intra-Area-Prefix LSAs referencing Router LSAs (not yet implemented)
will initially have their Link State ID hard-coded to one.
Then, as soon as we implement fragmentation of Intra-Area-Prefix LSAs,
Link State IDs for both types of Intra-Area-Prefix LSA will have to be
generated dynamically in a non-overlapping fashion.

discussed with claudio@

Revision 1.17 / (download) - annotate - [select for diffs], Thu Jan 29 11:57:42 2009 UTC (15 years, 4 months ago) by stsp
Branch: MAIN
Changes since 1.16: +3 -2 lines
Diff to previous 1.16 (colored)

Improve debugging message in orig_intra_lsa_net().
Print not just the area, but also the interface to the link the LSA
is generated for.
ok claudio@

Revision 1.16 / (download) - annotate - [select for diffs], Wed Jan 28 22:47:36 2009 UTC (15 years, 4 months ago) by stsp
Branch: MAIN
Changes since 1.15: +205 -3 lines
Diff to previous 1.15 (colored)

Teach ospf6d to originate Intra-Area-Prefix LSAs, which associate a list
of IPv6 prefixes with a Network LSA (there's another type of this LSA which
associates prefixes with a Router LSA -- this remains to be done).
Add what is necessary to allow ospf6ctl to read the new LSA type via IMSG.
ok claudio@

Revision 1.15 / (download) - annotate - [select for diffs], Tue Jan 27 12:52:08 2009 UTC (15 years, 4 months ago) by michele
Branch: MAIN
Changes since 1.14: +2 -3 lines
Diff to previous 1.14 (colored)

Again, no need to double check if neighbor exists.

ok stsp@

Revision 1.14 / (download) - annotate - [select for diffs], Sat Jan 3 00:23:50 2009 UTC (15 years, 5 months ago) by stsp
Branch: MAIN
Changes since 1.13: +2 -2 lines
Diff to previous 1.13 (colored)

Since link LSAs live in iface->lsa_tree and not in area->lsa_tree,
we had better include LSAs from iface->lsa_tree when sending
DB summaries. Fixes initial flood of link LSAs.
ok claudio@

Revision 1.13 / (download) - annotate - [select for diffs], Tue Dec 30 21:31:54 2008 UTC (15 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.12: +2 -1 lines
Diff to previous 1.12 (colored)

First try at originating Link (type-8) LSA. Code is wrong and the initial
LSA is lost in lsa_flood. Put this in because it goes in the right direction
and ospf6d is work in progress. Add necessary framework so that we can print
Link LSA in ospf6ctl.
Diff mostly from stsp@ ospf6ctl part by myself

Revision 1.12 / (download) - annotate - [select for diffs], Sun Dec 28 18:43:53 2008 UTC (15 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.11: +2 -2 lines
Diff to previous 1.11 (colored)

No need to byteswap req_hdr.type as lsa_find() will do that for us.
From Stefan Sperling

Revision 1.11 / (download) - annotate - [select for diffs], Mon Feb 11 13:48:39 2008 UTC (16 years, 4 months ago) by norby
Branch: MAIN
CVS Tags: OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.10: +9 -6 lines
Diff to previous 1.10 (colored)

Correct the output of several error and debug messages.

Revision 1.10 / (download) - annotate - [select for diffs], Thu Dec 13 08:54:05 2007 UTC (16 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.9: +28 -15 lines
Diff to previous 1.9 (colored)

Monster commit of stuff I did mostly last month. What it does:
 * removes kif and uses iface for everything interface related.
   This removes unneeded data redundancy which makes the code more complex.
 * adds the link local prefix to struct iface and attaches a list with
   the other prefixes to the struct iface. This is needed to generate the
   link LSA.
 * disconnects struct iface from struct area (the backpointer is gone)
   this will make the reload code a bit easier.
norby@ agrees with the direction we're heading with this

Revision 1.9 / (download) - annotate - [select for diffs], Tue Nov 27 12:23:06 2007 UTC (16 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.8: +27 -13 lines
Diff to previous 1.8 (colored)

Make lsa_find() find link local LSA by passing the interface instead of the
area as lookup point. Additionally make lsa_dump or actually the code around
it pass all LSA to ospf6ctl. The rde_spf.c are not final.

Revision 1.8 / (download) - annotate - [select for diffs], Tue Nov 27 11:29:34 2007 UTC (16 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.7: +11 -1 lines
Diff to previous 1.7 (colored)

Monster diff to bring us a bit on track again.
a) implement all (or at least most) lsa_check() cases.
b) classify the LSA scope correctly and add a per interface lsa_tree for
   the link local stuff.
c) implement a function to parse a prefix.

There is still a lot missing currently link local LSA are added to the
interface tree but nothing can access them (lsa_find() and a few friends
need some changes).
OK norby@

Revision 1.7 / (download) - annotate - [select for diffs], Wed Oct 17 07:16:02 2007 UTC (16 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.6: +2 -3 lines
Diff to previous 1.6 (colored)

lsa_snap() should work so enable it.

Revision 1.6 / (download) - annotate - [select for diffs], Tue Oct 16 20:27:24 2007 UTC (16 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.5: +1 -3 lines
Diff to previous 1.5 (colored)

Enable the IMSG_DD related code. This code starts to work.

Revision 1.5 / (download) - annotate - [select for diffs], Tue Oct 16 12:05:52 2007 UTC (16 years, 7 months ago) by norby
Branch: MAIN
Changes since 1.4: +4 -5 lines
Diff to previous 1.4 (colored)

In OSPFv3 the LSA type is a 16 bit value, furthermore it uses different
values than the v2 counterpart.

Change to u_int16_t and define new LSA types.

ok claudio@

Revision 1.4 / (download) - annotate - [select for diffs], Tue Oct 16 08:41:56 2007 UTC (16 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.3: +15 -7 lines
Diff to previous 1.3 (colored)

First step at making kroute IPv6 aware. This resulted in many additional
changes -- some are so hairy that I left them out for later by commenting out
larger blocks of code (just grep for XXX if you like to help).
Get it in early so that we can work on.
OK norby@

Revision 1.3 / (download) - annotate - [select for diffs], Thu Oct 11 20:01:38 2007 UTC (16 years, 8 months ago) by claudio
Branch: MAIN
Changes since 1.2: +5 -2 lines
Diff to previous 1.2 (colored)

Disable some code that is currently far from working and results in frequent
session resets because of bad packets. With this it seems we survive the
hello and database exchange phases. A closer look at the DR and BDR calculation
is still needed.

Revision 1.2 / (download) - annotate - [select for diffs], Thu Oct 11 19:02:47 2007 UTC (16 years, 8 months ago) by claudio
Branch: MAIN
Changes since 1.1: +4 -4 lines
Diff to previous 1.1 (colored)

From ospfd:
Bye bye global ospf options. OSPF options are per area (at least the one
flag that we set). So introduce a area_ospf_options() function that will
return the correct flags for each area. This makes stub area support a lot
easier.
Don't check for OSPF_OPTION_E in the parent. OSPF_OPTION_E is per area and
so the parent process has no way to know if it should redistribute or not.

Revision 1.1 / (download) - annotate - [select for diffs], Mon Oct 8 10:44:51 2007 UTC (16 years, 8 months ago) by norby
Branch: MAIN

Welcome ospf6d

The new ospf6d daemon will support OSPFv3, basically OSPF for IPv6 networks.

It is heavily based on ospfd(8), it is more or less a copy and paste of it.
Currently some unneeded stuff has been removed and the trasition from
IPv4 to IPv6 has begun.

ospf6d is not very usefull at the moment, it is being imported to allow more
people to work on it concurrently.

Not yet connected to the builds.

ok claudio@ dlg@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.