OpenBSD CVS

CVS log for src/usr.sbin/ospfd/database.c


[BACK] Up to [local] / src / usr.sbin / ospfd

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.37 / (download) - annotate - [select for diffs], Tue Jun 20 15:19:55 2023 UTC (11 months, 2 weeks ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, HEAD
Changes since 1.36: +5 -4 lines
Diff to previous 1.36 (colored)

Update ospfd to use new ibuf api.

This mostly moves away from memcpy(ibuf_seek(buf, off, size), data, size) to
ibuf_set(buf, off, data, size). Also ibuf_reserve() is replaced with
ibuf_add_zero().

OK tb@

Revision 1.36 / (download) - annotate - [select for diffs], Wed Mar 8 04:43:14 2023 UTC (15 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_7_3_BASE, OPENBSD_7_3
Changes since 1.35: +1 -2 lines
Diff to previous 1.35 (colored)

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

Revision 1.35 / (download) - annotate - [select for diffs], Wed Nov 3 21:40:03 2021 UTC (2 years, 7 months ago) by sthen
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.34: +39 -34 lines
Diff to previous 1.34 (colored)

log the interface along with the neighbour ID in various ospfd/ospf6d
messages.  ok remi@ benno@

if a neighbour is reachable over multiple network links, some problems
may be related to the link itself rather than the neighbour, so knowing
the interface can be important when trying to locate the source of a
problem.

Revision 1.34 / (download) - annotate - [select for diffs], Mon Jul 15 18:26:39 2019 UTC (4 years, 10 months ago) by remi
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.33: +7 -8 lines
Diff to previous 1.33 (colored)

Improve logging when sending a packet fails.

OK claudio@

Revision 1.33 / (download) - annotate - [select for diffs], Thu Feb 18 15:33:24 2016 UTC (8 years, 3 months ago) by bluhm
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.32: +2 -2 lines
Diff to previous 1.32 (colored)

Fix format string of a warning.
from markus@; OK claudio@

Revision 1.32 / (download) - annotate - [select for diffs], Fri Mar 13 02:31:29 2015 UTC (9 years, 2 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8
Changes since 1.31: +42 -34 lines
Diff to previous 1.31 (colored)

Make sure that the debug messages include the neighbor ID so we hava a chance
to know which neighbor caused the problems. While there make sure that all
messages log roughly in the same way.

Revision 1.31 / (download) - annotate - [select for diffs], Sat Oct 25 03:23:49 2014 UTC (9 years, 7 months ago) by lteo
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.30: +1 -2 lines
Diff to previous 1.30 (colored)

Remove unnecessary netinet/in_systm.h include.

ok millert@

Revision 1.30 / (download) - annotate - [select for diffs], Thu Jan 17 08:58:53 2013 UTC (11 years, 4 months ago) by markus
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3
Changes since 1.29: +1 -2 lines
Diff to previous 1.29 (colored)

the event NBR_EVT_SEQ_NUM_MIS is not defined in state NBR_STA_XSTRT
(would change back to NBR_STA_XSTRT anyway)
ok claudio@

Revision 1.29 / (download) - annotate - [select for diffs], Mon May 9 12:24:41 2011 UTC (13 years, 1 month ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0
Changes since 1.28: +10 -2 lines
Diff to previous 1.28 (colored)

First bits to support opaque LSA. Type-9, 10 and 11 are LSA that can
hold about any data you like and is used for things like greaceful
reload. Implement the basic redistribute logic and LSDB handling but
the data sent is currently not looked at.
Tested and OK sthen@

Revision 1.28 / (download) - annotate - [select for diffs], Fri Mar 4 09:24:46 2011 UTC (13 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.27: +4 -4 lines
Diff to previous 1.27 (colored)

Indent block correctly.

Revision 1.27 / (download) - annotate - [select for diffs], Wed May 26 13:56:08 2010 UTC (14 years ago) by nicm
Branch: MAIN
CVS Tags: OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.26: +9 -9 lines
Diff to previous 1.26 (colored)

Rename some imsg bits to make namespace collisions less likely buf to
ibuf, buf_read to ibuf_read, READ_BUF_SIZE to IBUF_READ_SIZE.

ok henning gilles claudio jacekm deraadt

Revision 1.26 / (download) - annotate - [select for diffs], Sat Jan 31 11:44:49 2009 UTC (15 years, 4 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7, OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.25: +3 -3 lines
Diff to previous 1.25 (colored)

Implement buf_left() to make some some more buffer handling easier.
buf_left() returns the bytes left in a buffer. This makes the check to
keep MD5_DIGEST_LENGTH bytes unallocated in some messages easier.
From the buf cleanup diff that was OK norby@ and henning@

Revision 1.25 / (download) - annotate - [select for diffs], Sat Jan 31 08:55:00 2009 UTC (15 years, 4 months ago) by claudio
Branch: MAIN
Changes since 1.24: +2 -2 lines
Diff to previous 1.24 (colored)

Pass the buffer to send_packet() instead of spliting it up. This removes
some direct access to struct buf internals in the rest of ospfe.
Based on a larger buffer cleanup diff that was OK norby@ henning@

Revision 1.24 / (download) - annotate - [select for diffs], Thu Jan 8 19:18:17 2009 UTC (15 years, 5 months ago) by claudio
Branch: MAIN
Changes since 1.23: +3 -2 lines
Diff to previous 1.23 (colored)

Include the neighbor ID in a debug output so that it is clear which router
is sendingf the duplicate entries. OK norby@

Revision 1.23 / (download) - annotate - [select for diffs], Mon Nov 24 18:28:02 2008 UTC (15 years, 6 months ago) by claudio
Branch: MAIN
Changes since 1.22: +4 -5 lines
Diff to previous 1.22 (colored)

Initial support for stub areas. The bit still missing is the redistribution
of the default summary net lsa on ABRs but that is comming. OK norby@

Revision 1.22 / (download) - annotate - [select for diffs], Mon Feb 11 12:37:37 2008 UTC (16 years, 4 months ago) by norby
Branch: MAIN
CVS Tags: OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.21: +3 -3 lines
Diff to previous 1.21 (colored)

Correct the output of several error and debug messages.

Revision 1.21 / (download) - annotate - [select for diffs], Thu Oct 11 12:19:31 2007 UTC (16 years, 8 months ago) by claudio
Branch: MAIN
Changes since 1.20: +2 -2 lines
Diff to previous 1.20 (colored)

Bye bye global ospf options. OSPF options are per area (at least the one
flag that we set). So introduce a area_ospf_options() function that will
return the correct flags for each area. This makes stub area support a lot
easier.
OK norby@

Revision 1.20 / (download) - annotate - [select for diffs], Thu Oct 11 08:21:29 2007 UTC (16 years, 8 months ago) by claudio
Branch: MAIN
Changes since 1.19: +31 -30 lines
Diff to previous 1.19 (colored)

Do not overload nbr->options with the dd exchange bits. nbr->options is used
by the hello protocol. Instead add a dd_more flag that is used together with
(the renamed) dd_master flag.
Tested and OK norby@

Revision 1.19 / (download) - annotate - [select for diffs], Mon Mar 13 09:36:06 2006 UTC (18 years, 3 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.18: +11 -9 lines
Diff to previous 1.18 (colored)

The return value of the start/stop timer functions is almost never checked.
Switch them to void functions and check if evtimer_add/del fails -- in which
case we fatal() as there is no useful way to recover in such an event.
OK norby@

Revision 1.18 / (download) - annotate - [select for diffs], Thu Mar 9 13:34:19 2006 UTC (18 years, 3 months ago) by claudio
Branch: MAIN
Changes since 1.17: +2 -1 lines
Diff to previous 1.17 (colored)

Mark event callbacks with ARGSUSED to silence lint.

Revision 1.17 / (download) - annotate - [select for diffs], Sat Nov 12 18:18:24 2005 UTC (18 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9
Changes since 1.16: +1 -2 lines
Diff to previous 1.16 (colored)

spacing mostly

Revision 1.16 / (download) - annotate - [select for diffs], Fri Nov 4 10:30:23 2005 UTC (18 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.15: +4 -5 lines
Diff to previous 1.15 (colored)

In the super fast start-up case in recv_db_description() make sure the
the 2WAY neighbor event is issued before the interface NBR_CHNG.
Fix some comments while there.

Revision 1.15 / (download) - annotate - [select for diffs], Wed Oct 19 21:43:20 2005 UTC (18 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.14: +2 -2 lines
Diff to previous 1.14 (colored)

fix some spellings in comments.

Revision 1.14 / (download) - annotate - [select for diffs], Tue Oct 18 15:39:05 2005 UTC (18 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.13: +4 -3 lines
Diff to previous 1.13 (colored)

Better warning for non equal MTU in the database phase. Instead of just
whining that the MTU differs tell actually what is expected and what was
sent.  OK norby@

Revision 1.13 / (download) - annotate - [select for diffs], Sat Sep 17 20:03:35 2005 UTC (18 years, 8 months ago) by msf
Branch: MAIN
Changes since 1.12: +2 -2 lines
Diff to previous 1.12 (colored)

- add get_rtr_id() based on bgpd's get_bgpid()
- remove rtr_id from struct iface we don't need to keep a copy of this value
  per interface
- replace all references to iface->rtr_id.s_addr with calls to ospfe_rtr_id()

ok claudio@ norby@

Revision 1.12 / (download) - annotate - [select for diffs], Fri May 27 05:51:22 2005 UTC (19 years ago) by norby
Branch: MAIN
CVS Tags: OPENBSD_3_8_BASE, OPENBSD_3_8
Changes since 1.11: +4 -3 lines
Diff to previous 1.11 (colored)

Virtual link support.

ok claudio@

Revision 1.11 / (download) - annotate - [select for diffs], Thu May 26 19:54:49 2005 UTC (19 years ago) by norby
Branch: MAIN
Changes since 1.10: +1 -4 lines
Diff to previous 1.10 (colored)

Simplify and cleanup passive interface handling.

ok claudio@

Revision 1.10 / (download) - annotate - [select for diffs], Thu May 26 19:10:56 2005 UTC (19 years ago) by norby
Branch: MAIN
Changes since 1.9: +1 -36 lines
Diff to previous 1.9 (colored)

Remove a lot of unneeded debug output during the database change.

Revision 1.9 / (download) - annotate - [select for diffs], Fri Apr 22 15:33:00 2005 UTC (19 years, 1 month ago) by claudio
Branch: MAIN
Changes since 1.8: +2 -2 lines
Diff to previous 1.8 (colored)

RFC tells that the MTU in the db exchange packet may not be bigger than
the interface MTU but it may be smaller. This makes Philip Olssons
extreme networks summit24 happy as this stupid thing sets the MTU to 0.
testing Philip Olsson, OK norby@

Revision 1.8 / (download) - annotate - [select for diffs], Tue Apr 12 09:47:30 2005 UTC (19 years, 2 months ago) by claudio
Branch: MAIN
Changes since 1.7: +2 -2 lines
Diff to previous 1.7 (colored)

spaces

Revision 1.7 / (download) - annotate - [select for diffs], Tue Apr 5 13:01:21 2005 UTC (19 years, 2 months ago) by claudio
Branch: MAIN
Changes since 1.6: +35 -37 lines
Diff to previous 1.6 (colored)

Use the dynamic buffer API for packet generation and sending.
OK norby@

Revision 1.6 / (download) - annotate - [select for diffs], Tue Mar 22 22:13:48 2005 UTC (19 years, 2 months ago) by norby
Branch: MAIN
Changes since 1.5: +2 -2 lines
Diff to previous 1.5 (colored)

Remove bool cruft.

ok claudio@

Revision 1.5 / (download) - annotate - [select for diffs], Thu Feb 10 14:05:48 2005 UTC (19 years, 4 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_3_7_BASE, OPENBSD_3_7
Changes since 1.4: +7 -3 lines
Diff to previous 1.4 (colored)

Work around a timing issue in the db exchange phase. The DB description
packets comming from the net are looped through the RDE and may get
delayed because of this. The result is that the neighbor FSM ends in
state FULL instead of LOADING and so the LSDB is not correctly
synchronized. Issue found by norby@ OK norby@

Revision 1.4 / (download) - annotate - [select for diffs], Wed Feb 9 15:39:22 2005 UTC (19 years, 4 months ago) by claudio
Branch: MAIN
Changes since 1.3: +5 -4 lines
Diff to previous 1.3 (colored)

Once again a round of bugfixes in the db exchange process. This is
one of the worst documented parts of the RFC.
The initial packet sent by the slave may have no flags set. Don't
enforce that the M bit is set but instead check that the I bit and
MS bit are unset.
The master should only issue NBR_EVT_XCHNG_DONE if it has sent at
least one packet with M bit cleared else the slave may get stuck
in state Exchange.
In NBR_STA_LOAD the db_tx_timer() still needs to send db descriptions
out. This will be the last packet sent with the cleared M bit.

Revision 1.3 / (download) - annotate - [select for diffs], Wed Feb 2 19:15:07 2005 UTC (19 years, 4 months ago) by henning
Branch: MAIN
Changes since 1.2: +2 -2 lines
Diff to previous 1.2 (colored)

KNF

Revision 1.2 / (download) - annotate - [select for diffs], Fri Jan 28 17:53:33 2005 UTC (19 years, 4 months ago) by norby
Branch: MAIN
Changes since 1.1: +2 -2 lines
Diff to previous 1.1 (colored)

Change my email address to the OpenBSD one since Ericsson has nothing to
do with this software, just happend to be my only valid email address at
the time.

Revision 1.1 / (download) - annotate - [select for diffs], Fri Jan 28 14:05:40 2005 UTC (19 years, 4 months ago) by claudio
Branch: MAIN

Welcome ospfd
started by Esben Norby some time ago by using the imsg/three process framework
of bgpd. He implemented the basic concept plus the ospf finite state machines.
Later I joined and helped him cleanup, debug and extend his work.
Right now it is not particularly useful, major parts are still missing but is
imported to allow more people to work on it.
status:
The basic protocol works for broadcast networks and the LS database is
synchronized and updated. It is not possible to be DR or BDR on a network
and other interface types like point-to-point are not yet supported.
The shortest path tree is not calculated and so no routing information is
exchanged with the kernel FIB.

Not yet connected to the builds.
OK henning@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.