OpenBSD CVS

CVS log for src/usr.sbin/pppd/sys-bsd.c


[BACK] Up to [local] / src / usr.sbin / pppd

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.33 / (download) - annotate - [select for diffs], Mon Feb 19 16:39:03 2024 UTC (3 months, 1 week ago) by denis
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, HEAD
Changes since 1.32: +2 -2 lines
Diff to previous 1.32 (colored)

use correct rtmsg member in sizeof()

OK miod@

Revision 1.32 / (download) - annotate - [select for diffs], Sun Oct 24 21:24:19 2021 UTC (2 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.31: +2 -2 lines
Diff to previous 1.31 (colored)

For open/openat, if the flags parameter does not contain O_CREAT, the
3rd (variadic) mode_t parameter is irrelevant.  Many developers in the past
have passed mode_t (0, 044, 0644, or such), which might lead future people
to copy this broken idiom, and perhaps even believe this parameter has some
meaning or implication or application. Delete them all.
This comes out of a conversation where tb@ noticed that a strange (but
intentional) pledge behaviour is to always knock-out high-bits from
mode_t on a number of system calls as a safety factor, and his bewilderment
that this appeared to be happening against valid modes (at least visually),
but no sorry, they are all irrelevant junk.  They could all be 0xdeafbeef.
ok millert

Revision 1.31 / (download) - annotate - [select for diffs], Fri Sep 3 08:18:31 2021 UTC (2 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0
Changes since 1.30: +7 -18 lines
Diff to previous 1.30 (colored)

sigh -- review one one pointless sys/param.h, and discover all the includes
are a mess.

Revision 1.30 / (download) - annotate - [select for diffs], Tue Dec 29 19:45:28 2020 UTC (3 years, 5 months ago) by benno
Branch: MAIN
CVS Tags: OPENBSD_6_9_BASE, OPENBSD_6_9
Changes since 1.29: +8 -3 lines
Diff to previous 1.29 (colored)

getifaddrs() can return entries where ifa_addr is NULL. Check for this
before accessing anything in ifa_addr.
ok claudio@

Revision 1.29 / (download) - annotate - [select for diffs], Fri Jun 28 13:32:49 2019 UTC (4 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.28: +65 -65 lines
Diff to previous 1.28 (colored)

When system calls indicate an error they return -1, not some arbitrary
value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

Revision 1.28 / (download) - annotate - [select for diffs], Tue Jan 22 09:25:29 2019 UTC (5 years, 4 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.27: +4 -4 lines
Diff to previous 1.27 (colored)

PF_ROUTE -> AF_ROUTE in the scattered sock()/setsockopt() calls
where the "wrong" #define was used.

ok dlg@

Revision 1.27 / (download) - annotate - [select for diffs], Sat Sep 12 12:42:36 2015 UTC (8 years, 8 months ago) by miod
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.26: +1 -10 lines
Diff to previous 1.26 (colored)

Remove dead get_host_seed() function; Martin Natano

Revision 1.26 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:53 2009 UTC (14 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7, OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.25: +1 -9 lines
Diff to previous 1.25 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.25 / (download) - annotate - [select for diffs], Wed Oct 8 18:42:21 2008 UTC (15 years, 7 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.24: +7 -4 lines
Diff to previous 1.24 (colored)

SIOCAIFADDR can fail with EEXIST either if the local or the destination
address already exists so mention both addresses in the error message.
From PR4584 (alexander at beard dot se) I just tuned the error message a bit.

Revision 1.24 / (download) - annotate - [select for diffs], Mon Jun 4 14:59:45 2007 UTC (17 years ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.23: +2 -103 lines
Diff to previous 1.23 (colored)

bye bye ipx

Revision 1.23 / (download) - annotate - [select for diffs], Wed May 26 14:22:54 2004 UTC (20 years ago) by otto
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6
Changes since 1.22: +4 -6 lines
Diff to previous 1.22 (colored)

Better message if interface is not available. Hint from Daniel Polak.
ok henning@ jmc@

Revision 1.22 / (download) - annotate - [select for diffs], Tue Aug 19 22:19:07 2003 UTC (20 years, 9 months ago) by itojun
Branch: MAIN
CVS Tags: OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.21: +31 -52 lines
Diff to previous 1.21 (colored)

rewrite SIOCGIFCONF into getifaddrs.  deraadt ok

Revision 1.21 / (download) - annotate - [select for diffs], Wed May 14 02:02:56 2003 UTC (21 years ago) by itojun
Branch: MAIN
Changes since 1.20: +4 -4 lines
Diff to previous 1.20 (colored)

move ETHERTYPE_xx declarations to <net/ethertypes.h>.  meets netbsd practice.
deraadt ok

Revision 1.20 / (download) - annotate - [select for diffs], Fri Apr 4 20:25:07 2003 UTC (21 years, 2 months ago) by deraadt
Branch: MAIN
Changes since 1.19: +4 -6 lines
Diff to previous 1.19 (colored)

strlcpy and snprintf; various people ok

Revision 1.19 / (download) - annotate - [select for diffs], Fri Sep 13 00:12:10 2002 UTC (21 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2
Changes since 1.18: +31 -16 lines
Diff to previous 1.18 (colored)

Paul Mackerras and the Australian National University have worked things
out, and as a result, Paul now owns copyright on all these files, with the
proper terms.

Revision 1.18 / (download) - annotate - [select for diffs], Mon Jul 1 19:31:37 2002 UTC (21 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.17: +40 -3 lines
Diff to previous 1.17 (colored)

license update of CMU parts.  due to communication with wcw+@andrew.cmu.edu,
pushed for by tygs@netcologne.de.  Apparently we also now known how to talk
to the lawyers there, if we were so mad.  Note that a few other copyright
issues in pppd still remain, so this does not close this story.

Revision 1.17 / (download) - annotate - [select for diffs], Sun May 26 09:25:21 2002 UTC (22 years ago) by deraadt
Branch: MAIN
Changes since 1.16: +9 -8 lines
Diff to previous 1.16 (colored)

pid_t cleanup

Revision 1.16 / (download) - annotate - [select for diffs], Sat Feb 16 21:28:07 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.15: +4 -4 lines
Diff to previous 1.15 (colored)

Part one of userland __P removal.  Done with a simple regexp with some minor hand editing to make comments line up correctly.  Another pass is forthcoming that handles the cases that could not be done automatically.

Revision 1.15 / (download) - annotate - [select for diffs], Sat Jun 23 15:34:02 2001 UTC (22 years, 11 months ago) by lebel
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0
Changes since 1.14: +14 -26 lines
Diff to previous 1.14 (colored)

use strlcpy vs strncpy+a[len-1]='\0'

Revision 1.14 / (download) - annotate - [select for diffs], Fri May 8 04:52:33 1998 UTC (26 years, 1 month ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_9_BASE, OPENBSD_2_9, OPENBSD_2_8_BASE, OPENBSD_2_8, OPENBSD_2_7_BASE, OPENBSD_2_7, OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4
Changes since 1.13: +21 -4 lines
Diff to previous 1.13 (colored)

pppd 2.3.5

Revision 1.13 / (download) - annotate - [select for diffs], Fri Mar 20 03:10:03 1998 UTC (26 years, 2 months ago) by angelos
Branch: MAIN
CVS Tags: OPENBSD_2_3_BASE, OPENBSD_2_3
Changes since 1.12: +4 -2 lines
Diff to previous 1.12 (colored)

Aliases...

Revision 1.12 / (download) - annotate - [select for diffs], Sat Jan 17 20:30:29 1998 UTC (26 years, 4 months ago) by millert
Branch: MAIN
Changes since 1.11: +4 -5 lines
Diff to previous 1.11 (colored)

ppp-2.3.3 + some -Wall

Revision 1.11 / (download) - annotate - [select for diffs], Wed Dec 17 08:49:46 1997 UTC (26 years, 5 months ago) by deraadt
Branch: MAIN
Changes since 1.10: +24 -10 lines
Diff to previous 1.10 (colored)

do not let fd_set overflow

Revision 1.10 / (download) - annotate - [select for diffs], Sun Nov 30 00:36:21 1997 UTC (26 years, 6 months ago) by millert
Branch: MAIN
Changes since 1.9: +3 -3 lines
Diff to previous 1.9 (colored)

Fix setting of crtscts.  It was not being set in set_up_tty() if the
local var "local" is set.  This is a problem since that is set
during chat.  Use the "modem" var instead.

Revision 1.9 / (download) - annotate - [select for diffs], Sun Sep 28 21:44:37 1997 UTC (26 years, 8 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.8: +10 -2 lines
Diff to previous 1.8 (colored)

Allow pppd to change interface addr when demand dialing & dynamic addressing.
Fix from Dave Huang <khym@bga.com> based on what ifconfig does.

Revision 1.8 / (download) - annotate - [select for diffs], Fri Sep 5 04:32:45 1997 UTC (26 years, 9 months ago) by millert
Branch: MAIN
Changes since 1.7: +69 -28 lines
Diff to previous 1.7 (colored)

ppp 2.3.1

Revision 1.7 / (download) - annotate - [select for diffs], Fri Jun 27 02:16:23 1997 UTC (26 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.6: +3 -3 lines
Diff to previous 1.6 (colored)

long nightmares

Revision 1.6 / (download) - annotate - [select for diffs], Sun Apr 27 21:45:16 1997 UTC (27 years, 1 month ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.5: +5 -4 lines
Diff to previous 1.5 (colored)

better failure msg; martin@rumolt.teuto.de

Revision 1.5 / (download) - annotate - [select for diffs], Mon Dec 23 13:22:49 1996 UTC (27 years, 5 months ago) by mickey
Branch: MAIN
Changes since 1.4: +109 -60 lines
Diff to previous 1.4 (colored)

pppd 2.3b3 import. some minor buf oflow fixes and so.
try it out ppl, but i've got it running talking to cisco w/ all the AFs
enabled in kernel.

Revision 1.4 / (download) - annotate - [select for diffs], Sun Jul 14 00:27:09 1996 UTC (27 years, 10 months ago) by downsj
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.3: +13 -3 lines
Diff to previous 1.3 (colored)

netbsd pr#2623: fix VJ compression and active filter, John Kohl
<jtk@kolvir.arlington.ma.us>

Revision 1.3 / (download) - annotate - [select for diffs], Sun Apr 21 23:41:29 1996 UTC (28 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.2: +8 -3 lines
Diff to previous 1.2 (colored)

sync to netbsd 960418

Revision 1.2 / (download) - annotate - [select for diffs], Mon Mar 25 15:55:57 1996 UTC (28 years, 2 months ago) by niklas
Branch: MAIN
Changes since 1.1: +460 -130 lines
Diff to previous 1.1 (colored)

From NetBSD: merge of 960317

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:48:00 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:48:00 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.