![[BACK]](/icons/back.gif){kind=icon}
Up to [local] / src / usr.sbin / relayd
Request diff between arbitrary revisions
Default branch: MAIN
Revision 1.19, Mon Oct 26 16:52:06 2020 UTC (3 years, 7 months ago) by martijn
Branch: MAIN
CVS Tags: HEAD
Changes since 1.18: +0 -0 lines
FILE REMOVED
Let relayd make use of libagentx. No functional change intended. OK tb@ Enthousiasm from Mischa Peters
Revision 1.18 / (download) - annotate - [select for diffs], Sun Oct 25 10:17:48 2020 UTC (3 years, 7 months ago) by denis
Branch: MAIN
Changes since 1.17: +9 -9 lines
Diff to previous 1.17 (colored)
Remove trailing spaces & tabs
Revision 1.17 / (download) - annotate - [select for diffs], Tue Sep 15 09:23:22 2020 UTC (3 years, 8 months ago) by martijn
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE,
OPENBSD_6_8
Changes since 1.16: +0 -1 lines
Diff to previous 1.16 (colored)
Fix a dead store and a wrong-level NULL-check. Found the static analyzer from tb@ OK beck@
Revision 1.16 / (download) - annotate - [select for diffs], Mon Sep 14 11:30:25 2020 UTC (3 years, 8 months ago) by martijn
Branch: MAIN
Changes since 1.15: +1171 -911 lines
Diff to previous 1.15 (colored)
Rewrite the agentx code of relayd. This new framework should allow us
to add new objects easier if so desired and should handle a lot more
corner-cases.
This commit should also fix the following:
- On most (all) tables it omits the *Entry elements, making it not map to
OPENBSD-RELAYD-MIB.txt.
- sstolen returns the size of the sockaddr_in{,6}, instead of the
sin{,6}_addr resulting in garbage data to be put in the ip-field.
- relaydSessionPortIn and relaydSessionPortOut are swapped
- relaydSessions only uses relaydSessionIndex, while
OPENBSD-RELAYD-MIB.txt says it should have 2 indices
- miscellaneous minor things related to the AGENTX-protocol, like wonky
index handeling and returning NOSUCHINSTANCE where NOSUCHOBJECT
should be returned, etc.
This commit does remove traps, but it's large enough as is and I intent
on adding it soon(tm). It also deprecates the snmp keyword in favour of
an agentx keyword. The snmp keyword is still available, but will be
removed in the future.
Tweaks and OK denis@ on the relayd parts
Tweaks and OK claudio@ on the agentx parts
"Get it in" deraadt@
Revision 1.15 / (download) - annotate - [select for diffs], Fri Jun 5 19:50:59 2020 UTC (3 years, 11 months ago) by denis
Branch: MAIN
Changes since 1.14: +1 -2 lines
Diff to previous 1.14 (colored)
Remove redundant code Reported by Prof. Dr. Steffen Wendzel <wendzel @ hs-worms . de>, thanks! OK martijn@ sthen@
Revision 1.14 / (download) - annotate - [select for diffs], Sun May 28 10:39:15 2017 UTC (7 years ago) by benno
Branch: MAIN
CVS Tags: OPENBSD_6_7_BASE,
OPENBSD_6_7,
OPENBSD_6_6_BASE,
OPENBSD_6_6,
OPENBSD_6_5_BASE,
OPENBSD_6_5,
OPENBSD_6_4_BASE,
OPENBSD_6_4,
OPENBSD_6_3_BASE,
OPENBSD_6_3,
OPENBSD_6_2_BASE,
OPENBSD_6_2
Changes since 1.13: +2 -2 lines
Diff to previous 1.13 (colored)
use __func__ in log messages. fix some whitespace while here. From Hiltjo Posthuma hiltjo -AT codemadness -DOT- org, thanks! ok florian, claudio
Revision 1.13 / (download) - annotate - [select for diffs], Mon Dec 7 04:03:27 2015 UTC (8 years, 5 months ago) by mmcc
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE,
OPENBSD_6_1,
OPENBSD_6_0_BASE,
OPENBSD_6_0,
OPENBSD_5_9_BASE,
OPENBSD_5_9
Changes since 1.12: +2 -3 lines
Diff to previous 1.12 (colored)
Remove NULL-checks before free(). No functional change.
Revision 1.12 / (download) - annotate - [select for diffs], Sun Jul 19 01:08:07 2015 UTC (8 years, 10 months ago) by blambert
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE,
OPENBSD_5_8
Changes since 1.11: +18 -9 lines
Diff to previous 1.11 (colored)
don't return failure for agentx messages with 0-length payloads allows snmpd to properly handle ping messages from agentx subagents ok reyk@
Revision 1.11 / (download) - annotate - [select for diffs], Thu Jan 22 17:42:09 2015 UTC (9 years, 4 months ago) by reyk
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE,
OPENBSD_5_7
Changes since 1.10: +2 -4 lines
Diff to previous 1.10 (colored)
Clean up the relayd headers with help of include-what-you-use and some manual review. Based on common practice, relayd.h now includes the necessary headers for itself. OK benno@
Revision 1.10 / (download) - annotate - [select for diffs], Thu Jan 22 15:21:28 2015 UTC (9 years, 4 months ago) by reyk
Branch: MAIN
Changes since 1.9: +4 -3 lines
Diff to previous 1.9 (colored)
spacing
Revision 1.9 / (download) - annotate - [select for diffs], Sun Dec 21 00:54:49 2014 UTC (9 years, 5 months ago) by guenther
Branch: MAIN
Changes since 1.8: +1 -3 lines
Diff to previous 1.8 (colored)
Stop pulling in <arpa/inet.h> or <arpa/nameser.h> when unnecessary.
*Do* pull it in when in_{port,addr}_h is needed and <netinet/in.h> isn't.
ok reyk@
Revision 1.8 / (download) - annotate - [select for diffs], Wed Nov 19 10:24:40 2014 UTC (9 years, 6 months ago) by blambert
Branch: MAIN
Changes since 1.7: +144 -20 lines
Diff to previous 1.7 (colored)
Support exporting relayd statistics via AgentX/snmpd This should be equivalent to the statistics available via the various relaydctl show commands okay benno@ reyk@
Revision 1.7 / (download) - annotate - [select for diffs], Fri Nov 14 16:18:43 2014 UTC (9 years, 6 months ago) by reyk
Branch: MAIN
Changes since 1.6: +11 -12 lines
Diff to previous 1.6 (colored)
Shorten the AgentX header debug messages (only compiled with -DDEBUG) to a single line and print to stderr instead of stdout. This makes it easier to follow the debug output again. Also, as a rule of thumb, it is OK to exceed 80 chars for these kinds of developer debug messages. OK blambert@
Revision 1.6 / (download) - annotate - [select for diffs], Sun Oct 12 13:08:47 2014 UTC (9 years, 7 months ago) by blambert
Branch: MAIN
Changes since 1.5: +5 -5 lines
Diff to previous 1.5 (colored)
Remove possibility of mutiplicative integer overflow by not multiplying.
Instead of the widespread-but-overflow-prone
while (newlen < wanted) { newlen *= 2; }
idiom, just realloc() for the space requested by the caller and check
for additive overflow.
Also change type of 'newlen' variable from int to size_t to avoid
overflows there.
Pointed out by deraadt@
ok reyk@
Revision 1.5 / (download) - annotate - [select for diffs], Sun Apr 20 16:07:10 2014 UTC (10 years, 1 month ago) by reyk
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE,
OPENBSD_5_6
Changes since 1.4: +4 -2 lines
Diff to previous 1.4 (colored)
Just to be pedantic, fail if strlcpy managed to overflow the socket path.
Revision 1.4 / (download) - annotate - [select for diffs], Sun Apr 20 10:46:20 2014 UTC (10 years, 1 month ago) by reyk
Branch: MAIN
Changes since 1.3: +7 -7 lines
Diff to previous 1.3 (colored)
Partially revert the previous: snmp_agentx_ping() didn't leak the pdu because it is added to a list on the handle and eventually released later with the handle itself. This confuses leak detection tools like clang, so at least add a comment that it is not a leak. ok blambert@
Revision 1.3 / (download) - annotate - [select for diffs], Sun Apr 20 09:29:22 2014 UTC (10 years, 1 month ago) by reyk
Branch: MAIN
Changes since 1.2: +9 -6 lines
Diff to previous 1.2 (colored)
Fix a small leak in the error path.
Revision 1.2 / (download) - annotate - [select for diffs], Mon Apr 14 15:11:24 2014 UTC (10 years, 1 month ago) by andre
Branch: MAIN
Changes since 1.1: +1 -2 lines
Diff to previous 1.1 (colored)
No need to include ber.h here, probably overlooked while importing. ok blambert@
Revision 1.1 / (download) - annotate - [select for diffs], Mon Apr 14 12:58:04 2014 UTC (10 years, 1 month ago) by blambert
Branch: MAIN
Adapt relayd to use AgentX protocol to send traps ok reyk@ benno@