OpenBSD CVS

CVS log for src/usr.sbin/ripd/control.c


[BACK] Up to [local] / src / usr.sbin / ripd

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.28 / (download) - annotate - [select for diffs], Wed Mar 8 04:43:14 2023 UTC (14 months, 3 weeks ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, HEAD
Changes since 1.27: +1 -3 lines
Diff to previous 1.27 (colored)

Delete obsolete /* ARGSUSED */ lint comments.

ok miod@ millert@

Revision 1.27 / (download) - annotate - [select for diffs], Tue Jan 19 10:00:36 2021 UTC (3 years, 4 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9
Changes since 1.26: +9 -2 lines
Diff to previous 1.26 (colored)

Apply same cleanup to the control code as in ospfd.
Internalize control_state and ctl_conns.

Revision 1.26 / (download) - annotate - [select for diffs], Sun Nov 4 07:52:55 2018 UTC (5 years, 6 months ago) by remi
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.25: +1 -9 lines
Diff to previous 1.25 (colored)

Pledge ripe and rde.
Use unveil to remove file system access for the parent proc.

Also remove control_cleanup as discussed on tech@. It allows to fully remove
fs access (ripd does not support reload). It's not an issue for ripd and
ripctrl if an unused socket file is lying around.

reads OK for claudio@ and mestre@

Revision 1.25 / (download) - annotate - [select for diffs], Tue Jan 17 22:10:56 2017 UTC (7 years, 4 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.24: +2 -2 lines
Diff to previous 1.24 (colored)

Nuke some whitespace that keeps poking me in the eye as I try to
steal code.

Revision 1.24 / (download) - annotate - [select for diffs], Sun Jan 8 23:04:42 2017 UTC (7 years, 4 months ago) by krw
Branch: MAIN
Changes since 1.23: +9 -7 lines
Diff to previous 1.23 (colored)

Replace hand-rolled for(;;) traversal of ctl_conns TAILQ with
TAILQ_FOREACH().

No intentional functional change.

ok reyk@

Revision 1.23 / (download) - annotate - [select for diffs], Tue Aug 2 16:05:32 2016 UTC (7 years, 10 months ago) by jca
Branch: MAIN
Changes since 1.22: +10 -10 lines
Diff to previous 1.22 (colored)

Allow specifying an alternate socket path.

This allows one to run multiple ripd instances, for example to serve
multiple rdomains.  Diff from Nima GHOTBI, ok claudio@ florian@ benno@

Revision 1.22 / (download) - annotate - [select for diffs], Sat Dec 5 13:13:47 2015 UTC (8 years, 5 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.21: +3 -2 lines
Diff to previous 1.21 (colored)

EAGAIN handling for imsg_read. OK henning@ benno@

Revision 1.21 / (download) - annotate - [select for diffs], Mon Feb 9 12:13:42 2015 UTC (9 years, 3 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.20: +5 -24 lines
Diff to previous 1.20 (colored)

More session_socket_blockmode() removal. While there make the main UDP
socket non-blocking by default.

Revision 1.20 / (download) - annotate - [select for diffs], Fri Jul 11 16:43:33 2014 UTC (9 years, 10 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.19: +2 -2 lines
Diff to previous 1.19 (colored)

Close the control fd when it has reported EOF.

ok henning@

Revision 1.19 / (download) - annotate - [select for diffs], Tue Nov 19 22:25:32 2013 UTC (10 years, 6 months ago) by benno
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.18: +2 -2 lines
Diff to previous 1.18 (colored)

handle msgbuf_write() returning EAGAIN

"looks right" deraadt and sthen.

Revision 1.18 / (download) - annotate - [select for diffs], Mon Mar 11 17:40:11 2013 UTC (11 years, 2 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4
Changes since 1.17: +3 -2 lines
Diff to previous 1.17 (colored)

handle ECONNABORTED errors from accept().  In many code blocks they can be
ignored silently and without aborting, much like EINTR and EWOULDBLOCK are.
ok's from various maintainers of these directories...

Revision 1.17 / (download) - annotate - [select for diffs], Wed Apr 11 08:33:53 2012 UTC (12 years, 1 month ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2
Changes since 1.16: +2 -3 lines
Diff to previous 1.16 (colored)

delete excessive evtimer_pending; ok claudio

Revision 1.16 / (download) - annotate - [select for diffs], Tue Apr 10 07:56:54 2012 UTC (12 years, 1 month ago) by deraadt
Branch: MAIN
Changes since 1.15: +27 -3 lines
Diff to previous 1.15 (colored)

Handle file descriptor exhaustion in the accept() case.
ok claudio

Revision 1.15 / (download) - annotate - [select for diffs], Fri May 14 11:52:19 2010 UTC (14 years ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.14: +2 -2 lines
Diff to previous 1.14 (colored)

Use calloc() instead of malloc() to allocate the connection structure. This
way the memory is zeroed. This is equivalent to the relayd commit by reyk.
OK reyk, jsg

Revision 1.14 / (download) - annotate - [select for diffs], Sun Feb 21 20:53:20 2010 UTC (14 years, 3 months ago) by michele
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.13: +1 -3 lines
Diff to previous 1.13 (colored)

Kill double declaration of control_imsg_relay().

From Christiano F. Haesbaert.

ok claudio@

Revision 1.13 / (download) - annotate - [select for diffs], Tue Dec 8 15:54:50 2009 UTC (14 years, 5 months ago) by jsg
Branch: MAIN
Changes since 1.12: +2 -2 lines
Diff to previous 1.12 (colored)

porcesses -> processes

Revision 1.12 / (download) - annotate - [select for diffs], Wed Dec 2 19:10:02 2009 UTC (14 years, 6 months ago) by mk
Branch: MAIN
Changes since 1.11: +2 -2 lines
Diff to previous 1.11 (colored)

log_warn() consistency.

`OK' claudio

Revision 1.11 / (download) - annotate - [select for diffs], Mon Nov 2 20:28:48 2009 UTC (14 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.10: +16 -1 lines
Diff to previous 1.10 (colored)

Another routing daemon that gets IMSG_CTL_LOG_VERBOSE to allow toggeling of
log_debug(). ok michele, henning, sthen

Revision 1.10 / (download) - annotate - [select for diffs], Sat Jun 6 08:20:55 2009 UTC (14 years, 11 months ago) by eric
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6
Changes since 1.9: +23 -21 lines
Diff to previous 1.9 (colored)

make ripctl/ripd imsg-in-a-lib ready too.

ok pyr@

Revision 1.9 / (download) - annotate - [select for diffs], Sun May 31 20:30:15 2009 UTC (15 years ago) by jacekm
Branch: MAIN
Changes since 1.8: +1 -2 lines
Diff to previous 1.8 (colored)

Remove redundant imsg_event_add calls; ok claudio@

Revision 1.8 / (download) - annotate - [select for diffs], Sun May 31 17:06:01 2009 UTC (15 years ago) by claudio
Branch: MAIN
Changes since 1.7: +5 -9 lines
Diff to previous 1.7 (colored)

Better EV_READ and EV_WRITE handling in the libevent callbacks. Again mostly
the same ospfd diff applied with some fuzz.

Revision 1.7 / (download) - annotate - [select for diffs], Wed Feb 25 17:09:55 2009 UTC (15 years, 3 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.6: +4 -2 lines
Diff to previous 1.6 (colored)

Fix an invalid pointer dereference in control_close(). If control_connbyfd()
fails -- which should never happen -- the function does not return and is
accession the NULL set control pointer later on.
Found by Matthew Haub. OK deraadt@

Revision 1.6 / (download) - annotate - [select for diffs], Thu Jan 31 12:17:35 2008 UTC (16 years, 4 months ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.5: +2 -1 lines
Diff to previous 1.5 (colored)

do not leak confd on malloc failure in control_accept()
found by Igor Zinovik <zinovik@cs.karelia.ru>

Revision 1.5 / (download) - annotate - [select for diffs], Wed Oct 24 20:20:32 2007 UTC (16 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.4: +2 -2 lines
Diff to previous 1.4 (colored)

Use an ssize_t instead of int like in all other imsg handlers. Hint by lint

Revision 1.4 / (download) - annotate - [select for diffs], Wed Oct 17 19:57:54 2007 UTC (16 years, 7 months ago) by claudio
Branch: MAIN
Changes since 1.3: +1 -6 lines
Diff to previous 1.3 (colored)

Remove redundant code.

Revision 1.3 / (download) - annotate - [select for diffs], Mon Mar 19 10:10:29 2007 UTC (17 years, 2 months ago) by henning
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2
Changes since 1.2: +2 -2 lines
Diff to previous 1.2 (colored)

do not signal "connection closed" upstream on EINTR/EAGAIN, from bgpd et al

Revision 1.2 / (download) - annotate - [select for diffs], Tue Jan 23 17:38:10 2007 UTC (17 years, 4 months ago) by claudio
Branch: MAIN
CVS Tags: OPENBSD_4_1_BASE, OPENBSD_4_1
Changes since 1.1: +3 -3 lines
Diff to previous 1.1 (colored)

Typo in fatal() message found by dunceor @ gmail dot com

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 16:11:58 2006 UTC (17 years, 7 months ago) by norby
Branch: MAIN

Welcome ripd
started by Michele Marchetto some time ago by using the imsg/three process framework
of ospfd. He implemented most of the daemon with a little help and guidance from
Claudio and I.

Currently the daemon is more or less complete, with the exception of key lifetime
and rollover.

Not yet connected to the builds.
OK claudio@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.