Return to output-bgpd.c CVS log

Up to [local] / src / usr.sbin / rpki-client

Fix capping of VAPs

The previous approach introduced a cap, but it might not always be hit as
intended (I missed this on review). Fix this to check the cap after merging
an ASPA into an already existing VAP. Also free the list of providers since
nothing should be looking at it anymore.

Count VAPs that hit the limit with a new overflowed counter. There are
still a few aspects of the accounting that probably aren't entirely right.
This will be fixed at another point. It's just statistics after all.

with/ok claudio, ok job

/*	$OpenBSD: output-bgpd.c,v 1.31 2024/04/08 14:02:13 tb Exp $ */
/*
 * Copyright (c) 2019 Kristaps Dzonsons <kristaps@bsd.lv>
 *
 * Permission to use, copy, modify, and distribute this software for any
 * purpose with or without fee is hereby granted, provided that the above
 * copyright notice and this permission notice appear in all copies.
 *
 * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
 * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
 * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
 * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
 * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
 * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

#include <stdlib.h>

#include "extern.h"

int
output_bgpd(FILE *out, struct vrp_tree *vrps, struct brk_tree *brks,
    struct vap_tree *vaps, struct vsp_tree *vsps, struct stats *st)
{
	struct vrp	*vrp;
	struct vap	*vap;
	size_t		 i;

	if (outputheader(out, st) < 0)
		return -1;

	if (fprintf(out, "roa-set {\n") < 0)
		return -1;

	RB_FOREACH(vrp, vrp_tree, vrps) {
		char ipbuf[64], maxlenbuf[100];

		ip_addr_print(&vrp->addr, vrp->afi, ipbuf, sizeof(ipbuf));
		if (vrp->maxlength > vrp->addr.prefixlen) {
			int ret = snprintf(maxlenbuf, sizeof(maxlenbuf),
			    "maxlen %u ", vrp->maxlength);
			if (ret < 0 || (size_t)ret > sizeof(maxlenbuf))
				return -1;
		} else
			maxlenbuf[0] = '\0';
		if (fprintf(out, "\t%s %ssource-as %u expires %lld\n",
		    ipbuf, maxlenbuf, vrp->asid, (long long)vrp->expires) < 0)
			return -1;
	}

	if (fprintf(out, "}\n") < 0)
		return -1;

	if (excludeaspa)
		return 0;

	if (fprintf(out, "\naspa-set {\n") < 0)
		return -1;
	RB_FOREACH(vap, vap_tree, vaps) {
		if (vap->overflowed)
			continue;
		if (fprintf(out, "\tcustomer-as %d expires %lld "
		    "provider-as { ", vap->custasid,
		    (long long)vap->expires) < 0)
			return -1;
		for (i = 0; i < vap->providersz; i++) {
			if (fprintf(out, "%u", vap->providers[i]) < 0)
				return -1;
			if (i + 1 < vap->providersz)
				if (fprintf(out, ", ") < 0)
					return -1;
		}

		if (fprintf(out, " }\n") < 0)
			return -1;
	}
	if (fprintf(out, "}\n") < 0)
		return -1;

	return 0;
}