CVS log for src/usr.sbin/smtpd/Attic/lka_report.c

Up to [local] / src / usr.sbin / smtpd

Request diff between arbitrary revisions

Default branch: MAIN

Revision 1.36, Thu Dec 12 20:49:06 2019 UTC (4 years, 5 months ago) by gilles
Branch: MAIN
CVS Tags: HEAD
Changes since 1.35: +1 -1 lines
FILE REMOVED

remove file, code was moved to a different file

Revision 1.35 / (download) - annotate - [select for diffs], Mon Dec 9 20:36:22 2019 UTC (4 years, 6 months ago) by gilles
Branch: MAIN
Changes since 1.34: +2 -2 lines
Diff to previous 1.34 (colored)

swap two fields in the filter response protocol to match order of fields in
the query protocol. this difference was overlooked and is error-prone for a
filter developer. bump filter protocol.

when you update your smtpd, if you use filters, they'll need to be updated.

spotted by Chris Ross <cross+openbsd@distal.com>

Revision 1.34 / (download) - annotate - [select for diffs], Thu Oct 3 05:42:57 2019 UTC (4 years, 8 months ago) by gilles
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE, OPENBSD_6_6
Changes since 1.33: +3 -3 lines
Diff to previous 1.33 (colored)

fix wrong sizeof in lka reporters init

Revision 1.33 / (download) - annotate - [select for diffs], Sat Sep 21 08:10:44 2019 UTC (4 years, 8 months ago) by semarie
Branch: MAIN
Changes since 1.32: +5 -2 lines
Diff to previous 1.32 (colored)

in report_smtp_broadcast(), the direction is expected to be "smtp-in" or
"smtp-out", but if something else happen, the `struct dict *d' will be
uninitialized when used in `dict_xget(d, event)'.

makes a logic error in smtpd to be visible instead of accessing uninitialized
memory.

ok gilles@

Revision 1.32 / (download) - annotate - [select for diffs], Wed Sep 11 04:19:19 2019 UTC (4 years, 8 months ago) by martijn
Branch: MAIN
Changes since 1.31: +4 -1 lines
Diff to previous 1.31 (colored)

Sprinkle around some __attribute__((__format__ (printf(...))).

OK gilles@

Revision 1.31 / (download) - annotate - [select for diffs], Tue Sep 10 07:03:16 2019 UTC (4 years, 8 months ago) by gilles
Branch: MAIN
Changes since 1.30: +36 -43 lines
Diff to previous 1.30 (colored)

simplify lka reporting functions by moving the reqid inside the broadcast
function: reqid is a mandatory part of the header. lka reporting functions
now only append their own specific parameters.

ok martijn@

Revision 1.30 / (download) - annotate - [select for diffs], Fri Sep 6 08:23:56 2019 UTC (4 years, 9 months ago) by martijn
Branch: MAIN
Changes since 1.29: +54 -2 lines
Diff to previous 1.29 (colored)

Add support for filter-reports. These allow filters to send freetext
reports to other filters/report handlers.
Builtin filters work via the new "report" keyword.
Proc filters can send reports via:
"report|<seconds.<microseconds>|smtp-in|<reqid>|<message>"
Subscribing to these reports can be done via the the "filter-report"
keyword.
The reports themselves contain the usual elements followed by:
<type>|<name>|<message>
Type can be builtin or proc.
Name is the process name for type proc and the filter name for type builtin.

OK gilles@

Revision 1.29 / (download) - annotate - [select for diffs], Wed Sep 4 08:30:36 2019 UTC (4 years, 9 months ago) by gilles
Branch: MAIN
Changes since 1.28: +2 -2 lines
Diff to previous 1.28 (colored)

bump version

Revision 1.28 / (download) - annotate - [select for diffs], Wed Sep 4 07:28:27 2019 UTC (4 years, 9 months ago) by gilles
Branch: MAIN
Changes since 1.27: +4 -1 lines
Diff to previous 1.27 (colored)

introduce the 'junk' builtin filter action which marks a session or
transaction as junked when a filter matches. this with the maildir
junk option allows classifying messages in Spam folder instead of
rejecting/disconnecting.

ok semarie@, eric@, martijn@

Revision 1.27 / (download) - annotate - [select for diffs], Thu Aug 29 07:23:18 2019 UTC (4 years, 9 months ago) by martijn
Branch: MAIN
Changes since 1.26: +4 -1 lines
Diff to previous 1.26 (colored)

Comment out the registration of smtp-out events.
These are currently under development and allowing them to be registered
might give the wrong idea of them working.

OK gilles@

Revision 1.26 / (download) - annotate - [select for diffs], Wed Aug 28 15:50:36 2019 UTC (4 years, 9 months ago) by martijn
Branch: MAIN
Changes since 1.25: +11 -2 lines
Diff to previous 1.25 (colored)

Add a link-greeting report. This allows us to get the active domain name
in use for the current request.

OK gilles@

Revision 1.25 / (download) - annotate - [select for diffs], Wed Aug 28 15:37:28 2019 UTC (4 years, 9 months ago) by martijn
Branch: MAIN
Changes since 1.24: +5 -5 lines
Diff to previous 1.24 (colored)

Make filters more developer-friendly by giving more feedback on why a
message was rejected.

Feedback semarie@
OK gilles@

Revision 1.24 / (download) - annotate - [select for diffs], Sun Aug 18 16:52:02 2019 UTC (4 years, 9 months ago) by gilles
Branch: MAIN
Changes since 1.23: +3 -3 lines
Diff to previous 1.23 (colored)

version field was reserved but not discussed, this is done now

ok millert@ martijn@

Revision 1.23 / (download) - annotate - [select for diffs], Sun Aug 11 17:35:27 2019 UTC (4 years, 9 months ago) by gilles
Branch: MAIN
Changes since 1.22: +2 -2 lines
Diff to previous 1.22 (colored)

the filtering protocol in OpenBSD 6.6 will be version 0, it has worked fine
for about a year now but until we have had a release with filters and until
we bring back the feedback from that release into the protocol, we will not
be version 1 of the protocol.

Revision 1.22 / (download) - annotate - [select for diffs], Fri Jul 26 06:30:13 2019 UTC (4 years, 10 months ago) by gilles
Branch: MAIN
Changes since 1.21: +9 -9 lines
Diff to previous 1.21 (colored)

even though RSET can be issued outside a tx, RFC states it's noop outside a
transaction so rename link-reset to tx-reset and only issue the smtp report
when a reset _actually_ has a side-effect.

note that rset is implicit on a message commit or rollback, so tx-reset get
issued even though there was no explicit RSET. the filters are MUCH simpler
to write when you don't need to track every event that can reset a tx :-)

Revision 1.21 / (download) - annotate - [select for diffs], Thu Jul 11 21:40:03 2019 UTC (4 years, 10 months ago) by gilles
Branch: MAIN
Changes since 1.20: +10 -1 lines
Diff to previous 1.20 (colored)

introduce link-auth to the smtp reporting stream so that filters may know
if a link has been authenticated successfully or not and for which user

Revision 1.20 / (download) - annotate - [select for diffs], Thu Jul 11 21:04:59 2019 UTC (4 years, 10 months ago) by gilles
Branch: MAIN
Changes since 1.19: +4 -3 lines
Diff to previous 1.19 (colored)

modify link-identify so it reports if HELO or EHLO was used

Revision 1.19 / (download) - annotate - [select for diffs], Thu Jul 11 20:58:54 2019 UTC (4 years, 10 months ago) by gilles
Branch: MAIN
Changes since 1.18: +9 -1 lines
Diff to previous 1.18 (colored)

introduce link-reset to let smtpd report resets happening in a session

Revision 1.18 / (download) - annotate - [select for diffs], Tue Jul 9 15:43:24 2019 UTC (4 years, 11 months ago) by gilles
Branch: MAIN
Changes since 1.17: +10 -5 lines
Diff to previous 1.17 (colored)

rework link-connect output so that messages enqueued over the unix socket
no longer display "local:0" as their source and dest addresses, but
"unix:/var/run/smtpd.sock" currently we only support enqueueing over the
control socket but that may not always be the case.

Revision 1.17 / (download) - annotate - [select for diffs], Sat Jan 5 09:43:39 2019 UTC (5 years, 5 months ago) by gilles
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.16: +11 -1 lines
Diff to previous 1.16 (colored)

introduce smtp 'timeout' reporting event to notify filters that a timeout
occured during the smtp session

Revision 1.16 / (download) - annotate - [select for diffs], Fri Dec 21 14:33:52 2018 UTC (5 years, 5 months ago) by gilles
Branch: MAIN
Changes since 1.15: +142 -42 lines
Diff to previous 1.15 (colored)

bring in new grammar for filters, allowing filter chains and plugging of
different filters & chains on different interfaces.

in this diff, proc filters are still disabled as they're missing on very
important piece of logic.

ok eric@

Revision 1.15 / (download) - annotate - [select for diffs], Thu Dec 13 17:08:10 2018 UTC (5 years, 5 months ago) by gilles
Branch: MAIN
Changes since 1.14: +32 -32 lines
Diff to previous 1.14 (colored)

in event reports, use a struct timeval instead of time_t since we want more
than second precision

discussed with eric@

Revision 1.14 / (download) - annotate - [select for diffs], Wed Dec 12 21:27:49 2018 UTC (5 years, 5 months ago) by gilles
Branch: MAIN
Changes since 1.13: +21 -1 lines
Diff to previous 1.13 (colored)

add tx-data reporting event

Revision 1.13 / (download) - annotate - [select for diffs], Tue Dec 11 11:29:44 2018 UTC (5 years, 5 months ago) by gilles
Branch: MAIN
Changes since 1.12: +80 -1 lines
Diff to previous 1.12 (colored)

report filter responses to smtp

Revision 1.12 / (download) - annotate - [select for diffs], Tue Dec 11 08:40:56 2018 UTC (5 years, 5 months ago) by gilles
Branch: MAIN
Changes since 1.11: +8 -1 lines
Diff to previous 1.11 (colored)

generate an event when a helo name identifies a link

Revision 1.11 / (download) - annotate - [select for diffs], Thu Dec 6 16:05:04 2018 UTC (5 years, 6 months ago) by gilles
Branch: MAIN
Changes since 1.10: +16 -3 lines
Diff to previous 1.10 (colored)

link-connect event report had an empty fcrdns field, but now that eric@ has
plugged fcrdns in the smtp_session we can fill the field with a value

Revision 1.10 / (download) - annotate - [select for diffs], Thu Dec 6 15:32:06 2018 UTC (5 years, 6 months ago) by gilles
Branch: MAIN
Changes since 1.9: +41 -1 lines
Diff to previous 1.9 (colored)

introduce tx-mail and tx-rcpt report events

Revision 1.9 / (download) - annotate - [select for diffs], Fri Nov 30 15:41:15 2018 UTC (5 years, 6 months ago) by gilles
Branch: MAIN
Changes since 1.8: +4 -3 lines
Diff to previous 1.8 (colored)

on link-connect report events, add an fc-rdns field, currently empty

Revision 1.8 / (download) - annotate - [select for diffs], Fri Nov 30 15:33:40 2018 UTC (5 years, 6 months ago) by gilles
Branch: MAIN
Changes since 1.7: +45 -41 lines
Diff to previous 1.7 (colored)

prepare for smtp-out reporting and while at it, make a few changes to the
report format

Revision 1.7 / (download) - annotate - [select for diffs], Thu Nov 8 13:21:00 2018 UTC (5 years, 7 months ago) by gilles
Branch: MAIN
Changes since 1.6: +15 -7 lines
Diff to previous 1.6 (colored)

when reporting tx events, report tx id
when reporting tx commit, report data size
report tx-envelope events

Revision 1.6 / (download) - annotate - [select for diffs], Thu Nov 8 12:42:29 2018 UTC (5 years, 7 months ago) by gilles
Branch: MAIN
Changes since 1.5: +27 -24 lines
Diff to previous 1.5 (colored)

add protocol version to report lines and reorder timestamp

Revision 1.5 / (download) - annotate - [select for diffs], Fri Nov 2 17:20:22 2018 UTC (5 years, 7 months ago) by gilles
Branch: MAIN
Changes since 1.4: +4 -4 lines
Diff to previous 1.4 (colored)

report rDNS in link connect event

Revision 1.4 / (download) - annotate - [select for diffs], Fri Nov 2 17:03:17 2018 UTC (5 years, 7 months ago) by gilles
Branch: MAIN
Changes since 1.3: +17 -5 lines
Diff to previous 1.3 (colored)

when reporting smtp-in link-connect event, report src and dest port too

Revision 1.3 / (download) - annotate - [select for diffs], Fri Nov 2 16:50:23 2018 UTC (5 years, 7 months ago) by gilles
Branch: MAIN
Changes since 1.2: +11 -3 lines
Diff to previous 1.2 (colored)

pass struct sockaddr_storage instead of ss_to_text() in reporting

Revision 1.2 / (download) - annotate - [select for diffs], Fri Nov 2 15:56:47 2018 UTC (5 years, 7 months ago) by gilles
Branch: MAIN
Changes since 1.1: +9 -9 lines
Diff to previous 1.1 (colored)

in-smtp -> smtp-in in reporting protocol

Revision 1.1 / (download) - annotate - [select for diffs], Thu Nov 1 14:48:49 2018 UTC (5 years, 7 months ago) by gilles
Branch: MAIN

teach smtp process how to report smtp events to lka and teach lka how to
report these events to a proc

ok millert@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.