OpenBSD CVS

CVS log for src/usr.sbin/smtpd/Attic/queue_shared.c


[BACK] Up to [local] / src / usr.sbin / smtpd

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.56, Wed Dec 14 23:08:40 2011 UTC (12 years, 5 months ago) by eric
Branch: MAIN
CVS Tags: HEAD
Changes since 1.55: +1 -1 lines
FILE REMOVED

finally kill queue_shared.c and move what is left to bounce.c
where it belongs.

ok gilles@

Revision 1.55 / (download) - annotate - [select for diffs], Wed Dec 14 18:42:27 2011 UTC (12 years, 5 months ago) by eric
Branch: MAIN
Changes since 1.54: +1 -100 lines
Diff to previous 1.54 (colored)

move show_queue() and related functions from queue_shared.c
to smtpctl.c

ok gilles@

Revision 1.54 / (download) - annotate - [select for diffs], Tue Nov 15 23:06:39 2011 UTC (12 years, 6 months ago) by gilles
Branch: MAIN
Changes since 1.53: +9 -167 lines
Diff to previous 1.53 (colored)

Qwalk, our API to linearly walk over the persistent queue, did not take the
queue_backend into account and assumed a filesystem with a specific layout.

This commit does plenty of things:

- make qwalk an abstraction in the queue_backend API, and impose queue
  drivers to implement qwalk_open(), qwalk() and qwalk_close();

- move previous qwalk_open(), qwalk() and qwalk_close() to the fsqueue
  driver since they were fsqueue specific ...

- make qwalk API work with msgid/evpid instead of pathnames since we're
  going to use the queue_backend API to load envelopes by evpid anyway;

- makes smtpd use *solely* the queue_backend API when manipulating the
  queue. pathnames were removed from smtpd.h and moved into the fsqueue
  which means we can now store a queue anywhere ... as long as we write
  the ten functions or so required for a queue driver ;-)

ok eric@, ok chl@

Revision 1.53 / (download) - annotate - [select for diffs], Thu Oct 27 14:32:57 2011 UTC (12 years, 7 months ago) by chl
Branch: MAIN
Changes since 1.52: +7 -6 lines
Diff to previous 1.52 (colored)

Use PRI{x,d}64 in format strings instead of %llx, %lld or %qd to print {u_,}int64_t or time_t

While there, cast some time_t to int64_t

These will fix build warnings for portable smptd

ok gilles@ eric@

Revision 1.52 / (download) - annotate - [select for diffs], Sun Oct 23 09:30:07 2011 UTC (12 years, 7 months ago) by gilles
Branch: MAIN
Changes since 1.51: +40 -43 lines
Diff to previous 1.51 (colored)

fsqueue no longer stores envelopes by dumping the structure, instead use a
couple of load/dump functions to convert to and from a human readable fmt.
while at it kill struct delivery and merge back its fields to the envelope.

this basically means we shouldn't require users to flush their queues every
time we make a change to struct envelope.

work is not done, but we're at a better state than the binary fsqueue so
we'll improve it in-tree.

has been running on my own box for the last 12 hours or so
ok eric@, chl@

Revision 1.51 / (download) - annotate - [select for diffs], Mon Aug 29 21:43:09 2011 UTC (12 years, 9 months ago) by chl
Branch: MAIN
Changes since 1.50: +4 -4 lines
Diff to previous 1.50 (colored)

cast all printed time_t to long long int, and change format string accordingly.

ok gilles@

Revision 1.50 / (download) - annotate - [select for diffs], Sun Aug 28 22:20:27 2011 UTC (12 years, 9 months ago) by chl
Branch: MAIN
Changes since 1.49: +3 -1 lines
Diff to previous 1.49 (colored)

Clear bounce envelope structure, to avoid wrong use when bounce_record_message() returns 0.

Initial report from me, tweak from gilles@

ok gilles@

Revision 1.49 / (download) - annotate - [select for diffs], Mon May 16 21:05:52 2011 UTC (13 years ago) by gilles
Branch: MAIN
CVS Tags: OPENBSD_5_0_BASE, OPENBSD_5_0
Changes since 1.48: +50 -49 lines
Diff to previous 1.48 (colored)

murder struct path and make sure smtpd uses simpler structures that do not
bring a shitload of unnecessary information everywhere. this required many
parts of smtpd to be refactored and more specifically envelope expansion.

in the process lots of code got simplified, and the envelope expansion code
has been isolated to lka_session.c with some longstanding bugs fixed.

Diff has been tested by many with no major regression reported.
armani@ spotted a bug in a setup where a domain is listed a both primary
and virtual, I will fix that in-tree as it's becoming painful to maintain
this diff out.

Revision 1.48 / (download) - annotate - [select for diffs], Tue May 10 17:04:43 2011 UTC (13 years, 1 month ago) by gilles
Branch: MAIN
Changes since 1.47: +2 -2 lines
Diff to previous 1.47 (colored)

fix an off-by-one that made smtpd skip an "invalid" bucket that was
actually valid.

bugfix tested by todd@

Revision 1.47 / (download) - annotate - [select for diffs], Sun May 1 12:57:11 2011 UTC (13 years, 1 month ago) by eric
Branch: MAIN
Changes since 1.46: +10 -10 lines
Diff to previous 1.46 (colored)

the smtpd env is meant to be global, so do not pass it all around.

discussed with and ok gilles@

Revision 1.46 / (download) - annotate - [select for diffs], Sun Apr 17 11:39:22 2011 UTC (13 years, 1 month ago) by gilles
Branch: MAIN
Changes since 1.45: +51 -51 lines
Diff to previous 1.45 (colored)

a structure describing an envelope should be called struct envelope, not
struct message ...

Revision 1.45 / (download) - annotate - [select for diffs], Fri Apr 15 17:30:23 2011 UTC (13 years, 1 month ago) by gilles
Branch: MAIN
Changes since 1.44: +11 -6 lines
Diff to previous 1.44 (colored)

teach walk_queue() about the new disk-queue layout

Revision 1.44 / (download) - annotate - [select for diffs], Fri Apr 15 17:01:05 2011 UTC (13 years, 1 month ago) by gilles
Branch: MAIN
Changes since 1.43: +9 -9 lines
Diff to previous 1.43 (colored)

kill message_id and message_uid

smtpd now has an evpid associated to each delivery message, the evpid is an
u_int64_t where the upper 32 bits are the msgid, and the 32 bits are the
envelope unique identifier for that message. this results in lots of space
saved in both disk-based and ram-based queues, but also simplifies a lot of
code.

change has been stressed on my desktop, and has ran on my MX for the entire
afternoon without a regression.

Revision 1.43 / (download) - annotate - [select for diffs], Thu Apr 14 23:29:56 2011 UTC (13 years, 1 month ago) by gilles
Branch: MAIN
Changes since 1.42: +1 -12 lines
Diff to previous 1.42 (colored)

bye bye queue_hash() you can now rest in peace.

Revision 1.42 / (download) - annotate - [select for diffs], Thu Apr 14 23:26:16 2011 UTC (13 years, 1 month ago) by gilles
Branch: MAIN
Changes since 1.41: +2 -148 lines
Diff to previous 1.41 (colored)

- implement missing operations for fsqueue:
	fsqueue_envelope_create(), fsqueue_message_purge()
- kill deprecated functions in queue_shared.c

At this point fsqueue backend is almost complete, all that is left to do is
to move the qwalk() API inside the queue_backend API, then make sure smtpd
is no longer calling anything queue related directly.

Revision 1.41 / (download) - annotate - [select for diffs], Thu Apr 14 22:36:09 2011 UTC (13 years, 1 month ago) by gilles
Branch: MAIN
Changes since 1.40: +6 -131 lines
Diff to previous 1.40 (colored)

- implement fsqueue_message_create() and fsqueue_message_commit()
- change a few prototypes to allow bounce messages to use the
	queue_backend API until it gets merged in
- kill functions of the queue API that have been deprecated

Revision 1.40 / (download) - annotate - [select for diffs], Thu Apr 14 22:00:26 2011 UTC (13 years, 1 month ago) by gilles
Branch: MAIN
Changes since 1.39: +2 -8 lines
Diff to previous 1.39 (colored)

remove annoying log_debug()

Revision 1.39 / (download) - annotate - [select for diffs], Thu Apr 14 21:53:46 2011 UTC (13 years, 1 month ago) by gilles
Branch: MAIN
Changes since 1.38: +1 -44 lines
Diff to previous 1.38 (colored)

fsqueue now provides fsqueue_message_fd_r() and fsqueue_message_fd_rw() to
obtain a read{-only,/write} descriptor to the message file.

make sure smtpd uses the new API everywhere it needs a fd, and kill the
many functions that were used until now.

Revision 1.38 / (download) - annotate - [select for diffs], Thu Apr 14 20:11:08 2011 UTC (13 years, 1 month ago) by gilles
Branch: MAIN
Changes since 1.37: +5 -154 lines
Diff to previous 1.37 (colored)

fsqueue queue backend will implement a filesystem queue:
- fsqueue->setup() performs the queue initialization;
- fsqueue->message() controls messages;
- fsqueue->envelope() controls envelopes;

This commit brings the following to fsbackend:
fsqueue_setup(), fsqueue_message_delete(), fsqueue_envelope_load(),
fsqueue_envelope_update(), fsqueue_envelope_delete().

It also makes smtpd use the queue_backend API for these operations.

Revision 1.37 / (download) - annotate - [select for diffs], Wed Apr 13 20:53:18 2011 UTC (13 years, 1 month ago) by gilles
Branch: MAIN
Changes since 1.36: +13 -11 lines
Diff to previous 1.36 (colored)

following an idea from jacekm@, smtpd now uses a ram-queue instead of doing
a continuous walk on the disk-queue. the implementation differs from what
jacekm@ commited (and I backed out) a while ago in that it uses a queue and
a host tree required for upcoming features.

code will be improved in tree, it requires changes to be done in queue and
bounce API, I just wanted to commit a working version first ...

tested by todd@ and I

Revision 1.36 / (download) - annotate - [select for diffs], Mon Mar 21 09:21:57 2011 UTC (13 years, 2 months ago) by gilles
Branch: MAIN
Changes since 1.35: +11 -3 lines
Diff to previous 1.35 (colored)

fix a memory leak in client.c and properly close envelope in
queue_shared.c

diff from Jared Yanovich, sent to bugs@ by Jonny Mosco

Revision 1.35 / (download) - annotate - [select for diffs], Sun Nov 28 14:35:58 2010 UTC (13 years, 6 months ago) by gilles
Branch: MAIN
CVS Tags: OPENBSD_4_9_BASE, OPENBSD_4_9
Changes since 1.34: +2 -4 lines
Diff to previous 1.34 (colored)

remove all unused headers

Revision 1.34 / (download) - annotate - [select for diffs], Sun Nov 28 13:56:43 2010 UTC (13 years, 6 months ago) by gilles
Branch: MAIN
Changes since 1.33: +3 -1 lines
Diff to previous 1.33 (colored)

a bit of .h cleanups, no functionnal change

Revision 1.33 / (download) - annotate - [select for diffs], Mon Nov 15 14:57:40 2010 UTC (13 years, 6 months ago) by jsing
Branch: MAIN
Changes since 1.32: +1 -1 lines
Diff to previous 1.32 (colored)

Do not fatal if an attempt to open a message envelope results in ENOENT.
This prevents smtpd from exiting if 'smtpctl schedule' is run with a valid
but non-existent message ID. Whilst here make ENOSPC fatal since this
should not happen.

ok gilles@

Revision 1.32 / (download) - annotate - [select for diffs], Thu Oct 28 21:15:50 2010 UTC (13 years, 7 months ago) by gilles
Branch: MAIN
Changes since 1.31: +3 -2 lines
Diff to previous 1.31 (colored)

teach smtpd how to handle per-rule delays for message expiry, this allows
some rules to have a longer expiry delay than the default:

	accept for [...] relay expire 8d  # will stay 8 days in queue

I added the man page bits so I don't forget but I need to reword it a bit

Revision 1.31 / (download) - annotate - [select for diffs], Sat Oct 9 22:12:26 2010 UTC (13 years, 8 months ago) by gilles
Branch: MAIN
Changes since 1.30: +1 -1 lines
Diff to previous 1.30 (colored)

these need to be re-added too

Revision 1.30, Tue Jun 1 23:06:23 2010 UTC (14 years ago) by jacekm
Branch: MAIN
Changes since 1.29: +1 -1 lines
FILE REMOVED

new queue, again; gcc2 compile tested by deraadt

Revision 1.29 / (download) - annotate - [select for diffs], Tue Jun 1 19:47:09 2010 UTC (14 years ago) by jacekm
Branch: MAIN
Changes since 1.28: +0 -0 lines
Diff to previous 1.28 (colored)

New queue doesn't compile on gcc2, back out.  Spotted by deraadt@

Revision 1.28, Mon May 31 23:38:56 2010 UTC (14 years ago) by jacekm
Branch: MAIN
Changes since 1.27: +1 -1 lines
FILE REMOVED

Rewrite entire queue code.

Major goals:

1) Fix bad performance caused by the runner process doing full queue
read in 1s intervals.  My Soekris can now happily accept >50 msg/s
while having multi-thousand queue; before, one hundred queue would
bring the system to its knees.

2) Introduce Qmail-like scheduler that doesn't write as much to the
disk so that it needs less code for servicing error conditions,
which in some places can be tricky to get right.

3) Introduce separation between the scheduler and the backend; these
two queue aspects shouldn't be too tied too each other.  This means
that eg. storing queue in SQL requires rewrite of just queue_backend.c.

4) Make on-disk queue format architecture independent, and more
easily extensible, to reduce number of flag days in the future.

Minor goals:

ENOSPC no longer prevents delivery attempts, fixed session limiting
for relayed mail, improved batching of "relay via" mails, human-readable
mailq output, "show queue raw" command, clearer logging, sending
of single bounce about multiple recipients, exact delay= computation,
zero delay between deliveries while within session limit (currently
1s delay between re-scheduling is enforced), mta no longer requests
content fd, corrected session limit for bounce submissions, tiny
<100B queue files instead of multi-KB, detect loops before accepting
mail, reduce traffic on imsg channels by killing enormous struct
submit_status.

Revision 1.27 / (download) - annotate - [select for diffs], Mon Dec 14 18:16:01 2009 UTC (14 years, 5 months ago) by jacekm
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.26: +2 -1 lines
Diff to previous 1.26 (colored)

Clear S_MESSAGE_PERMFAILURE when creating the bounce message.  Makes the
bounce mails visible in mailq output.

Revision 1.26 / (download) - annotate - [select for diffs], Sun Nov 8 21:40:05 2009 UTC (14 years, 7 months ago) by gilles
Branch: MAIN
Changes since 1.25: +1 -18 lines
Diff to previous 1.25 (colored)

- make aliases expansion use a rb tree instead of a tail queue, the code
  doesn't take advantage of the new structure yet, but this was a needed
  change for upcoming improvements.
- introduce aliasestree_{lookup,insert,remove} to the aliases api
- rename queue_generate_id() to generate_uid() and move it to utils.c as
  it is used all over the place and not only in queue

tree idea discussed with jacekm@, if you update rebuild aliases db, make
clean and flush queue

Revision 1.25 / (download) - annotate - [select for diffs], Tue Sep 15 16:50:06 2009 UTC (14 years, 8 months ago) by jacekm
Branch: MAIN
Changes since 1.24: +9 -2 lines
Diff to previous 1.24 (colored)

Extend SMTP client_* API to support SSL+AUTH, and use it in the mta
process to relay mails.  ok gilles@

Revision 1.24 / (download) - annotate - [select for diffs], Fri Sep 4 13:33:00 2009 UTC (14 years, 9 months ago) by jacekm
Branch: MAIN
Changes since 1.23: +3 -1 lines
Diff to previous 1.23 (colored)

Fix scheduling of bounce messages.

From gilles@

Revision 1.23 / (download) - annotate - [select for diffs], Fri Sep 4 11:44:23 2009 UTC (14 years, 9 months ago) by jacekm
Branch: MAIN
Changes since 1.22: +7 -1 lines
Diff to previous 1.22 (colored)

Fix a crash when messagep->batch_id is read from disk and used long
after the batch has ceased to exist.

From gilles@

Revision 1.22 / (download) - annotate - [select for diffs], Sat Aug 8 23:02:43 2009 UTC (14 years, 10 months ago) by gilles
Branch: MAIN
Changes since 1.21: +5 -13 lines
Diff to previous 1.21 (colored)

- simplify a bit queue_message_update()
- make sure queue_message_update() creates bounces using bounce_record()
- when mta sends update to queue and it sees that batch is flagged with
  F_BATCH_PERMFAIL, only update the envelope error message if it doesn't
  have F_MESSAGE_PERMFAIL set, otherwise we may lose the real reason why
  we failed for that recipient. There's cleanup to do around that old
  code, i'm sure we can get it simpler.

this commit fixes a bug pea@ spotted where a bounce message would not
display the reason of a failure when we generated it after failing to
deliver a relayed message.

Revision 1.21 / (download) - annotate - [select for diffs], Thu Aug 6 16:46:57 2009 UTC (14 years, 10 months ago) by gilles
Branch: MAIN
Changes since 1.20: +9 -10 lines
Diff to previous 1.20 (colored)

- change all occurences of T_DAEMON_BATCH,MESSAGE to T_BOUNCE_BATCH/MESSAGE
- make sure T_BOUNCE_MESSAGE is no longer OR-ed to T_MDA/MTA_MESSAGE
- define F_MESSAGE_BOUNCE flag and make sure bounce sessions set it
- teach smtpctl show queue how to recognize a bounce message

Revision 1.20 / (download) - annotate - [select for diffs], Thu Aug 6 13:40:45 2009 UTC (14 years, 10 months ago) by gilles
Branch: MAIN
Changes since 1.19: +20 -20 lines
Diff to previous 1.19 (colored)

This commit reworks the entire mailer daemon support to actually make it
work for real. As an added bonus, it simplifies it, makes it follow the
same code path as regular messages and kills quite some code from mta,
mda and store. There's still some work needed but the most painful part
is behind us now ;)

ok jacekm@

Revision 1.19 / (download) - annotate - [select for diffs], Tue Jul 28 22:03:55 2009 UTC (14 years, 10 months ago) by gilles
Branch: MAIN
Changes since 1.18: +72 -1 lines
Diff to previous 1.18 (colored)

introduce daemon_record_message() and needed glue in queue_shared.c to
atomically create a mailer daemon out of a message. it is unreferenced
for now, this commit makes no functional change.

Revision 1.18 / (download) - annotate - [select for diffs], Sun May 10 11:29:40 2009 UTC (15 years, 1 month ago) by jacekm
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6
Changes since 1.17: +2 -1 lines
Diff to previous 1.17 (colored)

assert copyright; ok gilles@

Revision 1.17 / (download) - annotate - [select for diffs], Sun Apr 19 12:42:39 2009 UTC (15 years, 1 month ago) by jacekm
Branch: MAIN
Changes since 1.16: +4 -1 lines
Diff to previous 1.16 (colored)

error checking for readdir(2); ok gilles@

Revision 1.16 / (download) - annotate - [select for diffs], Sun Apr 12 12:33:43 2009 UTC (15 years, 2 months ago) by gilles
Branch: MAIN
Changes since 1.15: +3 -2 lines
Diff to previous 1.15 (colored)

when an error occurs while delivering a message with an empty envelope as a
sender, do not try to generate a mailer daemon message for it.

fixes a crash experienced by sthen@ that I could reproduce

Revision 1.15 / (download) - annotate - [select for diffs], Mon Mar 9 11:29:52 2009 UTC (15 years, 3 months ago) by jacekm
Branch: MAIN
Changes since 1.14: +2 -2 lines
Diff to previous 1.14 (colored)

add hunk that should have been included in rev. 1.12, fixes occasional
crash; ok gilles@

Revision 1.14 / (download) - annotate - [select for diffs], Tue Feb 24 12:07:47 2009 UTC (15 years, 3 months ago) by gilles
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE, OPENBSD_4_5
Changes since 1.13: +3 -1 lines
Diff to previous 1.13 (colored)

teach smtpctl's parser how to deal with parameters that are not necessarily
a token so that it is possible to do: smtpctl schedule <message id/uid>

introduce F_MESSAGE_FORCESCHEDULE which lets the runner schedule a message
even if the retry delay has not been expired.

F_MESSAGE_ENQUEUED is a valid flag for a message and should not cause an\
errx() in smtpctl show queue

Revision 1.13 / (download) - annotate - [select for diffs], Mon Feb 23 00:51:32 2009 UTC (15 years, 3 months ago) by chl
Branch: MAIN
Changes since 1.12: +2 -1 lines
Diff to previous 1.12 (colored)

add missing headers needed by time()

ok jacekm@ gilles@

Revision 1.12 / (download) - annotate - [select for diffs], Sun Feb 22 23:29:54 2009 UTC (15 years, 3 months ago) by jacekm
Branch: MAIN
Changes since 1.11: +3 -1 lines
Diff to previous 1.11 (colored)

Fix race possible between runner and queue when starting up.
runner_reset_flags would attempt to update envelope, but its
envelope.tmp could be renamed by queue_purge. The fix is to store
envelope.tmp in a place no other process writes to, and
/queue/envelope.tmp is perfect for this.

ok gilles@

Revision 1.11 / (download) - annotate - [select for diffs], Sun Feb 22 11:55:17 2009 UTC (15 years, 3 months ago) by jacekm
Branch: MAIN
Changes since 1.10: +7 -9 lines
Diff to previous 1.10 (colored)

simplify qwalk() error handling; ok gilles@

Revision 1.10 / (download) - annotate - [select for diffs], Sun Feb 22 11:44:29 2009 UTC (15 years, 3 months ago) by form
Branch: MAIN
Changes since 1.9: +33 -32 lines
Diff to previous 1.9 (colored)

replace MAX* constants by sizeof where possible

ok jacekm@

Revision 1.9 / (download) - annotate - [select for diffs], Mon Feb 16 10:15:10 2009 UTC (15 years, 3 months ago) by jacekm
Branch: MAIN
Changes since 1.8: +4 -2 lines
Diff to previous 1.8 (colored)

Don't warn about F_MESSAGE_SCHEDULED flag being present in on-disk version of
the envelope; ok gilles@

Revision 1.8 / (download) - annotate - [select for diffs], Sun Feb 15 13:44:06 2009 UTC (15 years, 3 months ago) by jacekm
Branch: MAIN
Changes since 1.7: +3 -5 lines
Diff to previous 1.7 (colored)

kill local vars that are used only once; ok gilles@

Revision 1.7 / (download) - annotate - [select for diffs], Sat Feb 14 00:00:47 2009 UTC (15 years, 3 months ago) by jacekm
Branch: MAIN
Changes since 1.6: +41 -3 lines
Diff to previous 1.6 (colored)

Display envelope status & flags in "show queue"; ok gilles@

Revision 1.6 / (download) - annotate - [select for diffs], Fri Jan 30 16:37:52 2009 UTC (15 years, 4 months ago) by gilles
Branch: MAIN
Changes since 1.5: +10 -2 lines
Diff to previous 1.5 (colored)

fix a very annoying events masking issue which would cause a fatal() to be
hit under certain conditions; while tracking the bug I ran into other bugs
which were kind of related and could cause us to hit a fatal() too.

fix by me, but with lots of testing and investigation with jacekm@,
ok jacekm@

Revision 1.5 / (download) - annotate - [select for diffs], Thu Jan 29 12:43:25 2009 UTC (15 years, 4 months ago) by jacekm
Branch: MAIN
Changes since 1.4: +205 -1 lines
Diff to previous 1.4 (colored)

Common queue walking code for smtpd and smtpctl. Kills majority of showqueue.c,
the remaining code was moved to queue_shared.c; ok gilles@

Revision 1.4 / (download) - annotate - [select for diffs], Wed Jan 28 17:29:11 2009 UTC (15 years, 4 months ago) by jacekm
Branch: MAIN
Changes since 1.3: +12 -15 lines
Diff to previous 1.3 (colored)

Make races between queue and runner impossible by implementing the policy:
1) queue never reads /queue.
2) queue writes to /queue only at message injection time.
3) runner does all reading, and all writing apart from 2).

ok gilles@

Revision 1.3 / (download) - annotate - [select for diffs], Wed Jan 28 12:58:17 2009 UTC (15 years, 4 months ago) by gilles
Branch: MAIN
Changes since 1.2: +214 -1 lines
Diff to previous 1.2 (colored)

move some functions from queue.c to queue_shared.c as they are not only
used by queue process but also by runner, while at it change the prototype
of queue_open_message_file() so it takes the message id and not a batch,
runner process requires the decriptor before it even starts building a
batch.

Revision 1.2 / (download) - annotate - [select for diffs], Wed Jan 28 11:27:57 2009 UTC (15 years, 4 months ago) by gilles
Branch: MAIN
Changes since 1.1: +5 -5 lines
Diff to previous 1.1 (colored)

add a struct path to struct message so that we can keep track of the RCPT
provided recipient even after aliases/forwards expansion, we'll need this
for loop detection.

message id and uid being MAXPATHLEN long is a waste, define MAX_ID_SIZE
which is currently set to 64 (but can probably be further reduced) and
make sure that structures and the few strlcpy's use the right define.

original idea by jacekm@ a while ago

Revision 1.1 / (download) - annotate - [select for diffs], Tue Jan 27 22:54:01 2009 UTC (15 years, 4 months ago) by gilles
Branch: MAIN

follow the naming convention of other files, discussed with jacekm@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.