![[BACK]](/icons/back.gif){kind=icon}
Up to [local] / src / usr.sbin / snmpd
Request diff between arbitrary revisions
Default branch: MAIN
Revision 1.15, Tue Jun 30 17:11:49 2020 UTC (3 years, 11 months ago) by martijn
Branch: MAIN
CVS Tags: HEAD
Changes since 1.14: +1 -1 lines
FILE REMOVED
Remove agentx and control socket support. snmpctl has been removed two releases ago, which makes the control interface obsolete. agentx support has always been quirky at best, but got completely broken with the BER_MAX_OID_LEN increase in ber.h. This change resulted in the oid length on the snmp side being left uninitialized because of size difference, resulting in weird behaviour. No one reported the breakage, even after 6.7 was released. This change requires users to remove the socket keyword from their snmpd.conf. OK denis@
Revision 1.14 / (download) - annotate - [select for diffs], Fri Jun 5 19:50:59 2020 UTC (4 years ago) by denis
Branch: MAIN
Changes since 1.13: +1 -2 lines
Diff to previous 1.13 (colored)
Remove redundant code Reported by Prof. Dr. Steffen Wendzel <wendzel @ hs-worms . de>, thanks! OK martijn@ sthen@
Revision 1.13 / (download) - annotate - [select for diffs], Sun Jun 17 18:19:59 2018 UTC (5 years, 11 months ago) by rob
Branch: MAIN
CVS Tags: OPENBSD_6_7_BASE,
OPENBSD_6_7,
OPENBSD_6_6_BASE,
OPENBSD_6_6,
OPENBSD_6_5_BASE,
OPENBSD_6_5,
OPENBSD_6_4_BASE,
OPENBSD_6_4
Changes since 1.12: +9 -22 lines
Diff to previous 1.12 (colored)
Bring snmpd agentx.c closer in line with relayd. ok benno@, "sure" deraadt@
Revision 1.12 / (download) - annotate - [select for diffs], Wed Feb 14 12:43:07 2018 UTC (6 years, 3 months ago) by rob
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE,
OPENBSD_6_3
Changes since 1.11: +4 -3 lines
Diff to previous 1.11 (colored)
whitespace
Revision 1.11 / (download) - annotate - [select for diffs], Fri Jan 5 08:13:32 2018 UTC (6 years, 5 months ago) by mpi
Branch: MAIN
Changes since 1.10: +2 -2 lines
Diff to previous 1.10 (colored)
Remove useless <sys/socketvar.h> includes. ok kettenis@, visa@, claudio@, deraadt@
Revision 1.10 / (download) - annotate - [select for diffs], Sat Dec 5 06:42:18 2015 UTC (8 years, 6 months ago) by mmcc
Branch: MAIN
CVS Tags: OPENBSD_6_2_BASE,
OPENBSD_6_2,
OPENBSD_6_1_BASE,
OPENBSD_6_1,
OPENBSD_6_0_BASE,
OPENBSD_6_0,
OPENBSD_5_9_BASE,
OPENBSD_5_9
Changes since 1.9: +2 -3 lines
Diff to previous 1.9 (colored)
strings.h -> string.h to prevent an implicit declaration warning. Also remove a handful of NULL-checks before free().
Revision 1.9 / (download) - annotate - [select for diffs], Sun Jul 19 01:08:07 2015 UTC (8 years, 10 months ago) by blambert
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE,
OPENBSD_5_8
Changes since 1.8: +18 -9 lines
Diff to previous 1.8 (colored)
don't return failure for agentx messages with 0-length payloads allows snmpd to properly handle ping messages from agentx subagents ok reyk@
Revision 1.8 / (download) - annotate - [select for diffs], Wed Nov 19 10:19:00 2014 UTC (9 years, 6 months ago) by blambert
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE,
OPENBSD_5_7
Changes since 1.7: +194 -31 lines
Diff to previous 1.7 (colored)
add support for AgentX subagents in snmpd snmp requests are now packaged into pseudo-continuations to allow for being dispatched to seperate processes; lightly tested for interoperability with NetSNMP, but doesn't implement the complete set of AgentX messages while here, clean up return types of mps_get* functions, and make smi_insert refuse to insert duplicate OIDs okay benno@ reyk@
Revision 1.7 / (download) - annotate - [select for diffs], Fri Nov 14 16:18:43 2014 UTC (9 years, 6 months ago) by reyk
Branch: MAIN
Changes since 1.6: +11 -12 lines
Diff to previous 1.6 (colored)
Shorten the AgentX header debug messages (only compiled with -DDEBUG) to a single line and print to stderr instead of stdout. This makes it easier to follow the debug output again. Also, as a rule of thumb, it is OK to exceed 80 chars for these kinds of developer debug messages. OK blambert@
Revision 1.6 / (download) - annotate - [select for diffs], Sun Oct 12 13:08:47 2014 UTC (9 years, 7 months ago) by blambert
Branch: MAIN
Changes since 1.5: +5 -5 lines
Diff to previous 1.5 (colored)
Remove possibility of mutiplicative integer overflow by not multiplying.
Instead of the widespread-but-overflow-prone
while (newlen < wanted) { newlen *= 2; }
idiom, just realloc() for the space requested by the caller and check
for additive overflow.
Also change type of 'newlen' variable from int to size_t to avoid
overflows there.
Pointed out by deraadt@
ok reyk@
Revision 1.5 / (download) - annotate - [select for diffs], Sun Apr 20 16:07:10 2014 UTC (10 years, 1 month ago) by reyk
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE,
OPENBSD_5_6
Changes since 1.4: +4 -2 lines
Diff to previous 1.4 (colored)
Just to be pedantic, fail if strlcpy managed to overflow the socket path.
Revision 1.4 / (download) - annotate - [select for diffs], Sun Apr 20 10:46:20 2014 UTC (10 years, 1 month ago) by reyk
Branch: MAIN
Changes since 1.3: +7 -7 lines
Diff to previous 1.3 (colored)
Partially revert the previous: snmp_agentx_ping() didn't leak the pdu because it is added to a list on the handle and eventually released later with the handle itself. This confuses leak detection tools like clang, so at least add a comment that it is not a leak. ok blambert@
Revision 1.3 / (download) - annotate - [select for diffs], Sun Apr 20 09:29:22 2014 UTC (10 years, 1 month ago) by reyk
Branch: MAIN
Changes since 1.2: +9 -6 lines
Diff to previous 1.2 (colored)
Fix a small leak in the error path.
Revision 1.2 / (download) - annotate - [select for diffs], Mon Apr 14 15:11:24 2014 UTC (10 years, 1 month ago) by andre
Branch: MAIN
Changes since 1.1: +1 -2 lines
Diff to previous 1.1 (colored)
No need to include ber.h here, probably overlooked while importing. ok blambert@
Revision 1.1 / (download) - annotate - [select for diffs], Mon Apr 14 12:55:10 2014 UTC (10 years, 1 month ago) by blambert
Branch: MAIN
Make snmpd use the AgentX protcol for accepting trap requests. AgentX notifications are the only portion implemented right now; get in the tree to flesh out the remainder. ok reyk@ benno@