![[BACK]](/icons/back.gif){kind=icon}
Up to [local] / src / usr.sbin / syslogd
Request diff between arbitrary revisions
Default branch: MAIN
Revision 1.19 / (download) - annotate - [select for diffs], Fri Sep 3 16:28:33 2021 UTC (2 years, 9 months ago) by bluhm
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE,
OPENBSD_7_5,
OPENBSD_7_4_BASE,
OPENBSD_7_4,
OPENBSD_7_3_BASE,
OPENBSD_7_3,
OPENBSD_7_2_BASE,
OPENBSD_7_2,
OPENBSD_7_1_BASE,
OPENBSD_7_1,
OPENBSD_7_0_BASE,
OPENBSD_7_0,
HEAD
Changes since 1.18: +4 -12 lines
Diff to previous 1.18 (colored)
Use a define for the iov array size in syslogd. This is better than passing the magic number 6 around and checking at runtime whether its fits. OK deraadt@ martijn@ mvs@
Revision 1.18 / (download) - annotate - [select for diffs], Fri Jun 28 13:32:51 2019 UTC (4 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_9_BASE,
OPENBSD_6_9,
OPENBSD_6_8_BASE,
OPENBSD_6_8,
OPENBSD_6_7_BASE,
OPENBSD_6_7,
OPENBSD_6_6_BASE,
OPENBSD_6_6
Changes since 1.17: +3 -3 lines
Diff to previous 1.17 (colored)
When system calls indicate an error they return -1, not some arbitrary value < 0. errno is only updated in this case. Change all (most?) callers of syscalls to follow this better, and let's see if this strictness helps us in the future.
Revision 1.17 / (download) - annotate - [select for diffs], Thu Oct 5 16:15:24 2017 UTC (6 years, 8 months ago) by bluhm
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE,
OPENBSD_6_5,
OPENBSD_6_4_BASE,
OPENBSD_6_4,
OPENBSD_6_3_BASE,
OPENBSD_6_3
Changes since 1.16: +17 -1 lines
Diff to previous 1.16 (colored)
I have touched more than half the source code lines of syslogd(8). Add my copyright explicitly.
Revision 1.16 / (download) - annotate - [select for diffs], Tue Aug 8 14:23:23 2017 UTC (6 years, 10 months ago) by bluhm
Branch: MAIN
CVS Tags: OPENBSD_6_2_BASE,
OPENBSD_6_2
Changes since 1.15: +5 -4 lines
Diff to previous 1.15 (colored)
Kernel sendsyslog(2), libc syslog(3), and syslogd(8) restrict and truncate the length of a syslog message to 8192 bytes. Use one global define LOG_MAXLINE for all of them. OK deraadt@ millert@
Revision 1.15 / (download) - annotate - [select for diffs], Wed Apr 5 21:55:31 2017 UTC (7 years, 2 months ago) by bluhm
Branch: MAIN
Changes since 1.14: +24 -32 lines
Diff to previous 1.14 (colored)
As we did not have nice log functions before, ttymsg() had to return the error string. Log the message when the error happens and make the function void. OK millert@
Revision 1.14 / (download) - annotate - [select for diffs], Wed Apr 5 11:31:45 2017 UTC (7 years, 2 months ago) by bluhm
Branch: MAIN
Changes since 1.13: +3 -2 lines
Diff to previous 1.13 (colored)
Replace logdebug() with generic log_debug() from log.c. Implement log_debugadd() to construct debug message incrementally. OK deraadt@
Revision 1.13 / (download) - annotate - [select for diffs], Fri Mar 24 16:24:36 2017 UTC (7 years, 2 months ago) by bluhm
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE,
OPENBSD_6_1
Changes since 1.12: +3 -3 lines
Diff to previous 1.12 (colored)
Replace bcopy(3) with memmove(3) in function ttymsg(). Values of iov and localiov may overlap. No more bcopy(3) in syslogd(8). from Michael W. Bombardieri
Revision 1.12 / (download) - annotate - [select for diffs], Thu Mar 16 12:14:37 2017 UTC (7 years, 2 months ago) by bluhm
Branch: MAIN
Changes since 1.11: +5 -4 lines
Diff to previous 1.11 (colored)
There was a file descripotor leak in the syslogd(8) ttymsg() error path. Before returning early with an error, close the newly opened file descriptor. OK deraadt@
Revision 1.11 / (download) - annotate - [select for diffs], Tue Aug 16 18:41:57 2016 UTC (7 years, 9 months ago) by tedu
Branch: MAIN
Changes since 1.10: +5 -2 lines
Diff to previous 1.10 (colored)
stop including sys/param.h for nitems. define locally as needed. ok natano reyk
Revision 1.10 / (download) - annotate - [select for diffs], Sat Apr 2 19:55:10 2016 UTC (8 years, 2 months ago) by krw
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE,
OPENBSD_6_0
Changes since 1.9: +1 -2 lines
Diff to previous 1.9 (colored)
Eliminate superfluous 3rd params in fcntl(F_GETFL) calls. ttymsg.c doesn't need to include fcntl.h. Tweak standard fd sanitising to be more like the sanitise_stdfd() used elsewhere, though other uses of 'nullfd' make importing sanitise_stdfd() itself unappetizing. Add a die(0) if dup2() fails. suggestions & ok bluhm@
Revision 1.9 / (download) - annotate - [select for diffs], Fri Oct 23 16:28:52 2015 UTC (8 years, 7 months ago) by bluhm
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE,
OPENBSD_5_9
Changes since 1.8: +73 -30 lines
Diff to previous 1.8 (colored)
If writing to a tty blocks, syslogd forked and tried to write again in a background process. A potential fork(2) at every message is bad, so replace this with an event. As a bonus the syslogd child process does not need to pledge "proc" anymore. Also limit the number of delayed write events. OK deraadt@
Revision 1.8 / (download) - annotate - [select for diffs], Wed Oct 21 14:03:07 2015 UTC (8 years, 7 months ago) by bluhm
Branch: MAIN
Changes since 1.7: +29 -26 lines
Diff to previous 1.7 (colored)
Do some cleanup in syslogd ttymsg(). Add a debug message when the syslogd child calls fork(2) to delay blocked output. OK benno@
Revision 1.7 / (download) - annotate - [select for diffs], Mon Jul 6 16:12:16 2015 UTC (8 years, 11 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE,
OPENBSD_5_8
Changes since 1.6: +1 -3 lines
Diff to previous 1.6 (colored)
Remove some unneeded includes. OK deraadt@
Revision 1.6 / (download) - annotate - [select for diffs], Fri Jan 16 06:40:21 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_7_BASE,
OPENBSD_5_7
Changes since 1.5: +2 -2 lines
Diff to previous 1.5 (colored)
Replace <sys/param.h> with <limits.h> and other less dirty headers where possible. Annotate <sys/param.h> lines with their current reasons. Switch to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where sensible to avoid pulling in the pollution. These are the files confirmed through binary verification. ok guenther, millert, doug (helped with the verification protocol)
Revision 1.5 / (download) - annotate - [select for diffs], Mon Aug 25 18:05:30 2014 UTC (9 years, 9 months ago) by bluhm
Branch: MAIN
Changes since 1.4: +8 -5 lines
Diff to previous 1.4 (colored)
Fix the gcc compiler warnings "comparison between signed and unsigned". Some checks got stricter. The (size_t) cast is only done, if the argument is not negative. OK henning@
Revision 1.4 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:54 2009 UTC (14 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE,
OPENBSD_5_6,
OPENBSD_5_5_BASE,
OPENBSD_5_5,
OPENBSD_5_4_BASE,
OPENBSD_5_4,
OPENBSD_5_3_BASE,
OPENBSD_5_3,
OPENBSD_5_2_BASE,
OPENBSD_5_2,
OPENBSD_5_1_BASE,
OPENBSD_5_1,
OPENBSD_5_0_BASE,
OPENBSD_5_0,
OPENBSD_4_9_BASE,
OPENBSD_4_9,
OPENBSD_4_8_BASE,
OPENBSD_4_8,
OPENBSD_4_7_BASE,
OPENBSD_4_7
Changes since 1.3: +1 -8 lines
Diff to previous 1.3 (colored)
rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and unmaintainable). these days, people use source. these id's do not provide any benefit, and do hurt the small install media (the 33,000 line diff is essentially mechanical) ok with the idea millert, ok dms
Revision 1.3 / (download) - annotate - [select for diffs], Sat Jul 3 23:40:44 2004 UTC (19 years, 11 months ago) by djm
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE,
OPENBSD_4_6,
OPENBSD_4_5_BASE,
OPENBSD_4_5,
OPENBSD_4_4_BASE,
OPENBSD_4_4,
OPENBSD_4_3_BASE,
OPENBSD_4_3,
OPENBSD_4_2_BASE,
OPENBSD_4_2,
OPENBSD_4_1_BASE,
OPENBSD_4_1,
OPENBSD_4_0_BASE,
OPENBSD_4_0,
OPENBSD_3_9_BASE,
OPENBSD_3_9,
OPENBSD_3_8_BASE,
OPENBSD_3_8,
OPENBSD_3_7_BASE,
OPENBSD_3_7,
OPENBSD_3_6_BASE,
OPENBSD_3_6
Changes since 1.2: +3 -3 lines
Diff to previous 1.2 (colored)
-Wall,-Wshadow cleanup with avsm@; ok henning@ krw@
Revision 1.2 / (download) - annotate - [select for diffs], Wed Aug 27 00:27:50 2003 UTC (20 years, 9 months ago) by avsm
Branch: MAIN
CVS Tags: OPENBSD_3_5_BASE,
OPENBSD_3_5,
OPENBSD_3_4_BASE,
OPENBSD_3_4
Changes since 1.1: +3 -3 lines
Diff to previous 1.1 (colored)
correct error message (wall -> syslogd)
Revision 1.1 / (download) - annotate - [select for diffs], Thu Jul 31 18:20:07 2003 UTC (20 years, 10 months ago) by avsm
Branch: MAIN
Privilege separated syslog daemon. The child listening to log requests drops to user _syslogd and chroots itself, while the privileged parent grants it access to open logfiles and other calls it needs. The only difference from existing behaviour is that if syslog.conf changes and syslogd receives a HUP, it will re-exec itself and have two new PIDs. A HUP with an unchanged config will make syslogd reopen logfiles as before. Lots of help and code from deraadt@ , and advice from millert@ Various versions tested by todd, cloder, mpech, markus, tdeval and others