OpenBSD CVS

CVS log for src/usr.sbin/tcpdump/print-bootp.c


[BACK] Up to [local] / src / usr.sbin / tcpdump

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.25 / (download) - annotate - [select for diffs], Wed Dec 1 18:28:45 2021 UTC (2 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, HEAD
Changes since 1.24: +1 -3 lines
Diff to previous 1.24 (colored)

we do not need 'struct mbuf; struct rtentry;' to satisfy some ancient unix
variant that made a header file mistake.
ok jsg

Revision 1.24 / (download) - annotate - [select for diffs], Fri Jan 24 22:46:36 2020 UTC (4 years, 4 months ago) by procter
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.23: +7 -7 lines
Diff to previous 1.23 (colored)

- (void)printf() -> printf(); the cast adds clutter for little value.
- fprintf(stdout, ...) -> printf()
- fputs(x, stdout) -> printf(); for consistency.
fputs is twice as fast on atom x5-Z8300@1.44GHz but Amdahl sees a pure printf
tcpdump only 2% slower than a pure fputs (for constant strings) tcpdump
to /dev/null across a 20MB/~170k packet pcap file.

ok dlg@ for fputs and ok tedu@ krw@ deraadt@ a2k19 for the rest

Revision 1.23 / (download) - annotate - [select for diffs], Fri Jul 6 05:47:22 2018 UTC (5 years, 11 months ago) by dlg
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4
Changes since 1.22: +4 -4 lines
Diff to previous 1.22 (colored)

Rework UDP parsing, particularly around IP addresses.

This originally started as trying to put a consistent space between
the UDP header information and the payload parsing, but while doing
that I noticed inconsistent IPv4 vs IPv6 handling.

Apart from the default "srcip.srcport > dstip.dstpor" output, all
the other places that IP addresses were printed assumed IPv4. It
looks like it is possible that udp_print() can be called without
an IP header, which made these blind IPv4 prints turn into NULL
derefs.

This fixes the problem above by only having a single place that
prints the addresses out, and makes sure to get the difference
between IPv4, IPv6 and no IP correct.

This changes how the checksum is calculated. It incrementally builds
the UDP checksum by feeding the IPv4 and v6 addresses in separately,
then using common code for the rest of the pseudo header and actual
payload.

Lastly, this does make printing the space between the UDP header
and its payload consistent. The UDP code is now responsible for
adding a space after itself so the payload parsers don't have to.
They got it wrong in some cases anyway, so this should be a lot
more uniform.

help and ok sthen@

Revision 1.22 / (download) - annotate - [select for diffs], Tue Dec 22 21:01:07 2015 UTC (8 years, 5 months ago) by mmcc
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.21: +2 -2 lines
Diff to previous 1.21 (colored)

assign pointers to NULL rather than 0

Revision 1.21 / (download) - annotate - [select for diffs], Wed Nov 18 15:36:20 2015 UTC (8 years, 6 months ago) by mmcc
Branch: MAIN
Changes since 1.20: +1 -2 lines
Diff to previous 1.20 (colored)

Remove memory.h includes.

ok deraadt@

Revision 1.20 / (download) - annotate - [select for diffs], Sun Nov 15 20:35:36 2015 UTC (8 years, 6 months ago) by mmcc
Branch: MAIN
Changes since 1.19: +12 -12 lines
Diff to previous 1.19 (colored)

Remove more register keywords.

ok daniel@, discussed on hackers@

Revision 1.19 / (download) - annotate - [select for diffs], Fri Jan 16 06:40:21 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.18: +1 -2 lines
Diff to previous 1.18 (colored)

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible.  Annotate <sys/param.h> lines with their current reasons.  Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc.  Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution.  These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Revision 1.18 / (download) - annotate - [select for diffs], Sun Oct 27 18:49:25 2013 UTC (10 years, 7 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.17: +2 -2 lines
Diff to previous 1.17 (colored)

If a constant string needs a name, use a static const array instead of a
pointer or non-const array, as that minimizes the symbols, maximizes the
placement into read-only memory, and avoids warnings from gcc -Wformat=2
when they're used as format strings.

ok deraadt@

Revision 1.17 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:55 2009 UTC (14 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.16: +1 -6 lines
Diff to previous 1.16 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.16 / (download) - annotate - [select for diffs], Sun Oct 7 16:41:05 2007 UTC (16 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.15: +2 -2 lines
Diff to previous 1.15 (colored)

trash $Header goo which is just annoying; 5595

Revision 1.15 / (download) - annotate - [select for diffs], Mon Jan 8 21:29:35 2007 UTC (17 years, 5 months ago) by stevesk
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1
Changes since 1.14: +3 -3 lines
Diff to previous 1.14 (colored)

c should be u_char for printing option numbers.  fix parameter request
list option numbers >127 being negative.  ok krw@

Revision 1.14 / (download) - annotate - [select for diffs], Sun May 21 11:17:20 2006 UTC (18 years ago) by canacar
Branch: MAIN
CVS Tags: OPENBSD_4_0_BASE, OPENBSD_4_0
Changes since 1.13: +5 -5 lines
Diff to previous 1.13 (colored)

Fix size checks for bootp packets. Problem found and initial patch
from pedro@. ok moritz@

Revision 1.13 / (download) - annotate - [select for diffs], Thu Nov 17 23:33:50 2005 UTC (18 years, 6 months ago) by stevesk
Branch: MAIN
CVS Tags: OPENBSD_3_9_BASE, OPENBSD_3_9
Changes since 1.12: +4 -4 lines
Diff to previous 1.12 (colored)

fix byteorder for "s" and "l" formats; ok henning@ krw@

Revision 1.12 / (download) - annotate - [select for diffs], Tue Feb 19 19:39:40 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7, OPENBSD_3_6_BASE, OPENBSD_3_6, OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4, OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2, OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.11: +2 -4 lines
Diff to previous 1.11 (colored)

We live in an ANSI C world.  Remove lots of gratuitous #ifdef __STDC__ cruft.

Revision 1.11 / (download) - annotate - [select for diffs], Tue Oct 3 14:31:56 2000 UTC (23 years, 8 months ago) by ho
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0, OPENBSD_2_9_BASE, OPENBSD_2_9, OPENBSD_2_8_BASE, OPENBSD_2_8
Changes since 1.10: +3 -1 lines
Diff to previous 1.10 (colored)

Add $OpenBSD$. (jakob@ ok)

Revision 1.10 / (download) - annotate - [select for diffs], Wed Apr 26 21:35:39 2000 UTC (24 years, 1 month ago) by jakob
Branch: MAIN
CVS Tags: OPENBSD_2_7_BASE, OPENBSD_2_7
Changes since 1.9: +128 -2 lines
Diff to previous 1.9 (colored)

INET6
DHCP/BOOTP
tcp & udp checksum detection
numerous bugfixes

Revision 1.9 / (download) - annotate - [select for diffs], Thu Sep 16 20:58:46 1999 UTC (24 years, 8 months ago) by brad
Branch: MAIN
CVS Tags: OPENBSD_2_6_BASE, OPENBSD_2_6
Changes since 1.8: +2 -2 lines
Diff to previous 1.8 (colored)

bring more inline with tcpdump 3.4

Revision 1.8 / (download) - annotate - [select for diffs], Wed Jul 28 20:41:36 1999 UTC (24 years, 10 months ago) by jakob
Branch: MAIN
Changes since 1.7: +4 -1 lines
Diff to previous 1.7 (colored)

-  Merge some changes from tcpdump 3.4
   -a flag; attempt to convert network and broadcast addresses to names
   Improved signal handling
   Miscellaneous fixes and typos
   OSPF MD5 authentication support

-  -X flag; emacs-hexl print (including ascii)

-  Add ECN bits to TCP and IP headers

-  IKE & IPsec (ESP & AH) support

OK deraadt@

Revision 1.7 / (download) - annotate - [select for diffs], Wed Jul 8 22:32:03 1998 UTC (25 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4
Changes since 1.6: +2 -2 lines
Diff to previous 1.6 (colored)

length check bp_file; cgd

Revision 1.6 / (download) - annotate - [select for diffs], Fri Jul 25 20:12:22 1997 UTC (26 years, 10 months ago) by mickey
Branch: MAIN
CVS Tags: OPENBSD_2_3_BASE, OPENBSD_2_3, OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.5: +2 -2 lines
Diff to previous 1.5 (colored)

#if __STDC__ --> #ifdef __STDC__

Revision 1.5 / (download) - annotate - [select for diffs], Thu Dec 12 16:22:41 1996 UTC (27 years, 6 months ago) by bitblt
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.4: +30 -46 lines
Diff to previous 1.4 (colored)

*** empty log message ***

Revision 1.4 / (download) - annotate - [select for diffs], Sat Jul 13 11:01:16 1996 UTC (27 years, 11 months ago) by mickey
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.3: +23 -19 lines
Diff to previous 1.3 (colored)

it is 3.2 now.

Revision 1.3 / (download) - annotate - [select for diffs], Mon Jun 10 07:47:31 1996 UTC (28 years ago) by deraadt
Branch: MAIN
Changes since 1.2: +1 -1 lines
Diff to previous 1.2 (colored)

sync to latest

Revision 1.2 / (download) - annotate - [select for diffs], Mon Mar 4 15:59:18 1996 UTC (28 years, 3 months ago) by mickey
Branch: MAIN
Changes since 1.1: +1 -0 lines
Diff to previous 1.1 (colored)

Updating to the latest LBL release.
Sun's SKIP support added.

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:48:25 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:48:25 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.