OpenBSD CVS

CVS log for src/usr.sbin/tcpdump/print-gtp.c


[BACK] Up to [local] / src / usr.sbin / tcpdump

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.13 / (download) - annotate - [select for diffs], Mon Oct 26 23:19:18 2020 UTC (3 years, 7 months ago) by jca
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, HEAD
Changes since 1.12: +6 -1 lines
Diff to previous 1.12 (colored)

Fix parsing GTP packets with invalid extended headers.

In GTP a zero extended header length is invalid, deal with this instead
of looping forever.

Report and fix by Peter J. Philipp, tweaked by me, ok kn@

Revision 1.12 / (download) - annotate - [select for diffs], Wed May 20 01:20:37 2020 UTC (4 years ago) by dlg
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8
Changes since 1.11: +17 -10 lines
Diff to previous 1.11 (colored)

properly pass the number of strings in an array to gtp_print_str.

from miod

Revision 1.11 / (download) - annotate - [select for diffs], Mon Oct 22 16:12:45 2018 UTC (5 years, 7 months ago) by kn
Branch: MAIN
CVS Tags: OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5
Changes since 1.10: +1 -17 lines
Diff to previous 1.10 (colored)

Remove #ifdef INET6

There's not reason to build without IPv6 support, `-U INET6' builds were
broken anyway.

Fix an empty redefine for IPPROTO_IPV6 in print-ip.c while here.

No object change on amd64 and sparc64 with clang, gcc compiles differently
but behaviour stays the same.

OK denis deraadt

Revision 1.10 / (download) - annotate - [select for diffs], Fri Jul 6 05:47:22 2018 UTC (5 years, 10 months ago) by dlg
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE, OPENBSD_6_4
Changes since 1.9: +5 -5 lines
Diff to previous 1.9 (colored)

Rework UDP parsing, particularly around IP addresses.

This originally started as trying to put a consistent space between
the UDP header information and the payload parsing, but while doing
that I noticed inconsistent IPv4 vs IPv6 handling.

Apart from the default "srcip.srcport > dstip.dstpor" output, all
the other places that IP addresses were printed assumed IPv4. It
looks like it is possible that udp_print() can be called without
an IP header, which made these blind IPv4 prints turn into NULL
derefs.

This fixes the problem above by only having a single place that
prints the addresses out, and makes sure to get the difference
between IPv4, IPv6 and no IP correct.

This changes how the checksum is calculated. It incrementally builds
the UDP checksum by feeding the IPv4 and v6 addresses in separately,
then using common code for the rest of the pseudo header and actual
payload.

Lastly, this does make printing the space between the UDP header
and its payload consistent. The UDP code is now responsible for
adding a space after itself so the payload parsers don't have to.
They got it wrong in some cases anyway, so this should be a lot
more uniform.

help and ok sthen@

Revision 1.9 / (download) - annotate - [select for diffs], Tue Dec 22 21:01:07 2015 UTC (8 years, 5 months ago) by mmcc
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.8: +2 -2 lines
Diff to previous 1.8 (colored)

assign pointers to NULL rather than 0

Revision 1.8 / (download) - annotate - [select for diffs], Mon Nov 16 00:16:39 2015 UTC (8 years, 6 months ago) by mmcc
Branch: MAIN
Changes since 1.7: +27 -27 lines
Diff to previous 1.7 (colored)

Remove remaining instances of the register keyword.

ok deraadt@

Revision 1.7 / (download) - annotate - [select for diffs], Fri Jan 16 06:40:21 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.6: +1 -2 lines
Diff to previous 1.6 (colored)

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible.  Annotate <sys/param.h> lines with their current reasons.  Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc.  Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution.  These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Revision 1.6 / (download) - annotate - [select for diffs], Thu Aug 14 12:44:44 2014 UTC (9 years, 9 months ago) by mpi
Branch: MAIN
Changes since 1.5: +1 -2 lines
Diff to previous 1.5 (colored)

No use for <netinet/in_systm.h> nor <netinet/tcpip.h>.

Revision 1.5 / (download) - annotate - [select for diffs], Sun Sep 18 10:25:36 2011 UTC (12 years, 8 months ago) by jsing
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6, OPENBSD_5_5_BASE, OPENBSD_5_5, OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1
Changes since 1.4: +11 -11 lines
Diff to previous 1.4 (colored)

Fix whitespace.

Revision 1.4 / (download) - annotate - [select for diffs], Sun Sep 18 10:24:16 2011 UTC (12 years, 8 months ago) by jsing
Branch: MAIN
Changes since 1.3: +3 -1 lines
Diff to previous 1.3 (colored)

Avoid potential 64-bit unaligned access on strict alignment architectures.

Spotted by and ok naddy@

Revision 1.3 / (download) - annotate - [select for diffs], Thu Aug 19 15:26:38 2010 UTC (13 years, 9 months ago) by jsing
Branch: MAIN
CVS Tags: OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9
Changes since 1.2: +40 -20 lines
Diff to previous 1.2 (colored)

Correctly decode and print access point names.

Revision 1.2 / (download) - annotate - [select for diffs], Tue Aug 3 10:08:03 2010 UTC (13 years, 10 months ago) by jsg
Branch: MAIN
CVS Tags: OPENBSD_4_8_BASE, OPENBSD_4_8
Changes since 1.1: +2 -2 lines
Diff to previous 1.1 (colored)

Fix a usage of logical and where binary and was intended.
Spotted by Mike Belopuhov. ok jsing@ deraadt@

Revision 1.1 / (download) - annotate - [select for diffs], Wed Nov 4 09:43:11 2009 UTC (14 years, 7 months ago) by jsing
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE, OPENBSD_4_7

Add support to tcpdump for decoding the GPRS Tunnelling Protocol (GTP),
used to carry GPRS data over IP for GSM and UMTS networks. The decoder
understands GTPv0, GTPv0', GTPv1-C, GTPv1-U and GTPv1' traffic, however
at this stage not all TLV fields are fully decoded.

This work has been kindly sponsored by SystemNet AS (www.systemnet.no).

"commit" deraadt@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.