OpenBSD CVS

CVS log for src/usr.sbin/tcpdump/print-icmp.c


[BACK] Up to [local] / src / usr.sbin / tcpdump

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.27 / (download) - annotate - [select for diffs], Wed Dec 1 18:28:46 2021 UTC (2 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, HEAD
Changes since 1.26: +1 -3 lines
Diff to previous 1.26 (colored)

we do not need 'struct mbuf; struct rtentry;' to satisfy some ancient unix
variant that made a header file mistake.
ok jsg

Revision 1.26 / (download) - annotate - [select for diffs], Fri Jan 24 22:46:36 2020 UTC (4 years, 4 months ago) by procter
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.25: +9 -9 lines
Diff to previous 1.25 (colored)

- (void)printf() -> printf(); the cast adds clutter for little value.
- fprintf(stdout, ...) -> printf()
- fputs(x, stdout) -> printf(); for consistency.
fputs is twice as fast on atom x5-Z8300@1.44GHz but Amdahl sees a pure printf
tcpdump only 2% slower than a pure fputs (for constant strings) tcpdump
to /dev/null across a 20MB/~170k packet pcap file.

ok dlg@ for fputs and ok tedu@ krw@ deraadt@ a2k19 for the rest

Revision 1.25 / (download) - annotate - [select for diffs], Fri Jan 16 06:40:21 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9, OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7
Changes since 1.24: +4 -4 lines
Diff to previous 1.24 (colored)

Replace <sys/param.h> with <limits.h> and other less dirty headers where
possible.  Annotate <sys/param.h> lines with their current reasons.  Switch
to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc.  Change
MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where
sensible to avoid pulling in the pollution.  These are the files confirmed
through binary verification.
ok guenther, millert, doug (helped with the verification protocol)

Revision 1.24 / (download) - annotate - [select for diffs], Thu Aug 14 12:44:44 2014 UTC (9 years, 9 months ago) by mpi
Branch: MAIN
Changes since 1.23: +1 -3 lines
Diff to previous 1.23 (colored)

No use for <netinet/in_systm.h> nor <netinet/tcpip.h>.

Revision 1.23 / (download) - annotate - [select for diffs], Fri Jun 20 04:04:52 2014 UTC (9 years, 11 months ago) by lteo
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.22: +8 -5 lines
Diff to previous 1.22 (colored)

Instead of showing the difference between a bad checksum and a good
checksum, make tcpdump (with the -v flag) show the actual bad checksum
within the IP/protocol header itself and what the good checksum should
be, e.g. "[bad tcp cksum abcd! -> d1e6]"

This change applies to IP, TCP (over IPv4 and IPv6), UDP (over IPv4 and
IPv6), ICMP, and ICMPv6.  This commit also fixes several inconsistencies
in the way bad checksums were displayed for these protocols.

Tested on amd64, i386, and macppc.

ok henning@

Revision 1.22 / (download) - annotate - [select for diffs], Sat Jan 11 04:40:45 2014 UTC (10 years, 4 months ago) by lteo
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.21: +12 -2 lines
Diff to previous 1.21 (colored)

Let tcpdump detect bad ICMP checksums with the -v flag.

Tested on amd64, i386, loongson, and macppc.

OK florian@

Revision 1.21 / (download) - annotate - [select for diffs], Sat Jan 11 04:35:52 2014 UTC (10 years, 4 months ago) by lteo
Branch: MAIN
Changes since 1.20: +2 -2 lines
Diff to previous 1.20 (colored)

Make icmp_print() accept the length variable, which is the length of the
packet without the IP header.  This is needed by the next commit that
will allow tcpdump to detect bad ICMP checksums.

Related functions like {tcp,udp,icmp6}_print() already accept this
length variable, so this change makes icmp_print() consistent with
them as well.

This commit makes no functional change to tcpdump itself.

OK florian@

Revision 1.20 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:55 2009 UTC (14 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.19: +1 -6 lines
Diff to previous 1.19 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.19 / (download) - annotate - [select for diffs], Mon May 25 10:53:35 2009 UTC (15 years ago) by sthen
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6
Changes since 1.18: +3 -2 lines
Diff to previous 1.18 (colored)

add a missing check for truncated dport in the returned UDP header for
ICMP_UNREACH_PORT. from Peter J. Philipp, ok jsing@. Closes system/6149.

Revision 1.18 / (download) - annotate - [select for diffs], Sun Oct 7 16:41:05 2007 UTC (16 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4, OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.17: +2 -2 lines
Diff to previous 1.17 (colored)

trash $Header goo which is just annoying; 5595

Revision 1.17 / (download) - annotate - [select for diffs], Sun Oct 17 05:47:17 2004 UTC (19 years, 7 months ago) by otto
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7
Changes since 1.16: +29 -26 lines
Diff to previous 1.16 (colored)

implement -q for icmp, deregister, print usigned values using an unsigned
format. ok markus@

Revision 1.16 / (download) - annotate - [select for diffs], Tue Aug 10 19:54:18 2004 UTC (19 years, 10 months ago) by markus
Branch: MAIN
CVS Tags: OPENBSD_3_6_BASE, OPENBSD_3_6
Changes since 1.15: +15 -2 lines
Diff to previous 1.15 (colored)

print the original ip packet on -vv; based on tcpdump.org; ok otto@

Revision 1.15 / (download) - annotate - [select for diffs], Mon Sep 8 17:35:57 2003 UTC (20 years, 9 months ago) by cedric
Branch: MAIN
CVS Tags: OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.14: +5 -4 lines
Diff to previous 1.14 (colored)

Fix 'tcpdump -v icmp' endianess buglet, print ID in hex.
Found by ho@, help/test pb@, hex suggestion/ok deraadt@

Revision 1.14 / (download) - annotate - [select for diffs], Tue Feb 19 19:39:40 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2, OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.13: +2 -4 lines
Diff to previous 1.13 (colored)

We live in an ANSI C world.  Remove lots of gratuitous #ifdef __STDC__ cruft.

Revision 1.13 / (download) - annotate - [select for diffs], Wed Nov 7 18:48:16 2001 UTC (22 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.12: +16 -20 lines
Diff to previous 1.12 (colored)

simplify buffer handling; ok ho

Revision 1.12 / (download) - annotate - [select for diffs], Sun Sep 2 12:06:57 2001 UTC (22 years, 9 months ago) by jakob
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0
Changes since 1.11: +3 -3 lines
Diff to previous 1.11 (colored)

bad typecast

Revision 1.11 / (download) - annotate - [select for diffs], Sun Sep 2 12:05:13 2001 UTC (22 years, 9 months ago) by jakob
Branch: MAIN
Changes since 1.10: +4 -7 lines
Diff to previous 1.10 (colored)

to much copy and paste; cleanup

Revision 1.10 / (download) - annotate - [select for diffs], Sun Sep 2 12:01:35 2001 UTC (22 years, 9 months ago) by jakob
Branch: MAIN
Changes since 1.9: +18 -2 lines
Diff to previous 1.9 (colored)

add support for printing id and seq with icmp echo/echoreply; based on patch from cyxob@thief.dyndns.org

Revision 1.9 / (download) - annotate - [select for diffs], Sun Jun 10 22:17:08 2001 UTC (23 years ago) by mickey
Branch: MAIN
Changes since 1.8: +11 -7 lines
Diff to previous 1.8 (colored)

detailed ICMP_PARAMPROB printing; jakob@ ok

Revision 1.8 / (download) - annotate - [select for diffs], Tue Oct 3 14:31:57 2000 UTC (23 years, 8 months ago) by ho
Branch: MAIN
CVS Tags: OPENBSD_2_9_BASE, OPENBSD_2_9, OPENBSD_2_8_BASE, OPENBSD_2_8
Changes since 1.7: +3 -1 lines
Diff to previous 1.7 (colored)

Add $OpenBSD$. (jakob@ ok)

Revision 1.7 / (download) - annotate - [select for diffs], Mon Jul 13 22:13:47 1998 UTC (25 years, 11 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_7_BASE, OPENBSD_2_7, OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4
Changes since 1.6: +29 -23 lines
Diff to previous 1.6 (colored)

snprintf madness

Revision 1.6 / (download) - annotate - [select for diffs], Fri Jul 25 20:12:24 1997 UTC (26 years, 10 months ago) by mickey
Branch: MAIN
CVS Tags: OPENBSD_2_3_BASE, OPENBSD_2_3, OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.5: +2 -2 lines
Diff to previous 1.5 (colored)

#if __STDC__ --> #ifdef __STDC__

Revision 1.5 / (download) - annotate - [select for diffs], Thu Dec 12 16:22:37 1996 UTC (27 years, 6 months ago) by bitblt
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.4: +122 -19 lines
Diff to previous 1.4 (colored)

*** empty log message ***

Revision 1.4 / (download) - annotate - [select for diffs], Sat Jul 13 11:01:23 1996 UTC (27 years, 11 months ago) by mickey
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.3: +106 -73 lines
Diff to previous 1.3 (colored)

it is 3.2 now.

Revision 1.3 / (download) - annotate - [select for diffs], Mon Jun 10 07:47:36 1996 UTC (28 years ago) by deraadt
Branch: MAIN
Changes since 1.2: +1 -1 lines
Diff to previous 1.2 (colored)

sync to latest

Revision 1.2 / (download) - annotate - [select for diffs], Mon Mar 4 15:59:25 1996 UTC (28 years, 3 months ago) by mickey
Branch: MAIN
Changes since 1.1: +1 -0 lines
Diff to previous 1.1 (colored)

Updating to the latest LBL release.
Sun's SKIP support added.

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:48:25 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:48:25 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.