OpenBSD CVS

CVS log for src/usr.sbin/vmd/log.c


[BACK] Up to [local] / src / usr.sbin / vmd

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.9 / (download) - annotate - [select for diffs], Tue Sep 26 01:53:54 2023 UTC (8 months ago) by dv
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, HEAD
Changes since 1.8: +11 -28 lines
Diff to previous 1.8 (colored)

vmd(8): disambiguate log messages per vm and device.

The logging output from vmd(8) often specifies the function performing
the logging, but leaves which vm or vm device to guesswork and
reading tea leaves.

Change the logging formatting to prefix with information about the
specific vm and potentially the device subprocess. Most of this
logging is behind the "verbose" mode, but for warnings this will
clarify which vm or device logged the warning.

The format of vm/<name>/<device><index> is chosen to be concise and
less ugly than other approaches. This adjusts the process naming
for devices to match, dropping the use of brackets.

In the process of this change, updating log settings dynamically
via vmctl(8) is fixed by properly broadcasting that information to
the device subprocesses. The "vmm" process also now updates its own
state properly, so settings survive vm reboots.

ok mlarkin@

Revision 1.8 / (download) - annotate - [select for diffs], Tue Mar 21 12:06:56 2017 UTC (7 years, 2 months ago) by bluhm
Branch: MAIN
CVS Tags: OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1
Changes since 1.7: +6 -6 lines
Diff to previous 1.7 (colored)

From a syslog perspective it does not make sense to log fatal and
warn with the same severity.  Switch log_warn() to LOG_ERR and keep
fatal() at LOG_CRIT.
OK reyk@ florian@

Revision 1.7 / (download) - annotate - [select for diffs], Mon Jan 9 14:49:22 2017 UTC (7 years, 4 months ago) by reyk
Branch: MAIN
Changes since 1.6: +12 -5 lines
Diff to previous 1.6 (colored)

Stop accessing verbose and debug variables from log.c directly.

This replaces log_verbose() and "extern int verbose" with the two functions
log_setverbose() and log_getverbose().

Pointed out by benno@
OK krw@ eric@ gilles@ (OK gilles@ for the snmpd bits as well)

Revision 1.6 / (download) - annotate - [select for diffs], Thu Nov 24 21:39:45 2016 UTC (7 years, 6 months ago) by reyk
Branch: MAIN
Changes since 1.5: +4 -2 lines
Diff to previous 1.5 (colored)

Restore the errno in vlog() as well to have the same "safe errno"
effect in log_debug(), log_warn*() and all the other logging
functions.

Revision 1.5 / (download) - annotate - [select for diffs], Tue Nov 22 21:54:01 2016 UTC (7 years, 6 months ago) by reyk
Branch: MAIN
Changes since 1.4: +3 -1 lines
Diff to previous 1.4 (colored)

Restore previous errno after log_warn*() to make sure that it never
alters it.

OK mlarkin@

Revision 1.4 / (download) - annotate - [select for diffs], Mon Oct 31 02:57:27 2016 UTC (7 years, 7 months ago) by guenther
Branch: MAIN
Changes since 1.3: +6 -8 lines
Diff to previous 1.3 (colored)

Pass the errno value to vfatal(), renaming it to vfatalc() to match,
intead of using errno as an implicit argument

ok reyk@

Revision 1.3 / (download) - annotate - [select for diffs], Wed Oct 12 11:47:34 2016 UTC (7 years, 7 months ago) by reyk
Branch: MAIN
Changes since 1.2: +11 -8 lines
Diff to previous 1.2 (colored)

For correctness, always save errno when doing additional actions
before printing it.

OK rzalamena@

Revision 1.2 / (download) - annotate - [select for diffs], Mon Dec 7 12:10:02 2015 UTC (8 years, 5 months ago) by reyk
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.1: +3 -3 lines
Diff to previous 1.1 (colored)

Skip the "fatal in" message prefix when aborting with fatal() - when
the daemon died with a message, it is obvious that a fatal condition
happened.  More important is a useful, but short, message that
provides enough information to fix the problem.

OK benno@ deraadt@

Revision 1.1 / (download) - annotate - [select for diffs], Mon Nov 23 13:04:49 2015 UTC (8 years, 6 months ago) by reyk
Branch: MAIN

Add support for logging to stderr or syslog, and to run vmd in
foreground with -d.

OK mlarkin@ jung@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.