![[BACK]](/icons/back.gif){kind=icon}
Up to [local] / src / usr.sbin / ypldap
Request diff between arbitrary revisions
Default branch: MAIN
Revision 1.35, Sat May 11 17:46:02 2019 UTC (5 years, 1 month ago) by rob
Branch: MAIN
CVS Tags: HEAD
Changes since 1.34: +1 -1 lines
FILE REMOVED
The BER API is currently used by ldap, ldapd, ldapctl, ypldap, snmpd, and snmpctl. Separate copies of ber.[ch] have existed and been maintained in sync in ldap, ldapd, ypldap and snmpd. This commit moves the BER API into /usr/lib/libutil. All current consumers already link libutil. ldapd and snmpd regress passes, and release builds. With help from tb@ and guenther@. ok deraadt@, tb@
Revision 1.34 / (download) - annotate - [select for diffs], Sat Apr 27 14:58:15 2019 UTC (5 years, 1 month ago) by rob
Branch: MAIN
Changes since 1.33: +4 -3 lines
Diff to previous 1.33 (colored)
Only apply sign extension when less than eight bytes have been consumed. This fixes a problem when handling large negative integers. ok claudio@
Revision 1.33 / (download) - annotate - [select for diffs], Tue Nov 27 12:06:39 2018 UTC (5 years, 6 months ago) by martijn
Branch: MAIN
CVS Tags: OPENBSD_6_5_BASE,
OPENBSD_6_5
Changes since 1.32: +23 -1 lines
Diff to previous 1.32 (colored)
Sync aldap and ber with ldap(1). OK claudio@
Revision 1.32 / (download) - annotate - [select for diffs], Tue Nov 20 07:20:22 2018 UTC (5 years, 6 months ago) by martijn
Branch: MAIN
Changes since 1.31: +3 -1 lines
Diff to previous 1.31 (colored)
Fix when ber_free_elements is called with a NULL-value. Found via snmpctl snmp walk 127.0.0.1 oid 1 OK claudio@
Revision 1.31 / (download) - annotate - [select for diffs], Sun Aug 12 22:04:09 2018 UTC (5 years, 9 months ago) by rob
Branch: MAIN
CVS Tags: OPENBSD_6_4_BASE,
OPENBSD_6_4
Changes since 1.30: +2 -2 lines
Diff to previous 1.30 (colored)
Change ber_write_elements() to return ssize_t instead of int. ok claudio@
Revision 1.30 / (download) - annotate - [select for diffs], Fri Aug 3 01:51:28 2018 UTC (5 years, 10 months ago) by rob
Branch: MAIN
Changes since 1.29: +11 -2 lines
Diff to previous 1.29 (colored)
Place a limit on the number of elements in a ber sequence/set. This prevents possible stack overflow due to recursion in ber_free_elements(). ok claudio@
Revision 1.29 / (download) - annotate - [select for diffs], Tue Jul 31 19:38:09 2018 UTC (5 years, 10 months ago) by rob
Branch: MAIN
Changes since 1.28: +63 -63 lines
Diff to previous 1.28 (colored)
Relocate some public functions above the internal functions comment. ok claudio@
Revision 1.28 / (download) - annotate - [select for diffs], Tue Jul 31 11:37:18 2018 UTC (5 years, 10 months ago) by rob
Branch: MAIN
Changes since 1.27: +2 -2 lines
Diff to previous 1.27 (colored)
Fix some debugging output now that ber type and encoding are unsigned int. ok claudio@
Revision 1.27 / (download) - annotate - [select for diffs], Tue Jul 31 11:00:12 2018 UTC (5 years, 10 months ago) by claudio
Branch: MAIN
Changes since 1.26: +16 -16 lines
Diff to previous 1.26 (colored)
Make ber type and encoding a unsigned int instead of unsigned long. This way the size is the same on all archs and 32bit should be good enough. OK rob@
Revision 1.26 / (download) - annotate - [select for diffs], Fri Jul 13 08:50:38 2018 UTC (5 years, 10 months ago) by rob
Branch: MAIN
Changes since 1.25: +5 -5 lines
Diff to previous 1.25 (colored)
Fix some comments referencing sockets which are not used by the ber api. The api uses read and write buffers (byte streams) that are utilized by calling applications which may or may not use sockets. ok claudio@ buffer byte streams that applications then use for
Revision 1.25 / (download) - annotate - [select for diffs], Fri Jul 13 08:30:10 2018 UTC (5 years, 10 months ago) by rob
Branch: MAIN
Changes since 1.24: +5 -6 lines
Diff to previous 1.24 (colored)
Fix loop condition in ber.c. Discussed with claudio. ok claudio@, jca@
Revision 1.24 / (download) - annotate - [select for diffs], Mon Jul 9 09:21:26 2018 UTC (5 years, 11 months ago) by jca
Branch: MAIN
Changes since 1.23: +16 -36 lines
Diff to previous 1.23 (colored)
Simplify ber_read() After the removal of fd-based read/writes I could have trimmed the code further. - no socket-based reads so ber_read() doesn't need to loop until it gets the desired amount of data - return either the requested amount of data or -1/ECANCELED, the caller shouldn't have to handle partial reads itself - inline ber_readbuf() into ber_read() ok rob@ claudio@ tb@
Revision 1.23 / (download) - annotate - [select for diffs], Wed Jul 4 15:21:24 2018 UTC (5 years, 11 months ago) by rob
Branch: MAIN
Changes since 1.22: +2 -4 lines
Diff to previous 1.22 (colored)
More whitespace.
Revision 1.22 / (download) - annotate - [select for diffs], Wed Jul 4 13:31:57 2018 UTC (5 years, 11 months ago) by rob
Branch: MAIN
Changes since 1.21: +2 -2 lines
Diff to previous 1.21 (colored)
Cleanup some whitespace.
Revision 1.21 / (download) - annotate - [select for diffs], Wed Jul 4 13:04:30 2018 UTC (5 years, 11 months ago) by rob
Branch: MAIN
Changes since 1.20: +4 -8 lines
Diff to previous 1.20 (colored)
Relocate the update of br_offs from ber_read() to ber_readbuf() so ber_getc() can call ber_readbuf() in all cases. This resolves a problem previously encountered with SNMPv3 authentication, simplifies the code, and completes a full synchronization of all ber instances. Proposed by claudio@. Problematic use case in snmpd tested by sthen@ and me. ldap(s) appear happy as well. looks good to claudio@
Revision 1.20 / (download) - annotate - [select for diffs], Tue Jul 3 18:49:10 2018 UTC (5 years, 11 months ago) by rob
Branch: MAIN
Changes since 1.19: +62 -3 lines
Diff to previous 1.19 (colored)
Synchronize ber changes from the snmpd instance to ldap, ldapd, and ypldap. See usr.sbin/snmpd/ber.c revision 1.24 commit log for a summary of these changes (e.g. SNMPv2 traps, User-based Security Model, callback for USM HMAC calculations). There is one final ber piece to copy from the snmpd instance related to ber_getc() which will be done in a separate diff. "looks good to me" deraadt@
Revision 1.19 / (download) - annotate - [select for diffs], Sun Jul 1 20:03:48 2018 UTC (5 years, 11 months ago) by rob
Branch: MAIN
Changes since 1.18: +2 -2 lines
Diff to previous 1.18 (colored)
s/constructive/constructed in DPRINTF output.
Revision 1.18 / (download) - annotate - [select for diffs], Fri Jun 29 18:28:42 2018 UTC (5 years, 11 months ago) by rob
Branch: MAIN
Changes since 1.17: +2 -2 lines
Diff to previous 1.17 (colored)
Consistent use of copyright notices. Ok reyk@
Revision 1.17 / (download) - annotate - [select for diffs], Fri Jun 29 15:18:03 2018 UTC (5 years, 11 months ago) by rob
Branch: MAIN
Changes since 1.16: +21 -8 lines
Diff to previous 1.16 (colored)
Synchronize ber.c and ber.h across ldap, ldapd, and ypldap, and reduce diff with snmpd. More tweaks to come once things are fully synchronized. Feedback from claudio and Robert Klein. Ok claudio@
Revision 1.16 / (download) - annotate - [select for diffs], Wed Jun 27 20:38:10 2018 UTC (5 years, 11 months ago) by rob
Branch: MAIN
Changes since 1.15: +3 -3 lines
Diff to previous 1.15 (colored)
Synchronize some comments.
Revision 1.15 / (download) - annotate - [select for diffs], Wed Jun 27 20:11:27 2018 UTC (5 years, 11 months ago) by rob
Branch: MAIN
Changes since 1.14: +2 -2 lines
Diff to previous 1.14 (colored)
Consistent use of calloc in ber.c. Ok claudio@, "looks right" gsoares@
Revision 1.14 / (download) - annotate - [select for diffs], Wed Jun 27 13:22:17 2018 UTC (5 years, 11 months ago) by rob
Branch: MAIN
Changes since 1.13: +3 -2 lines
Diff to previous 1.13 (colored)
Synchronize correct processing of BER_TYPE_EOC. Fixes support for empty LDAP passwords. A similar fix was applied to snmpd in 2010 (rev 1.23). Pointers from Reyk. Ok claudio@
Revision 1.13 / (download) - annotate - [select for diffs], Thu Feb 8 18:02:06 2018 UTC (6 years, 4 months ago) by jca
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE,
OPENBSD_6_3
Changes since 1.12: +7 -33 lines
Diff to previous 1.12 (colored)
Kill ber.c support for direct fd read/writes This mechanism is already unused and annotated with lots of XXX's, no need to keep it around. ok claudio@
Revision 1.12 / (download) - annotate - [select for diffs], Wed Apr 6 13:04:10 2016 UTC (8 years, 2 months ago) by jmatthew
Branch: MAIN
CVS Tags: OPENBSD_6_2_BASE,
OPENBSD_6_2,
OPENBSD_6_1_BASE,
OPENBSD_6_1,
OPENBSD_6_0_BASE,
OPENBSD_6_0
Changes since 1.11: +8 -1 lines
Diff to previous 1.11 (colored)
Apply revisions 1.4 and 1.5 from ldapd's ber.c to ypldap's copy, so it can deal with messages that haven't been fully read from the server yet. Not needed yet, but will be soon. ok dlg@
Revision 1.11 / (download) - annotate - [select for diffs], Sat Mar 5 03:31:39 2016 UTC (8 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.10: +4 -4 lines
Diff to previous 1.10 (colored)
mirror memset changes to ber.c made in ldapd (these 3 daemons have subtly modified copies of the file) from rob pierce
Revision 1.10 / (download) - annotate - [select for diffs], Sat Dec 5 19:10:19 2015 UTC (8 years, 6 months ago) by mmcc
Branch: MAIN
CVS Tags: OPENBSD_5_9_BASE,
OPENBSD_5_9
Changes since 1.9: +3 -4 lines
Diff to previous 1.9 (colored)
strings.h -> string.h to prevent an implicit declaration. Also removes two NULL-checks before free().
Revision 1.9 / (download) - annotate - [select for diffs], Thu Feb 12 00:30:38 2015 UTC (9 years, 3 months ago) by pelikan
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE,
OPENBSD_5_8,
OPENBSD_5_7_BASE,
OPENBSD_5_7
Changes since 1.8: +31 -14 lines
Diff to previous 1.8 (colored)
ber_printf_elements should return NULL if any of its parts fail. Leave the error handling up to its callers. ok reyk
Revision 1.8 / (download) - annotate - [select for diffs], Fri Jan 16 06:40:22 2015 UTC (9 years, 4 months ago) by deraadt
Branch: MAIN
Changes since 1.7: +3 -3 lines
Diff to previous 1.7 (colored)
Replace <sys/param.h> with <limits.h> and other less dirty headers where possible. Annotate <sys/param.h> lines with their current reasons. Switch to PATH_MAX, NGROUPS_MAX, HOST_NAME_MAX+1, LOGIN_NAME_MAX, etc. Change MIN() and MAX() to local definitions of MINIMUM() and MAXIMUM() where sensible to avoid pulling in the pollution. These are the files confirmed through binary verification. ok guenther, millert, doug (helped with the verification protocol)
Revision 1.7 / (download) - annotate - [select for diffs], Mon Jun 14 13:46:08 2010 UTC (13 years, 11 months ago) by martinh
Branch: MAIN
CVS Tags: OPENBSD_5_6_BASE,
OPENBSD_5_6,
OPENBSD_5_5_BASE,
OPENBSD_5_5,
OPENBSD_5_4_BASE,
OPENBSD_5_4,
OPENBSD_5_3_BASE,
OPENBSD_5_3,
OPENBSD_5_2_BASE,
OPENBSD_5_2,
OPENBSD_5_1_BASE,
OPENBSD_5_1,
OPENBSD_5_0_BASE,
OPENBSD_5_0,
OPENBSD_4_9_BASE,
OPENBSD_4_9,
OPENBSD_4_8_BASE,
OPENBSD_4_8
Changes since 1.6: +6 -6 lines
Diff to previous 1.6 (colored)
Fixes unlinking the first element inside a set or a sequence, and fix reading empty sequences/sets. This minimizes the changes against ldapd. "looks good" pyr@, ok reyk@
Revision 1.6 / (download) - annotate - [select for diffs], Tue Jun 8 17:52:47 2010 UTC (14 years ago) by martinh
Branch: MAIN
Changes since 1.5: +5 -5 lines
Diff to previous 1.5 (colored)
ber_calc_len() is not an internal function, so adjust the comment. from Dawe
Revision 1.5 / (download) - annotate - [select for diffs], Wed Feb 24 14:09:45 2010 UTC (14 years, 3 months ago) by jmc
Branch: MAIN
CVS Tags: OPENBSD_4_7_BASE,
OPENBSD_4_7
Changes since 1.4: +2 -5 lines
Diff to previous 1.4 (colored)
match code and doc; ok claudio
Revision 1.4 / (download) - annotate - [select for diffs], Wed Dec 16 22:17:53 2009 UTC (14 years, 5 months ago) by deraadt
Branch: MAIN
Changes since 1.3: +2 -5 lines
Diff to previous 1.3 (colored)
knf and unused variables
Revision 1.3 / (download) - annotate - [select for diffs], Thu Nov 12 15:28:34 2009 UTC (14 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.2: +2 -2 lines
Diff to previous 1.2 (colored)
accessses 1 entry too far, found by parfait, ok jsg claudio
Revision 1.2 / (download) - annotate - [select for diffs], Thu Jun 4 18:03:07 2009 UTC (15 years ago) by jsg
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE,
OPENBSD_4_6
Changes since 1.1: +2 -2 lines
Diff to previous 1.1 (colored)
Make the types of ber_read() decl match the prototype. 'looks good' pyr@
Revision 1.1 / (download) - annotate - [select for diffs], Tue Sep 30 16:24:16 2008 UTC (15 years, 8 months ago) by aschrijver
Branch: MAIN
CVS Tags: OPENBSD_4_5_BASE,
OPENBSD_4_5
aldap library -- Replacement for openldap used in ypldap. aldap is an semi-asynchronous client interface to connect to LDAP servers.