Annotation of www/porting.html, Revision 1.28
1.20 rohee 1: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">
1.1 marc 2: <html>
3: <head>
4: <meta http-equiv="Content-Type"
1.15 espie 5: content="text/html; charset=iso-8859-1">
1.1 marc 6: <meta name="resource-type"
1.15 espie 7: content="document">
1.1 marc 8: <meta name="description"
1.15 espie 9: CONTENT="How to make an OpenBSD port">
1.1 marc 10: <meta name="keywords"
1.15 espie 11: content="openbsd,ports">
1.1 marc 12: <meta name="distribution"
1.15 espie 13: content="global">
1.1 marc 14: <meta name="copyright"
1.20 rohee 15: content="This document copyright 1997-1999 by the OpenBSD project">
1.1 marc 16: <title>Building an OpenBSD port</title>
17: <link rev="made" HREF="mailto:www@openbsd.org">
18: </head>
19: <body text="#000000" bgcolor="#FFFFFF" link="#23238E">
1.6 pauls 20: <img height=30 width=141 src=images/smalltitle.gif alt="[OpenBSD]" >
1.1 marc 21:
1.20 rohee 22: <h2><font color="#e00000">Building an OpenBSD port</font></h2>
1.1 marc 23:
24: So you've just compiled your favorite software package on your
25: OpenBSD machine and you want to share your effort by turning
26: it into a standard port. What to do?
27: <p>
1.25 espie 28: The most important thing you can is to <strong>communicate</strong>.
29: Ask people on <a href="mailto:ports@openbsd.org">ports@openbsd.org</a>
30: if they are working on the same port. <em>Tell the original software
31: author about it</em>, including problems you may find. If licensing
32: information appears incorrect tell him. If you had to jump through
33: loops to make the port build, tell him what he can fix. If they are
34: only developping on Linux and feel like ignoring the rest of the Unix
35: world, try to make them change their view.
36: <p>
37: <strong>COMMUNICATION</strong> makes the difference between a successful
38: port and a port that will slowly be abandonned by everyone.
39: <p>
1.9 marc 40: First look at the porting information on this page. Then check
41: out the referenced documents, especially the OpenBSD porting
1.26 espie 42: <a href="checklist.html">checklist</a>.
1.1 marc 43: <p>
1.9 marc 44: Test, then re-test, and finally test again!
45: <p>
46: Submit the port. Create a gzipped tarball of the port directory.
47: You can then either place it on a public FTP or HTTP server, sending
1.20 rohee 48: its address to <a href="mailto:ports@openbsd.org">ports@openbsd.org</a>
1.9 marc 49: or send the port mime encoded to the same address. Pick whichever
50: method works best for you.
1.1 marc 51: <p>
1.20 rohee 52: <h3><font color="#0000e0">Available Porting Information</font></h3>
1.1 marc 53: <ul>
54: <li>The file <code>/usr/share/mk/bsd.port.mk</code>. This is the
55: system ports makefile included at the end of each individual
56: port makefile. Read the comments at the start of the makefile.
57: They do a good job of describing the available make options.
58: <li>The
1.13 art 59: <a href="http://www.netbsd.org/Documentation/software/packages.html">
60: NetBSD Package System</a> documentation. This document describes
61: NetBSD's version of the FreeBSD ports system and is quite helpful.
1.8 marc 62: <li>Section 19.2.5 of the
1.1 marc 63: <a href="http://www.freebsd.org/handbook/porting.html">FreeBSD
64: Handbook</a>. This is the FreeBSD porting bible.
1.26 espie 65: <li>OpenBSD porting <a href="checklist.html">checklist</a>.
1.27 espie 66: <li><a href="audio-port.html">Porting audio applications to OpenBSD</a>.
1.1 marc 67: <li>The OpenBSD ports mailing list,
68: <a href="mailto:ports@openbsd.org">ports@OpenBSD.ORG</a>.
69: </ul>
1.20 rohee 70: <h3><font color="#0000e0">OpenBSD Porting Policy</font></h3>
1.1 marc 71: <ul>
1.24 rohee 72: <li>OpenBSD does NOT use <code>/usr/local/etc/rc.d</code>.<br>
1.7 espie 73: <code>/usr/local</code> is often shared between several machines
1.15 espie 74: thanks to NFS. For this reason, configuration files that are specific
75: to a given machine can't be stored under <code>/usr/local</code>,
76: <code>/etc</code> is the central repository for per machine
77: configuration files. Moreover, OpenBSD policy is to never update
78: files under <code>/etc</code> automatically. Ports that need some
79: specific boot setup should advise the administrator about what to do
80: instead of blindly installing files.
1.1 marc 81: <li>OpenBSD does NOT compress man pages.
82: <li>OpenBSD does NOT require <code>-lcrypt</code>.<br>
83: DES encryption is part of the standard <code>libc</code>.
1.10 espie 84: <li>OpenBSD is strongly security-oriented. You should read and understand
85: this page's <a href="#security">security section</a>.
1.24 rohee 86: <li>Be sure to add the <code>$OpenBSD$</code> CVS tag to
1.10 espie 87: the Makefile. If importing a port from another system be sure to
88: leave their tag in the Makefile, too. However, replace the FreeBSD
1.24 rohee 89: <code>$Id$</code> tag with the
90: <code>$FreeBSD$</code> tag.
1.10 espie 91: <li>The goal is to get all ported applications to support OpenBSD. To
92: achieve this goal you <strong>must</strong> feed any OpenBSD patches
93: back to the application maintainer.
94: </ul>
1.20 rohee 95: <a name=security></a>
96: <h3><font color="#0000e0">Security recommendations</font></h3>
1.10 espie 97: There are many security problems to worry about. If
1.2 marc 98: you are not absolutely sure of what you are doing please request
1.1 marc 99: help from the <a href="mailto:ports@openbsd.org">ports</a> mailing
100: list.
1.10 espie 101:
102: <ul>
1.20 rohee 103: <li>Do <em>not</em> use alpha or beta code when preparing a port. Use the
1.10 espie 104: latest regular or patch release.
105:
1.1 marc 106: <li>Any software to be installed as a server should be scanned
107: for buffer overflows, especially unsafe use of
108: <code>strcat/strcpy/strcmp/sprintf</code>. In general,
109: <code>sprintf</code> should be replaced with <code>snprintf</code>.
1.10 espie 110:
1.17 espie 111: <li>Never use filenames instead of true security. There are numerous race
1.10 espie 112: conditions where you don't have proper control. For instance, an attacker
113: who already has user privileges on your machines may replace files in
114: <code>/tmp</code> with symbolic links to more strategic files, such as
1.19 rohee 115: <code>/etc/master.passwd</code>.
1.16 espie 116:
117: <li>For instance, both <code>fopen</code> and <code>freopen</code>
118: <strong>create a new file or open an existing file</strong> for
119: writing. An attacker may create a symbolic link from
1.19 rohee 120: <code>/etc/master.passwd</code> to <code>/tmp/addrpool_dump</code>. The
1.16 espie 121: instant you open it, your password file is hosed. Yes, even with
122: an <code>unlink</code> right before. You only narrow the window
123: of opportunity. Use <code>open</code> with
1.22 rohee 124: <code>O_CREAT|O_EXCL</code> and <code>fdopen</code> instead.
1.15 espie 125:
1.16 espie 126: <li>Another very common problem is the <code>mktemp</code>
1.17 espie 127: function. Heed the warnings of the bsd linker about its uses.
1.15 espie 128: <strong>These must be fixed</strong>.
129: This is not quite as simple as <code>s/mktemp/mkstemp/g</code>. <br>
130: Refer to the <code>mktemp(3)</code> man page of OpenBSD current
131: for more indications.
132: Correct code using <code>mkstemp</code> includes the source to
133: <code>ed</code> or <code>mail</code>.
134: A rare instance of code that uses <code>mktemp</code> correctly
135: can be found in the <code>rsync</code> port.
1.10 espie 136:
137: <li>Just because you can read it doesn't mean you should. A well-known hole
138: of this nature was the <code>startx</code> problem. As a setuid program,
139: you could launch startx with any file as a script. If the file was not
140: a valid shell script, a syntax error message would follow, along with the
141: first line of the offending file, without any further permission check.
142: Pretty handy to grab the first line of a shadow passwd file, considering
1.12 deraadt 143: these often start with root entry. Do not open your file, and then do
144: an <code>fstat</code> on the open descriptor to check if you should have
1.15 espie 145: been able to open it (or the attacker will play with /dev/rst0 and rewind
1.12 deraadt 146: your tape) -- open it with the correct uid/gid/grouplist set.
1.10 espie 147:
148: <li>Don't use anything that forks a shell in setuid programs before dropping
1.15 espie 149: your privileges. This includes <code>popen</code> and
150: <code>system</code>.
1.10 espie 151: Use <code>fork</code>, <code>pipe</code> and <code>execve</code> instead.
152:
1.15 espie 153: <li>Pass open descriptors instead of filenames to other programs to
154: avoid race conditions. Even if a program does not accept file
155: descriptors, you can still use <code>/dev/fd/0</code>.
1.10 espie 156:
1.15 espie 157: <li>Access rights are attached to file descriptors. If you need setuid rights
1.10 espie 158: to open a file, open that file, then drop your privileges. You can still
159: access the open descriptor, but you have less to worry about. This is
160: double-edged: even after dropping privileges, you should still watch out
161: for those descriptors.
162:
163: <li>Avoid root setuid as much as you can. Basically, root can do anything,
1.15 espie 164: but root rights are very rarely needed, except maybe to create
165: socket ports with a number under 1024. It is arguably better to
166: keep that under <code>inetd</code>
1.10 espie 167: control and just add the relevant entries to <code>inetd.conf</code>.
168: You must know the appropriate magic for writing daemons to achieve that.
1.15 espie 169: It could be argued that you have no business writing setuid programs
170: if you don't know how to do that.
1.10 espie 171:
1.15 espie 172: <li>Use setgid instead of setuid. Apart from those specific files needed
173: by setgid programs, most files are not group-writable. Hence, a
174: security problem in a setgid program won't compromise your system as
175: much: with only group rights, the worst an intruder will be able to
176: do is hack a games score table or some such.
1.10 espie 177: See the <code>xkobo</code> port for an instance of such a change.
178:
1.15 espie 179: <li>Don't trust group-writable files. Even though they are audited,
180: setgid programs are not perceived as important potential security
181: holes. Hence stuff they can tamper with shouldn't be considered
182: sensitive information.
183:
184: <li>Don't trust your environment ! This involves simple things such as
185: your <code>PATH</code> (never use <code>system</code> with an
186: unqualified name, avoid <code>execvp</code>), but also more subtle
187: items such as your locale, timezone, termcap, and so on.
188: Be aware of transitivity: even though you're taking full precautions,
189: programs you call directly won't necessarily. <strong>Never</strong>
190: use <code>system</code> in privileged programs, build your command
191: line, a controlled environment, and call <code>execve</code> directly.
192: The <code>perlsec</code> man page is a good tutorial on such problems.
193:
194: <li>Never used setuid shell-scripts. These are inherently insecure.
195: Wrap them into some C code that ensures a proper environment.
196: On the other hand, OpenBSD features secure perl scripts.
197:
198: <li>Beware the dynamic loader. If you are running setuid, it will only
199: use trusted libraries that were scanned with ldconfig.
200: Setgid is not enough.
201:
202: <li>Dynamic libraries are tricky. C++ code sets a similar problem.
203: Basically, libraries may take some action based upon your environment
204: before your main program even gets to check its setuid status.
205: OpenBSD <code>issetugid</code> addresses this problem, from the
206: library writer point of view. Don't try to port libraries unless you
207: understand this issue thoroughly.
1.10 espie 208: </ul>
1.20 rohee 209: <h3><font color="#0000e0">Generic porting hints</font></h3>
1.10 espie 210: <ul>
211: <li><code>__OpenBSD__</code> should be used sparingly, if at all.
212: Constructs that look like
213: <pre>
214: #if defined(__NetBSD__) || defined(__FreeBSD__)
215: </pre>
216: are often inappropriate. Don't add blindly <code>__OpenBSD__</code>
217: to it. Instead, try to figure out what's going on, and what actual
218: feature is needed. Manual pages are often useful, as they include
219: historic comments, stating when a particular feature was incorporated
220: into BSD. Checking the numeric value of <code>BSD</code> against known
221: releases is often the right way. See
1.17 espie 222: <a href="ftp://ftp.netbsd.org/pub/NetBSD/packages/pkgsrc/Packages.txt">the NetBSD package guide</a>
1.10 espie 223: for more information.
224: <li>Defining <code>BSD</code> is a bad idea. Try to include <code>sys/param.h</code>.
225: This not only defines <code>BSD</code>, it also gives it a proper value.
226: The right code fragment should look like:
227: <pre>
1.23 rohee 228: #if (defined(__unix__) || defined(unix)) && !defined(USG)
1.10 espie 229: #include <sys/param.h>
230: #endif
231: </pre>
232: <li>Test for features, not for specific OSes. In the long run, it is much
1.15 espie 233: better to test whether <code>tcgetattr</code> works than whether
234: you're running under BSD 4.3 or later, or SystemVR4. These kind of
235: tests just confuse the issue. The way to go about it is, for instance,
236: to test for one particular system, set up a slew of
237: <code>HAVE_TCGETATTR</code> defines, then proceed to the next system.
238: This technique separates features tests from specific OSes.
239: In a hurry, another porter can just add the whole set of
240: <code>-DHAVE_XXX</code> defines to the Makefile. One may also write
241: or add to a configure script to check for that feature and add it
242: automatically. As an example not to follow, check nethack 3.2.2
243: source: it assumes loads of things based on the system type. Most
244: of these assumptions are obsolete and no longer reflect reality:
245: POSIX functions are more useful than older BSD versus SystemV
246: differences, to the point that some traditional bsd functions are
1.10 espie 247: now only supported through compatibility libraries.
248:
249: <li>Avoid include files that include other includes that... First, because
1.15 espie 250: this is inefficient. Your project will end up including a file that
251: includes everything. Also, because it makes some problems difficult
252: to fix. It becomes harder to <em>not</em> include one particular file
253: at a given point.
1.10 espie 254:
255: <li>Avoid bizarre macro tricks. Undefining a macro that was defined by a
256: header file is a bad idea. Defining macros to get some specific behavior
1.15 espie 257: from an include file is also a bad idea: compilation modes should be
258: global. If you want POSIX behavior, say so, and
259: <code>#define POSIX_C_SOURCE</code>
1.10 espie 260: throughout the whole project, not when you feel like it.
261:
262: <li>Don't ever write system function prototypes. All modern systems,
263: OpenBSD included, have a standard location for these prototypes. Likely
1.15 espie 264: places include <code>unistd.h</code>, <code>fcntl.h</code> or
265: <code>termios.h</code>.
266: The man page frequently states where the prototype can be found.
267: You might need another slew of <code>HAVE_XXX</code> macros to
268: procure the right file. Don't worry about including the same file
269: twice, include files have guards that prevent all kinds of nastiness.<br>
1.10 espie 270: If some broken system needs you to write the prototype, don't impose
1.15 espie 271: on all other systems. Roll-your-own prototypes will break because they
272: may use types that are equivalent on your system, but are not portable
273: to other systems (<code>unsigned long</code> instead of
274: <code>size_t</code>), or get some <code>const</code> status wrong.
275: Also, some compilers, such as OpenBSD's own gcc,
1.10 espie 276: are able to do a better job with some very frequent functions such as
277: <code>strlen</code> if you include the right header file.
278:
279: <li>Don't use the name of a standard system function for anything else.
1.15 espie 280: If you want to write your own function, give it its own name, and
281: call that function everywhere. If you wish to revert to the
282: default system function, you just need to comment your code out,
283: and define your own name to the system function. Don't do it the
284: other way round. Code should look like this
1.10 espie 285: <pre>
286: /* prototype part */
287: #ifdef USE_OWN_GCVT
288: char *foo_gcvt(double number, size_t ndigit, char *buf);
289: #else
290: /* include correct file */
291: #include <stdlib.h>
292: /* use system function */
293: #define foo_gcvt gcvt
294: #endif
295:
296: /* definition part */
297: #ifdef USE_OWN_GCVT
298: char *foo_gcvt(double number, size_t ndigit, char *buf)
299: {
1.15 espie 300: /* proper definition */
301: }
1.10 espie 302:
303: /* typical use */
304: s = foo_gcvt(n, 15, b);
305: </pre>
1.1 marc 306: </ul>
1.20 rohee 307: <h3><font color="#0000e0">Other Helpful Hints</font></h3>
1.1 marc 308: <ul>
1.15 espie 309: <li>Recent versions of <code>bsd.port.mk</code> set the installers
310: path. Specifically, they set <code>/usr/bin</code> and
311: <code>/bin</code> to be searched <em>before</em>
312: <code>/usr/local/bin</code> and <code>/usr/X11R6/bin</code>.
1.19 rohee 313: <li>Do <em>NOT</em> generate shared libraries if
1.21 rohee 314: <code>${NO_SHARED_LIBS}</code> is defined (beware, it can be defined
315: only after inclusion of <code>bsd.port.mk</code>). If your port has
316: a GNU configure simply add the line
317: <code>CONFIGURE_ARGS += ${CONFIGURE_SHARED}</code> to the Makefile.
1.19 rohee 318: <li>If you rely on a feature that appeared in a recent version of
319: <code>bsd.port.mk</code> don't forget to add a line
320: <code>NEED_VERSION = x.yy</code> in the Makefile.
1.1 marc 321: <li>In OpenBSD <code>curses.h/libcurses/libtermlib</code> are the
322: ``new curses''. Change:<br>
1.15 espie 323: <code>ncurses.h ==> curses.h</code><br>
324: <code>-lncurses ==> -lcurses</code><br>
325: ``old (BSD) curses'' is available by defining
326: <code>_USE_OLD_CURSES_</code>
1.11 millert 327: before including <code>curses.h</code> (usually in a Makefile) and
1.15 espie 328: linking with <code>-locurses</code>.
1.11 millert 329: <li>In OpenBSD, terminal discipline has been upgraded from the older BSD
330: <code>sgtty</code> to the newer POSIX <code>tcgetattr</code> family.
1.15 espie 331: Avoid the older style in new code. Some code may define
332: <code>tcgetattr</code> to be a synonym for the older
333: <code>sgtty</code>, but this is at best a stopgap measure on OpenBSD.
334: The <code>xterm</code> source code is a very good example of
335: what not to do. Try to get your system functionality right: you
336: want a type that remembers the state of your terminal
337: (possible typedef), you want a function that extracts the current
338: state, and a function that sets the new state.
339: Functions that modify this state are more difficult, as they tend
340: to vary depending upon the system. Also, don't forget that you will
341: have to handle cases where you are not connected to a terminal,
342: and that you need to handle signals: not only termination, but
343: also background (<code>SIGTSTP</code>). You should always leave
344: the terminal in a sane state. Do your tests under an older shell,
345: such as sh, which does not reset the terminal in any way at
1.10 espie 346: program's termination.
1.15 espie 347: <li>The newer termcap/terminfo and curses, as included with OpenBSD,
348: include standard sequences for controlling color terminals. You
349: should use these if possible, reverting to standard ANSI color
350: sequences on other systems. However, some terminal descriptions
351: have not been updated yet, and you may need to be able to specify
352: these sequences manually. This is the way vim handles it. This is
353: not strictly necessary. Except for privileged programs, it is
354: generally possible to override a termcap definition through the
1.10 espie 355: <code>TERMCAP</code> variable and get it to work properly.
1.15 espie 356: <li>Signal semantics are tricky, and vary from one system to another.
357: Use <code>sigaction</code> to ensure a specific semantics, along
358: with other system calls referenced in the corresponding manpage.
1.1 marc 359: </ul>
360: <hr>
1.6 pauls 361: <a href="index.html"><img height=24 width=24 src=back.gif border=0 alt=OpenBSD></a>
1.20 rohee 362: <a href="mailto:www@openbsd.org">www@openbsd.org</a>
1.28 ! wvdputte 363: <br><small>$OpenBSD: porting.html,v 1.27 2000/02/23 10:54:29 espie Exp $</small>
1.1 marc 364: </body>
365: </html>