Up to [local] / src / usr.bin / doas
Request diff between arbitrary revisions
Default branch: MAIN
Current tag: OPENBSD_6_0_BASE
Revision 1.60 / (download) - annotate - [select for diffs], Mon Jul 18 16:46:30 2016 UTC (7 years, 10 months ago) by zhuk
Branch: MAIN
CVS Tags: OPENBSD_6_0_BASE,
OPENBSD_6_0
Changes since 1.59: +6 -4 lines
Diff to previous 1.59 (colored)
The string with path to shell could be taken directly from struct passwd. At some point later the data it points to is overridden by getpwuid() call, resulting in garbage. The problem could be easily demonstreated by double doas call: $ doas doas -su _sndio doas: mpty: command not found The fix is easy: just strdup() the pw_shell field value. okay tedu@, tweaks from & okay natano@