OpenBSD CVS

CVS log for src/usr.bin/ssh/ssh-sk-client.c


[BACK] Up to [local] / src / usr.bin / ssh

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.12 / (download) - annotate - [select for diffs], Fri Jan 14 03:34:00 2022 UTC (2 years, 4 months ago) by djm
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1, HEAD
Changes since 1.11: +2 -3 lines
Diff to previous 1.11 (colored)

sshsk_load_resident: don't preallocate resp

resp is allocated by client_converse(), at which point we lose
the original pointer.

From Pedro Martelletto; ok dtucker & me

Revision 1.11 / (download) - annotate - [select for diffs], Fri Jan 14 03:32:52 2022 UTC (2 years, 4 months ago) by djm
Branch: MAIN
Changes since 1.10: +1 -8 lines
Diff to previous 1.10 (colored)

sshsk_sign: trim call to sshkey_fingerprint()

the resulting fingerprint doesn't appear to be used for anything,
and we end up leaking it.

from Pedro Martelletto; ok dtucker & me

Revision 1.10 / (download) - annotate - [select for diffs], Thu Oct 28 02:54:18 2021 UTC (2 years, 6 months ago) by djm
Branch: MAIN
Changes since 1.9: +64 -24 lines
Diff to previous 1.9 (colored)

When downloading resident keys from a FIDO token, pass back the
user ID that was used when the key was created and append it to
the filename the key is written to (if it is not the default).

Avoids keys being clobbered if the user created multiple
resident keys with the same application string but different
user IDs.

feedback Pedro Martelletto; ok markus

NB. increments SSH_SK_VERSION_MAJOR

Revision 1.9 / (download) - annotate - [select for diffs], Sat Apr 3 06:18:41 2021 UTC (3 years, 1 month ago) by djm
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9
Changes since 1.8: +4 -4 lines
Diff to previous 1.8 (colored)

highly polished whitespace, mostly fixing spaces-for-tab and bad
indentation on continuation lines. Prompted by GHPR#185

Revision 1.8 / (download) - annotate - [select for diffs], Sun Oct 18 11:32:02 2020 UTC (3 years, 6 months ago) by djm
Branch: MAIN
Changes since 1.7: +38 -39 lines
Diff to previous 1.7 (colored)

use the new variant log macros instead of prepending __func__ and
appending ssh_err(r) manually; ok markus@

Revision 1.7 / (download) - annotate - [select for diffs], Thu Jan 23 07:10:22 2020 UTC (4 years, 3 months ago) by dtucker
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.6: +5 -4 lines
Diff to previous 1.6 (colored)

Replace all calls to signal(2) with a wrapper around sigaction(2).
This wrapper blocks all other signals during the handler preventing
races between handlers, and sets SA_RESTART which should reduce the
potential for short read/write operations.

Revision 1.6 / (download) - annotate - [select for diffs], Tue Jan 21 07:07:31 2020 UTC (4 years, 3 months ago) by djm
Branch: MAIN
Changes since 1.5: +9 -1 lines
Diff to previous 1.5 (colored)

check access(ssh-sk-helper, X_OK) to provide friendly error message
for misconfigured helper paths

Revision 1.5 / (download) - annotate - [select for diffs], Fri Jan 10 23:43:26 2020 UTC (4 years, 4 months ago) by djm
Branch: MAIN
Changes since 1.4: +23 -17 lines
Diff to previous 1.4 (colored)

pass the log-on-stderr flag and log level through to ssh-sk-helper,
making debugging a bit easier. ok markus@

Revision 1.4 / (download) - annotate - [select for diffs], Mon Jan 6 02:00:46 2020 UTC (4 years, 4 months ago) by djm
Branch: MAIN
Changes since 1.3: +9 -5 lines
Diff to previous 1.3 (colored)

Extends the SK API to accept a set of key/value options for all
operations. These are intended to future-proof the API a little by
making it easier to specify additional fields for without having to
change the API version for each.

At present, only two options are defined: one to explicitly specify
the device for an operation (rather than accepting the middleware's
autoselection) and another to specify the FIDO2 username that may
be used when generating a resident key. These new options may be
invoked at key generation time via ssh-keygen -O

This also implements a suggestion from Markus to avoid "int" in favour
of uint32_t for the algorithm argument in the API, to make implementation
of ssh-sk-client/helper a little easier.

feedback, fixes and ok markus@

Revision 1.3 / (download) - annotate - [select for diffs], Mon Dec 30 09:23:28 2019 UTC (4 years, 4 months ago) by djm
Branch: MAIN
Changes since 1.2: +37 -10 lines
Diff to previous 1.2 (colored)

SK API and sk-helper error/PIN passing

Allow passing a PIN via the SK API (API major crank) and let the
ssh-sk-helper API follow.

Also enhance the ssh-sk-helper API to support passing back an error
code instead of a complete reply. Will be used to signal "wrong PIN",
etc.

feedback and ok markus@

Revision 1.2 / (download) - annotate - [select for diffs], Mon Dec 30 09:21:59 2019 UTC (4 years, 4 months ago) by djm
Branch: MAIN
Changes since 1.1: +71 -1 lines
Diff to previous 1.1 (colored)

implement loading of resident keys in ssh-sk-helper

feedback and ok markus@

Revision 1.1 / (download) - annotate - [select for diffs], Fri Dec 13 20:16:56 2019 UTC (4 years, 5 months ago) by djm
Branch: MAIN

actually commit the ssh-sk-helper client code; ok markus

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.