OpenBSD CVS

CVS log for src/usr.bin/tr/tr.c


[BACK] Up to [local] / src / usr.bin / tr

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.22 / (download) - annotate - [select for diffs], Sun Dec 4 23:50:49 2022 UTC (17 months, 2 weeks ago) by cheloha
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, HEAD
Changes since 1.21: +1 -2 lines
Diff to previous 1.21 (colored)

userspace: remove vestigial '?' cases from top-level getopt(3) loops

getopt(3) returns '?' when it encounters a flag not present in the in
the optstring or if a flag is missing its option argument.  We can
handle this case with the "default" failure case with no loss of
legibility.  Hence, remove all the redundant "case '?':" lines.

Prompted by dlg@.  With help from dlg@ and millert@.

Link: https://marc.info/?l=openbsd-tech&m=167011979726449&w=2

ok naddy@ millert@ dlg@

Revision 1.21 / (download) - annotate - [select for diffs], Fri Feb 11 16:09:21 2022 UTC (2 years, 3 months ago) by cheloha
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.20: +23 -22 lines
Diff to previous 1.20 (colored)

tr(1): rename lookup tables

The lookup tables in tr(1) are called "string1" and "string2".  This is
misleading:

- They aren't C strings, they are lookup tables.

- The names "string1" and "string2" don't hint at what their contents
  actually mean.  The meaning of a given table changes with tr(1)'s
  operating mode.  There are five different modes.

It would be considerably easier to see what is happening at a glance
if the tables were named for their corresponding byte transformation.

So instead of two tables named "string1" and "string2" we'll have
three tables named "delete", "squeeze", and "translate".  In addition,
the "string" passed to the setup() function will be called a "table".

With this patch the code in main() is way easier to understand.
Hopefully this makes subsequent patches easier to review.

Thread: https://marc.info/?l=openbsd-tech&m=164355980600901&w=2

No complaints on tech@ after over a week.

Revision 1.20 / (download) - annotate - [select for diffs], Tue Nov 2 15:45:52 2021 UTC (2 years, 6 months ago) by cheloha
Branch: MAIN
Changes since 1.19: +7 -17 lines
Diff to previous 1.19 (colored)

tr(1): main(): eliminate isstring2 variable

If only there we a way to express how many positional arguments we
needed to run tr(1) in a given operating mode.

... oh.  Wait.  We have argc for that.

Remove the isstring2 variable to simplify some of the logic in main().

Revision 1.19 / (download) - annotate - [select for diffs], Fri Oct 9 01:37:09 2015 UTC (8 years, 7 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9, OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7, OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4, OPENBSD_6_3_BASE, OPENBSD_6_3, OPENBSD_6_2_BASE, OPENBSD_6_2, OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9
Changes since 1.18: +3 -3 lines
Diff to previous 1.18 (colored)

Change all tame callers to namechange to pledge(2).

Revision 1.18 / (download) - annotate - [select for diffs], Tue Oct 6 13:49:33 2015 UTC (8 years, 7 months ago) by deraadt
Branch: MAIN
Changes since 1.17: +4 -1 lines
Diff to previous 1.17 (colored)

only modifies data, stdin to stdout, so tame "stdout"

Revision 1.17 / (download) - annotate - [select for diffs], Tue Jun 3 20:57:23 2014 UTC (9 years, 11 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7, OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.16: +11 -10 lines
Diff to previous 1.16 (colored)

Accept -C as an alias for -c.  The -C option should be locale-aware,
but we don't have collation support yet.  Man bits OK jmc@

Revision 1.16 / (download) - annotate - [select for diffs], Wed Nov 27 13:32:02 2013 UTC (10 years, 5 months ago) by okan
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.15: +2 -2 lines
Diff to previous 1.15 (colored)

remove erroneous char cast to switch expression processing getopt(3);
not used in any cases.

ok deraadt@, guenther@, millert@

Revision 1.15 / (download) - annotate - [select for diffs], Tue Oct 27 23:59:46 2009 UTC (14 years, 6 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE, OPENBSD_5_4, OPENBSD_5_3_BASE, OPENBSD_5_3, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1, OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7
Changes since 1.14: +1 -14 lines
Diff to previous 1.14 (colored)

rcsid[] and sccsid[] and copyright[] are essentially unmaintained (and
unmaintainable).  these days, people use source.  these id's do not provide
any benefit, and do hurt the small install media
(the 33,000 line diff is essentially mechanical)
ok with the idea millert, ok dms

Revision 1.14 / (download) - annotate - [select for diffs], Wed Jul 9 19:41:56 2008 UTC (15 years, 10 months ago) by sobrado
Branch: MAIN
CVS Tags: OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.13: +7 -6 lines
Diff to previous 1.13 (colored)

documentation tweaks.

Revision 1.13 / (download) - annotate - [select for diffs], Wed Sep 15 22:12:19 2004 UTC (19 years, 8 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3, OPENBSD_4_2_BASE, OPENBSD_4_2, OPENBSD_4_1_BASE, OPENBSD_4_1, OPENBSD_4_0_BASE, OPENBSD_4_0, OPENBSD_3_9_BASE, OPENBSD_3_9, OPENBSD_3_8_BASE, OPENBSD_3_8, OPENBSD_3_7_BASE, OPENBSD_3_7
Changes since 1.12: +5 -5 lines
Diff to previous 1.12 (colored)

signed and unsigned char wiggles

Revision 1.12 / (download) - annotate - [select for diffs], Sun May 9 03:20:20 2004 UTC (20 years ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_3_6_BASE, OPENBSD_3_6
Changes since 1.11: +7 -7 lines
Diff to previous 1.11 (colored)

spacing

Revision 1.11 / (download) - annotate - [select for diffs], Thu Jun 26 16:03:43 2003 UTC (20 years, 10 months ago) by mickey
Branch: MAIN
CVS Tags: OPENBSD_3_5_BASE, OPENBSD_3_5, OPENBSD_3_4_BASE, OPENBSD_3_4
Changes since 1.10: +6 -6 lines
Diff to previous 1.10 (colored)

print usage in one printf (instead of four)

Revision 1.10 / (download) - annotate - [select for diffs], Tue Jun 10 22:20:53 2003 UTC (20 years, 11 months ago) by deraadt
Branch: MAIN
Changes since 1.9: +5 -11 lines
Diff to previous 1.9 (colored)

mostly ansi cleanup; pval ok

Revision 1.9 / (download) - annotate - [select for diffs], Tue Jun 3 02:56:20 2003 UTC (20 years, 11 months ago) by millert
Branch: MAIN
Changes since 1.8: +3 -7 lines
Diff to previous 1.8 (colored)

Remove the advertising clause in the UCB license which Berkeley
rescinded 22 July 1999.  Proofed by myself and Theo.

Revision 1.8 / (download) - annotate - [select for diffs], Sat Feb 16 21:27:55 2002 UTC (22 years, 3 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_3_3_BASE, OPENBSD_3_3, OPENBSD_3_2_BASE, OPENBSD_3_2, OPENBSD_3_1_BASE, OPENBSD_3_1
Changes since 1.7: +4 -4 lines
Diff to previous 1.7 (colored)

Part one of userland __P removal.  Done with a simple regexp with some minor hand editing to make comments line up correctly.  Another pass is forthcoming that handles the cases that could not be done automatically.

Revision 1.7 / (download) - annotate - [select for diffs], Sat Feb 9 02:03:28 2002 UTC (22 years, 3 months ago) by deraadt
Branch: MAIN
Changes since 1.6: +3 -2 lines
Diff to previous 1.6 (colored)

fix "no characters" input case; tim@robbins.dropbear.id.au

Revision 1.6 / (download) - annotate - [select for diffs], Mon Nov 19 19:02:17 2001 UTC (22 years, 6 months ago) by mpech
Branch: MAIN
Changes since 1.5: +4 -4 lines
Diff to previous 1.5 (colored)

kill more registers

millert@ ok

Revision 1.5 / (download) - annotate - [select for diffs], Fri Jul 25 21:14:04 1997 UTC (26 years, 10 months ago) by mickey
Branch: MAIN
CVS Tags: OPENBSD_3_0_BASE, OPENBSD_3_0, OPENBSD_2_9_BASE, OPENBSD_2_9, OPENBSD_2_8_BASE, OPENBSD_2_8, OPENBSD_2_7_BASE, OPENBSD_2_7, OPENBSD_2_6_BASE, OPENBSD_2_6, OPENBSD_2_5_BASE, OPENBSD_2_5, OPENBSD_2_4_BASE, OPENBSD_2_4, OPENBSD_2_3_BASE, OPENBSD_2_3, OPENBSD_2_2_BASE, OPENBSD_2_2
Changes since 1.4: +4 -32 lines
Diff to previous 1.4 (colored)

use err(3)

Revision 1.4 / (download) - annotate - [select for diffs], Fri Jul 25 21:05:45 1997 UTC (26 years, 10 months ago) by mickey
Branch: MAIN
Changes since 1.3: +5 -5 lines
Diff to previous 1.3 (colored)

#if __STDC__ --> #ifdef __STDC__

Revision 1.3 / (download) - annotate - [select for diffs], Wed Jan 15 23:43:24 1997 UTC (27 years, 4 months ago) by millert
Branch: MAIN
CVS Tags: OPENBSD_2_1_BASE, OPENBSD_2_1
Changes since 1.2: +3 -3 lines
Diff to previous 1.2 (colored)

getopt(3) returns -1 when out of args, not EOF, whee!

Revision 1.2 / (download) - annotate - [select for diffs], Wed Jun 26 05:41:51 1996 UTC (27 years, 10 months ago) by deraadt
Branch: MAIN
CVS Tags: OPENBSD_2_0_BASE, OPENBSD_2_0
Changes since 1.1: +2 -1 lines
Diff to previous 1.1 (colored)

rcsid

Revision 1.1.1.1 / (download) - annotate - [select for diffs] (vendor branch), Wed Oct 18 08:46:26 1995 UTC (28 years, 7 months ago) by deraadt
CVS Tags: netbsd_1_1
Changes since 1.1: +0 -0 lines
Diff to previous 1.1 (colored)

initial import of NetBSD tree

Revision 1.1 / (download) - annotate - [select for diffs], Wed Oct 18 08:46:26 1995 UTC (28 years, 7 months ago) by deraadt
Branch: MAIN

Initial revision

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.