OpenBSD CVS

CVS log for src/usr.bin/ssh/umac.c


[BACK] Up to [local] / src / usr.bin / ssh

Request diff between arbitrary revisions


Default branch: MAIN


Revision 1.23 / (download) - annotate - [select for diffs], Tue Mar 7 01:30:52 2023 UTC (14 months, 3 weeks ago) by djm
Branch: MAIN
CVS Tags: OPENBSD_7_5_BASE, OPENBSD_7_5, OPENBSD_7_4_BASE, OPENBSD_7_4, OPENBSD_7_3_BASE, OPENBSD_7_3, HEAD
Changes since 1.22: +3 -2 lines
Diff to previous 1.22 (colored) to selected 1.5 (colored)

correct size for array argument when changing UMAC_OUTPUT_LEN
Coverity CID 291845; ok dtucker@

Revision 1.22 / (download) - annotate - [select for diffs], Sat Jan 1 05:55:06 2022 UTC (2 years, 5 months ago) by jsg
Branch: MAIN
CVS Tags: OPENBSD_7_2_BASE, OPENBSD_7_2, OPENBSD_7_1_BASE, OPENBSD_7_1
Changes since 1.21: +2 -2 lines
Diff to previous 1.21 (colored) to selected 1.5 (colored)

spelling

Revision 1.21 / (download) - annotate - [select for diffs], Sat Apr 3 06:58:30 2021 UTC (3 years, 1 month ago) by djm
Branch: MAIN
CVS Tags: OPENBSD_7_0_BASE, OPENBSD_7_0, OPENBSD_6_9_BASE, OPENBSD_6_9
Changes since 1.20: +2 -2 lines
Diff to previous 1.20 (colored) to selected 1.5 (colored)

typos in comments; GHPR#180 from Ville Skyttä

Revision 1.20 / (download) - annotate - [select for diffs], Fri Mar 13 03:17:07 2020 UTC (4 years, 2 months ago) by djm
Branch: MAIN
CVS Tags: OPENBSD_6_8_BASE, OPENBSD_6_8, OPENBSD_6_7_BASE, OPENBSD_6_7
Changes since 1.19: +2 -2 lines
Diff to previous 1.19 (colored) to selected 1.5 (colored)

spelling errors in comments; no code change
from https://fossies.org/linux/misc/openssh-8.2p1.tar.gz/codespell.html

Revision 1.19 / (download) - annotate - [select for diffs], Wed Feb 26 13:40:09 2020 UTC (4 years, 3 months ago) by jsg
Branch: MAIN
Changes since 1.18: +2 -3 lines
Diff to previous 1.18 (colored) to selected 1.5 (colored)

change explicit_bzero();free() to freezero()

While freezero() returns early if the pointer is NULL the tests for
NULL in callers are left to avoid warnings about passing an
uninitialised size argument across a function boundry.

ok deraadt@ djm@

Revision 1.18 / (download) - annotate - [select for diffs], Wed Nov 13 04:47:52 2019 UTC (4 years, 6 months ago) by deraadt
Branch: MAIN
Changes since 1.17: +2 -1 lines
Diff to previous 1.17 (colored) to selected 1.5 (colored)

stdarg.h required more broadly; ok djm

Revision 1.17 / (download) - annotate - [select for diffs], Tue Apr 10 00:10:49 2018 UTC (6 years, 1 month ago) by djm
Branch: MAIN
CVS Tags: OPENBSD_6_6_BASE, OPENBSD_6_6, OPENBSD_6_5_BASE, OPENBSD_6_5, OPENBSD_6_4_BASE, OPENBSD_6_4
Changes since 1.16: +7 -7 lines
Diff to previous 1.16 (colored) to selected 1.5 (colored)

lots of typos in comments/docs. Patch from Karsten Weiss after checking
with codespell tool (https://github.com/lucasdemarchi/codespell)

Revision 1.16 / (download) - annotate - [select for diffs], Tue Dec 12 15:06:12 2017 UTC (6 years, 5 months ago) by naddy
Branch: MAIN
CVS Tags: OPENBSD_6_3_BASE, OPENBSD_6_3
Changes since 1.15: +3 -1 lines
Diff to previous 1.15 (colored) to selected 1.5 (colored)

Create a persistent umac128.c source file: #define the output size and
the name of the entry points for UMAC-128 before including umac.c.
Idea from FreeBSD.
ok dtucker@

Revision 1.15 / (download) - annotate - [select for diffs], Tue Nov 28 06:09:38 2017 UTC (6 years, 6 months ago) by djm
Branch: MAIN
Changes since 1.14: +8 -8 lines
Diff to previous 1.14 (colored) to selected 1.5 (colored)

more whitespace errors

Revision 1.14 / (download) - annotate - [select for diffs], Tue Nov 28 06:04:51 2017 UTC (6 years, 6 months ago) by djm
Branch: MAIN
Changes since 1.13: +41 -41 lines
Diff to previous 1.13 (colored) to selected 1.5 (colored)

whitespace at EOL

Revision 1.13 / (download) - annotate - [select for diffs], Fri Oct 27 01:01:17 2017 UTC (6 years, 7 months ago) by djm
Branch: MAIN
Changes since 1.12: +53 -53 lines
Diff to previous 1.12 (colored) to selected 1.5 (colored)

whitespace at EOL (lots)

Revision 1.12 / (download) - annotate - [select for diffs], Wed May 31 08:09:45 2017 UTC (7 years ago) by markus
Branch: MAIN
CVS Tags: OPENBSD_6_2_BASE, OPENBSD_6_2
Changes since 1.11: +8 -2 lines
Diff to previous 1.11 (colored) to selected 1.5 (colored)

clear session keys from memory; ok djm@

Revision 1.11 / (download) - annotate - [select for diffs], Tue Jul 22 07:13:42 2014 UTC (9 years, 10 months ago) by guenther
Branch: MAIN
CVS Tags: OPENBSD_6_1_BASE, OPENBSD_6_1, OPENBSD_6_0_BASE, OPENBSD_6_0, OPENBSD_5_9_BASE, OPENBSD_5_9, OPENBSD_5_8_BASE, OPENBSD_5_8, OPENBSD_5_7_BASE, OPENBSD_5_7, OPENBSD_5_6_BASE, OPENBSD_5_6
Changes since 1.10: +2 -2 lines
Diff to previous 1.10 (colored) to selected 1.5 (colored)

Convert from <sys/endian.h> to the shiney new <endian.h>

ok dtucker@, who also confirmed that -portable handles this already

Revision 1.10 / (download) - annotate - [select for diffs], Wed Apr 30 19:07:48 2014 UTC (10 years, 1 month ago) by naddy
Branch: MAIN
Changes since 1.9: +12 -2 lines
Diff to previous 1.9 (colored) to selected 1.5 (colored)

UMAC can use our local fallback implementation of AES when OpenSSL isn't
available.  Glue code straight from Ted Krovetz's original umac.c.
ok markus@

Revision 1.9 / (download) - annotate - [select for diffs], Sun Apr 20 02:30:25 2014 UTC (10 years, 1 month ago) by djm
Branch: MAIN
Changes since 1.8: +14 -29 lines
Diff to previous 1.8 (colored) to selected 1.5 (colored)

use get/put_u32 to load values rather than *((UINT32 *)p) that breaks on
strict-alignment architectures; reported by and ok stsp@

Revision 1.4.6.1 / (download) - annotate - [select for diffs], Fri Nov 8 05:52:21 2013 UTC (10 years, 6 months ago) by djm
Branch: OPENBSD_5_3
Changes since 1.4: +2 -2 lines
Diff to previous 1.4 (colored) next main 1.5 (colored)

openssh-6.4 for the 5.3 branch; reminded by deraadt@

Revision 1.7.2.1 / (download) - annotate - [select for diffs], Fri Nov 8 01:33:56 2013 UTC (10 years, 6 months ago) by djm
Branch: OPENBSD_5_4
Changes since 1.7: +2 -2 lines
Diff to previous 1.7 (colored) next main 1.8 (colored) to selected 1.5 (colored)

cherrypick commit:

date: 2013/11/08 00:39:15;  author: djm;  state: Exp;  lines: +2 -2;
use calloc for all structure allocations; from markus@

Revision 1.8 / (download) - annotate - [select for diffs], Fri Nov 8 00:39:15 2013 UTC (10 years, 6 months ago) by djm
Branch: MAIN
CVS Tags: OPENBSD_5_5_BASE, OPENBSD_5_5
Changes since 1.7: +2 -2 lines
Diff to previous 1.7 (colored) to selected 1.5 (colored)

use calloc for all structure allocations; from markus@

Revision 1.7 / (download) - annotate - [select for diffs], Mon Jul 22 05:00:17 2013 UTC (10 years, 10 months ago) by djm
Branch: MAIN
CVS Tags: OPENBSD_5_4_BASE
Branch point for: OPENBSD_5_4
Changes since 1.6: +31 -31 lines
Diff to previous 1.6 (colored) to selected 1.5 (colored)

make MAC key, data to be hashed and nonce for final hash const;
checked with -Wcast-qual

Revision 1.6 / (download) - annotate - [select for diffs], Sat Jul 20 01:43:46 2013 UTC (10 years, 10 months ago) by djm
Branch: MAIN
Changes since 1.5: +9 -7 lines
Diff to previous 1.5 (colored)

use a union to ensure correct alignment; ok deraadt

Revision 1.5 / (download) - annotate - [selected], Fri May 17 00:13:14 2013 UTC (11 years ago) by djm
Branch: MAIN
Changes since 1.4: +2 -2 lines
Diff to previous 1.4 (colored)

bye, bye xfree(); ok markus@

Revision 1.4 / (download) - annotate - [select for diffs], Wed Oct 19 10:39:48 2011 UTC (12 years, 7 months ago) by djm
Branch: MAIN
CVS Tags: OPENBSD_5_3_BASE, OPENBSD_5_2_BASE, OPENBSD_5_2, OPENBSD_5_1_BASE, OPENBSD_5_1
Branch point for: OPENBSD_5_3
Changes since 1.3: +2 -2 lines
Diff to previous 1.3 (colored) to selected 1.5 (colored)

typo in comment; patch from Michael W. Bombardieri

Revision 1.3 / (download) - annotate - [select for diffs], Mon May 12 20:52:20 2008 UTC (16 years ago) by pvalchev
Branch: MAIN
CVS Tags: OPENBSD_5_0_BASE, OPENBSD_5_0, OPENBSD_4_9_BASE, OPENBSD_4_9, OPENBSD_4_8_BASE, OPENBSD_4_8, OPENBSD_4_7_BASE, OPENBSD_4_7, OPENBSD_4_6_BASE, OPENBSD_4_6, OPENBSD_4_5_BASE, OPENBSD_4_5, OPENBSD_4_4_BASE, OPENBSD_4_4
Changes since 1.2: +5 -3 lines
Diff to previous 1.2 (colored) to selected 1.5 (colored)

Ensure nh_result lies on a 64-bit boundary (fixes warnings observed
on Itanium on Linux); from Dale Talcott (bug #1462); ok djm@

Revision 1.2 / (download) - annotate - [select for diffs], Wed Sep 12 19:39:19 2007 UTC (16 years, 8 months ago) by stevesk
Branch: MAIN
CVS Tags: OPENBSD_4_3_BASE, OPENBSD_4_3
Changes since 1.1: +4 -3 lines
Diff to previous 1.1 (colored) to selected 1.5 (colored)

use xmalloc() and xfree(); ok markus@ pvalchev@

Revision 1.1 / (download) - annotate - [select for diffs], Thu Jun 7 19:37:34 2007 UTC (16 years, 11 months ago) by pvalchev
Branch: MAIN
CVS Tags: OPENBSD_4_2_BASE, OPENBSD_4_2
Diff to selected 1.5 (colored)

Add a new MAC algorithm for data integrity, UMAC-64 (not default yet, must
specify umac-64@openssh.com). Provides about 20% end-to-end speedup
compared to hmac-md5. Represents a different approach to message
authentication to that of HMAC that may be beneficial if HMAC based on one
of its underlying hash algorithms is found to be vulnerable to a new attack.
http://www.ietf.org/rfc/rfc4418.txt

in conjunction with and OK djm@

This form allows you to request diff's between any two revisions of a file. You may select a symbolic revision name using the selection box or you may type in a numeric name using the type-in text box.